Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

2020-02-29 Thread Eric Anholt
On Fri, Feb 28, 2020 at 12:48 AM Dave Airlie wrote: > > On Fri, 28 Feb 2020 at 18:18, Daniel Stone wrote: > > > > On Fri, 28 Feb 2020 at 03:38, Dave Airlie wrote: > > > b) we probably need to take a large step back here. > > > > > > Look at this from a sponsor POV, why would I give X.org/fd.o >

Re: Repos to archive?

2018-11-20 Thread Eric Anholt
Alan Coopersmith writes: > While iterating over all the /xorg/ repos to update their READMEs > (which I think I've now finished - let me know if you spot one I missed), > I noticed a few more to consider archiving: I agree with your reasoning for all of these. signature.asc Description: PGP

Re: Migrating x.org wiki to GitLab

2018-11-14 Thread Eric Anholt
Zach writes: > Hello X.Org Developers, > > I have been working on migrating the x.org/wiki/ to GitLab pages. The > tracking issue is at > https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/80 and > the current development branch is at >

Re: [PATCH app/fonttosfnt] Mark vsprintf_alloc as printf-like function

2018-11-01 Thread Eric Anholt
Peter Hutterer writes: > Signed-off-by: Peter Hutterer > --- > Review this quickly please, we have another release coming up in 9 years > time and I don't want to miss the merge window. Reviewed-by: Eric Anholt signature.asc Description: P

Re: [PATCH xserver] miext/damage: take care of the coordinate mode in damagePolyPoint

2018-09-21 Thread Eric Anholt
Cedric Roux writes: > The mode (CoordModeOrigin or CoordModePrevious) was not taken into > account when computing the box. The result was a bad drawing of > points in some situations (on my hardware/software configuration, > calling XDrawString followed by XDrawPoints in the mode >

Re: [PATCH xserver] glamor_egl: request GL2.1 when requesting Desktop GL context

2018-09-06 Thread Eric Anholt
Icenowy Zheng writes: > Some devices cannot support OpenGL 2.1, which is the minimum desktop GL > version required by glamor. However, they may support OpenGL ES 2.0, > which is the GLES version required by glamor. Usually in this situation > the desktop GL version supported is 2.0 or 1.4. > >

[PATCH xserver] glamor: Add support for exporting depth 16 pixmaps.

2018-09-04 Thread Eric Anholt
support DRI3 on those pixmaps means that we can avoid having a different path for EGL pbuffers compared to pixmaps. Signed-off-by: Eric Anholt --- glamor/glamor_egl.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/glamor/glamor_egl.c b/glamor/glamor_egl.c

Re: [PATCH xserver] meson: Add an option to build XSELINUX.

2018-08-09 Thread Eric Anholt
Peter Hutterer writes: > On Thu, Aug 09, 2018 at 01:02:41PM -0700, Eric Anholt wrote: >> Dependencies are ported from the automake build. >> >> v2: Make it a tristate defaulting to 'auto'. Use pkg-config for libaudit. >> >> Signed-off-by: Eric Anholt

Re: [PATCH v2] meson: add option to disable selective werror

2018-08-09 Thread Eric Anholt
Matt Turner writes: > On Thu, Aug 9, 2018 at 1:03 PM, Eric Anholt wrote: >> "Marty E. Plummer" writes: >> >>> Signed-off-by: Marty E. Plummer >> >> We definitely want our -W flags. Are you finding that one of the >> -Werro

Re: [PATCH v2] meson: add option to disable selective werror

2018-08-09 Thread Eric Anholt
"Marty E. Plummer" writes: > Signed-off-by: Marty E. Plummer We definitely want our -W flags. Are you finding that one of the -Werror ones is throwing errors for you? If so, let's fix that for everyone. signature.asc Description: PGP signature

[PATCH xserver] meson: Add an option to build XSELINUX.

2018-08-09 Thread Eric Anholt
Dependencies are ported from the automake build. v2: Make it a tristate defaulting to 'auto'. Use pkg-config for libaudit. Signed-off-by: Eric Anholt --- meson.build | 20 +--- meson_options.txt | 2 ++ 2 files changed, 19 insertions(+), 3 deletions(-) diff --git

[PATCH xserver 05/10] meson: Make xf86vidmodeproto mandatory.

2018-08-07 Thread Eric Anholt
This is silly to have optional based on detection of the protocol headers, particularly now that we have a single protocol header repo to install. Signed-off-by: Eric Anholt --- include/meson.build | 2 +- meson.build | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH xserver 02/10] meson: Add PIO access support for FreeBSD and NetBSD on Alpha.

2018-08-07 Thread Eric Anholt
Signed-off-by: Eric Anholt --- hw/xfree86/os-support/meson.build | 11 ++- include/meson.build | 3 --- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/xfree86/os-support/meson.build b/hw/xfree86/os-support/meson.build index 512bc8c1f951..49b138ed2dab

[PATCH xserver 06/10] meson: Add an option to build XSELINUX.

2018-08-07 Thread Eric Anholt
Dependencies are ported from the automake build. The only part I skipped was making sure we can find libaudit.h. Signed-off-by: Eric Anholt --- meson.build | 12 +--- meson_options.txt | 2 ++ 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/meson.build b

[PATCH xserver 07/10] meson: Make FALLBACK_INPUT_DRIVER configurable in meson.

2018-08-07 Thread Eric Anholt
This makes us match the featureset of autotools, and also fixes the non-Linux default value to match. Signed-off-by: Eric Anholt --- hw/xfree86/common/meson.build | 14 +- include/meson.build | 2 -- meson_options.txt | 2 ++ 3 files changed, 15 insertions

[PATCH xserver 04/10] meson: Add linking to x86 iopl libs on BSDs.

2018-08-07 Thread Eric Anholt
Ported from automake. Signed-off-by: Eric Anholt --- hw/xfree86/os-support/meson.build | 8 include/meson.build | 2 -- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/os-support/meson.build b/hw/xfree86/os-support/meson.build index 49b138ed2dab

[PATCH xserver 01/10] meson, automake: Drop unused USESTDRES cflag setup.

2018-08-07 Thread Eric Anholt
Nothing in tree references the flag. Signed-off-by: Eric Anholt --- hw/xfree86/os-support/bsd/Makefile.am | 2 +- hw/xfree86/os-support/hurd/Makefile.am| 2 +- hw/xfree86/os-support/linux/Makefile.am | 2 +- hw/xfree86/os-support/meson.build | 2 -- hw/xfree86/os-support

[PATCH xserver 08/10] meson: Add missing setup of the NO_LOCAL_CLIENT_CRED define.

2018-08-07 Thread Eric Anholt
Ported from autotools. Signed-off-by: Eric Anholt --- include/meson.build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/include/meson.build b/include/meson.build index 13ca1f8f8d34..6d08b05733b8 100644 --- a/include/meson.build +++ b/include/meson.build @@ -45,7

[PATCH xserver 00/10] meson build parity progress

2018-08-07 Thread Eric Anholt
Here's another series to get us closer to parity on the meson build. You can see the things that I know of left to fix at: https://gitlab.freedesktop.org/anholt/xserver/merge_requests/1 Eric Anholt (10): meson, automake: Drop unused USESTDRES cflag setup. meson: Add PIO access support

[PATCH xserver 03/10] meson: Add HAVE_LIBDISPATCH define to xquartz build.

2018-08-07 Thread Eric Anholt
Signed-off-by: Eric Anholt --- hw/xquartz/meson.build | 20 +--- include/meson.build| 1 - 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/xquartz/meson.build b/hw/xquartz/meson.build index f92fbc960145..ebb24132c3f7 100644 --- a/hw/xquartz/meson.build

[PATCH xserver 09/10] meson: Get close to parity with autotools for CLIENTIDS tracking.

2018-08-07 Thread Eric Anholt
The client ID is only needed for XRes, and autotools build ignores the --clientids= arg if xres is disabled. We haven't made a meson option for disabling tracking client ids (is it actually worth a build option?), so just make this depend on xres. Signed-off-by: Eric Anholt --- include

[PATCH xserver 10/10] meson: Add detection of libsystemd-daemon.

2018-08-07 Thread Eric Anholt
This enables Xtrans's systemd socket activation. Signed-off-by: Eric Anholt --- include/meson.build | 3 ++- meson.build | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/include/meson.build b/include/meson.build index 2c139e6b0651..9a7547c4708a 100644

Re: [PATCH xserver 6/6] meson: Automatically detect HAVE_PTHREAD_SETNAME_NP

2018-08-02 Thread Eric Anholt
Adam Jackson writes: > On Thu, 2018-08-02 at 15:22 +1000, Peter Hutterer wrote: >> On Wed, Aug 01, 2018 at 01:49:54PM -0700, Eric Anholt wrote: >> > Signed-off-by: Eric Anholt >> >> series Reviewed-by: Peter Hutterer > > 4/6 doesn't go too far enough, but

[PATCH xserver 4/6] xorg: Remove the XF86PM define.

2018-08-01 Thread Eric Anholt
We already have pm_noop.c being built most of the time for the no-OS-PM case, so just switch to always using it. Signed-off-by: Eric Anholt --- configure.ac | 8 hw/xfree86/common/xf86Events.c| 6 -- hw/xfree86/common/xf86Init.c | 8 hw

[PATCH xserver 5/6] meson: Try to hook up BSD APM build configuration.

2018-08-01 Thread Eric Anholt
I don't have a BSD to test on, but this should do the same as what autotools did. Signed-off-by: Eric Anholt --- hw/xfree86/os-support/meson.build | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/os-support/meson.build b/hw/xfree86/os-support

[PATCH xserver 6/6] meson: Automatically detect HAVE_PTHREAD_SETNAME_NP

2018-08-01 Thread Eric Anholt
Signed-off-by: Eric Anholt --- include/meson.build | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/include/meson.build b/include/meson.build index 6ed7cc6ca997..678555692f6d 100644 --- a/include/meson.build +++ b/include/meson.build @@ -58,7 +58,23

[PATCH xserver 2/6] meson: Automatically detect support for XTRANS_SEND_FDs.

2018-08-01 Thread Eric Anholt
The SCM_RIGHTS flag seems to be the thing that xtrans depends on, and meson makes the check easy without needing a build option. Signed-off-by: Eric Anholt --- include/meson.build | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/meson.build b/include/meson.build

[PATCH xserver 3/6] automake,meson: Remove HAVE_LIBUDEV define.

2018-08-01 Thread Eric Anholt
CONFIG_UDEV and CONFIG_UDEV_KMS are the actual defines that are used in the C code. Signed-off-by: Eric Anholt --- configure.ac| 1 - include/meson.build | 1 - 2 files changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 7d5cb0d4d0ed..e0ebc78a1c73 100644

[PATCH xserver 1/6] meson: Remove XXX for libconfig in kdrive.

2018-08-01 Thread Eric Anholt
This is already included in ephyr (the only kdrive server left) Signed-off-by: Eric Anholt --- hw/kdrive/src/meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/kdrive/src/meson.build b/hw/kdrive/src/meson.build index 06bc34e04460..f57040745605 100644 --- a/hw/kdrive/src

[PATCH modular] xorg.modules: Update to use meson for the xserver.

2018-08-01 Thread Eric Anholt
I'm proposing a patch to delete autotools, so try to make sure jhbuild keeps working. --- xorg.modules | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xorg.modules b/xorg.modules index 3db392aa358d..638e88daefa4 100644 --- a/xorg.modules +++ b/xorg.modules @@ -1571,7

Re: gitlab migration

2018-06-08 Thread Eric Anholt
Adam Jackson writes: > I'd like us to start moving repos and bug tracking into gitlab. > Hopefully everyone's aware that gitlab exists and why fdo projects are > migrating to it. If not, the thread about Mesa's migration provides > some useful background: > >

Re: glamor_init: clamp GLSL to 120 if platform doesn't have instanced arrays

2018-05-16 Thread Eric Anholt
GL2 (if you've got integer textures, you could do glamor_font.c's accelerated core text rendering, for example), so I'm tempted to take the patch for now so we can start working toward that. Reviewed-by: Eric Anholt <e...@anholt.net> but I'll give others a chance to offer input on t

[PATCH xserver 3/6] dri3: Switch get_drawable_modifiers to using stdint.

2018-05-07 Thread Eric Anholt
We were mixing stdint and CARD* types, causing compiler warnings on 32-bit. Just switch over to stdint, which is what we'd like the server to be using long term, anyway. Signed-off-by: Eric Anholt <e...@anholt.net> --- dri3/dri3.h| 6 +++--- dri3/dri3_screen.c | 4 ++-- glamor/gl

[PATCH xserver 2/6] randr: Fix a compiler warning on 32-bit.

2018-05-07 Thread Eric Anholt
Signed-off-by: Eric Anholt <e...@anholt.net> --- randr/rrprovider.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/randr/rrprovider.c b/randr/rrprovider.c index e4bc2bf6a786..c430f74770c2 100644 --- a/randr/rrprovider.c +++ b/randr/rrprovider.c @@ -276,7

[PATCH xserver 5/6] dri3: Switch fds_from_pixmap to stdint types.

2018-05-07 Thread Eric Anholt
Again, this was causing 32-bit build warnings due to mixing CARD* and stdint. Signed-off-by: Eric Anholt <e...@anholt.net> --- dri3/dri3.h| 6 +++--- dri3/dri3_priv.h | 4 ++-- dri3/dri3_screen.c | 10 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH xserver 6/6] xwayland: Fix a 32-bit build warning.

2018-05-07 Thread Eric Anholt
Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/xwayland/xwayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index f7e2ce931258..87d9ba22c22f 100644 --- a/hw/xwayland/xwayland.c +++ b/hw/xwayland/xwayland.c @@

[PATCH xserver 1/6] dix: Fix a warning about GetTimeInMillis return value in XFont2.

2018-05-07 Thread Eric Anholt
Signed-off-by: Eric Anholt <e...@anholt.net> --- dix/dixfonts.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index cca92ed2791c..0ea8678bbe03 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -2015,6 +2015,11 @@ _remove_fs_ha

[PATCH xserver 4/6] dri3: Switch get_modifiers to using stdint.

2018-05-07 Thread Eric Anholt
We were mixing stdint and CARD* types, causing compiler warnings on 32-bit. Just switch over to stdint, which is what we'd like the server to be using long term, anyway. --- dri3/dri3.h | 6 +++--- dri3/dri3_screen.c| 4 ++-- glamor/glamor.h

Re: [PATCH xserver] glx: Fix attribute handling for GLX_TEXTURE_FORMAT_EXT

2018-05-01 Thread Eric Anholt
Adam Jackson writes: > On Mon, 2018-04-02 at 14:52 -0400, Adam Jackson wrote: > >> @@ -1737,6 +1740,9 @@ __glXDisp_BindTexImageEXT(__GLXclientState * cl, >> GLbyte * pc) >>DixReadAccess, , )) >> return error; >> >> +if (pGlxDraw->format

Re: [PATCH xserver 7/7] modesetting: Allow a DRM fd to be passed through XF86_VIDEO_MODESETTING_FD

2018-02-23 Thread Eric Anholt
Keith Packard writes: > This lets an application open a suitable DRM device and pass the file > descriptor to the mode setting driver through an environment variable. > > There's a companion application, xlease, which creates a DRM master by > leasing an output from another X

Re: [PATCH xserver 5/5] glamor: Enable composite acceleration for rgb10 formats.

2018-02-09 Thread Eric Anholt
Mario Kleiner writes: > argb2101010 and xrgb2101010. Seems to work fine, > but not sure if because of dumb luck or because > it is meant to be. (Re)viewer discretion advised! > > Tested on KDE Plasma-5 with XRender based composite > acceleration backend. Much smoother

Re: [PATCH xserver 1/7] miinitext: General cleanup (v2)

2018-01-21 Thread Eric Anholt
tter place. > > v2: A bunch of drivers assume they'll get the DPMS tokens implicitly, > so add it to globals.h. Patch 1-2, 5-6 are: Reviewed-by: Eric Anholt <e...@anholt.net> For patch 3-4, I'm happy with you and Kyle just coming to agreement on the details of it. I haven't figured out

Re: [PATCH xserver 1/2] meson: Enable SUN-DES-1 auth code

2018-01-18 Thread Eric Anholt
Jon Turney writes: > On 08/01/2018 20:50, Adam Jackson wrote: >> --- >> include/meson.build | 1 + >> meson_options.txt | 1 + >> os/meson.build | 4 >> 3 files changed, 6 insertions(+) > > After this, I needed something like the attached. I'm

Re: [PATCH xserver] meson.build: Fix hw/xwin build when dependencies are installed in a non-default location

2018-01-18 Thread Eric Anholt
Jon Turney <jon.tur...@dronecode.org.uk> writes: > Signed-off-by: Jon Turney <jon.tur...@dronecode.org.uk> Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH xserver] x86emu: Teach the debug code about varargs

2018-01-16 Thread Eric Anholt
rewrite the printf code to actually use varargs and the > appropriate format attribute. All callers of DECODE_PRINTF() pass a > string with no % specifiers, so we pass that as the argument to > printf("%s"). For DECODE_PRINTF2() we just pass the args through. > > Signed-off-by:

Re: [PATCH xserver 1/2] meson: Enable SUN-DES-1 auth code

2018-01-16 Thread Eric Anholt
Adam Jackson <a...@redhat.com> writes: > Signed-off-by: Adam Jackson <a...@redhat.com> These two are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org devel

Re: [PATCH xserver] modesetting: Use seq instead of msc in ms_queue_vblank failure path

2018-01-16 Thread Eric Anholt
ng the wrong value. > > Signed-off-by: Keith Packard <kei...@keithp.com> Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/

Re: [PATCH xserver] glamor: Rename var in glamor_xv, SAMPLE is GLSL keyword

2018-01-03 Thread Eric Anholt
Corentin Rossignon writes: > From: Corentin Rossignon > > This fix issue with gnome-shell and playing video using xv > > Signed-off-by: Corentin Rossignon > Bugzilla: https://bugs.freedesktop.org/104405 This is

Re: [PATCH xserver 2/2] glx: Enable GLX_ARB_create_context_no_error

2017-12-14 Thread Eric Anholt
Adam Jackson writes: > This is mostly for the client library's convenience, if this extension > is listed then it can know the attribute won't be rejected. Note that we > don't _do_ anything with this attribute, meaning indirect contexts will > not be no-error. That's fine, we

Re: [PATCH xserver 1/2] glx: Stop printing messages about what GLX extensions we enable

2017-12-14 Thread Eric Anholt
Adam Jackson <a...@redhat.com> writes: > glxinfo already exists, use it. Yes, please. Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: htt

Re: Another protocol repository merge attempt

2017-12-14 Thread Eric Anholt
Keith Packard writes: > [ Unknown signature status ] > > The idea of merging all of our X protocol repositories came up again, > and Adam Jackson asked if I wanted to wait for this before merging my > randr lease/non-desktop changes. > > Not really? But, I'm still interested

Re: [PATCH xserver] test: Fix build dependency for bigreq test

2017-12-11 Thread Eric Anholt
Adam Jackson <a...@redhat.com> writes: > libxcb-xinput isn't a thing in whichever Ubuntu it is that Travis is > using. The test is already optional, make it more so. We should probably be including current xcb in the docker image. This seems correct, though: Reviewed-by: Er

Re: [PATCH xserver 3/3] glx: Implement GLX_EXT_no_config_context (v2)

2017-11-16 Thread Eric Anholt
tension, under review at: > > https://github.com/KhronosGroup/OpenGL-Registry/pull/102 > > v2: Require that the two screen numbers match, per v4 of spec. Once the spec is accepted, 2-3 are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature _

Re: [PATCH xserver 1/3] glx: Fix glXQueryContext for GLX_FBCONFIG_ID and GLX_RENDER_TYPE (v2)

2017-11-16 Thread Eric Anholt
that request of a direct context, and > if they did we'd be in trouble because we never bothered to preserve the > associated fbconfig in the context state, so we'd crash looking up > GLX_VISUAL_ID_EXT. So let's fix that too. > > v2: Fixed missing preservation of the config in DRI2 (Eric Anhol

Re: [PATCH xserver] glamor: Drop the non-VAO rendering path

2017-11-14 Thread Eric Anholt
tually intended Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] configure.ac: unconditionally enable kdrive

2017-11-02 Thread Eric Anholt
failing > xts, which points the finger at llvmpipe since it rules out any change > in glamor as the culprit. > > I'd already worked around one such regression with llvmpipe [2] but > this one has eluded me. Eric Anholt had written a script to run the > test on a hardware-backed

[PATCH xserver] xkb: Print the xkbcomp path being executed when we fail to compile.

2017-10-31 Thread Eric Anholt
I don't know how many times I've had a broken server due to a bad directory to xkbcomp, and only finding the whole path has shown me where I went wrong. --- xkb/ddxLoad.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xkb/ddxLoad.c b/xkb/ddxLoad.c index

Re: [PATCH v4 xserver] test: Add a test for the overflow bug in bigreqs.

2017-10-30 Thread Eric Anholt
Peter Hutterer <peter.hutte...@who-t.net> writes: > From: Eric Anholt <e...@anholt.net> > > The failing struct comes from the python test written by Michal Srb > <m...@suse.com>. > > v2: Use a drawable (root window) and gc, so that PolyLines hopefully &g

Re: [PATCH xserver 1/3] glamor: Unconditionalize GLAMOR_GRADIENT_SHADER

2017-10-25 Thread Eric Anholt
Adam Jackson <a...@redhat.com> writes: > Effectively always true anyway. All 3: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists

Re: [PATCH xserver] glamor: Use GL_MESA_tile_raster_order for overlapping blits.

2017-10-13 Thread Eric Anholt
Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >>> Looks like you're also requiring nv_texture_barrier to use the new >>> extension? >> >> texture_barrier is an explicit requi

Re: [PATCH xserver] glamor: Use GL_MESA_tile_raster_order for overlapping blits.

2017-10-11 Thread Eric Anholt
Keith Packard <kei...@keithp.com> writes: > [ Unknown signature status ] > Eric Anholt <e...@anholt.net> writes: > >> +/* Include the enums here for the moment, to keep from needing to bump >> epoxy. */ >> +#ifndef GL_TILE_RASTER_ORDER_FIXED_MESA >

[PATCH xserver] glamor: Use GL_MESA_tile_raster_order for overlapping blits.

2017-10-10 Thread Eric Anholt
Improves Raspberry Pi 3 x11perf -copywinwin100 from ~4700/sec to ~5130/sec. Signed-off-by: Eric Anholt <e...@anholt.net> --- glamor/glamor.c | 2 ++ glamor/glamor_copy.c | 74 ++-- glamor/glamor_priv.h | 1 + 3 files changed, 52 inse

Re: [PATCH] os: Make sure big requests have sufficient length.

2017-10-09 Thread Eric Anholt
Peter Hutterer <peter.hutte...@who-t.net> writes: > On Mon, Sep 25, 2017 at 12:55:47PM -0700, Eric Anholt wrote: >> Michal Srb <m...@suse.com> writes: >> >> > On neděle 24. září 2017 0:20:07 CEST Eric Anholt wrote: >> >> Michal Srb <m...@

[PATCH xserver] test: Add a test for the overflow bug in bigreqs.

2017-10-09 Thread Eric Anholt
owever, this does let us distinguish between detecting the bigrequests error and not, at least. v3: Clean up the description of what we expect the poll() call to do. Signed-off-by: Eric Anholt <e...@anholt.net> --- test/bigreq/meson.build | 8 + test/bigreq/request-l

Re: [PATCH xserver 4/6] meson: Default to gnu99

2017-09-28 Thread Eric Anholt
ling it __typeof__, but who wants that? Nobody, > that's who. > > Signed-off-by: Adam Jackson <a...@redhat.com> Patch 1-4 are: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.

Re: [PATCH xserver] xfree86: Hush some warnings when Xv is disabled

2017-09-25 Thread Eric Anholt
Mesa has started using their _X_UNUSED equivalent for stuff like this, so that things are compiled either way but DCEed without complaint when the caller is disabled. However, this is also a correct cleanup, so: Reviewed-by: Eric Anholt <e...@anh

Re: [PATCH] os: Make sure big requests have sufficient length.

2017-09-25 Thread Eric Anholt
Michal Srb <m...@suse.com> writes: > On neděle 24. září 2017 0:20:07 CEST Eric Anholt wrote: >> Michal Srb <m...@suse.com> writes: >> > Here is a script that can be used to crash X server using a broken big >> > request for PolyLine. It con

Re: [PATCH] os: Make sure big requests have sufficient length.

2017-09-24 Thread Eric Anholt
Michal Srb writes: > Here is a script that can be used to crash X server using a broken big > request > for PolyLine. It connects to DISPLAY=:1 and doesn't support authentication. > Look inside the script for more details. > > Other requests could be used to crash X server in

Re: [PATCH xserver] travis: Also build on OSX

2017-09-24 Thread Eric Anholt
Jon Turney writes: > Signed-off-by: Jon Turney Thanks for doing this! I'll want to convert it to meson some day, but it'll be a lot easier now that we have travis in place. remote: I: patch #178342 updated using rev

Re: [PATCH xserver] meson: Make it possible to build for 32-bit targets

2017-09-24 Thread Eric Anholt
Jon Turney writes: > Setting glx_align64 to '' gives a null string in the arguments list passed > to the compiler. This is taken as an input filename, leading to: > > "cc: error: : No such file or directory" > > Instead, assign an empty list to glx_align64, which

Re: [PATCH xserver 2/2] glx: Implement GLX_EXT_no_config_context

2017-09-21 Thread Eric Anholt
Adam Jackson writes: > Only enabled for the DRI backends at the moment. In principle WGL/CGL > could support this - it's sort of implied by GL 3.0 support - but in > practice I don't know that it would actually work. > > This is currently a draft extension, under review at: > >

Re: [PATCH xserver 1/2] glx: Fix glXQueryContext for GLX_FBCONFIG_ID and GLX_RENDER_TYPE

2017-09-21 Thread Eric Anholt
rd -- QueryContext and QueryContextInfoEXT are both returning the same values, and the existing values we were giving were only for QCIE. This seems to be OK because the proto is the same for both, and the glX call must be picking the attributes it cares about out of the reply. So, with the glx

Re: [PATCH xserver 2/2] meson: Use dependency version_compare()

2017-09-20 Thread Eric Anholt
said, you've reduced the build system complexity with the rest of this patch, so: Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver 1/2] Build: Use dri3proto/libdrm CFLAGS

2017-09-20 Thread Eric Anholt
Daniel Stone <dani...@collabora.com> writes: > Make sure we get the CFLAGS required for building DRI3 into the > command line. > > Signed-off-by: Daniel Stone <dani...@collabora.com> Reviewed-by: Eric Anholt <e...@anholt.net> signature.

[PATCH xserver 2/6] meson: Add Xvfb and Xephyr-glamor testing.

2017-09-18 Thread Eric Anholt
The Xvfb tests are passing and Xephyr-glamor is failing for me, but it fails identically on autotools. It's disabled on Travis for now because the >10 minutes of silence during testing times out the entire build. v2: Fix the disable on travis. Signed-off-by: Eric Anholt <e...@anho

[PATCH xserver 4/6] test: Add basic SYNC tests.

2017-09-18 Thread Eric Anholt
Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Keith Packard <kei...@keithp.com> --- hw/vfb/meson.build| 2 +- test/meson.build | 2 + test/sync/meson.build | 9 ++ test/sync/sync.c | 304 ++ 4 files changed

[PATCH xserver 1/6] meson: Move Xvfb build under an option.

2017-09-18 Thread Eric Anholt
Autotools also had it as an option. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/meson.build| 4 +++- meson_options.txt | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/meson.build b/hw/meson.build index c0d2db3f5c85..96c1559c348b 100644 --- a/hw/meson

[PATCH xserver 6/6] sync: Clean up a bit of header formatting.

2017-09-18 Thread Eric Anholt
Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Keith Packard <kei...@keithp.com> --- miext/sync/misyncstr.h | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/miext/sync/misyncstr.h b/miext/sync/misyncstr.h index 084ca4c82d9d..2eab2aa

[PATCH xserver 3/6] test: Return error from simple-xinit if the client crashes.

2017-09-18 Thread Eric Anholt
I want to be able to call client tests with simple-xinit, so assertion failures should be an error. v2: Clean up identical returns. Signed-off-by: Eric Anholt <e...@anholt.net> --- test/simple-xinit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/simple-xinit.c b/test/

[PATCH RESEND xserver 0/6] sync int64 series resend

2017-09-18 Thread Eric Anholt
I've squashed in the fixes and I'm resending, since some of the early patches never got reviewed. I suspect they got lost in all the noise about casting. Still passes the tests locally and on Travis. Eric Anholt (6): meson: Move Xvfb build under an option. meson: Add Xvfb and Xephyr-glamor

[PATCH xserver 5/6] sync: Convert from "CARD64" to int64_t.

2017-09-18 Thread Eric Anholt
, let's just use that here, instead. v2: Fix alarm delta changes. v3: Do the potentially overflowing math as uint and convert to int afterward, out of C spec paranoia. Signed-off-by: Eric Anholt <e...@anholt.net> Reviewed-by: Keith Packard <kei...@keithp.com> --- Xext/sync.c

Re: [PATCH libpciaccess] linux: support 32 bit PCI domains (v3)

2017-09-18 Thread Eric Anholt
compatibility, though it still only supports one > domain and will never be better. > > Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=101744 > Signed-off-by: Stephen Hemminger <sthem...@microsoft.com> Reviewed-by: Eric Anholt <e...@anholt.net> signature.asc Desc

Re: [PATCH] glx: remove unused systemTimeExtension

2017-09-08 Thread Eric Anholt
Emil Velikov <emil.l.veli...@gmail.com> writes: > On 23 August 2017 at 18:08, Eric Anholt <e...@anholt.net> wrote: >> Emil Velikov <emil.l.veli...@gmail.com> writes: >> >>> Not even a single DRI2/DRISW driver in mesa ever used this. Appears to be a >&

Re: [PATCH libpciaccess] linux: support 32 bit PCI domains (v2)

2017-09-08 Thread Eric Anholt
Adam Jackson writes: > From: Stephen Hemminger > > The PCI domain may be larger than 16 bits on Microsoft Azure and other > virtual environments. PCI busses reported by ACPI are limited to 16 > bits, but in Azure the domain value for pass through

Re: [PATCH xserver] squash! sync: Convert from "CARD64" to int64_t. (v2)

2017-09-05 Thread Eric Anholt
Pekka Paalanen <ppaala...@gmail.com> writes: > [ Unknown signature status ] > On Fri, 1 Sep 2017 11:55:15 -0700 > Eric Anholt <e...@anholt.net> wrote: > >> --- >> >> Pekka - that link didn't help, because we still need a correct >> "result&q

Re: [PATCH] configure.ac: Make BUILD_{DATE, TIME} respect SOURCE_DATE_EPOCH if set

2017-09-01 Thread Eric Anholt
Chris Lamb writes: > Hi xorg-devel, > > Whilst working on the Reproducible Builds effort [0], we noticed > that xorg-server could not be built reproducibly. I tried applying the patch today, but it broke the build by changing the format. I fixed it up, propagated it over to

[PATCH xserver 4/4] meson: Move the BUILD_DATE/TIME setup to configure time.

2017-09-01 Thread Eric Anholt
final Xorg, but BUILD_DATE/TIME is such a dubious feature (compared to including a git sha, which is easy with meson) it doesn't seem worth the build time cost. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/xfree86/common/meson.build | 6 ++ 1 file changed, 2 insertions(+), 4 deletion

[PATCH xserver 3/4] meson: Include BUILD_DATE in the meson xf86Build.h.

2017-09-01 Thread Eric Anholt
Due to a typo, I only had BUILD_TIME present. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/xfree86/common/xf86Build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/common/xf86Build.sh b/hw/xfree86/common/xf86Build.sh index e1b14cec5a85..5f859a

[PATCH xserver 1/4] configure.ac: Make BUILD_{DATE, TIME} respect SOURCE_DATE_EPOCH if set

2017-09-01 Thread Eric Anholt
(1). [0] https://reproducible-builds.org/ v2: Fix change in Y-M-D format that broke the build. Signed-off-by: Eric Anholt <e...@anholt.net> --- configure.ac | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eee1257a96ed..f13a54ab9dbf 100

[PATCH xserver 2/4] meson: Respect SOURCE_DATE_EPOCH for reproducible builds.

2017-09-01 Thread Eric Anholt
This just copies over Chris Lamb's code from autotools. Signed-off-by: Eric Anholt <e...@anholt.net> --- hw/xfree86/common/xf86Build.sh | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/common/xf86Build.sh b/hw/xfree86/common/xf86Build.sh

[PATCH xserver] squash! sync: Convert from "CARD64" to int64_t. (v2)

2017-09-01 Thread Eric Anholt
--- Pekka - that link didn't help, because we still need a correct "result" value. I don't believe that the compiler could break uint -> int conversions with the high bit, but here's the patch I think we would need for that. I still think v1 is the better version. include/misc.h | 21

[PATCH xserver] squash! sync: Convert from "CARD64" to int64_t.

2017-08-24 Thread Eric Anholt
--- We pass the overflow unit tests both before and after this change, but this should be safer. include/misc.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/misc.h b/include/misc.h index 0feeaebc7c1a..9d0e422e36b4 100644 --- a/include/misc.h +++

[PATCH xserver 4/7 v2] test: Return error from simple-xinit if the client crashes.

2017-08-23 Thread Eric Anholt
I want to be able to call client tests with simple-xinit, so assertion failures should be an error. v2: Clean up identical returns. Signed-off-by: Eric Anholt <e...@anholt.net> --- This, and patch 2 and 3 need review, then I think we're ready. test/simple-xinit.c | 3 +++ 1 file chan

Re: [PATCH xserver 5.5/7] test: Extend sync tests to cover alarm delta and waitvalue changes.

2017-08-23 Thread Eric Anholt
Eric Anholt <e...@anholt.net> writes: > This would be squashed into the other tests. > > Signed-off-by: Eric Anholt <e...@anholt.net> Bah. I accidentally globbed the wrong set. signature.asc Description: PGP signature ___ x

Re: [PATCH] glx: remove unused systemTimeExtension

2017-08-23 Thread Eric Anholt
Emil Velikov <emil.l.veli...@gmail.com> writes: > Not even a single DRI2/DRISW driver in mesa ever used this. Appears to be a > dri1 artefact copy/pasted in the dri2/drisw codebase. Agreed that it seems to be only DRI1 drivers that used it. Reviewed-by: Eric Anholt <

[PATCH xserver 6/7 v2] sync: Convert from "CARD64" to int64_t.

2017-08-23 Thread Eric Anholt
, let's just use that here, instead. v2: Fix alarm delta changes. Signed-off-by: Eric Anholt <e...@anholt.net> --- Xext/sync.c | 302 +++- Xext/syncsrv.h | 23 ++-- include/misc.h | 25 miext/sync/misync.c

[PATCH xserver 5.5/7] test: Extend sync tests to cover alarm delta and waitvalue changes.

2017-08-23 Thread Eric Anholt
This would be squashed into the other tests. Signed-off-by: Eric Anholt <e...@anholt.net> --- test/sync/sync.c | 71 ++-- 1 file changed, 69 insertions(+), 2 deletions(-) diff --git a/test/sync/sync.c b/test/sync/sync.c index c39774

Re: [PATCH xserver v2] meson: Fix epoll detection

2017-08-14 Thread Eric Anholt
Peter Harris writes: > The epoll code depends on epoll_create1, not epoll_create. Reviewed and pushed. Thanks! signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives:

Re: [PATCH xserver 2/3] glamor: Scissor CopyArea to the bounds of the drawing.

2017-08-14 Thread Eric Anholt
Mark Marshall <markmarshal...@gmail.com> writes: > On 1 August 2017 at 22:59, Eric Anholt <e...@anholt.net> wrote: >> Like the previous fix to rectangles, this reduces the area drawn on >> tiled renderers by letting the CPU-side tile setup know what til

Re: [PATCH xserver] meson: Fix epoll detection

2017-08-14 Thread Eric Anholt
Peter Harris writes: > On 2017-08-11 5:50 AM, Peter Hutterer wrote: >> On Tue, Aug 08, 2017 at 11:16:13AM -0400, Peter Harris wrote: >>> The epoll code depends on epoll_create1, not epoll_create. >>> >>> The trinary " ? 1 : false" is used because HAVE_EPOLL_CREATE1 is

  1   2   3   4   5   6   7   8   9   10   >