[PATCH 1/1] randr: avoid rrGetScreenResources replying with uninitialized bytes.

2011-03-09 Thread Oliver McFadden
: ProcEstablishConnection (dispatch.c:3685) ====by 0x26CEB: Dispatch (dispatch.c:432) ====by 0x205E7: main (main.c:291) ==== Uninitialised value was created by a stack allocation ====at 0xCA4E0: rrGetScreenResources (rrscreen.c:313) Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com

Memory corruption with xbindkeys and xcb 1.7-2 (debian)

2011-03-07 Thread Oliver McFadden
Hi, I am not sure whether this is a known issue, but anyway, I am seeing xbindkeys crashing after a few button presses. Perhaps this should go to the xbindkeys developers, but I'm reasonably sure this is a bug in xcb. You can reproduce it as follows: 1. Start xbindkeys in non-daemon mode so you

Re: [PATCH] [xserver] record: avoid crash when calling RecordFlushReplyBuffer recursively

2011-02-14 Thread Oliver McFadden
rami.ylim...@vincit.fi Signed-off-by: Erkki Seppälä erkki.sepp...@vincit.fi Reviewed-by: Oliver McFadden oliver.mcfad...@nokia.com --- record/record.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/record/record.c b/record/record.c index 6a93d7a..bea3046 100644

Re: [PATCH] [xserver] record: avoid crash when calling RecordFlushReplyBuffer recursively

2011-02-14 Thread Oliver McFadden
On Mon, 2011-02-14 at 19:59 +0200, Oliver McFadden wrote: I don't think this has been merged into master yet (and we should apply it to the 1.9.xxx branches too), so I've added my Reviewed-by below. Good catch! Sorry for the bump again. I was asked to add the Reported-by and Tested-by tags

Re: [PATCH] [xserver] record: avoid crash when calling RecordFlushReplyBuffer recursively

2011-02-14 Thread Oliver McFadden
On Mon, 2011-02-14 at 19:23 +0100, ext Julien Cristau wrote: On Mon, Feb 14, 2011 at 20:05:45 +0200, Oliver McFadden wrote: On Mon, 2011-02-14 at 19:59 +0200, Oliver McFadden wrote: I don't think this has been merged into master yet (and we should apply it to the 1.9.xxx branches too

Re: [PATCH 0/4] Fix some valgrind uninitialised byte errors.

2011-02-08 Thread Oliver McFadden
that there wouldn't be huge commit messages. You can add this for the entire series: Reviewed-by: Oliver McFadden oliver.mcfad...@nokia.com Ander Conselvan de Oliveira (4): ProcRRQueryVersion: fix use of uninitialized bytes valgrind error. ProcRRCreateMode: fix use of uninitialized bytes

[PATCH 1.9.2.902 1/1] dix: GetPointerEvents: added valuator range checking

2011-01-24 Thread Oliver McFadden
: GetPointerEvents (getevents.c:1074) Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- I'm not sure anyone actually cares about this patch anymore, since this code has changed completely due to the valuator rework. If someone wants to apply it to the 1.9.2(.xxx) branches, then please be my

Re: [PATCH evdev] evdev: added property Evdev Axes Rotation. #27688

2010-10-29 Thread Oliver McFadden
On Fri, 2010-10-29 at 15:37 +1000, ext Peter Hutterer wrote: On Sun, Oct 24, 2010 at 01:45:03PM +0200, Paolo D'Apice wrote: The evdev driver does not allow to set a custom axes rotation as the mousedrv driver does with the option AngleOffset. This option is necessary for some trackballs,

[PATCH 1/1] os: added the -sigstop option for Upstart (or equivalent) startup.

2010-07-14 Thread Oliver McFadden
, send us SIGCONT and move our job status from SPAWNED to RUNNING. Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- include/opaque.h |1 + os/connection.c |5 + os/utils.c |5 + 3 files changed, 11 insertions(+), 0 deletions(-) diff --git a/include/opaque.h

[PATCH v3 1/1] os: added the -upstart option for Upstart's signaling method.

2010-07-13 Thread Oliver McFadden
job status from SPAWNED to RUNNING. Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- v3: resend patch because it seems to have been idle for some time... - changed kill(getpid()) to raise(). include/opaque.h |1 + os/connection.c |5 + os/utils.c |5 + 3

Re: [PATCH] fb: Trim fill to drawable bounds

2010-07-02 Thread Oliver McFadden
On Fri, 2010-07-02 at 10:43 +0200, ext Chris Wilson wrote: Fixes: Bug 27313 - random X11 crash (SIGSEGV) when rendering firefox in pixman/intel https://bugs.freedesktop.org/show_bug.cgi?id=27313 As pixman does not guard against a fill request outside of the buffer, we must be be

Re: [PATCH] fb: Trim fill to drawable bounds

2010-07-02 Thread Oliver McFadden
be be careful and trim oversized fills. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Tested-by: Michael Stapelberg michael+freedesk...@stapelberg.de Reviewed-by: Oliver McFadden oliver.mcfad...@nokia.com --- fb/fbfill.c| 38 -- include/misc.h |1

Re: helping organize x.org documentation

2010-05-27 Thread Oliver McFadden
On Fri, 2010-05-28 at 01:55 +0200, ext Tiago Vignatti wrote: Matt, On 05/26/2010 04:12 PM, Matt Dew wrote: Ok here's a summary of current changes: 1) I used kernelnewbies.org as the template, so this page doesn't look like the xorg wiki. (probably least important diff), I guess you

Re: helping organize x.org documentation

2010-05-27 Thread Oliver McFadden
On Fri, 2010-05-28 at 06:34 +0200, ext Peter Hutterer wrote: On Fri, May 28, 2010 at 03:23:32AM +0300, Oliver McFadden wrote: On Fri, 2010-05-28 at 01:55 +0200, ext Tiago Vignatti wrote: Matt, On 05/26/2010 04:12 PM, Matt Dew wrote: Ok here's a summary of current changes

Re: helping organize x.org documentation

2010-05-27 Thread Oliver McFadden
On Fri, 2010-05-28 at 07:09 +0200, ext Alan Coopersmith wrote: Oliver McFadden wrote: Right, that's true. I would suggest switching over to MediaWiki at some point though. This could of course be after cleaning up the docs. I like MediaWiki too, at least from the user perspective

Re: [PATCH] xfixes: Remove the invisible cursor sprite, using NullCursor instead.

2010-05-24 Thread Oliver McFadden
-05-24 at 20:45 +0200, ext Jamey Sharp wrote: Oliver McFadden reports that the invisible cursor sprite caused damage events and thus unnecessary redrawing, so removing it improves performance when using software cursor sprites, especially on those devices where you do not want a visible cursor

Re: [PATCH] xfixes: Remove the invisible cursor sprite, using NullCursor instead.

2010-05-24 Thread Oliver McFadden
Oops; forgot to reply-to-all. On Tue, 2010-05-25 at 07:17 +0300, Oliver McFadden wrote: On Tue, 2010-05-25 at 05:00 +0200, ext Jamey Sharp wrote: Hi Oliver! On Mon, May 24, 2010 at 7:45 PM, Oliver McFadden oliver.mcfad...@nokia.com wrote: I'll check this today on my hardware; I think

Re: [PATCH] mi: removed the invisible cursor and never realize this cursor.

2010-05-21 Thread Oliver McFadden
cursor (touchscreen tablets, embedded devices, etc.) Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- v2 of [PATCH] mi: removed the invisible cursor sprite; use NullCursor instead. xfixes/cursor.c | 46 -- 1 files changed

Re: [PATCH] mi: removed the invisible cursor sprite; use NullCursor instead.

2010-05-20 Thread Oliver McFadden
On Tue, 2010-05-18 at 22:38 +0200, ext Jamey Sharp wrote: For the xfree86 DDX, if hardware cursors are used, the driver is required to provide a HideCursor function, which will be called instead of trying to set a null cursor. I think software cursors are already safe. The other DDXes also

Re: [PATCH] mi: removed the invisible cursor sprite; use NullCursor instead.

2010-05-18 Thread Oliver McFadden
On Tue, 2010-05-18 at 08:34 +0200, ext Keith Packard wrote: On Tue, 18 May 2010 08:44:27 +0300, Oliver McFadden oliver.mcfad...@nokia.com wrote: I suppose for HW cursor it doesn't really matter since we wouldn't take damage on that, right? We just draw everything normally, then tell

[PATCH] mi: removed unused PointerNonInterestBox functions.

2010-05-13 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- hw/xnest/Screen.c|1 - include/scrnintstr.h |2 +- mi/mipointer.c | 12 mi/miscrinit.c |1 - 4 files changed, 1 insertions(+), 15 deletions(-) diff --git a/hw/xnest/Screen.c b/hw/xnest

Re: [PATCH] mi: removed unused PointerNonInterestBox functions.

2010-05-13 Thread Oliver McFadden
On Thu, 2010-05-13 at 13:23 +0200, ext Keith Packard wrote: On Thu, 13 May 2010 11:45:02 +0300, Oliver McFadden oliver.mcfad...@nokia.com wrote: -PointerNonInterestBoxProcPtr PointerNonInterestBox; +PointerNonInterestBoxProcPtr PointerNonInterestBox; /** unused */ I'd just go

[PATCH v2 1/2] mi: removed unused PointerNonInterestBox functions.

2010-05-13 Thread Oliver McFadden
Please note this patch breaks the ABI. Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com Reviewed-by: Keith Packard kei...@keithp.com --- v2: completely remove the unused function pointer from the ScreenRec struct in scrnintstr.h. Added note regarding ABI breakage. hw/xnest/Screen.c

[PATCH 2/2] scrnintstr.h: removed unused PaintWindow function pointers.

2010-05-13 Thread Oliver McFadden
Please note this patch breaks the ABI. Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- hw/dmx/doc/dmx.sgml |3 +-- hw/xquartz/quartz.c |1 - include/scrnintstr.h |5 - mi/miexpose.c|2 -- 4 files changed, 1 insertions(+), 10 deletions(-) diff --git

Re: [PATCH] mi: removed unused PointerNonInterestBox functions.

2010-05-13 Thread Oliver McFadden
On Thu, 2010-05-13 at 21:07 +0200, ext Adam Jackson wrote: On Thu, 2010-05-13 at 09:58 -0700, Keith Packard wrote: On Thu, 13 May 2010 17:24:06 +0300, Oliver McFadden oliver.mcfad...@nokia.com wrote: Wouldn't this break the ScreenRec ABI? I noticed this structure also has a few

[PATCH v2 2/2] scrnintstr.h: removed unused PaintWindow function pointers.

2010-05-13 Thread Oliver McFadden
Please note this patch breaks the ABI. Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- hw/dmx/doc/dmx.sgml |3 +-- hw/xquartz/quartz.c |1 - include/scrnintstr.h | 10 -- mi/miexpose.c|2 -- 4 files changed, 1 insertions(+), 15 deletions(-) diff

[PULL] mi, scrnintstr.h: removed unused function pointers.

2010-05-13 Thread Oliver McFadden
The following changes since commit 795432d4a92ed5b9fa4d9163e73c8e4fe4c74534: Keith Packard (1): Merge remote branch 'jamey/cleanups' are available in the git repository at: git://gitorious.org/omcfadde/xserver.git master Oliver McFadden (2): mi: removed unused

[PATCH] x-list.c: null-returning function malloc() was called without checking

2010-04-22 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- hw/xquartz/xpr/x-list.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xquartz/xpr/x-list.c b/hw/xquartz/xpr/x-list.c index 3596dd3..77c9309 100644 --- a/hw/xquartz/xpr/x-list.c +++ b/hw/xquartz/xpr/x-list.c

Re: [PATCH] evdev: add 3x3 transformation matrix xinput property for multi-head handling

2010-04-21 Thread Oliver McFadden
On Wed, 2010-04-21 at 07:56 +0200, ext Peter Korsgaard wrote: Oliver == Oliver McFadden oliver.mcfad...@nokia.com writes: Oliver Hi Peter, Oliver There is one minor bug in this patch, you forgot to xfree() Oliver str from xf86CheckStrOption when you're done with it; see my Oliver

Re: [PATCH] evdev: add 3x3 transformation matrix xinput property for multi-head handling

2010-04-21 Thread Oliver McFadden
On Wed, 2010-04-21 at 08:30 +0200, ext Peter Korsgaard wrote: Oliver == Oliver McFadden oliver.mcfad...@nokia.com writes: Hi, Oliver Everything else looks fine; just the leaked storage issue. Great, can I add your Acked-by then when I resend? Yeah, no problem. -- Oliver

Re: Coverity fixes for xf86-input-evdev

2010-04-20 Thread Oliver McFadden
On Tue, 2010-04-20 at 07:27 +0200, ext Peter Hutterer wrote: On Tue, Apr 20, 2010 at 07:11:15AM +0300, Oliver McFadden wrote: Hi Peter, Most of these fixes are quite minor and related to memory leaks from xf86...StrOption. They fix all Coverity errors in evdev apart from one dead-code

[PULL] evdev: pull request for Coverity fixes

2010-04-20 Thread Oliver McFadden
The following changes since commit aaf65e7bfacd9501c4475a579d92c3bc60409893: Paulo Ricardo Zanoni (1): Don't set pEvdev-rel for mouse wheel events are available in the git repository at: git://gitorious.org/omcfadde/xf86-input-evdev.git master Oliver McFadden (3): evdev

Re: [PATCH] evdev: add 3x3 transformation matrix xinput property for multi-head handling

2010-04-20 Thread Oliver McFadden
Hi Peter, There is one minor bug in this patch, you forgot to xfree() str from xf86CheckStrOption when you're done with it; see my recent patch to evdev. I'll apply the patch locally and do a full analysis after my coffee. :-) -- Oliver. On Tue, 2010-04-20 at 17:36 +0200, ext Peter Korsgaard

Coverity fixes for xf86-input-evdev

2010-04-19 Thread Oliver McFadden
Hi Peter, Most of these fixes are quite minor and related to memory leaks from xf86...StrOption. They fix all Coverity errors in evdev apart from one dead-code error in EvdevUtilButtonEventToButtonNumber which I have intentionally left unmodified (in case that code changes in the future.) Event

[PATCH 2/7] evdev: leaked_storage: EvdevAddAbsClass: Variable mode goes out of scope

2010-04-19 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- src/evdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index c3b44bb..aae9b23 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1235,6 +1235,7 @@ EvdevAddAbsClass(DeviceIntPtr device

[PATCH 6/7] dragLock: leaked_storage: EvdevDragLockPreInit: Variable option_string goes out of scope

2010-04-19 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- src/draglock.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/draglock.c b/src/draglock.c index 6157cae..a7ad974 100644 --- a/src/draglock.c +++ b/src/draglock.c @@ -145,6 +145,8 @@ EvdevDragLockPreInit

[PATCH 4/7] evdev: leaked_storage: EvdevInitButtonMapping: Variable mapping goes out of scope

2010-04-19 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- src/evdev.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 9fe952e..6992c68 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1371,15 +1371,16 @@ EvdevInitButtonMapping

[PATCH 1/7] evdev: leaked_storage: EvdevPreInit: Variable str goes out of scope

2010-04-19 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- src/evdev.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index d133870..c3b44bb 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -2071,6 +2071,7 @@ EvdevPreInit(InputDriverPtr drv

[PATCH 3/7] evdev: var_assign: EvdevCacheCompare: NEGATIVE return value of ioctl assigned to unsigned variable len

2010-04-19 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- src/evdev.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index aae9b23..9fe952e 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1631,8 +1631,7 @@ static int EvdevCacheCompare

[PATCH 7/7] evdev: checked_return: EvdevProbe: Unchecked call

2010-04-19 Thread Oliver McFadden
Called function ioctl whose return value should be checked (checked 10 out of 11 times) Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- src/evdev.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 6992c68..ccea90d 100644

[PATCH 5/7] emuWheel: leaked_storage: EvdevWheelEmuHandleButtonMap: Variable option_string goes out of scope

2010-04-19 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- src/emuWheel.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/emuWheel.c b/src/emuWheel.c index 3f0dfd4..afafff7 100644 --- a/src/emuWheel.c +++ b/src/emuWheel.c @@ -232,8 +232,8

Re: [PULL] Minor bug-fixes discovered by static analysis.

2010-03-15 Thread Oliver McFadden
On Mon, 2010-03-15 at 16:23 +0100, ext Keith Packard wrote: On Tue, 09 Mar 2010 12:56:33 +0200, Oliver McFadden oliver.mcfad...@nokia.com wrote: Yeah, okay; my bad then. I will resend the patches individually. Were you going to post these patches so we can finish up the review process

[PATCH 3/5] parser: xf86readConfigFile: unreachable: This code cannot be reached: free(val.str);

2010-03-15 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- hw/xfree86/parser/read.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/parser/read.c b/hw/xfree86/parser/read.c index 1091be5..4e42b24 100644 --- a/hw/xfree86/parser/read.c +++ b/hw/xfree86

[PATCH 2/5] fb: fbFinishScreenInit: leaked_storage: Variable (visuals|depths) goes out of scope

2010-03-15 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com Reviewed-by: Matt Turner matts...@gmail.com --- fb/fbscreen.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fb/fbscreen.c b/fb/fbscreen.c index 24eadde..53e2ada 100644 --- a/fb/fbscreen.c +++ b/fb/fbscreen.c

[PATCH 5/5] Xext: IdleTimeBlockHandler: unsigned_compare: Comparing unsigned less than zero is never true. timeout 0UL

2010-03-15 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- Xext/sync.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/Xext/sync.c b/Xext/sync.c index ce65314..cf78cdc 100644 --- a/Xext/sync.c +++ b/Xext/sync.c @@ -2329,10 +2329,8 @@ IdleTimeBlockHandler(pointer env

Minor bug-fixes discovered by static analysis.

2010-03-15 Thread Oliver McFadden
Hi, This is the same as the pull request, but in easier to review patch format. I have added Matt Turner's Reviewed-by lines to the patches he checked as OK. [PATCH 1/5] exa: exaFinishAccess: Overrun of static array pExaScr-access of size 6 at position 6 with index variable i [PATCH 2/5] fb:

[PATCH 1/5] exa: exaFinishAccess: Overrun of static array pExaScr-access of size 6 at position 6 with index variable i

2010-03-15 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- exa/exa.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exa/exa.c b/exa/exa.c index c5ac7de..590d9a5 100644 --- a/exa/exa.c +++ b/exa/exa.c @@ -417,8 +417,8 @@ exaFinishAccess(DrawablePtr pDrawable, int

Re: [PULL] Minor bug-fixes discovered by static analysis.

2010-03-07 Thread Oliver McFadden
On Sat, 2010-03-06 at 19:19 +0100, ext Matt Turner wrote: On Fri, Mar 5, 2010 at 7:12 AM, Oliver McFadden oliver.mcfad...@nokia.com wrote: are available in the git repository at: git://gitorious.org/omcfadde/xserver.git analysis Do you not have an account on FreeDesktop.org? I do

[PULL] Minor bug-fixes discovered by static analysis.

2010-03-05 Thread Oliver McFadden
are available in the git repository at: git://gitorious.org/omcfadde/xserver.git analysis Oliver McFadden (5): exa: exaFinishAccess: Overrun of static array pExaScr-access of size 6 at position 6 with index variable i fb: fbFinishScreenInit: leaked_storage: Variable (visuals

Re: [PATCH] os: Prevent backtrace from being stopped in noreturn functions.

2010-03-01 Thread Oliver McFadden
On Mon, 2010-03-01 at 11:53 +0100, ext Guillem Jover wrote: Hi! On Mon, 2010-03-01 at 09:42:58 +0200, Oliver McFadden wrote: From: Ylimaki Rami (EXT-Vincit/Tampere) ext-rami.ylim...@nokia.com diff --git a/configure.ac b/configure.ac index b9c7574..acedf74 100644 --- a/configure.ac

One missing patch from Rami's ARM backtrace series.

2010-02-28 Thread Oliver McFadden
Hi, I'm sending this on behalf of Rami as it doesn't seem to have been included into the tree with the other ARM backtrace patches. It's related to the already included commits: 5b9a52be7e975e59e0bbc6b43539ecaff96b2ecd ca364ca82a760d8e5347a6f9f79636c9a5e4e03f (etc) Perhaps it was never sent, or

[PATCH] evdev: pass the valuators to the X server for ButtonPress/Release events.

2010-02-25 Thread Oliver McFadden
Previously this was not implemented because it requires the X server has the xf86PostButtonEventP() function which was not released at the time. Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- src/evdev.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] evdev: pass the valuators to the X server for ButtonPress/Release events.

2010-02-25 Thread Oliver McFadden
On Thu, 2010-02-25 at 11:25 +0100, ext Julien Cristau wrote: On Thu, Feb 25, 2010 at 10:21:07 +0200, Oliver McFadden wrote: Previously this was not implemented because it requires the X server has the xf86PostButtonEventP() function which was not released at the time. Can you either

Re: [PATCH] evdev: pass the valuators to the X server for ButtonPress/Release events.

2010-02-25 Thread Oliver McFadden
On Fri, 2010-02-26 at 01:48 +0100, ext Peter Hutterer wrote: On Thu, Feb 25, 2010 at 10:21:07AM +0200, Oliver McFadden wrote: Previously this was not implemented because it requires the X server has the xf86PostButtonEventP() function which was not released at the time. Signed-off

Re: [PATCH] evdev: pass the valuators to the X server for ButtonPress/Release events.

2010-02-25 Thread Oliver McFadden
On Fri, 2010-02-26 at 01:53 +0100, ext Peter Hutterer wrote: On Thu, Feb 25, 2010 at 11:45:59AM +0100, Julien Cristau wrote: On Thu, Feb 25, 2010 at 12:35:00 +0200, Oliver McFadden wrote: On Thu, 2010-02-25 at 11:25 +0100, ext Julien Cristau wrote: On Thu, Feb 25, 2010 at 10:21:07

Re: [PATCH] os: added the -upstart option for Upstart's signaling method.

2010-02-24 Thread Oliver McFadden
On Wed, 2010-02-24 at 08:49 +0100, ext Aaron Plattner wrote: On Tue, Feb 23, 2010 at 10:15:31PM -0800, Oliver McFadden wrote: This is very similar to the RunFromSmartParent option, except we do not send the signal to our parent process, but our own process instead; also the signal

[PATCH v2] os: added the -upstart option for Upstart's signaling method.

2010-02-24 Thread Oliver McFadden
SIGCONT, and move our job from the SPAWNED to RUNNING status. Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- doc/Xserver.man.pre |5 + include/opaque.h|1 + os/connection.c |5 + os/utils.c |5 + 4 files changed, 16 insertions(+), 0

[PATCH] emuMB: default to disabled mouse button emulation for touchscreens.

2010-02-24 Thread Oliver McFadden
devices (unless overwritten by Xorg.conf.) Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- src/emuMB.c |3 +++ src/evdev.c | 11 --- src/evdev.h | 11 +++ 3 files changed, 14 insertions(+), 11 deletions(-) diff --git a/src/emuMB.c b/src/emuMB.c index 199c0d7

[PATCH v2] emuMB: default to disabled mouse button emulation for touchscreens.

2010-02-24 Thread Oliver McFadden
devices (unless overwritten by Xorg.conf.) Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- v2: made the if/else explicit (instead of setting to AUTO first, then DISABLED if the device is a touchscreen.) src/emuMB.c |6 +- src/evdev.c | 11 --- src/evdev.h | 11

Re: [PATCH v2] emuMB: default to disabled mouse button emulation for touchscreens.

2010-02-24 Thread Oliver McFadden
On Thu, 2010-02-25 at 02:01 +0100, ext Peter Hutterer wrote: On Wed, Feb 24, 2010 at 11:39:07AM +0200, Oliver McFadden wrote: Because touchscreens only use one button (see EvdevProcessKeyEvent()) EvdevMBEmuFilterEvent() never calls EvdevMBEmuEnable(..., FALSE) to disable emulation

[PATCH] os: added the -upstart option for Upstart's signaling method.

2010-02-23 Thread Oliver McFadden
SIGCONT, and move our job from the SPAWNED to RUNNING status. Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- Unfortunately we're stuck with using Upstart, and in the tradition of trying to keep as close to upstream as possible, I'm sending this for review... According to http

Re: [PATCH v2] parser: corrected xf86getBoolValue to use case insensitive compare

2010-02-16 Thread Oliver McFadden
On Tue, 2010-02-16 at 21:24 +0100, ext Matt Turner wrote: It was in the main tree, committed by Oliver, but then it disappeared. This was all just a couple days ago. Yes, I pushed it to the master branch of the X server, but the development process seems to have changed since my time committing

[PATCH v2] parser: corrected xf86getBoolValue to use case insensitive compare

2010-02-03 Thread Oliver McFadden
commit c6e8637e29e0ca11dfb35c02da7ca6002ac8c597 introduced this regression; it can cause existing config files to be parsed incorrectly. Acked-by: Julien Cristau jcris...@debian.org Reviewed-by: Dan Nicholson dbn.li...@gmail.com Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- hw

[PATCH 3/4] Coverity: mi/mibitblt.c: leaked_storage: Variable prgnSrcClip goes out of scope

2009-12-28 Thread Oliver McFadden
alloc_fn: Called allocation function miRegionCreate var_assign: Assigned variable prgnSrcClip to storage returned from miRegionCreate(box, 1) Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- mi/mibitblt.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mi

[PATCH 4/4] Coverity: mi/mispans.c: leaked_storage: Variable newpoints and newwidths goes out of scope

2009-12-28 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- mi/mispans.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/mi/mispans.c b/mi/mispans.c index 5504341..c9bd025 100644 --- a/mi/mispans.c +++ b/mi/mispans.c @@ -460,6 +460,10 @@ void miFillUniqueSpanGroup

[PATCH 1/4] Coverity: dix/resource.c: leaked_storage: Variable funcs goes out of scope

2009-12-28 Thread Oliver McFadden
Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- dix/resource.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dix/resource.c b/dix/resource.c index 91d0cfb..71774d1 100644 --- a/dix/resource.c +++ b/dix/resource.c @@ -209,7 +209,10

[PATCH 2/4] Coverity: dix/window.c: double_free: Double free of pointer srcbits and mskbits in call to Xfree

2009-12-28 Thread Oliver McFadden
freed_arg: Pointer srcbits and mskbits freed by function AllocARGBCursor Signed-off-by: Oliver McFadden oliver.mcfad...@nokia.com --- dix/window.c |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/dix/window.c b/dix/window.c index caff1cb..be90981 100644 --- a/dix

Re: [PATCH 4/4] Coverity: mi/mispans.c: leaked_storage: Variable newpoints and newwidths goes out of scope

2009-12-28 Thread Oliver McFadden
On Mon, 2009-12-28 at 11:09 +0100, ext Mikhail Gusarov wrote: Twas brillig at 12:02:58 28.12.2009 UTC+02 when oliver.mcfad...@nokia.com did gyre and gimble: OM + if (newpoints) OM + xfree (newpoints); Which is equivalent to if (newpoints) if (newpoints) free(newpoints);

Re: [PATCH] evdev: Support the Calibration string option.

2009-10-12 Thread Oliver McFadden
Hi Peter, Ok, I'll make the changes requested as soon as I can (hopefully today) and send out another patch. -- Oliver. On Thu, 2009-10-08 at 05:05 +0200, ext Peter Hutterer wrote: On Mon, Aug 03, 2009 at 02:31:02AM +0300, oliver.mcfad...@nokia.com wrote: From: Oliver McFadden oliver.mcfad

[PATCH v3] evdev: Support the Calibration string option.

2009-10-12 Thread Oliver McFadden
Originally based on a patch from Daniel Stone, this commit allows for the calibration factors to be set either from Xorg.conf or via HAL. Previously the only way was via the properties interface. --- man/evdev.man |5 + src/evdev.c | 56

[PATCH] evdev: Use the EvdevPost...Event() functions in the emulation code.

2009-08-02 Thread oliver . mcfadden
From: Oliver McFadden oliver.mcfad...@nokia.com This is similar to commit 1f641d75edba7394201c1c53938215bae696791b. It provides the same functionality of queuing the (in this case emulated) events and waiting until an EV_SYN synchronization event is received before posting them to the server

Re: [RFC] xf86Xinput: Added the xf86Post(Proximity|Button|Key)EventP helper functions.

2009-07-27 Thread Oliver McFadden
On Mon, 2009-07-27 at 02:58 +0200, ext Peter Hutterer wrote: On Thu, Jul 23, 2009 at 02:33:24PM +0300, oliver.mcfad...@nokia.com wrote: From: Oliver McFadden oliver.mcfad...@nokia.com I only intend to use xf86PostButtonEventP in xf86-input-evdev, however, for the sake of symmetry

[PATCH v2] xf86Xinput: Added the xf86Post(Proximity|Button|Key)EventP helper functions.

2009-07-27 Thread oliver . mcfadden
From: Oliver McFadden oliver.mcfad...@nokia.com I only intend to use xf86PostButtonEventP in xf86-input-evdev, however, for the sake of symmetry (and possible future use) I have added pointer versions of all the VA args functions. xf86PostKeyboardEvent also makes use of xf86PostKeyEventP

Re: [PATCH v2] xf86Xinput: Added the xf86Post(Proximity|Button|Key)EventP helper functions.

2009-07-27 Thread Oliver McFadden
On Tue, 2009-07-28 at 03:49 +0200, ext Peter Hutterer wrote: Thanks for the update. On Mon, Jul 27, 2009 at 12:06:14PM +0300, oliver.mcfad...@nokia.com wrote: From: Oliver McFadden oliver.mcfad...@nokia.com I only intend to use xf86PostButtonEventP in xf86-input-evdev, however

[PATCH v3] xf86Xinput: Add the xf86Post(Proximity|Button|Key)EventP helper functions.

2009-07-27 Thread oliver . mcfadden
From: Oliver McFadden oliver.mcfad...@nokia.com xf86PostKeyboardEvent also makes use of xf86PostKeyEventP to avoid code duplication, and the valuator verification has been split into the XI_VERIFY_VALUATORS macro. --- I only intend to use xf86PostButtonEventP in xf86-input-evdev, however

Re: [PATCH v3] xf86Xinput: Add the xf86Post(Proximity|Button|Key)EventP helper functions.

2009-07-27 Thread Oliver McFadden
, 2009-07-28 at 07:20 +0200, Mcfadden Oliver (Nokia-D/Helsinki) wrote: From: Oliver McFadden oliver.mcfad...@nokia.com xf86PostKeyboardEvent also makes use of xf86PostKeyEventP to avoid code duplication, and the valuator verification has been split into the XI_VERIFY_VALUATORS macro. --- I

Re: [PATCH] evdev: Only send the events at synchronization time.

2009-07-23 Thread Oliver McFadden
On Thu, 2009-07-23 at 02:30 +0200, ext Peter Hutterer wrote: Thanks for the patch. it looks good, I have a few minor changes though, mostly style. Ok, I'll send a new patch addressing these issues. On Mon, Jul 20, 2009 at 10:15:55AM +0300, oliver.mcfad...@nokia.com wrote: From: Oliver

[PATCH v2] evdev: Only send the events at synchronization time.

2009-07-23 Thread oliver . mcfadden
From: Oliver McFadden oliver.mcfad...@nokia.com Instead of just posting the button/key press/release events to the server as soon as they arrive, add them to an internal queue and post them once we receive an EV_SYN synchronization event. The motion events are always sent first, followed

[RFC] xf86Xinput: Added the xf86Post(Proximity|Button|Key)EventP helper functions.

2009-07-23 Thread oliver . mcfadden
From: Oliver McFadden oliver.mcfad...@nokia.com I only intend to use xf86PostButtonEventP in xf86-input-evdev, however, for the sake of symmetry (and possible future use) I have added pointer versions of all the VA args functions. --- hw/xfree86/common/xf86Xinput.c | 94

[PATCH] evdev: Only send the events at synchronization time.

2009-07-20 Thread oliver . mcfadden
From: Oliver McFadden oliver.mcfad...@nokia.com Instead of just posting the button/key press/release events to the server as soon as they arrive, add them to an internal queue and post them once we receive an EV_SYN synchronization event. The motion events are always sent first, followed

[PATCH] Coverity Prevent: NO_EFFECT in EvdevWheelEmuSetProperty:

2009-07-16 Thread oliver . mcfadden
From: Oliver McFadden oliver.mcfad...@nokia.com Event unsigned_compare: Comparing unsigned less than zero is never true. pEvdev-emulateWheel.timeout 0UL 342 if (pEvdev-emulateWheel.timeout 0) --- src/emuWheel.c |9 - 1 files changed, 0 insertions(+), 9 deletions