[PATCH:libXi] Remove check that can never be true.

clang warns: warning: comparison of constant 268435455 with expression of type 'CARD16' (aka 'unsigned short') is always false --- src/XGetFCtl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/XGetFCtl.c b/src/XGetFCtl.c index bb50bf3..2d71fab 100644 --- a/src/XGetFCtl.c +++

[PATCH:libX11 1/4] Stop truncating source to destination length if it is larger.

It seems useless to do that since the code tests for both source length and destination to be non-zero. This fixes a cut'n'paste problem in xterm where the paste length was limited to 1024 (BUFSIZ) in button.c. --- modules/lc/gen/lcGenConv.c | 28 1 file changed, 28

[PATCH:libX11 2/4] Use newer callback-based API for XIM.

Let libX11 load and make available the newer (X11R6) callback-based API for XIM (expected by emacs). This patch updates the files to match the other nls/ files. Patch from Ian D. Leroux idler...@fastmail.fm on pkgsrc-us...@netbsd.org following a hint by Nhat Minh Lê nhat.minh...@gmail.com.

[PATCH:libX11 3/4] Check for symbol existence with #ifdef, not #if

Reviewed-by: Jamey Sharp ja...@minilop.net --- src/XlibInt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/XlibInt.c b/src/XlibInt.c index b06e57b..92a4340 100644 --- a/src/XlibInt.c +++ b/src/XlibInt.c @@ -239,7 +239,7 @@ void _XSeqSyncFunction( static int

[PATCH:libX11 4/4] Fix out-of-range comparison.

clang complained (correctly): warning: comparison of constant 768614336404564650 with expression of type 'CARD32' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare] --- src/Font.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Font.c

[PATCH:libX11] Fix more out-of-range comparisons.

--- src/FontNames.c | 2 +- src/GetFPath.c | 2 +- src/ListExt.c | 2 +- src/ModMap.c| 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/FontNames.c b/src/FontNames.c index b5bc7b4..7647115 100644 --- a/src/FontNames.c +++ b/src/FontNames.c @@ -66,7 +66,7 @@ int

libXt fixes for compilation with clang-3.4

This fixes all warnings that clang-3.4 reports, except for Error.c:265:30: warning: format string is not a string literal [-Wformat-nonliteral] (void) fprintf (stderr, buffer, ^~ Error.c:307:40: warning: format string is not a string literal

[PATCH:libXt 1/6] Remove unnecessary clause.

len is unsigned and can't be smaller than zero. --- src/Alloc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/Alloc.c b/src/Alloc.c index c523d81..477dfe0 100644 --- a/src/Alloc.c +++ b/src/Alloc.c @@ -140,9 +140,6 @@ Cardinal XtAsprintf( len = vsnprintf(buf, sizeof(buf), format,

[PATCH:libXt 2/6] Avoid shadowing variables.

--- src/Composite.c | 10 +- src/Convert.c | 2 +- src/Geometry.c | 8 src/Intrinsic.c | 6 +++--- src/NextEvent.c | 1 - src/Object.c| 16 src/Selection.c | 1 - src/TMaction.c | 10 +- 8 files changed, 26 insertions(+), 28 deletions(-)

[PATCH:libXt 5/6] Silence compiler clang warnings.

Fixes: warning: cast from function call of type 'char *' to non-matching type 'XtArgVal' (aka 'long') [-Wbad-function-cast] --- src/Resources.c | 2 +- src/Varargs.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Resources.c b/src/Resources.c index 1d2871c..657c55d

[PATCH:libXt 3/6] Mark non-returning function with appropriate attribute.

--- src/Error.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/Error.c b/src/Error.c index fc9b11a..334e001 100644 --- a/src/Error.c +++ b/src/Error.c @@ -75,6 +75,13 @@ in this Software without prior written authorization from The Open Group. #include stdio.h

[PATCH:libXt 6/6] Ignore test-driver from automake-1.13.

--- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 84e5899..1b9e5df 100644 --- a/.gitignore +++ b/.gitignore @@ -41,6 +41,7 @@ mkinstalldirs py-compile stamp-h? symlink-tree +test-driver texinfo.tex ylwrap -- 1.8.3.1

[PATCH:libXt 4/6] Fix char vs. unsigned char warnings.

--- src/ResConfig.c | 4 ++-- src/TMparse.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/ResConfig.c b/src/ResConfig.c index 152d9cf..5a7f6d2 100644 --- a/src/ResConfig.c +++ b/src/ResConfig.c @@ -892,7 +892,7 @@ _XtResourceConfigurationEH ( int

Re: [PATCH:libXt 1/6] Remove unnecessary clause.

On Tue, Jun 25, 2013 at 11:13:54PM +0200, Mark Kettenis wrote: From: Thomas Klausner w...@netbsd.org Date: Tue, 25 Jun 2013 23:02:45 +0200 len is unsigned and can't be smaller than zero. But vsnprintf(3) returns a signed integer, which can be -1. But you can't put that in an unsigned

Re: [PATCH:libXt 1/6] Remove unnecessary clause.

On Tue, Jun 25, 2013 at 02:18:53PM -0700, Alan Coopersmith wrote: On 06/25/13 02:13 PM, Mark Kettenis wrote: From: Thomas Klausner w...@netbsd.org Date: Tue, 25 Jun 2013 23:02:45 +0200 len is unsigned and can't be smaller than zero. But vsnprintf(3) returns a signed integer, which can

Re: [PATCH:libXt 3/6] Mark non-returning function with appropriate attribute.

On Tue, Jun 25, 2013 at 02:20:58PM -0700, Alan Coopersmith wrote: On 06/25/13 02:02 PM, Thomas Klausner wrote: --- src/Error.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/Error.c b/src/Error.c index fc9b11a..334e001 100644 --- a/src/Error.c +++ b/src

[PATCH:libXt 1/6] Use appropriate variable type for vsnprintf return value.

--- src/Alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Alloc.c b/src/Alloc.c index c523d81..c9ffce8 100644 --- a/src/Alloc.c +++ b/src/Alloc.c @@ -133,7 +133,7 @@ Cardinal XtAsprintf( ...) { char buf[256]; -Cardinal len; +int len; va_list

[PATCH:libXt 3/6] Mark non-returning function with appropriate attribute.

--- src/Error.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Error.c b/src/Error.c index fc9b11a..50f6c3c 100644 --- a/src/Error.c +++ b/src/Error.c @@ -89,7 +89,7 @@ static XrmDatabase errorDB = NULL; static Boolean error_inited = FALSE; void

Re: managing patches with git

On Tue, Jun 25, 2013 at 03:13:18PM -0700, Alan Coopersmith wrote: To resync with HEAD, I use git pull --rebase. To merge patches, or change previous ones, I use git rebase -i origin, especially with the squash and fixup options (or reword if I'm just adding reviewed-by tags similar commit

Re: [PATCH:libX11 2/8] Let libX11 load and make available the newer (X11R6) callback-based API for XIM (expected by emacs).

On Sun, Jun 16, 2013 at 02:37:09AM -0400, James Cloos wrote: TK == Thomas Klausner w...@netbsd.org writes: TK They basically all look like this: TK -XIMcommon/ximcp_XimOpenIM # XIM_open TK +XIM common/ximcp _XimOpenIM _XimRegisterIMInstantiateCallback TK

Re: [PATCH:libX11 2/8] Let libX11 load and make available the newer (X11R6) callback-based API for XIM (expected by emacs).

On Thu, Jun 06, 2013 at 11:17:49PM -0700, Alan Coopersmith wrote: For patches 2, 4, 5 from this series, while I have vague memories that I once knew how those files worked, I certainly don't have access to those brain cells any more, so will leave these for someone with more familiarity with

Re: [PATCH:libpciaccess 3/3] Support more pci functions on NetBSD.

Hi Matthieu! Thanks for the review! On Thu, Jun 13, 2013 at 12:28:05AM +0200, Matthieu Herrb wrote: +#if defined(__i386__) || defined(__amd64__) +#include machine/sysarch.h +//#include machine/pio.h ^^ Please Remove the commented out line above Ok, will do. +static struct

Re: [PATCH:xrandr 2/2] Use __UNCONST to work around const problem.

On Thu, Jun 06, 2013 at 11:23:00PM -0700, Alan Coopersmith wrote: On 06/ 2/13 05:15 PM, Thomas Klausner wrote: On Mon, Jun 03, 2013 at 01:37:31AM +0200, Thomas Klausner wrote: On Sun, Jun 02, 2013 at 04:35:51PM -0700, Alan Coopersmith wrote: On 06/ 2/13 12:30 PM, Thomas Klausner wrote: XXX

[PATCH:libpciaccess 1/3] Enable boot_vga support only if WSDISPLAYIO_GET_BUSID is defined.

Fixes build on NetBSD-5. --- src/netbsd_pci.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/netbsd_pci.c b/src/netbsd_pci.c index 3566d7b..c9bd052 100644 --- a/src/netbsd_pci.c +++ b/src/netbsd_pci.c @@ -248,6 +248,7 @@ pci_device_netbsd_write(struct pci_device *dev, const void

[PATCH:libpciaccess 2/3] Fix build on NetBSD-4.

--- configure.ac | 10 ++ src/netbsd_pci.c | 13 + 2 files changed, 23 insertions(+) diff --git a/configure.ac b/configure.ac index 3441b63..537cfe3 100644 --- a/configure.ac +++ b/configure.ac @@ -108,7 +108,17 @@ AC_SYS_LARGEFILE AC_CHECK_HEADERS([err.h]) +if test

[PATCH:libpciaccess 3/3] Support more pci functions on NetBSD.

From Chuck Silvers c...@chuq.com based on openbsd_pci.c. Signed-off-by: Thomas Klausner w...@netbsd.org --- src/netbsd_pci.c | 335 +++ 1 file changed, 335 insertions(+) diff --git a/src/netbsd_pci.c b/src/netbsd_pci.c index 2d99680..ab49272

Re: [PATCH:libpciaccess 1/2] Move 'const' to correct place, so it has meaning.

On Tue, Jun 11, 2013 at 11:22:32PM -0700, Alan Coopersmith wrote: Thanks for following these through - I've now pushed both patches of this set to git master: To ssh://git.freedesktop.org/git/xorg/lib/libpciaccess 719888a..5aff35d master - master Thank you! Looks like we should make a

[PATCH:libpciaccess 2/2] Update NetBSD support.

From Michael Lorenz macal...@netbsd.org Signed-off-by: Michael Lorenz macal...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org Reviewed-by: Matthieu Herrb matthieu.he...@laas.fr --- configure.ac | 4 +- src/netbsd_pci.c | 471

[PATCH:libpciaccess 1/2] Move 'const' to correct place, so it has meaning.

--- src/common_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common_interface.c b/src/common_interface.c index 6dccf8e..3425edc 100644 --- a/src/common_interface.c +++ b/src/common_interface.c @@ -268,7 +268,7 @@ pci_device_map_range(struct pci_device *dev,

Re: [PATCH:libpciaccess 3/3] Update NetBSD support. From Michael Lorenz macal...@netbsd.org.

On Sun, Jun 09, 2013 at 09:32:37AM -0700, Alan Coopersmith wrote: On 06/ 8/13 11:28 AM, Thomas Klausner wrote: On Fri, Jun 07, 2013 at 08:39:52PM -0700, Alan Coopersmith wrote: On 06/ 2/13 01:38 PM, Thomas Klausner wrote: --- configure.ac | 4 +- src/netbsd_pci.c | 471

Re: [PATCH:libpciaccess 3/3] Update NetBSD support. From Michael Lorenz macal...@netbsd.org.

On Fri, Jun 07, 2013 at 08:39:52PM -0700, Alan Coopersmith wrote: On 06/ 2/13 01:38 PM, Thomas Klausner wrote: --- configure.ac | 4 +- src/netbsd_pci.c | 471 +++ 2 files changed, 342 insertions(+), 133 deletions(-) Since

Re: [PATCH:libX11 8/8] Deal with the limited range of VAX floating point numbers when compiling for VAX.

On Thu, Jun 06, 2013 at 11:14:07PM -0700, Alan Coopersmith wrote: On 06/ 2/13 04:19 PM, Thomas Klausner wrote: On Sun, Jun 02, 2013 at 04:11:08PM -0700, Alan Coopersmith wrote: People still compile X for VAX? I had no idea... Yes, NetBSD-6.1 was released for vax, including X. http

Re: [PATCH:xf86-video-glint] when doing DDC2 on Permedia2 make sure to clear the USE_MONID bit in the DDCdata register so the i2c bits actually do something Now DDC2 works on my PGX32 / Raptor 8P

On Mon, Jun 03, 2013 at 08:47:05AM -0700, Matt Turner wrote: Not sure I like just commenting out code like this. Fix the commit title and summary message. Ok, I've improved the patch, I hope it's acceptable now. Thanks, Thomas ___

[PATCH:libX11 1/8] Avoid .TS H and .TH for now as it doesn't alter the output in this case, and improve the output with mandoc(1).

--- man/XCreateGC.man | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/man/XCreateGC.man b/man/XCreateGC.man index 62a2f00..de0d039 100644 --- a/man/XCreateGC.man +++ b/man/XCreateGC.man @@ -460,7 +460,7 @@ are: .\ and operation. .\.CP T 1 .\Display Functions -.TS H +.TS

[PATCH:libXScrnSaver] Don't declare a 'const char *' when you pass it to a 'char *'.

--- src/XScrnSaver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/XScrnSaver.c b/src/XScrnSaver.c index 2a89246..bf53c03 100644 --- a/src/XScrnSaver.c +++ b/src/XScrnSaver.c @@ -36,7 +36,7 @@ in this Software without prior written authorization from the X Consortium.

[PATCH:libXfont] Protect config.h inclusion with ifdef HAVE_CONFIG_H, like usual.

--- src/fontfile/bunzip2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/fontfile/bunzip2.c b/src/fontfile/bunzip2.c index 44d19f0..4078796 100644 --- a/src/fontfile/bunzip2.c +++ b/src/fontfile/bunzip2.c @@ -26,7 +26,9 @@ */ +#ifdef HAVE_CONFIG_H #include config.h +#endif

[PATCH:libX11 3/8] ifdef out code that truncates the source length to the destination length if it is larger. Seems useless to do that since the code tests for both source length and destination to be

--- modules/lc/gen/lcGenConv.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/modules/lc/gen/lcGenConv.c b/modules/lc/gen/lcGenConv.c index 42d63c5..5a4fd64 100644 --- a/modules/lc/gen/lcGenConv.c +++ b/modules/lc/gen/lcGenConv.c @@ -764,8 +764,10 @@ mbstowcs_org(

[PATCH:libX11 5/8] Let libX11 load and make available the newer (X11R6) callback-based API for XIM (expected by emacs).

Patch from Ian D. Leroux idler...@fastmail.fm on pkgsrc-users following a hint by Nhat Minh Lê nhat.minh...@gmail.com. --- nls/iso8859-1/XI18N_OBJS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nls/iso8859-1/XI18N_OBJS b/nls/iso8859-1/XI18N_OBJS index 32e4f35..3a9a1bb 100644

[PATCH:libX11 6/8] Check for symbol existence with #ifdef, not #if.

--- src/XlibInt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/XlibInt.c b/src/XlibInt.c index b06e57b..92a4340 100644 --- a/src/XlibInt.c +++ b/src/XlibInt.c @@ -239,7 +239,7 @@ void _XSeqSyncFunction( static int _XPrivSyncFunction (Display *dpy) { -#if XTHREADS

[PATCH:libX11 2/8] Let libX11 load and make available the newer (X11R6) callback-based API for XIM (expected by emacs).

Patch from Ian D. Leroux idler...@fastmail.fm on pkgsrc-users following a hint by Nhat Minh Lê nhat.minh...@gmail.com. --- nls/C/XI18N_OBJS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nls/C/XI18N_OBJS b/nls/C/XI18N_OBJS index 32e4f35..3a9a1bb 100644 --- a/nls/C/XI18N_OBJS

[PATCH:libX11 8/8] Deal with the limited range of VAX floating point numbers when compiling for VAX.

--- src/xcms/cmsTrig.c | 4 1 file changed, 4 insertions(+) diff --git a/src/xcms/cmsTrig.c b/src/xcms/cmsTrig.c index a917b78..fc65d9b 100644 --- a/src/xcms/cmsTrig.c +++ b/src/xcms/cmsTrig.c @@ -71,7 +71,11 @@ _XcmsModuloF( #define XCMS_SIXTHPI 0.523598775598298820 #define

[PATCH:libX11 4/8] Let libX11 load and make available the newer (X11R6) callback-based API for XIM (expected by emacs).

Patch from Ian D. Leroux idler...@fastmail.fm on pkgsrc-users following a hint by Nhat Minh Lê nhat.minh...@gmail.com. AND fix a couple of defaults that make emacs and a few other things work. as reported on tech-x11. --- nls/en_US.UTF-8/XI18N_OBJS | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH:libXmu] Fix a const issue.

--- src/StrToGrav.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/StrToGrav.c b/src/StrToGrav.c index ca8bb53..e7ad699 100644 --- a/src/StrToGrav.c +++ b/src/StrToGrav.c @@ -106,7 +106,7 @@ Boolean XmuCvtGravityToString(Display *dpy, XrmValue *args, Cardinal *num_args,

[PATCH:libXtst] Fix some const issues.

--- src/XRecord.c | 2 +- src/XTest.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/XRecord.c b/src/XRecord.c index 5bbd5ac..e146778 100644 --- a/src/XRecord.c +++ b/src/XRecord.c @@ -74,7 +74,7 @@ static inline void _XEatDataWords(Display *dpy, unsigned long n)

[PATCH:mkfontscale 1/2] Protect config.h inclusion like usual.

--- ident.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ident.c b/ident.c index bf54483..8addee7 100644 --- a/ident.c +++ b/ident.c @@ -47,7 +47,9 @@ and 0 if it should be processed normally. identifyBitmap is much faster than parsing the whole font. */ +#ifdef HAVE_CONFIG_H

[PATCH:mkfontscale 2/2] Remove a couple of 'const' that aren't OK for the caller.

--- mkfontscale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mkfontscale.c b/mkfontscale.c index 53c5303..15efaac 100644 --- a/mkfontscale.c +++ b/mkfontscale.c @@ -60,7 +60,7 @@ #define QUOTE(x) #x #define STRINGIFY(x) QUOTE(x) -static const char

[PATCH:xrandr 2/2] Use __UNCONST to work around const problem.

XXX: should probably be fixed differently. --- xrandr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xrandr.c b/xrandr.c index da786cb..0b285a3 100644 --- a/xrandr.c +++ b/xrandr.c @@ -1524,7 +1524,7 @@ crtc_set_transform (crtc_t *crtc, transform_t *transform) if

[PATCH:xrandr 1/2] Protect config.h like usual.

--- xrandr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xrandr.c b/xrandr.c index 94e5c2e..da786cb 100644 --- a/xrandr.c +++ b/xrandr.c @@ -41,7 +41,9 @@ #include stdarg.h #include math.h +#ifdef HAVE_CONFIG_H #include config.h +#endif static char*program_name; static

[PATCH:libXt] Add missing comma to fix DEBUG build.

--- src/ResConfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ResConfig.c b/src/ResConfig.c index 161366a..152d9cf 100644 --- a/src/ResConfig.c +++ b/src/ResConfig.c @@ -981,7 +981,7 @@ _XtResourceConfigurationEH ( resource =

Re: [PATCH:libX11 7/8] Add missing stdio header for printf(3) in DEBUG build.

On Sun, Jun 02, 2013 at 10:02:39PM +0200, walter harms wrote: Am 02.06.2013 20:49, schrieb Thomas Klausner: --- src/xcms/cmsMath.c | 4 1 file changed, 4 insertions(+) diff --git a/src/xcms/cmsMath.c b/src/xcms/cmsMath.c index 70b0675..487eb3f 100644 --- a/src/xcms

[PATCH:libXinerama] Const fix.

--- src/Xinerama.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Xinerama.c b/src/Xinerama.c index 67a35b5..17e8ec8 100644 --- a/src/Xinerama.c +++ b/src/Xinerama.c @@ -51,7 +51,7 @@ static inline void _XEatDataWords(Display *dpy, unsigned long n) static

[PATCH:libXRes] Const fix.

--- src/XRes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/XRes.c b/src/XRes.c index 51e905f..aef32ce 100644 --- a/src/XRes.c +++ b/src/XRes.c @@ -28,7 +28,7 @@ static inline void _XEatDataWords(Display *dpy, unsigned long n) static XExtensionInfo

[PATCH:libXrandr] Add some casts for gcc with more warnings enabled.

--- src/XrrProvider.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/XrrProvider.c b/src/XrrProvider.c index 309e321..cc339cd 100644 --- a/src/XrrProvider.c +++ b/src/XrrProvider.c @@ -77,7 +77,7 @@ XRRGetProviderResources(Display *dpy, Window window)

[PATCH:xdm] Add a cast to avoid a compiler error.

XXX: this code should be revisited. --- xdm/prngc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xdm/prngc.c b/xdm/prngc.c index f0db8eb..fe737e3 100644 --- a/xdm/prngc.c +++ b/xdm/prngc.c @@ -130,7 +130,7 @@ reopen: msg[0] = 0x02; msg[1] = len; - if

[PATCH:xkbcomp] Protect config.h like usual.

--- utils.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/utils.h b/utils.h index 417d104..b00067d 100644 --- a/utils.h +++ b/utils.h @@ -35,7 +35,9 @@ #include X11/Xfuncs.h #include stddef.h +#ifdef HAVE_CONFIG_H #include config.h +#endif #ifndef NUL #defineNUL

[PATCH:libpciaccess 1/3] Protect config.h like usual.

--- src/common_bridge.c | 3 +++ src/common_device_name.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/common_bridge.c b/src/common_bridge.c index 82a13fd..b4b5d7e 100644 --- a/src/common_bridge.c +++ b/src/common_bridge.c @@ -29,7 +29,10 @@ * \author Ian Romanick

[PATCH:libpciaccess 2/3] Remove useless extra const in const sometype const * var = value; . Found using clang -Wduplicate-decl-specifier.

--- src/common_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common_interface.c b/src/common_interface.c index 6dccf8e..8eace4e 100644 --- a/src/common_interface.c +++ b/src/common_interface.c @@ -268,7 +268,7 @@ pci_device_map_range(struct pci_device *dev,

[PATCH:libpciaccess 3/3] Update NetBSD support. From Michael Lorenz macal...@netbsd.org.

--- configure.ac | 4 +- src/netbsd_pci.c | 471 +++ 2 files changed, 342 insertions(+), 133 deletions(-) diff --git a/configure.ac b/configure.ac index 91374e5..3441b63 100644 --- a/configure.ac +++ b/configure.ac @@ -77,10 +77,10 @@

[PATCH:xf86-video-ast] Use uint32_t for a variable that's passed to a function expecting a uint32_t.

--- src/ast_vgatool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ast_vgatool.c b/src/ast_vgatool.c index 513cf7b..378822a 100644 --- a/src/ast_vgatool.c +++ b/src/ast_vgatool.c @@ -2709,7 +2709,7 @@ void vGetDefaultSettings(ScrnInfoPtr pScrn) Bool

[PATCH:xf86-video-glint] when doing DDC2 on Permedia2 make sure to clear the USE_MONID bit in the DDCdata register so the i2c bits actually do something Now DDC2 works on my PGX32 / Raptor 8P

From Michael Lorez macal...@netbsd.org --- src/pm2_dac.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/pm2_dac.c b/src/pm2_dac.c index 85093ff..b6771a5 100644 --- a/src/pm2_dac.c +++ b/src/pm2_dac.c @@ -458,8 +458,14 @@ Permedia2I2CPutBits(I2CBusPtr b, int scl,

[PATCH:xf86-video-i740] I740_Sync is only define if HAVE_XAA_H, so limit prototype to same define.

--- src/i740_dga.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/i740_dga.c b/src/i740_dga.c index 532d614..eb362c5 100644 --- a/src/i740_dga.c +++ b/src/i740_dga.c @@ -41,10 +41,10 @@ static Bool I740_OpenFramebuffer(ScrnInfoPtr, char **, unsigned char **, int

Re: [PATCH:libX11 3/8] ifdef out code that truncates the source length to the destination length if it is larger. Seems useless to do that since the code tests for both source length and destination t

, no. I'll send an updated patch. In any case, I don't think this is a release blocker for 1.6, so should wait until after that release is made. Fine with me, as long as it doesn't get lost :) Thomas -alan- On 06/ 2/13 11:49 AM, Thomas Klausner wrote: --- modules/lc/gen/lcGenConv.c

Re: [PATCH:libX11 8/8] Deal with the limited range of VAX floating point numbers when compiling for VAX.

On Sun, Jun 02, 2013 at 04:11:08PM -0700, Alan Coopersmith wrote: People still compile X for VAX? I had no idea... Yes, NetBSD-6.1 was released for vax, including X. http://netbsd.org/ports/vax/ Of course, it was cross-compiled. Thomas ___

[PATCH] Remove code limiting buffer size.

Remove code that truncates the source length to the destination length if it is larger. Seems useless to do that since the code tests for both source length and destination to be non-zero. This fixes cut-n-paste problem in xterm where the paste length was limited to 1024 (BUFSIZ) in button.c ---

Re: [PATCH:libXxf86vm] Const fix.

On Sun, Jun 02, 2013 at 04:32:13PM -0700, Alan Coopersmith wrote: On 06/ 2/13 01:13 PM, Thomas Klausner wrote: --- src/XF86VMode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/XF86VMode.c b/src/XF86VMode.c index fb94816..5cd8020 100644 --- a/src/XF86VMode.c

Re: [PATCH:xrandr 2/2] Use __UNCONST to work around const problem.

On Sun, Jun 02, 2013 at 04:35:51PM -0700, Alan Coopersmith wrote: On 06/ 2/13 12:30 PM, Thomas Klausner wrote: XXX: should probably be fixed differently. --- xrandr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xrandr.c b/xrandr.c index da786cb..0b285a3 100644

Re: [PATCH:xrandr 2/2] Use __UNCONST to work around const problem.

On Mon, Jun 03, 2013 at 01:37:31AM +0200, Thomas Klausner wrote: On Sun, Jun 02, 2013 at 04:35:51PM -0700, Alan Coopersmith wrote: On 06/ 2/13 12:30 PM, Thomas Klausner wrote: XXX: should probably be fixed differently. --- xrandr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [xinit] XSLASHGLOB

. Thanks, Thomas On Thu, Apr 04, 2013 at 02:59:34PM +0200, Thomas Klausner wrote: On Mon, Apr 01, 2013 at 10:18:10PM -0700, Alan Coopersmith wrote: On 07/12/12 04:57 AM, Thomas Klausner wrote: Hi! While looking at NetBSD xsrc patches I found one for xinit. Index: xinit/dist

Re: [PATCH:xrdb] Add a command line flag -cppargs which allows passing arguments to cpp (while still complying with the access(2) check for the cpp executable).

Any comments? Thomas On Thu, Aug 23, 2012 at 04:48:10PM +0200, Thomas Klausner wrote: See thread starting at http://mail-index.netbsd.org/tech-x11/2009/12/01/msg000687.html --- man/xrdb.man | 4 xrdb.c | 27 +++ 2 files changed, 27 insertions(+), 4

[w...@netbsd.org: [PATCH:xinit] Use xinitrc.d/?*.sh as the matching pattern instead of needing a fragile sed substitution XSLASHGLOB to produce xinitrc.d/*.sh. (If that were used literally the slash-s

Hi Alan! Here it is again, as requested. Hope the forward works fine. Thanks for looking at this, Thomas - Forwarded message from Thomas Klausner w...@netbsd.org - Date: Thu, 4 Apr 2013 14:58:30 +0200 From: Thomas Klausner w...@netbsd.org To: xorg-devel@lists.x.org, Alan Coopersmith

Re: [xinit] XSLASHGLOB

On Mon, Apr 01, 2013 at 10:18:10PM -0700, Alan Coopersmith wrote: On 07/12/12 04:57 AM, Thomas Klausner wrote: Hi! While looking at NetBSD xsrc patches I found one for xinit. Index: xinit/dist/xinitrc.cpp === RCS file

[PATCH:xinit] Use xinitrc.d/?*.sh as the matching pattern instead of needing a fragile sed substitution XSLASHGLOB to produce xinitrc.d/*.sh. (If that were used literally the slash-star would confuse

--- cpprules.in | 1 - xinitrc.cpp | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/cpprules.in b/cpprules.in index 92a987d..eaea428 100644 --- a/cpprules.in +++ b/cpprules.in @@ -10,7 +10,6 @@ CPP_SED_MAGIC = $(SED) -e '/^\# *[0-9][0-9]* *.*$$/d' \

Re: fd passing for X

On Sat, Oct 06, 2012 at 11:26:05AM -0700, Keith Packard wrote: Thomas Klausner t...@giga.or.at writes: On Fri, Oct 05, 2012 at 01:46:57PM -0700, Keith Packard wrote: I did a bunch of experiments with fd passing in Linux to see how it might work in X. Do you have a test program I could

Re: xscope: missing xtrans configure check

On Fri, Oct 19, 2012 at 10:23:58PM -0700, Alan Coopersmith wrote: That looks like a bug - I saw it hang in the QueryFont call when I ran with the installed xscope 1.3.1 on my system, but running with the local build I have here (1.3.99.901 plus the three patches I mailed this week) let it

xscope: missing xtrans configure check

xscope configure doesn't check for xtrans, but the build fails if it's not found, because one of its headers is included. Patch needed? Thomas ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: xscope: missing xtrans configure check

On Fri, Oct 19, 2012 at 08:45:50AM +1000, Peter Hutterer wrote: On Thu, Oct 18, 2012 at 11:46:00AM +0200, Thomas Klausner wrote: xscope configure doesn't check for xtrans, but the build fails if it's not found, because one of its headers is included. Patch needed? yes, if it fails

Re: xscope: missing xtrans configure check

On Thu, Oct 18, 2012 at 10:35:26PM -0700, Alan Coopersmith wrote: I do see it doesn't build without xtrans now - is there some reason that's a useful way to build it? Should we just make the xtrans requirement absolute? It's not hard to fix, but since no one maintains the non-xtrans mode,

Re: fd passing for X

On Fri, Oct 05, 2012 at 01:46:57PM -0700, Keith Packard wrote: I did a bunch of experiments with fd passing in Linux to see how it might work in X. Do you have a test program I could run on NetBSD to see if it works there as well? Thomas ___

Re: xcursor-themes - why no index.theme files?

On Fri, Sep 21, 2012 at 11:38:44AM +0200, Alan Coopersmith wrote: On 09/20/12 10:45 PM, Thomas Klausner wrote: Subject basically says it, but: Why are no index.theme file installed for the cursor themes from xcursor-themes? Because no one submitted a patch to add them? It's hard to know

Re: xcursor-themes - why no index.theme files?

On Fri, Sep 21, 2012 at 11:55:57AM +0200, Alan Coopersmith wrote: They work fine for me without the index.theme with libXcursor in the GNOME 2.x Appearance preferences. Perhaps something else has added a index.themes requirement without telling us? Or perhaps I'm setting it up incorrectly.

xcursor-themes - why no index.theme files?

Subject basically says it, but: Why are no index.theme file installed for the cursor themes from xcursor-themes? Thomas ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: xwininfo: const in iconv

On Fri, Aug 24, 2012 at 06:14:20PM -0700, Alan Coopersmith wrote: I think that's already taken care of via the AM_ICONV autoconf macro that checks for the constness of the pointer and sets ICONV_CONST appropriately, but we don't seem to have released a tarball with that fix (commit

[PATCH:xwininfo] Get rid of a number of warnings. Signed-off-by: Thomas Klausner w...@netbsd.org

--- xwininfo.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/xwininfo.c b/xwininfo.c index f1126e6..a9f1e96 100644 --- a/xwininfo.c +++ b/xwininfo.c @@ -251,7 +251,7 @@ static Bool window_id_format_dec = False; static iconv_t

Re: xwininfo: const in iconv

On Sat, Aug 25, 2012 at 10:51:10AM -0700, Alan Coopersmith wrote: These are the lines: xwininfo.c:static xcb_screen_t *screen; xwininfo.c:scale_init (xcb_screen_t *screen) Patch attached. Looks good to me. xwininfo.c: In function ‘wm_size_hints_reply’: xwininfo.c:707:40:

Re: New keyboard config files for some Sharp hardware

On Thu, Aug 23, 2012 at 08:05:44AM -0700, Alan Coopersmith wrote: On 08/23/12 08:00 AM, Thomas Klausner wrote: Keyboard config files for 5 Sharp machines, from Nonaka Kimihiro non...@netbsd.org. xkeyboard-config has it's own mailing list for patch submission: http://www.freedesktop.org

[PATCH:xwininfo 2/2] Mark usage() as not returning.

Signed-off-by: Thomas Klausner w...@netbsd.org --- xwininfo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xwininfo.c b/xwininfo.c index a9f1e96..34d7702 100644 --- a/xwininfo.c +++ b/xwininfo.c @@ -278,6 +278,7 @@ static size_t strlcat (char *dst, const char *src, size_t dstsize

Re: xwininfo: const in iconv

On Sat, Aug 25, 2012 at 04:29:48PM -0700, Alan Coopersmith wrote: On 08/25/12 03:11 PM, Thomas Klausner wrote: I've just sent a patch to the mailing list which fixes all but two of them. xwininfo.c: In function ‘usage’: xwininfo.c:282:1: warning: function might be possible candidate

[PATCH:xrdb] Add a command line flag -cppargs which allows passing arguments to cpp (while still complying with the access(2) check for the cpp executable).

See thread starting at http://mail-index.netbsd.org/tech-x11/2009/12/01/msg000687.html --- man/xrdb.man | 4 xrdb.c | 27 +++ 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/man/xrdb.man b/man/xrdb.man index e30b0d5..d024210 100644 ---

New keyboard config files for some Sharp hardware

Keyboard config files for 5 Sharp machines, from Nonaka Kimihiro non...@netbsd.org. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH:xkeyboard-config 1/4] Added keyboard config files for Sharp Zaurus SL-C3x00.

From: Nonaka Kimihiro non...@netbsd.org --- symbols/sharp_vndr/sl-c3x00 | 74 + 1 file changed, 74 insertions(+) create mode 100644 symbols/sharp_vndr/sl-c3x00 diff --git a/symbols/sharp_vndr/sl-c3x00 b/symbols/sharp_vndr/sl-c3x00 new file mode

[PATCH:xkeyboard-config 3/4] Added keyboard config files for Sharp WS011SH/WS020SH.

From: Nonaka Kimihiro non...@netbsd.org --- symbols/sharp_vndr/ws011sh | 78 ++ symbols/sharp_vndr/ws020sh | 67 +++ 2 files changed, 145 insertions(+) create mode 100644 symbols/sharp_vndr/ws011sh create mode

[PATCH:xkeyboard-config 2/4] Added keyboard config files for Sharp WS003SH/WS007SH.

From: Nonaka Kimihiro non...@netbsd.org --- symbols/sharp_vndr/ws003sh | 73 ++ symbols/sharp_vndr/ws007sh | 73 ++ 2 files changed, 146 insertions(+) create mode 100644 symbols/sharp_vndr/ws003sh create

[PATCH:xkeyboard-config 4/4] Hook new Sharp keyboard config files into the build.

From: Nonaka Kimihiro non...@netbsd.org --- configure.in | 1 + rules/base.ml_s.part | 5 + symbols/sharp_vndr/Makefile.am | 8 3 files changed, 14 insertions(+) create mode 100644 symbols/sharp_vndr/Makefile.am diff --git a/configure.in b/configure.in

xwininfo: const in iconv

When compiling xwininfo on NetBSD, I get: xwininfo.c:1912:6: warning: passing argument 2 of 'iconv' from incompatible pointer type /usr/include/iconv.h:46:8: note: expected 'const char ** restrict' but argument is of type 'char **' In NetBSD's xsrc we use the attached patch to fix this. I

Fix build on NetBSD-5

Fix compilation on systems that don't provide O_CLOEXEC. I wonder if it will work as intended, or if more is needed. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

Re: NetBSD patches: how to move forward

On Mon, Jul 30, 2012 at 03:50:39PM -0700, Alan Coopersmith wrote: Even during non-holiday seasons, patience is advisable for patches outside the well-maintained areas (Xserver, active drivers). There's only a few of us who go through the rest so we try not to let stuff slip through, even if we

NetBSD patches: how to move forward

Hi! No comments and no commits for my patches in the last week. Is there a procedure I should follow so these don't get dropped, or should I just be more patient because it's holiday season? :) Should I keep sending patches in the meantime? (Lots more to come.) Thanks, Thomas

Re: [PATCH:libXTrap] Fix memset usage.

On Fri, Jul 20, 2012 at 08:40:26AM +0200, Rémi Cardona wrote: Le 18/07/2012 16:47, Thomas Klausner a écrit : -(void)memset(tc,0L,sizeof(tc)); +(void)memset(tc,0L,sizeof(*tc)); I'd say you might as well drop the useless cast too. There are twelve memsets with casts, only

libXTrap patches

Original patch, marked as reviewed, and memset cleanup requested by Rémi Cardona. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH:libXTrap 1/2] Fix memset usage.

From Joerg Sonnenberger jo...@netbsd.org Signed-off-by: Thomas Klausner w...@netbsd.org Reviewed-by: Rémi Cardona remi.card...@free.fr --- src/XEConTxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/XEConTxt.c b/src/XEConTxt.c index e2dff16..d075c4f 100644 --- a/src

<    1   2   3   4   5   >