Re: [PATCH:libXdmcp 3/4] Ensure ARRAYofARRAY8 pointers are initialized to NULL

2013-09-30 Thread Mouse
[...] Has X.org given up on portability to systems where all-bits-0 is not a nil pointer? [...] Yes. [...lots of other such cases...] Do you know of any such systems X was ever ported to? No - not that I've gone looking, mind you. But that's hardly surprising; X making such assumptions

Re: [PATCH:libXdmcp 3/4] Ensure ARRAYofARRAY8 pointers are initialized to NULL

2013-09-30 Thread Alan Coopersmith
On 09/30/13 07:07 AM, Mouse wrote: [...] Has X.org given up on portability to systems where all-bits-0 is not a nil pointer? [...] Yes. [...lots of other such cases...] Do you know of any such systems X was ever ported to? No - not that I've gone looking, mind you. But that's hardly

Re: [PATCH:libXdmcp 3/4] Ensure ARRAYofARRAY8 pointers are initialized to NULL

2013-09-28 Thread Jasper St. Pierre
Yes, we have given up on portability to Cray systems. That's the only system, as far as I know, that ever used all-bits-0 != nil pointers. On Sat, Sep 28, 2013 at 1:22 AM, Mouse mo...@rodents-montreal.org wrote: Use calloc for the array of pointers to ensure pointers are cleared out so we

Re: [PATCH:libXdmcp 3/4] Ensure ARRAYofARRAY8 pointers are initialized to NULL

2013-09-28 Thread Alan Coopersmith
On 09/27/13 10:22 PM, Mouse wrote: Use calloc for the array of pointers to ensure pointers are cleared out so we don't try to free garbage if XdmcpDisposeARRAYofARRAY8 is called before the caller sets them to valid pointers. C does not promise that all-bits-0 (what calloc produces) gives nil

[PATCH:libXdmcp 3/4] Ensure ARRAYofARRAY8 pointers are initialized to NULL

2013-09-27 Thread Alan Coopersmith
Use calloc for the array of pointers to ensure pointers are cleared out so we don't try to free garbage if XdmcpDisposeARRAYofARRAY8 is called before the caller sets them to valid pointers. Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- Array.c | 19 ++-