Re: [PATCH] glx: Fix fbconfigs with no corresponding visual

2011-04-12 Thread Jon TURNEY
On 11/04/2011 16:29, Adam Jackson wrote: There are, in general, more fbconfig depths than visual depths. fbconfigs need not support Window rendering, however any that do must have an associated visual ID (which we got right), and any that do not must not claim GLX_WINDOW_BIT in

Re: [PATCH] glx: Fix fbconfigs with no corresponding visual

2011-04-12 Thread Adam Jackson
On Tue, 2011-04-12 at 19:34 +0100, Jon TURNEY wrote: Would you consider combining this with the patch [1] I posted a while ago to check that GLX_WINDOW_BIT is actually set in the fbConfig before we create a visual [1] http://patchwork.freedesktop.org/patch/374/ I was confused for a moment

Re: [PATCH] glx: Fix fbconfigs with no corresponding visual

2011-04-12 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/12/2011 12:12 PM, Adam Jackson wrote: On Tue, 2011-04-12 at 19:34 +0100, Jon TURNEY wrote: Would you consider combining this with the patch [1] I posted a while ago to check that GLX_WINDOW_BIT is actually set in the fbConfig before we

Re: [PATCH] glx: Fix fbconfigs with no corresponding visual

2011-04-12 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/11/2011 08:29 AM, Adam Jackson wrote: There are, in general, more fbconfig depths than visual depths. fbconfigs need not support Window rendering, however any that do must have an associated visual ID (which we got right), and any that do not

[PATCH] glx: Fix fbconfigs with no corresponding visual

2011-04-11 Thread Adam Jackson
There are, in general, more fbconfig depths than visual depths. fbconfigs need not support Window rendering, however any that do must have an associated visual ID (which we got right), and any that do not must not claim GLX_WINDOW_BIT in GLX_DRAWABLE_TYPE (which we got wrong). Fixes

Re: [PATCH] glx: Fix fbconfigs with no corresponding visual

2011-04-11 Thread Eric Anholt
On Mon, 11 Apr 2011 11:29:48 -0400, Adam Jackson a...@redhat.com wrote: There are, in general, more fbconfig depths than visual depths. fbconfigs need not support Window rendering, however any that do must have an associated visual ID (which we got right), and any that do not must not claim