[PATCH] sna: avoid negative timeouts

2013-10-03 Thread Felipe Contreras
It's nice to avoid X server crashes (by not passing negative values to select(3)). For more information: http://article.gmane.org/gmane.comp.freedesktop.xorg.devel/37388 Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- src/sna/sna_accel.c | 3 +++ 1 file changed, 3 insertions(+)

Re: [PATCH] sna: avoid negative timeouts

2013-10-03 Thread Chris Wilson
On Thu, Oct 03, 2013 at 01:29:29AM -0500, Felipe Contreras wrote: It's nice to avoid X server crashes (by not passing negative values to select(3)). For more information: http://article.gmane.org/gmane.comp.freedesktop.xorg.devel/37388 Signed-off-by: Felipe Contreras

Re: [PATCH] sna: avoid negative timeouts

2013-10-03 Thread Felipe Contreras
On Thu, Oct 3, 2013 at 2:36 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 03, 2013 at 01:29:29AM -0500, Felipe Contreras wrote: It's nice to avoid X server crashes (by not passing negative values to select(3)). For more information:

Re: [PATCH] sna: avoid negative timeouts

2013-10-03 Thread Chris Wilson
On Thu, Oct 03, 2013 at 03:06:03AM -0500, Felipe Contreras wrote: On Thu, Oct 3, 2013 at 2:36 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 03, 2013 at 01:29:29AM -0500, Felipe Contreras wrote: It's nice to avoid X server crashes (by not passing negative values to select(3)).

Re: [PATCH] sna: avoid negative timeouts

2013-10-03 Thread Felipe Contreras
On Thu, Oct 3, 2013 at 3:17 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 03, 2013 at 03:06:03AM -0500, Felipe Contreras wrote: On Thu, Oct 3, 2013 at 2:36 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 03, 2013 at 01:29:29AM -0500, Felipe Contreras wrote: It's

Re: [PATCH] sna: avoid negative timeouts

2013-10-03 Thread Chris Wilson
On Thu, Oct 03, 2013 at 04:09:32AM -0500, Felipe Contreras wrote: On Thu, Oct 3, 2013 at 3:17 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: That will hopefully catch which path is consuming too much time This is what I got: restarting timeout[2] (14, 0, 0) restarting timeout[0] (16,

Re: [PATCH] sna: avoid negative timeouts

2013-10-03 Thread Felipe Contreras
On Thu, Oct 3, 2013 at 4:15 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 03, 2013 at 04:09:32AM -0500, Felipe Contreras wrote: On Thu, Oct 3, 2013 at 3:17 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: That will hopefully catch which path is consuming too much time This

Re: [PATCH] sna: avoid negative timeouts

2013-10-03 Thread Chris Wilson
On Thu, Oct 03, 2013 at 10:56:43AM -0500, Felipe Contreras wrote: On Thu, Oct 3, 2013 at 4:15 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 03, 2013 at 04:09:32AM -0500, Felipe Contreras wrote: On Thu, Oct 3, 2013 at 3:17 AM, Chris Wilson ch...@chris-wilson.co.uk wrote:

Re: [PATCH] sna: avoid negative timeouts

2013-10-03 Thread Felipe Contreras
On Thu, Oct 3, 2013 at 11:01 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 03, 2013 at 10:56:43AM -0500, Felipe Contreras wrote: On Thu, Oct 3, 2013 at 4:15 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Thu, Oct 03, 2013 at 04:09:32AM -0500, Felipe Contreras wrote: On

Re: [PATCH] sna: avoid negative timeouts

2013-10-03 Thread Chris Wilson
On Thu, Oct 03, 2013 at 11:19:56AM -0500, Felipe Contreras wrote: On Thu, Oct 3, 2013 at 11:01 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: Oh, TearFree. That explains it. I plan to fix that up very soon. Cool. Any idea why this happens only in this game, and only in that exact