Re: [PATCH] xorg-wrapper: fix build without libdrm

Mark Kettenis, le Mon 19 Oct 2015 12:26:27 +0200, a écrit : > > If you're doing this with certain platforms in mind, maybe > > we need to only not check for libdrm on those platforms ? > > Does it make sense at all to use the wrapper on platforms without drm? We need some setuid wrapper, yes,

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 19-10-15 14:00, Samuel Thibault wrote: Mark Kettenis, le Mon 19 Oct 2015 12:26:27 +0200, a écrit : If you're doing this with certain platforms in mind, maybe we need to only not check for libdrm on those platforms ? Does it make sense at all to use the wrapper on platforms without

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede, le Mon 19 Oct 2015 14:40:46 +0200, a écrit : > To me hurd is the exception here. So maybe change the patch to drop > the configure libdrm check for hurd ? Like is done for cygwin and darwin? Sure. > If that is done I'm fine with the #ifdef LIBDRM in the wrapper itself. I have

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 19-10-15 10:53, Samuel Thibault wrote: Hans de Goede, le Mon 19 Oct 2015 10:44:30 +0200, a écrit : @@ -237,6 +242,7 @@ int main(int argc, char *argv[]) close(fd); } } +#endif This turns needs_root_rights=auto into needs_root_rights=yes do we really want

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit : > In which case would you want to build without libdrm anyways ? Can you > explain the use-case for this patch ? Systems with no drm support, simply :) Samuel ___ xorg-devel@lists.x.org: X.Org

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 18-10-15 18:48, Samuel Thibault wrote: Signed-off-by: Samuel Thibault --- configure.ac | 2 -- hw/xfree86/xorg-wrapper.c | 6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit : > On 19-10-15 10:53, Samuel Thibault wrote: > >Hans de Goede, le Mon 19 Oct 2015 10:44:30 +0200, a écrit : > >>>@@ -237,6 +242,7 @@ int main(int argc, char *argv[]) > >>> close(fd); > >>> } > >>> } > >>>+#endif

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hi, On 19-10-15 11:03, Samuel Thibault wrote: Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit : In which case would you want to build without libdrm anyways ? Can you explain the use-case for this patch ? Systems with no drm support, simply :) Actually I do not think it is that

Re: [PATCH] xorg-wrapper: fix build without libdrm

Samuel Thibault, le Mon 19 Oct 2015 11:25:08 +0200, a écrit : > Hans de Goede, le Mon 19 Oct 2015 11:14:21 +0200, a écrit : > > On 19-10-15 11:03, Samuel Thibault wrote: > > >Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit : > > >>In which case would you want to build without libdrm

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede, le Mon 19 Oct 2015 10:44:30 +0200, a écrit : > >@@ -237,6 +242,7 @@ int main(int argc, char *argv[]) > > close(fd); > > } > > } > >+#endif > > > > This turns needs_root_rights=auto into needs_root_rights=yes do we really > want that > when not building

Re: [PATCH] xorg-wrapper: fix build without libdrm

Hans de Goede, le Mon 19 Oct 2015 11:14:21 +0200, a écrit : > On 19-10-15 11:03, Samuel Thibault wrote: > >Hans de Goede, le Mon 19 Oct 2015 10:56:26 +0200, a écrit : > >>In which case would you want to build without libdrm anyways ? Can you > >>explain the use-case for this patch ? > > > >Systems

[PATCH] xorg-wrapper: fix build without libdrm

Signed-off-by: Samuel Thibault --- configure.ac | 2 -- hw/xfree86/xorg-wrapper.c | 6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index e434720..818026f 100644 --- a/configure.ac +++ b/configure.ac