Re: [PATCH 04/18] Three minor warning and whitespace fixes

2014-09-12 Thread Keith Packard
Eric Anholt writes: > Keith Packard writes: > >> Declare a constant string 'const', clean up some indentation whitespace > > I'm confused about these whitespace fixes -- the lines surrounding those > two are also tabs. I eliminated the whitespace changes and went ahead and pushed the 'const' ch

Re: [PATCH 04/18] Three minor warning and whitespace fixes

2014-08-26 Thread Eric Anholt
Keith Packard writes: > Eric Anholt writes: > >> So there's a bunch of disagreement between this new code and existing >> practice about whitespace, and still misc unrelated whitespace changes >> sprinkled into the remaining patches. That makes me grumpy when >> reviewing, but I don't actually

Re: [PATCH 04/18] Three minor warning and whitespace fixes

2014-08-25 Thread Keith Packard
Eric Anholt writes: > So there's a bunch of disagreement between this new code and existing > practice about whitespace, and still misc unrelated whitespace changes > sprinkled into the remaining patches. That makes me grumpy when > reviewing, but I don't actually care to block things due to tha

Re: [PATCH 04/18] Three minor warning and whitespace fixes

2014-08-25 Thread Eric Anholt
Keith Packard writes: > Declare a constant string 'const', clean up some indentation whitespace OK, instead of ad-hoc writing that command every time, I put a script in ~/bin: anholt@eliezer:xf86-video-intel/src/uxa% git whitespace-vote tabs: 17202 spaces: 518 anholt@eliezer:xf86-video-intel/s

Re: [PATCH 04/18] Three minor warning and whitespace fixes

2014-08-25 Thread Eric Anholt
Keith Packard writes: > Declare a constant string 'const', clean up some indentation whitespace I'm confused about these whitespace fixes -- the lines surrounding those two are also tabs. pgptDagCNSkq3.pgp Description: PGP signature ___ xorg-devel@li

[PATCH 04/18] Three minor warning and whitespace fixes

2014-08-16 Thread Keith Packard
Declare a constant string 'const', clean up some indentation whitespace Signed-off-by: Keith Packard --- src/uxa/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/uxa/intel_display.c b/src/uxa/intel_display.c index e1b09ab..cd5f80c 100644 --- a/src/uxa