Re: [PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-31 Thread Michel Dänzer
On Sam, 2010-10-30 at 12:36 -0700, Keith Packard wrote: On Sat, 30 Oct 2010 18:07:19 +0200, Michel Dänzer mic...@daenzer.net wrote: Right, but as long as there's at least one rendering operation in between, at that point EXA will synchronize the pixmap copies according to the accumulated

Re: [PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-30 Thread Michel Dänzer
On Fre, 2010-10-29 at 12:21 -0700, Eric Anholt wrote: On Fri, 29 Oct 2010 10:46:00 +0200, Michel Dänzer mic...@daenzer.net wrote: On Don, 2010-10-28 at 20:46 -0700, Eric Anholt wrote: In all these cases, any rendering implied by this damage has already occurred, and we want to get the

Re: [PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-30 Thread Keith Packard
On Sat, 30 Oct 2010 18:07:19 +0200, Michel Dänzer mic...@daenzer.net wrote: Right, but as long as there's at least one rendering operation in between, at that point EXA will synchronize the pixmap copies according to the accumulated pending damage. That's the assumption broken by your change.

Re: [PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-29 Thread Michel Dänzer
On Don, 2010-10-28 at 20:46 -0700, Eric Anholt wrote: In all these cases, any rendering implied by this damage has already occurred, and we want to get the damage out to the client. Some of the DamageRegionAppend calls were explicitly telling damage to flush the reportAfter damage out, but

Re: [PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-29 Thread Eric Anholt
On Fri, 29 Oct 2010 10:46:00 +0200, Michel Dänzer mic...@daenzer.net wrote: On Don, 2010-10-28 at 20:46 -0700, Eric Anholt wrote: In all these cases, any rendering implied by this damage has already occurred, and we want to get the damage out to the client. Some of the DamageRegionAppend

[PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-28 Thread Eric Anholt
In all these cases, any rendering implied by this damage has already occurred, and we want to get the damage out to the client. Some of the DamageRegionAppend calls were explicitly telling damage to flush the reportAfter damage out, but not all. Bug #30260. Fixes the compiz wallpaper plugin with

Re: [PATCH 1/2] Replace usage of DamageRegionAppend with DamageDamageRegion to fix reportAfter.

2010-10-28 Thread Keith Packard
On Thu, 28 Oct 2010 20:46:22 -0700, Eric Anholt e...@anholt.net wrote: In all these cases, any rendering implied by this damage has already occurred, and we want to get the damage out to the client. Some of the DamageRegionAppend calls were explicitly telling damage to flush the reportAfter