Re: [PATCH util/macros] Drop -fno-strict-aliasing from XORG_CWARNFLAGS

2017-12-14 Thread Peter Harris
On 2017-12-14 11:35 AM, Michel Dänzer wrote: > I don't think compilers can reliably warn about all strict aliasing > violations yet (ever?). > > Is this really worth the risk? Do you have any numbers showing tangible > benefits of this change? The main benefit is in code cleanliness, not

Re: [PATCH util/macros] Drop -fno-strict-aliasing from XORG_CWARNFLAGS

2017-12-14 Thread Michel Dänzer
On 2017-12-13 08:47 PM, Adam Jackson wrote: > On Wed, 2017-12-13 at 11:31 -0800, Keith Packard wrote: >> Adam Jackson writes: >> >>> This has been "deprecated" since 2011, but because it is still >>> referenced from XORG_DEFAULT_OPTIONS nothing has ever been updated to >>> get

Re: [PATCH util/macros] Drop -fno-strict-aliasing from XORG_CWARNFLAGS

2017-12-13 Thread Adam Jackson
On Wed, 2017-12-13 at 11:31 -0800, Keith Packard wrote: > Adam Jackson writes: > > > This has been "deprecated" since 2011, but because it is still > > referenced from XORG_DEFAULT_OPTIONS nothing has ever been updated to > > get strict aliasing right. Let's fix that. > > I

Re: [PATCH util/macros] Drop -fno-strict-aliasing from XORG_CWARNFLAGS

2017-12-13 Thread Keith Packard
Adam Jackson writes: > This has been "deprecated" since 2011, but because it is still > referenced from XORG_DEFAULT_OPTIONS nothing has ever been updated to > get strict aliasing right. Let's fix that. I don't understand this -- are you getting rid of this option from our