Re: no more indexes - clean up API

2012-05-15 Thread Adam Jackson
On 5/14/12 12:40 PM, Dave Airlie wrote: The screen/scrninfo APIs are very into passing index values, that are then immediately used to lookup a global array, this is not an API, its whatever the opposite is. This set of patches changes all the API passing of screen indices (apart from the

Re: no more indexes - clean up API

2012-05-15 Thread Alan Coopersmith
On 05/15/12 02:10 PM, Adam Jackson wrote: There's a lot of cleanup material if anyone really wanted to go after it after this, 4/19 for example I think we could drop FreeScreen from the ScrnInfoRec entirely with only modest driver fixups. Not for Dave's series, but I've always dreamed of

Re: no more indexes - clean up API

2012-05-15 Thread Adam Jackson
On 5/15/12 5:33 PM, Alan Coopersmith wrote: On 05/15/12 02:10 PM, Adam Jackson wrote: There's a lot of cleanup material if anyone really wanted to go after it after this, 4/19 for example I think we could drop FreeScreen from the ScrnInfoRec entirely with only modest driver fixups. Not for

no more indexes - clean up API

2012-05-14 Thread Dave Airlie
The screen/scrninfo APIs are very into passing index values, that are then immediately used to lookup a global array, this is not an API, its whatever the opposite is. This set of patches changes all the API passing of screen indices (apart from the logging functions). It seriously breaks the

Re: no more indexes - clean up API

2012-05-14 Thread Alan Coopersmith
On 05/14/12 09:40 AM, Dave Airlie wrote: The screen/scrninfo APIs are very into passing index values, that are then immediately used to lookup a global array, this is not an API, its whatever the opposite is. This set of patches changes all the API passing of screen indices (apart from the

Re: no more indexes - clean up API

2012-05-14 Thread Aaron Plattner
On 05/14/2012 02:25 PM, Alan Coopersmith wrote: On 05/14/12 09:40 AM, Dave Airlie wrote: The screen/scrninfo APIs are very into passing index values, that are then immediately used to lookup a global array, this is not an API, its whatever the opposite is. This set of patches changes all the