On 05/14/12 09:40 AM, Dave Airlie wrote: > The screen/scrninfo APIs are very into passing index values, that > are then immediately used to lookup a global array, this is not > an API, its whatever the opposite is. > > This set of patches changes all the API passing of screen indices > (apart from the logging functions). It seriously breaks the driver > API/ABI, and I've got a demo of some compat for it I've sent out before. > > I'll try and co-ordinate with Keith, Alex/Chris/Ben so that main 3 > drivers are compatible when we push the server with all these in it.
And presumably with Aaron to get the ABI version bumped appropriately. > I was holding back on this to try and get some bit by bit review, but > it might be easier for someone to just block off an hour and go mad, > so here goes. I mostly just looked at what you had, didn't double check you caught all the places that needed updating (that's what git grep & compilers are for). Thanks for taking care to update the docs to match. For 1-12,14,16-17,19: Reviewed-by: Alan Coopersmith <[email protected]> Comments sent separately on the rest. -- -Alan Coopersmith- [email protected] Oracle Solaris Engineering - http://blogs.oracle.com/alanc _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
