[PATCH:kbproto] Add spec images to dist_spec_DATA for distribution installation

2010-12-20 Thread Alan Coopersmith
Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- specs/Makefile.am | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/specs/Makefile.am b/specs/Makefile.am index d421927..6d99edd 100644 --- a/specs/Makefile.am +++ b/specs/Makefile.am @@ -46,7

Re: [PATCH xserver] X Sync Cleanups

2010-12-20 Thread Keith Packard
On Wed, 15 Dec 2010 14:24:07 -0800, James Jones jajo...@nvidia.com wrote: Various cleanups identified during review of the X Sync Fence Object patches. -Correctly handle failure of AddResource() -Don't assert when data structures are corrupt. -Use the default switch label rather than

Re: [PATCH] randr: check for virtual size limits before set crtc

2010-12-20 Thread Keith Packard
On Fri, 17 Dec 2010 16:09:35 +0200, Tiago Vignatti tiago.vigna...@nokia.com wrote: Return a error if the screen is configured to an invalid size. Merged. 4b88c7b..d110791 master - master -- keith.pack...@intel.com pgppG5oZYE4It.pgp Description: PGP signature

Re: [PULL] Minor build fixes asprintf repairs

2010-12-20 Thread Keith Packard
On Sat, 18 Dec 2010 00:27:59 -0800, Alan Coopersmith alan.coopersm...@oracle.com wrote: Alan Coopersmith (1): Bug 32436 - hw/xfree86/parser/Makefile.am TOP_SRCDIR should be top_srcdir Colin Harrison (1): Typo in xserver Xvasprintf() David Barksdale (1): Bug 21827:

Re: xdm - xdmcp

2010-12-20 Thread Adam Jackson
On Sat, 2010-12-18 at 10:59 -0500, Gaetan Nadon wrote: On Fri, 2010-12-17 at 08:35 -0500, Trevor Woerner wrote: Causes xdm to fail to build because app/xdm/xdm/genauth.c can't find the following symbols: _XdmcpAuthSetup _XdmcpAuthDoIt _XdmcpWrapperToOddParity I don't

Re: Handling GenericEvents in XSendEvent()

2010-12-20 Thread Daniel Stone
Hi Carlos, On Fri, Nov 26, 2010 at 11:19:40PM +0100, Carlos Garnacho wrote: A few weeks ago I sent some patches to make XSendEvent() deal with GenericEvents, which stayed mostly unreviewed, I'm reposting these, rebased against recent masters, also including some docs for the XGE updates.

Re: [PATCH 3/3] exa/mixed: Exclude frontbuffer from deferred pixmap handling.

2010-12-20 Thread Maarten Maathuis
2010/12/14 Michel Dänzer mic...@daenzer.net: On Mon, 2010-12-13 at 19:42 +0100, Maarten Maathuis wrote: - Apps like xterm can trigger a lot of fallback rendering. - This can lead to (annoyingly) high latencies, because you   have to wait for the block handler. - You need a driver that doesn't

Re: [PATCH 3/3] exa/mixed: Exclude frontbuffer from deferred pixmap handling.

2010-12-20 Thread Michel Dänzer
On Mon, 2010-12-20 at 15:46 +0100, Maarten Maathuis wrote: 2010/12/14 Michel Dänzer mic...@daenzer.net: On Mon, 2010-12-13 at 19:42 +0100, Maarten Maathuis wrote: - Apps like xterm can trigger a lot of fallback rendering. - This can lead to (annoyingly) high latencies, because you have

Re: [PATCH 3/3] exa/mixed: Exclude frontbuffer from deferred pixmap handling.

2010-12-20 Thread Maarten Maathuis
2010/12/20 Michel Dänzer mic...@daenzer.net: On Mon, 2010-12-20 at 15:46 +0100, Maarten Maathuis wrote: 2010/12/14 Michel Dänzer mic...@daenzer.net: On Mon, 2010-12-13 at 19:42 +0100, Maarten Maathuis wrote: - Apps like xterm can trigger a lot of fallback rendering. - This can lead to

Re: [PATCH 3/3] exa/mixed: Exclude frontbuffer from deferred pixmap handling.

2010-12-20 Thread Maarten Maathuis
2010/12/20 Maarten Maathuis madman2...@gmail.com: 2010/12/20 Michel Dänzer mic...@daenzer.net: On Mon, 2010-12-20 at 15:46 +0100, Maarten Maathuis wrote: 2010/12/14 Michel Dänzer mic...@daenzer.net: On Mon, 2010-12-13 at 19:42 +0100, Maarten Maathuis wrote: - Apps like xterm can trigger a

Re: Handling GenericEvents in XSendEvent()

2010-12-20 Thread Peter Harris
On 2010-12-20 09:26, Daniel Stone wrote: I also made a patch for xcbproto. Thanks! Peter, could you please comment on these? Different Peter, I'm guessing, but I'll comment on the xcb parts anyway. git://anongit.freedesktop.org/~daniels/xcbproto:ge This needs something like list type=BYTE

Re: Handling GenericEvents in XSendEvent()

2010-12-20 Thread Daniel Stone
On Mon, Dec 20, 2010 at 09:58:18AM -0500, Peter Harris wrote: On 2010-12-20 09:26, Daniel Stone wrote: I also made a patch for xcbproto. Thanks! Peter, could you please comment on these? Different Peter, I'm guessing, but I'll comment on the xcb parts anyway. Well yeah, but thanks!

Composite ClipNotify fix and expose event elimination

2010-12-20 Thread ville . syrjala
Rather than continue my attempts to hack around the issue of incorrect ClipNotifys during window redirection changes, I decided to tackle the issue in more proper manner. This series will remove the internal MapWindow+UnmapWindow cycle and replace it with a single ValidateTree+HandleExposures

[PATCH 2/4] composite: Initialize borderClip with current values

2010-12-20 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@nokia.com ValidateTree needs a valid borderClip so initialize the parent constrained border clip with the window's current borderClip in compRedirectWindow. Signed-off-by: Ville Syrjälä ville.syrj...@nokia.com --- composite/compalloc.c |6 -- 1 files

[PATCH 4/4] composite: Copy the window contents back from the pixmap

2010-12-20 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@nokia.com Since extra expose events are no longer generated during window unredirection, the window contents must be preserved by the server. So copy the window contents back from the pixmap. The copy can only be done after the clips have been recomputed, so

[PATCH 1/4] composite: Call ValidateGC after ChangeGC

2010-12-20 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@nokia.com ChangeGC changes the GC, so ValidateGC should be called after it, not before. Signed-off-by: Ville Syrjälä ville.syrj...@nokia.com --- composite/compalloc.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

[PATCH 3/4] composite: Get rid of the internal UnmapWindow+MapWindow cycle

2010-12-20 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@nokia.com Eliminate the internal MapWindow+UnmapWindow cycle around window redirection changes. Instead do the work in a single pass by marking the afected windows and calling ValidateTree and HandleExposures directly. This gets rid of unnecessary expose events,

Re: [PATCH] randr: Add additional cursor confinement hook in the ScreenRec

2010-12-20 Thread Adam Jackson
On Mon, 2010-11-15 at 16:23 -0500, Adam Jackson wrote: And use it to confine cursor motion to within the bounds of a single CRTC, iff all the CRTCs within a ScreenRec are reachable from each other. If not you get the same cursor floats within the bounding rect behaviour you get now. v2: -

Re: [PATCH] x86emu: Fix more mis-decoding of the data prefix

2010-12-20 Thread Adam Jackson
On Fri, 2010-12-10 at 14:47 -0500, Adam Jackson wrote: cc2c73ddcb4370a7c3ad439cda4da825156c26c9's three-cent titanium tax doesn't go too far enough. Fix the rest of the call and jmp instructions to handle the data prefix correctly. Reference: Intel 64 and IA-32 Architectures Software

[PULL] Minor 1.10 fixes

2010-12-20 Thread Adam Jackson
The following changes since commit e7dc253452a1ba64718a08fdc070405b494f53cd: Merge remote branch 'alanc/master' (2010-12-20 00:48:45 -0800) are available in the git repository at: ssh://people.freedesktop.org/~ajax/xserver for-keithp Adam Jackson (6): xfree86: Remove unused

Re: [PATCH 3/4] composite: Get rid of the internal UnmapWindow+MapWindow cycle

2010-12-20 Thread Ville Syrjälä
On Mon, Dec 20, 2010 at 01:04:07PM -0500, ext Adam Jackson wrote: On Mon, 2010-12-20 at 18:05 +0200, ville.syrj...@nokia.com wrote: From: Ville Syrjälä ville.syrj...@nokia.com Eliminate the internal MapWindow+UnmapWindow cycle around window redirection changes. Instead do the work in a

Re: Composite ClipNotify fix and expose event elimination

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 18:05:38 +0200, ville.syrj...@nokia.com wrote: Rather than continue my attempts to hack around the issue of incorrect ClipNotifys during window redirection changes, I decided to tackle the issue in more proper manner. This series will remove the internal

Re: [PATCH 1/4] composite: Call ValidateGC after ChangeGC

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 18:05:39 +0200, ville.syrj...@nokia.com wrote: From: Ville Syrjälä ville.syrj...@nokia.com ChangeGC changes the GC, so ValidateGC should be called after it, not before. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpCJSz85GfaN.pgp

Re: [PATCH 3/4] composite: Get rid of the internal UnmapWindow+MapWindow cycle

2010-12-20 Thread Adam Jackson
On Mon, 2010-12-20 at 20:03 +0200, Ville Syrjälä wrote: On Mon, Dec 20, 2010 at 01:04:07PM -0500, ext Adam Jackson wrote: This can't be right, I don't think. You've eliminated the Map/Unmap cycle - entirely laudable, thank you for taking it on - but in doing so you're not replacing it with

Re: [PATCH 4/4] composite: Copy the window contents back from the pixmap

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 18:05:42 +0200, ville.syrj...@nokia.com wrote: -void +PixmapPtr compFreePixmap (WindowPtr pWin) { ScreenPtrpScreen = pWin-drawable.pScreen; @@ -612,7 +647,8 @@ compFreePixmap (WindowPtr pWin) pParentPixmap = (*pScreen-GetWindowPixmap)

Re: [PULL] Minor 1.10 fixes

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 12:32:47 -0500, Adam Jackson a...@nwnk.net wrote: Adam Jackson (6): xfree86: Remove unused xf86inSuspend Remove SCO support fonts: Fix typo in async ListFonts logic xfree86: Symmetrize xf86AccessEnter and xf86AccessLeave xfree86: Remove

[PATCH xserver (v2)] X Sync Cleanups

2010-12-20 Thread James Jones
Various cleanups identified during review of the X Sync Fence Object patches. -Correctly handle failure of AddResource() -Don't assert when data structures are corrupt. Instead, use a new helper function to check for counter sync objects when they're expected, and warn if the type is wrong.

Re: [PATCH xserver (v2)] X Sync Cleanups

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 10:27:57 -0800, James Jones jajo...@nvidia.com wrote: +static Bool +SyncCheckWarnIsCounter(const SyncObject* pSync, const char *warning) +{ +if (pSync (SYNC_COUNTER != pSync-type)) +{ + ErrorF(%s, warning); + ErrorF( Counter type: %d\n,

Re: [PATCH 4/4] composite: Copy the window contents back from the pixmap

2010-12-20 Thread Ville Syrjälä
On Mon, Dec 20, 2010 at 10:16:22AM -0800, ext Keith Packard wrote: On Mon, 20 Dec 2010 18:05:42 +0200, ville.syrj...@nokia.com wrote: -void +PixmapPtr compFreePixmap (WindowPtr pWin) { ScreenPtr pScreen = pWin-drawable.pScreen; @@ -612,7 +647,8 @@ compFreePixmap

Re: [PATCH:libX11] Add XKBlib spec images to dist_spec_DATA for distribution installation

2010-12-20 Thread Gaetan Nadon
On Sun, 2010-12-19 at 23:53 -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- specs/XKB/Makefile.am | 23 ++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/specs/XKB/Makefile.am b/specs/XKB/Makefile.am

Re: [PATCH:kbproto] Add spec images to dist_spec_DATA for distribution installation

2010-12-20 Thread Gaetan Nadon
On Mon, 2010-12-20 at 00:11 -0800, Alan Coopersmith wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com --- specs/Makefile.am | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/specs/Makefile.am b/specs/Makefile.am index d421927..6d99edd

[PATCH xserver (v3)] X Sync Cleanups

2010-12-20 Thread James Jones
Various cleanups identified during review of the X Sync Fence Object patches. -Correctly handle failure of AddResource() -Don't assert when data structures are corrupt. Instead, use a new helper function to check for counter sync objects when they're expected, and warn if the type is wrong.

Re: [PATCH:kbproto] Add spec images to dist_spec_DATA for distribution installation

2010-12-20 Thread Matt Dew
Alan, Do we want to convert images in the tree to svg? I want to do this, before the 7.7 release next summer. Thoughts? Matt On Mon, Dec 20, 2010 at 1:11 AM, Alan Coopersmith alan.coopersm...@oracle.com wrote: Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com ---  

Re: Handling GenericEvents in XSendEvent()

2010-12-20 Thread Peter Harris
On 2010-12-20 10:23, Daniel Stone wrote: On Mon, Dec 20, 2010 at 09:58:18AM -0500, Peter Harris wrote: This needs something like list type=BYTE name=data / to describe the rest of the event. (See also: PutImage) Rather. Ahem. Can you tell I've never used XCB before? We all have to start

Re: xdm - xdmcp

2010-12-20 Thread Gaetan Nadon
On Mon, 2010-12-20 at 08:56 -0500, Adam Jackson wrote: The ones I pushed hadn't been nacked, I didn't think? Regardless, yeah, revert. Correct. A number of similar patches were posted within a 6 day period with various reviewers responding to various patches. That leaves one patch for

Re: Handling GenericEvents in XSendEvent()

2010-12-20 Thread Daniel Stone
On Mon, Dec 20, 2010 at 02:39:14PM -0500, Peter Harris wrote: On 2010-12-20 10:23, Daniel Stone wrote: On Mon, Dec 20, 2010 at 09:58:18AM -0500, Peter Harris wrote: This needs something like list type=BYTE name=data / to describe the rest of the event. (See also: PutImage) Rather.

Re: [PATCH xserver (v2)] X Sync Cleanups

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 11:08:39 -0800, James Jones jajo...@nvidia.com wrote: Err, somehow I forgot to do that. Fixed in the third version. I went with a cap of 5 rather than just printing the message once. My reasoning being this might help differentiate between random memory corruption and

Re: Composite ClipNotify fix and expose event elimination

2010-12-20 Thread Soeren Sandmann
Keith Packard kei...@keithp.com writes: On Mon, 20 Dec 2010 18:05:38 +0200, ville.syrj...@nokia.com wrote: Rather than continue my attempts to hack around the issue of incorrect ClipNotifys during window redirection changes, I decided to tackle the issue in more proper manner. This

Re: [PATCH:kbproto] Add spec images to dist_spec_DATA for distribution installation

2010-12-20 Thread Alan Coopersmith
On 12/20/10 11:32 AM, Matt Dew wrote: Alan, Do we want to convert images in the tree to svg? I want to do this, before the 7.7 release next summer. Thoughts? Yes, those images seem like they'd be much better done as SVG, but this at least lets people see them until then. --

Re: Reviewed patches from the Ubuntu tree

2010-12-20 Thread Thierry Vignaud
On 20 December 2010 01:45, Keith Packard kei...@keithp.com wrote: Ping?  The sync fixes resolve some fairly visible and annoying behaviour with an uninterruptible fade in gnome-screensaver. Thanks for the ping. Merged.   f1542f1..4b88c7b  master - master This bug affects xserver-1.9 on

Re: [PATCH] x86emu: Fix more mis-decoding of the data prefix

2010-12-20 Thread Julien Cristau
On Mon, Dec 20, 2010 at 16:55:18 -0500, Adam Jackson wrote: On Mon, 2010-12-20 at 19:41 +0100, Julien Cristau wrote: On Fri, Dec 10, 2010 at 14:47:20 -0500, Adam Jackson wrote: @@ -7084,8 +7089,12 @@ static void x86emuOp_call_far_IMM(u8 X86EMU_UNUSED(op1)) TRACE_AND_STEP();

Re: [PATCH] randr: Add additional cursor confinement hook in the ScreenRec

2010-12-20 Thread Christopher James Halse Rogers
On Mon, 2010-11-15 at 16:23 -0500, Adam Jackson wrote: And use it to confine cursor motion to within the bounds of a single CRTC, iff all the CRTCs within a ScreenRec are reachable from each other. If not you get the same cursor floats within the bounding rect behaviour you get now. v2: -

[PATCH evdev 1/3] Rename proximity to in_proximity.

2010-12-20 Thread Peter Hutterer
No functional change, just making it a bit more obvious to read. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/evdev.c | 28 ++-- src/evdev.h |2 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index

[PATCH evdev 2/3] Revert Don't count BTN_TOUCH as tool. (#29428)

2010-12-20 Thread Peter Hutterer
Synaptics devices send garbage between BTN_TOUCH and BTN_TOOL_FINGER. By switching to use this as proximity data now, the pointer is reset to the garbage data position (usually around 1/5855). This reverts commit 899218e18120918138f6d7420465763422d5b3b7. Reported-by: Dave Airlie

[PATCH evdev 3/3] Add use_proximity bit for BTN_TOOL handling.

2010-12-20 Thread Peter Hutterer
Touchpads send garbage data between BTN_TOOL_FINGER and BTN_TOUCH. This leads to cursor movement towards invalid positions (bottom left corner, usually). Add a new flag use_proximity as a delimiter for BTN_TOUCH handling. If unset, the actual proximity bits are ignored, no proximity events are

Re: [PATCH evdev 3/3] Add use_proximity bit for BTN_TOOL handling.

2010-12-20 Thread Chris Bagwell
I ack on patch concept. Its easy to see this invalid data on synaptics hardware and needs to be accounted for. I'm not up on current proximity support in evdev but patch makes sense overall. Just two comments to consider. 1) Will BTN_TOUCH always be sent when you need it to? I'm wondering if

Re: [PATCH evdev 3/3] Add use_proximity bit for BTN_TOOL handling.

2010-12-20 Thread Chris Bagwell
On Mon, Dec 20, 2010 at 9:28 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, 20 Dec 2010 20:38:30 -0600, Chris Bagwell ch...@cnpbagwell.com wrote: I ack on patch concept.  Its easy to see this invalid data on synaptics hardware and needs to be accounted for. I'm not up on current

Re: [PATCH evdev 3/3] Add use_proximity bit for BTN_TOOL handling.

2010-12-20 Thread Peter Hutterer
On Mon, Dec 20, 2010 at 09:41:32PM -0600, Chris Bagwell wrote: On Mon, Dec 20, 2010 at 9:28 PM, Peter Hutterer peter.hutte...@who-t.net wrote: On Mon, 20 Dec 2010 20:38:30 -0600, Chris Bagwell ch...@cnpbagwell.com wrote: I ack on patch concept.  Its easy to see this invalid data on