Re: [PATCH:xdm 2/5] Add echoPasswdChar resource to set character to display

2011-02-20 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sat, 19 Feb 2011 22:36:38 -0800 Stop hardcoding it to '*'. Allows setting a resource with no value to display to advance the cursor without drawing text. What's the motivation for this change? Giving users more knobs to play with

Re: [PATCH:xdm 1/5] Delete some unused variables

2011-02-20 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sat, 19 Feb 2011 22:36:37 -0800 auth.c: In function `DefineSelf': auth.c:1045: warning: unused variable `n' error.c: In function `Debug': error.c:116: warning: unused variable `buf' Signed-off-by: Alan Coopersmith

Re: [PATCH:xdm 4/5] greeter: Remove unused extern dpy that is shadowed by local variables

2011-02-20 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sat, 19 Feb 2011 22:36:40 -0800 Resolves these warnings from gcc -Wshadow: greet.c: In function `InitGreet': greet.c:244: warning: declaration of 'dpy' shadows a global declaration greet.c:146: warning: shadowed declaration is here

Re: [PATCH:xdm 3/5] Remove forced cursor move for no-echo entry when echoPasswd not set

2011-02-20 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sat, 19 Feb 2011 22:36:39 -0800 If you want to have it, for feedback that's visible to the user but harder to shoulder-surf, enable echoPasswd and set the echoPasswdChar to empty/space. But that would move the pixel more than one

Re: [PATCH:xdm 5/5] greeter: Rename valueMask for xpm window to avoid shadowing argument

2011-02-20 Thread Mark Kettenis
From: Alan Coopersmith alan.coopersm...@oracle.com Date: Sat, 19 Feb 2011 22:36:41 -0800 The Realize function names one of its arguments valueMask, so rename the local variable to xpmValueMask to reduce confusion and clear the gcc -Wshadow warning: Login.c: In function `Realize':

[PATCH] xfree86: Fix undefined reference to `XNFsprintf' on sparc.

2011-02-20 Thread Cyril Brulebois
Build failure on sparc: | copying selected object files to avoid basename conflicts... | CCLD Xorg | ./.libs/libxorg.a(xf86sbusBus.o): In function `xf86SbusConfigureNewDev': | […]/hw/xfree86/common/xf86sbusBus.c:712: undefined reference to `XNFsprintf' | collect2: ld returned 1 exit status

[PATCH v2 keyboard 2/3] Removed useless leds (member structure KbdDevRec)

2011-02-20 Thread Alexandr Shadchin
Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- src/kbd.c |8 ++-- src/xf86OSKbd.h |1 - 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/kbd.c b/src/kbd.c index 86b5be5..e0d55e5 100644 --- a/src/kbd.c +++ b/src/kbd.c @@ -220,14 +220,12 @@

[PATCH v2 keyboard 3/3] Rewrote code to set initial state LEDS

2011-02-20 Thread Alexandr Shadchin
Saved only initial state CapsLock and NumLock Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- src/kbd.c | 105 - 1 files changed, 27 insertions(+), 78 deletions(-) diff --git a/src/kbd.c b/src/kbd.c index

[PATCH v2 keyboard 1/3] Removed option XLeds

2011-02-20 Thread Alexandr Shadchin
IMHO nobody needs because it works not correctly and still not fixed Signed-off-by: Alexandr Shadchin alexandr.shadc...@gmail.com --- man/kbd.man |7 --- src/kbd.c | 19 +-- src/xf86OSKbd.h |1 - 3 files changed, 1 insertions(+), 26 deletions(-) diff

Re: [PATCH synaptics 0/4] synaptics cleanup patches

2011-02-20 Thread Chris Bagwell
For the series: Reviewed-by: Chris Bagwell ch...@cnpbagwell.com On Wed, Feb 16, 2011 at 7:19 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Just a few cleanup patches I had in my tree for a while. Shouldn't change the driver behaviour, at least I didn't notice anything yet. Cheers,  

Re: XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-20 Thread Sedat Dilek
[ Please CC me, I am not subscribed to this ML ] Hi, which toolchain from Debian are you using? Did you try with gcc-4.5 and binutils-2.21.0 (both from experimental)? Changelog from [1] says (see also [2]): ... * Pass --no-add-needed by default to the linker. See

Re: XDM: Fix FTBFS with gold or recent gcc releases.

2011-02-20 Thread Fernando Lemos
Hi, On Sun, Feb 20, 2011 at 3:44 PM, Sedat Dilek sedat.di...@googlemail.com wrote: [...] which toolchain from Debian are you using? Everything from wheezy/sid, and I'm not using gold. I don't even have gold or GCC 4.5+ installed. gcc version 4.4.5 (Debian 4.4.5-12) GNU ld (GNU Binutils for

Re: xserver distcheck broken with and without --disable-devel-docs

2011-02-20 Thread Dan Nicholson
On Sat, Feb 19, 2011 at 8:24 AM, Gaetan Nadon mems...@videotron.ca wrote: On Sat, 2011-02-19 at 17:08 +0100, Cyril Brulebois wrote: Gaetan Nadon mems...@videotron.ca (19/02/2011): The scenario in question is running distcheck in a VPATH build when doc generation is disabled which conflicts

Fixing out-of-tree failures in hw/dmx/doc

2011-02-20 Thread Cyril Brulebois
Hi, I saw Dan's reply, but I'm posting anyway the tiny patch series that fixes the out-of-tree build for me (with devel docs enabled, with doxygen; not tried distcheck). [PATCH 1/3] hw/dmx/doc: Fix missing slash in css target. Trivial enough. [PATCH 2/3] hw/dmx/doc: Specify {src,build}dir in

[PATCH 3/3] hw/dmx/doc: Move from $(builddir) to $(abs_builddir).

2011-02-20 Thread Cyril Brulebois
$(builddir)/doxygen.* targets are never considered out-of-date, so symlinks never get created and out-of-tree builds fail. Using $(abs_builddir) instead fixes it. Signed-off-by: Cyril Brulebois k...@debian.org --- hw/dmx/doc/Makefile.am |8 1 files changed, 4 insertions(+), 4

[PATCH 1/3] hw/dmx/doc: Fix missing slash in css target.

2011-02-20 Thread Cyril Brulebois
Signed-off-by: Cyril Brulebois k...@debian.org --- hw/dmx/doc/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/dmx/doc/Makefile.am b/hw/dmx/doc/Makefile.am index 4bbc8bf..17defb5 100644 --- a/hw/dmx/doc/Makefile.am +++ b/hw/dmx/doc/Makefile.am @@ -260,6

[PATCH] dmx: Construct paths in doxygen.conf to fix VPATH builds

2011-02-20 Thread Dan Nicholson
The paths in doxygen.conf assumed that srcdir=builddir and broke otherwise. Use autoconf to fill in the paths to the srcdir so that the files can be found when users have a separate build directory (as with distcheck). Signed-off-by: Dan Nicholson dbn.li...@gmail.com --- I actually tested this

Re: xserver distcheck broken with and without --disable-devel-docs

2011-02-20 Thread Gaetan Nadon
On Sun, 2011-02-20 at 08:51 -0800, Dan Nicholson wrote: I don't see how this could be automake doing anything. doxygen has been passed the correct path to doxygen.conf, but it's having trouble finding doxygen.head, which isn't specified on the command line. Correct. Something too long to

Re: [PATCH] dmx: Construct paths in doxygen.conf to fix VPATH builds

2011-02-20 Thread Cyril Brulebois
Dan Nicholson dbn.li...@gmail.com (20/02/2011): The paths in doxygen.conf assumed that srcdir=builddir and broke otherwise. Use autoconf to fill in the paths to the srcdir so that the files can be found when users have a separate build directory (as with distcheck). Signed-off-by: Dan

Re: [PATCH] xfree86: Fix undefined reference to `XNFsprintf' on sparc.

2011-02-20 Thread Alan Coopersmith
On 02/20/11 07:26 AM, Cyril Brulebois wrote: Build failure on sparc: | copying selected object files to avoid basename conflicts... | CCLD Xorg | ./.libs/libxorg.a(xf86sbusBus.o): In function `xf86SbusConfigureNewDev': | […]/hw/xfree86/common/xf86sbusBus.c:712: undefined reference to

Re: xserver distcheck broken with and without --disable-devel-docs

2011-02-20 Thread Dan Nicholson
On Sun, Feb 20, 2011 at 11:05 AM, Gaetan Nadon mems...@videotron.ca wrote: On Sun, 2011-02-20 at 08:51 -0800, Dan Nicholson wrote: I don't see how this could be automake doing anything. doxygen has been passed the correct path to doxygen.conf, but it's having trouble finding doxygen.head,

Re: dmx: Construct paths in doxygen.conf to fix VPATH builds

2011-02-20 Thread Sedat Dilek
Hi, I also have rename detection on here to make the reviewing easier, so you'll need git am or apply to do the right thing. applying the patch from [1] here with git-1.7.4.1 via git apply fails. The renaming part hw/dmx/doc/{doxygen.conf = doxygen.conf.in fails and doxygen.conf file was

Re: Input drivers (was [ANNOUNCE] xorg-server 1.9.99.902 (1.10 RC2))

2011-02-20 Thread Peter Hutterer
On Sat, Feb 19, 2011 at 03:57:38PM +0100, Cyril Brulebois wrote: Hi, Keith Packard kei...@keithp.com (18/02/2011): Other than that, I think we're pretty much ready for the 1.10 release. Let me know if you've got pending fixes that you want to see merged in 1.10. Peter, could we please

[PATCH mouse 1/6] man: remove mention of core pointer.

2011-02-20 Thread Peter Hutterer
This doesn't apply to X servers 1.7 and later. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- man/mousedrv.man |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/man/mousedrv.man b/man/mousedrv.man index e805335..a6b443d 100644 --- a/man/mousedrv.man +++

[PATCH mouse 2/6] man: add mention of xorg.conf.d snippet

2011-02-20 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- man/mousedrv.man |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/man/mousedrv.man b/man/mousedrv.man index a6b443d..13db918 100644 --- a/man/mousedrv.man +++ b/man/mousedrv.man @@ -73,8 +73,9 @@ what matters.

[PATCH mouse 3/6] man: README.mouse is just README

2011-02-20 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- man/mousedrv.man |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/man/mousedrv.man b/man/mousedrv.man index 13db918..7be4935 100644 --- a/man/mousedrv.man +++ b/man/mousedrv.man @@ -86,8 +86,9 @@ platforms this

[PATCH mouse 4/6] man: fix typo Auto platform → Auto protocol

2011-02-20 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- man/mousedrv.man |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/man/mousedrv.man b/man/mousedrv.man index 7be4935..f9b9993 100644 --- a/man/mousedrv.man +++ b/man/mousedrv.man @@ -105,7 +105,7 @@ NetMousePS/2,

[PATCH mouse 5/6] man: protocol option isn't mandatory, it's platform-specific.

2011-02-20 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- man/mousedrv.man |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/man/mousedrv.man b/man/mousedrv.man index f9b9993..917ca8e 100644 --- a/man/mousedrv.man +++ b/man/mousedrv.man @@ -106,8 +106,8 @@ NetMousePS/2,

[PATCH mouse 6/6] man: ClearDTR and ClearRTS are handled by the X server.

2011-02-20 Thread Peter Hutterer
If it breaks, we know who to blame (or file a bug against). Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- man/mousedrv.man |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/man/mousedrv.man b/man/mousedrv.man index 917ca8e..23528f6 100644 ---

Re: [PATCH mouse 1/6] man: remove mention of core pointer.

2011-02-20 Thread Cyril Brulebois
Peter Hutterer peter.hutte...@who-t.net (21/02/2011): This doesn't apply to X servers 1.7 and later. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net For the series: Reviewed-by: Cyril Brulebois k...@debian.org KiBi. signature.asc Description: Digital signature

Re: [Patch synaptics] add hysteresis-based noise cancellation

2011-02-20 Thread Peter Hutterer
On Tue, Feb 15, 2011 at 12:24:39AM +0100, Simon Thum wrote: This adresses the noise motion coming from most touchpads. The reviews have been incorporated, the code now get fuzz from the kernel if that is set (which it usually isn't). all 4 merged, though the ComputeDelta's patch has moved a

Re: [PATCH synaptics] Stop scrolling if not exactly two fingers on touchpad.

2011-02-20 Thread Peter Hutterer
On Mon, Feb 14, 2011 at 10:08:41PM +0800, Daniel Kurtz wrote: X.Org Bug 34257 http://bugs.freedesktop.org/show_bug.cgi?id=34257 Signed-off-by: Daniel Kurtz djku...@google.com --- src/synaptics.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/synaptics.c

[PATCH] dix: a valuator count of 0 is valid (#34510)

2011-02-20 Thread Peter Hutterer
For all but motion and proximity events, having no valuators is ok. Regression from 1.9, keyboard events are not converted to protocol events. X.Org Bug 34510 http://bugs.freedesktop.org/show_bug.cgi?id=34510 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- dix/eventconvert.c | 16

[PATCH] test: write some event → XI1 conversion tests.

2011-02-20 Thread Peter Hutterer
These tests don't test everything, but hey, life is short and I'm trying to have one. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/input.c | 139 ++ 1 files changed, 139 insertions(+), 0 deletions(-) diff --git

[PATCH v2] xkb: Fix a check for MASTER_KEYBOARD

2011-02-20 Thread Peter Hutterer
And copy into the master keyboard, not just the directly attached device. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- On Fri, Feb 18, 2011 at 10:48:10AM +0100, Benjamin Tissoires wrote: @@ -5883,9 +5884,8 @@ ProcXkbGetKbdByName(ClientPtr client) nkn.changed|=

Re: [PATCH] dix: a valuator count of 0 is valid (#34510)

2011-02-20 Thread Keith Packard
On Mon, 21 Feb 2011 15:39:17 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: For all but motion and proximity events, having no valuators is ok. Regression from 1.9, keyboard events are not converted to protocol events. Looks right to me. Reviewed-by: Keith Packard kei...@keithp.com

Re: [PATCH] test: write some event → XI1 conversion tests.

2011-02-20 Thread Keith Packard
On Mon, 21 Feb 2011 15:44:31 +1000, Peter Hutterer peter.hutte...@who-t.net wrote: These tests don't test everything, but hey, life is short and I'm trying to have one. These look good to me. Reviewed-by: Keith Packard kei...@keithp.com -- keith.pack...@intel.com pgpIAT60g7FeP.pgp

Re: [PATCH v2] xkb: Fix a check for MASTER_KEYBOARD

2011-02-20 Thread Daniel Stone
On Mon, Feb 21, 2011 at 04:00:23PM +1000, Peter Hutterer wrote: And copy into the master keyboard, not just the directly attached device. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- On Fri, Feb 18, 2011 at 10:48:10AM +0100, Benjamin Tissoires wrote: @@ -5883,9 +5884,8 @@

Re: [PATCH] dix: a valuator count of 0 is valid (#34510)

2011-02-20 Thread Daniel Stone
On Mon, Feb 21, 2011 at 03:39:17PM +1000, Peter Hutterer wrote: For all but motion and proximity events, having no valuators is ok. Regression from 1.9, keyboard events are not converted to protocol events. X.Org Bug 34510 http://bugs.freedesktop.org/show_bug.cgi?id=34510 Signed-off-by: