Re: [PATCH xorgproto 2/2] Assorted typo fixes in headers
On 06/18/18 02:51 PM, Jon Turney wrote: On 17/06/2018 17:55, Alan Coopersmith wrote: - ** o Convience Marcos + ** o Convenience Marcos "Convenience Macros" ? Good point. So busy looking at the typo in the first word that I didn't notice the second (and neither did the spell checker). Fixed, thanks! -- -Alan Coopersmith- alan.coopersm...@oracle.com Oracle Solaris Engineering - https://blogs.oracle.com/alanc ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xorgproto 2/2] Assorted typo fixes in headers
On 17/06/2018 17:55, Alan Coopersmith wrote: - ** o Convience Marcos + ** o Convenience Marcos "Convenience Macros" ? ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Grabbing modesetting ddx related patches for pull request
To help ajax out with getting a bug release out for Xorg, we figured it would be a good idea for me to go through the stuff I needed to get upstream and file pull requests for all of it. This is pretty much the same thing as what I'm doing for EGLStreams stuff in Xwayland, except for modesetting. For starters, my current WIP branch for this pull lives at: https://gitlab.freedesktop.org/lyudess/xserver/tree/wip/modesetting-pull This contains all the modesetting patches on patchwork I could find that have been reviewed and are ready to go. Additionally, there's a rather important fix for the modesetting ddx regarding the new partial atomic support that I haven't written up yet that will be included in this too. Other then that, there's currently some patches on the ML that I found which need reviews: * "modesetting: Update fb_id from shadow allocate and destroy if not set" from Tony Lindgren: https://patchwork.freedesktop.org/patch/203834/ * "modesetting: Allow a DRM fd to be passed on command line with -masterfd" from Keith Packard https://patchwork.freedesktop.org/patch/207655/ I will try to give a review of these, but reviews from others would be appreciated as well since there are probably people a lot more experienced with this ddx than I on this list :). If I've missed anyone's patches, please feel free to respond to this email. I'll give an update when I think it's ready for pulling time (which should hopefully not be too long from now). -- Cheers, Lyude Paul ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver] modesetting: use drmmode_bo_import() for rotate_fb
Reviewed-by: Lyude Paul
On Fri, 2018-06-15 at 08:57 +0200, Olivier Fourdan wrote:
> drmmode_shadow_allocate() still uses drmModeAddFB() which may fail if
> the format is not as expected, preventing from using a rotated output.
>
> Change it to use the new function drmmode_bo_import() which takes care
> of calling the drmModeAddFB2() API.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106715
> Signed-off-by: Olivier Fourdan
> ---
> hw/xfree86/drivers/modesetting/drmmode_display.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
> b/hw/xfree86/drivers/modesetting/drmmode_display.c
> index 859a21a9d..ec11b3f56 100644
> --- a/hw/xfree86/drivers/modesetting/drmmode_display.c
> +++ b/hw/xfree86/drivers/modesetting/drmmode_display.c
> @@ -1794,11 +1794,8 @@ drmmode_shadow_allocate(xf86CrtcPtr crtc, int width,
> int height)
> return NULL;
> }
>
> -ret = drmModeAddFB(drmmode->fd, width, height, crtc->scrn->depth,
> - drmmode->kbpp,
> - drmmode_bo_get_pitch(_crtc->rotate_bo),
> - drmmode_bo_get_handle(_crtc->rotate_bo),
> - _crtc->rotate_fb_id);
> +ret = drmmode_bo_import(drmmode, _crtc->rotate_bo,
> +_crtc->rotate_fb_id);
>
> if (ret) {
> ErrorF("failed to add rotate fb\n");
--
Cheers,
Lyude Paul
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
Gathering EGLStream related changed for Xwayland for a pull request
Hey guys! So, talking to Ajax he said that something which would probably help out with getting a bugfix release out there for X is if people started getting their changes together into pull requests so that he doesn't need to go through a bunch of threads and figure out what needs to be pulled in or not. I've got some other stuff I need to make sure gets fixed in the X server, but for now as far as I can tell all of the EGLStream related fixes we need to get in Xwayland are reviewed and ready for a pull request. This includes: https://cgit.freedesktop.org/~ofourdan/xserver/log/?h=xwayland (thanks Olivier for putting everything in one place!) If anyone else has EGLStream related stuff they would like to get in that I missed, it's probably a good idea to respond to this! -- Cheers, Lyude Paul ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: gitlab migration
On Tue, 2018-06-12 at 17:38 -0400, James Cloos wrote: > Two comments: > > BZ is superior to GL (or GH or the like). > > Mailing lists are vastly superior to any web-only crap. 'web-only' is only a problem until you actually go write a command line client for it. Which, you can do if you really need these sort of workflows. Additionally I'm with daniels here, Gitlab and Github are two massively different things with different workflows and if you're just going off the assumption "if it sounds like the word Github then it must be another github" you're not actually contributing anything useful to the discussion, especially if you don't actually provide any points as to "gitlab is bad because of X or Y reason". > > -JimC -- Cheers, Lyude Paul ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
