Re: [PATCH v2 app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

2017-11-02 Thread Giuseppe Bilotta
On Thu, Nov 2, 2017 at 6:20 PM, Pali Rohár wrote: > > But back to my documentation update patch. It is needed to rework it? > And if yes, how, In light of my opinion on the relevant of the core DPI value, here's my take on it, chunk by chunk: > -Sets the reported values

[PATCH xserver] dix/window: fix typos

2017-11-02 Thread Giuseppe Bilotta
--- dix/window.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dix/window.c b/dix/window.c index ead4dc27f..8789a5ece 100644 --- a/dix/window.c +++ b/dix/window.c @@ -456,9 +456,9 @@ TraverseTree(WindowPtr pWin, VisitWindowProcPtr func, void *data) /* *

[PATCH xserver] glamor: Drop the non-VAO rendering path

2017-11-02 Thread Adam Jackson
GLES spells this extension as GL_OES_vertex_array_object, but it is functionally equivalent to the GL_ARB version. Mesa has supported both since 9.0, let's go ahead and require it. Signed-off-by: Adam Jackson --- glamor/glamor.c| 8 ++--

Re: [PATCH xserver] configure.ac: unconditionally enable kdrive

2017-11-02 Thread Eric Anholt
Adam Jackson writes: > On Wed, 2017-11-01 at 21:50 -0700, Matt Turner wrote: >> On Tue, Oct 24, 2017 at 10:27 AM, Matt Turner >> wrote: >> > Reviewed-by: Matt Turner >> >> Please merge. :) > > Full disclosure: the reason I haven't is

Re: [PATCH v2 app/xrandr] Document that --dpi and --fbmm options set DPI of whole X screen

2017-11-02 Thread Pali Rohár
On Wednesday 01 November 2017 16:35:04 Adam Jackson wrote: > On Wed, 2017-11-01 at 21:04 +0100, Giuseppe Bilotta wrote: > > > (Heck, I would even argue that the core DPI should be set to the > > primary monitor DPI by default, regardless of whether the system has > > one or more than one

Re: [PATCH xserver 4/8] glamor: Split out glamor_xv.h

2017-11-02 Thread Emil Velikov
On 1 November 2017 at 20:31, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- Please add a line about the reason behind the split. It's not immediately obvious if there's some technical merit or simply things easier to follow. With that patches 2-6 incl.

Re: [PATCH xserver 1/8] miinitext: General cleanup

2017-11-02 Thread Emil Velikov
On 1 November 2017 at 20:31, Adam Jackson wrote: > This really just wants to be the list of disable booleans and > initialization functions, and nothing else. Stop including the protocol > headers from extinit.h, remove a stray mention of xgl, and move an > XInput declaration to

Re: [PATCH xserver 8/8] glamor: Eliminate EGL stubs

2017-11-02 Thread Emil Velikov
Hi Adam, Above all - hell yea... No more ugly wrappers and build magic :-) On 1 November 2017 at 20:31, Adam Jackson wrote: > glamor_init is now spelled glamor_api_init, and takes as a new parameter > the winsys API initialization function. A compatibility function is > added

Re: [RFC] DeepColor Visual Class Extension

2017-11-02 Thread Adam Jackson
On Thu, 2017-10-26 at 19:50 -0700, Alex Goins wrote: > DPCGetWindowDisplayCapabilities > > window: WINDOW > => > output: OUTPUT > colorspace_list: LISTofCOLORSPACEPRIORITY > > Errors: Window > > DPCGetWindowDisplayCapabilities functions

Re: [PATCH xserver 7/8] glamor: Add glamor_get_screen_context

2017-11-02 Thread Emil Velikov
On 1 November 2017 at 20:31, Adam Jackson wrote: > Also, fold glamor_context.h into glamor.h, and use the standard Xnest > trick so we can include server headers in glamor_glx.c. > There seems to be no user of the new API - guessing that you have some local patches for that?

Re: [PATCH xserver] xfree86: fix gamma compute when palette_size > 256

2017-11-02 Thread Michel Dänzer
On 01/11/17 11:27 AM, Yu, Qiang wrote: > >>> 2. the palette_size can be bigger than crtc->gamma_size, [...] >> >> Can it really? In Aaron's example, both have 1024 entries. > Isn't it 2^11 for palette_size but 2^10 gamma_size? No, palette size is 2^10 at depth 30. >>> So according to the above

Re: [PATCH] glx: Duplicate relevant fbconfigs for compositing visuals

2017-11-02 Thread Thomas Hellstrom
Ping? It would be good to resolve this. Thomas On 10/13/2017 07:43 AM, Thomas Hellstrom wrote: Hi, On 10/12/2017 10:32 PM, Adam Jackson wrote: On Thu, 2017-10-12 at 15:06 +0200, Thomas Hellstrom wrote: Ping? If we're going to do this, and I guess we have to, I'd like to see two changes:

Re: [PATCH xserver] configure.ac: unconditionally enable kdrive

2017-11-02 Thread Adam Jackson
On Wed, 2017-11-01 at 21:50 -0700, Matt Turner wrote: > On Tue, Oct 24, 2017 at 10:27 AM, Matt Turner > wrote: > > Reviewed-by: Matt Turner > > Please merge. :) Full disclosure: the reason I haven't is because it exposed that my test setup was failing to