[PATCH xserver] xfree86: drop KDSKBMUTE handling

This was never merged upstream. It was a Fedora kernel patch but dropped from Fedora in 2013 with kernel 3.12. The reason for the KDSKBMUTE proposal has been fixed in systemd in Feb 2013, systemd 198. https://lists.freedesktop.org/archives/systemd-devel/2013-February/008795.html Signed-off-by:

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

I'm sorry to report it didn't fix it. This tested with current head of xserver master, mesa master, so with my and your fixes included, and apparently some new fixes from today. Compositing under old Ubuntu Unity-7 == compiz and Gnome shell work fine, as does KDE-5 Plasma with GLX+OpenGL

Re: [PATCH xserver 0/8] GCC8 warning fixes

On Thu, 2018-04-05 at 10:42 -0700, Keith Packard wrote: > Adam Jackson writes: > > > gcc 8's buffer size logic got a bit pickier, in mostly reasonable ways, > > but -Wmaybe-uninitialized got a lot more speculative. Regardless I'm > > tired of seeing warnings in my build logs. >

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

Nope still not working Intel DDX didn't launch, Modesetting did however compositing was disabled due to the previous failure. Upon reenabling the screen went blank, however things were still running, when I went to the top left corner I could see the window titles, then the outline of the kicker

Re: [PATCH xserver 0/8] GCC8 warning fixes

Adam Jackson writes: > gcc 8's buffer size logic got a bit pickier, in mostly reasonable ways, > but -Wmaybe-uninitialized got a lot more speculative. Regardless I'm > tired of seeing warnings in my build logs. (some of these are truly ridiculous, but...) Acked-by: Keith

[PATCH xserver] xwayland: Silence a build warning if we can

[735/786] Generating 'hw/xwayland/Xwayland@exe/relative-pointer-unstable-v1-protocol.c'. Using "code" is deprecated - use private-code or public-code. See the help page for details. Use private-code if wayland-scanner is new enough. Signed-off-by: Adam Jackson ---

[PATCH xserver 2/8] dmx: Fix some snprintf warnings.

snprintf doesn't terminate the string if it truncates, so things like this are lurking crashers: ../hw/dmx/dmxprop.c: In function ‘dmxPropertyIdentifier.part.0’: ../hw/dmx/dmxprop.c:94:36: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 123

[PATCH xserver 4/8] dmx: Clean up some argument parsing code

This threw: ../hw/dmx/input/dmxarg.c: In function ‘dmxArgParse’: ../hw/dmx/input/dmxarg.c:128:5: warning: ‘strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=] strncpy(tmp, string, len); ^ ../hw/dmx/input/dmxarg.c:126:11:

[PATCH xserver 0/8] GCC8 warning fixes

gcc 8's buffer size logic got a bit pickier, in mostly reasonable ways, but -Wmaybe-uninitialized got a lot more speculative. Regardless I'm tired of seeing warnings in my build logs. - ajax ___ xorg-devel@lists.x.org: X.Org development Archives:

[PATCH xserver 3/8] dmx: Fix a read-from-uninitialized warning

../hw/dmx/dmxpixmap.c: In function ‘dmxBitmapToRegion’: ../include/regionstr.h:174:22: warning: ‘Box.x1’ may be used uninitialized in this function [-Wmaybe-uninitialized] (_pReg)->extents = *(_pBox); ~^~ ../hw/dmx/dmxpixmap.c:208:12: note: ‘Box.x1’ was declared

[PATCH xserver 8/8] dix: Hush an almost certainly bogus warning

../dix/getevents.c: In function ‘transformAbsolute’: ../dix/getevents.c:1195:28: warning: ‘oy’ may be used uninitialized in this function [-Wmaybe-uninitialized] struct pixman_f_vector p = {.v = {*x, *y, 1} }; ^ ../dix/getevents.c:1234:22: note: ‘oy’ was declared

[PATCH xserver 6/8] xkb: Silence some compiler warnings

Of the form: ../xkb/XKBGAlloc.c: In function ‘SrvXkbAddGeomKeyAlias’: ../xkb/XKBGAlloc.c:591:13: warning: ‘strncpy’ specified bound 4 equals destination size [-Wstringop-truncation] strncpy(alias->real, realStr, XkbKeyNameLength);

[PATCH xserver 7/8] mi: Hush an almost certainly bogus warning

In file included from ../mi/miexpose.c:83: ../mi/miexpose.c: In function ‘miHandleExposures’: ../include/regionstr.h:174:22: warning: ‘expBox.y2’ may be used uninitialized in this function [-Wmaybe-uninitialized] (_pReg)->extents = *(_pBox); ~^~

[PATCH xserver 5/8] dmx: Silence a string truncation warning.

../hw/dmx/config/dmxparse.c: In function ‘dmxConfigCreateOption’: ../hw/dmx/config/dmxparse.c:385:13: warning: ‘strncpy’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] strncpy(option->string + offset, p->string,

[PATCH xserver 1/8] gtf: Warning fix

../hw/xfree86/utils/gtf/gtf.c: In function ‘print_fb_mode’: ../hw/xfree86/utils/gtf/gtf.c:241:50: warning: cast from function call of type ‘double’ to non-matching type ‘int’ [-Wbad-function-cast] printf("timings %d %d %d %d %d %d %d\n", (int) rint(100.0 / m->pclk), /*

Re: [PATCH xserver v3 3/3] modesetting: Actually get framebuffer ID

On Thu, 2018-04-05 at 18:01 +0200, Olivier Fourdan wrote: > > On 5 April 2018 at 17:47, Daniel Stone wrote: > > We would fail to get the FB ID if it wasn't already imported, since we > > were checking to see if the pointer was NULL (it never was) rather than > > if the

Re: [PATCH xserver v3 3/3] modesetting: Actually get framebuffer ID

On 2018-04-05 05:47 PM, Daniel Stone wrote: > We would fail to get the FB ID if it wasn't already imported, since we > were checking to see if the pointer was NULL (it never was) rather than > if the content of the pointer was 0. > > Signed-off-by: Daniel Stone >

Re: [PATCH xserver v3 3/3] modesetting: Actually get framebuffer ID

On 5 April 2018 at 17:47, Daniel Stone wrote: > We would fail to get the FB ID if it wasn't already imported, since we > were checking to see if the pointer was NULL (it never was) rather than > if the content of the pointer was 0. > > Signed-off-by: Daniel Stone

[PATCH xserver v3 3/3] modesetting: Actually get framebuffer ID

We would fail to get the FB ID if it wasn't already imported, since we were checking to see if the pointer was NULL (it never was) rather than if the content of the pointer was 0. Signed-off-by: Daniel Stone Reported-by: Olivier Fourdan ---

[PATCH xserver v3 1/3] modesetting: Don't reuse iterator in nested loop

drmmode_crtc_set_mode has a loop nested inside another loop, where both of them were using 'i' as the loop iterator. Rename it to avoid an infinite loop. Signed-off-by: Daniel Stone Reported-by: Michel Dänzer Reviewed-by: Michel Dänzer

[PATCH xserver v3 2/3] dri3: Set stride and size for old clients

For old clients using the fd_from_pixmap entrypoint, make sure we set stride and size correctly. Noticed by inspection. Signed-off-by: Daniel Stone --- dri3/dri3_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dri3/dri3_screen.c b/dri3/dri3_screen.c index

Re: [PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

On 2018-04-05 03:58 PM, Daniel Stone wrote: > drmmode_crtc_set_mode has a loop nested inside another loop, where both > of them were using 'i' as the loop iterator. Rename it to avoid an > infinite loop. > > Signed-off-by: Daniel Stone > Reported-by: Michel Dänzer

Re: [PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

> Daniel Stone hat am 5. April 2018 um 16:08 geschrieben: > > > On 5 April 2018 at 15:06, Walter Harms wrote: > >> Daniel Stone hat am 5. April 2018 um 15:58 > >> geschrieben: > >> -for (i = 0; i <

Re: [PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

On Thu, Apr 5, 2018 at 3:58 PM, Daniel Stone wrote: > drmmode_crtc_set_mode has a loop nested inside another loop, where both > of them were using 'i' as the loop iterator. Rename it to avoid an > infinite loop. > > Signed-off-by: Daniel Stone >

Re: [PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

On 5 April 2018 at 15:06, Walter Harms wrote: >> Daniel Stone hat am 5. April 2018 um 15:58 >> geschrieben: >> -for (i = 0; i < xf86_config->num_output; i++) { >> -xf86OutputPtr output = xf86_config->output[i]; >> +for

Re: [PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

> Daniel Stone hat am 5. April 2018 um 15:58 > geschrieben: > > > drmmode_crtc_set_mode has a loop nested inside another loop, where both > of them were using 'i' as the loop iterator. Rename it to avoid an > infinite loop. > > Signed-off-by: Daniel Stone

[PATCH xserver v2 2/2] dri3: Set stride and size for old clients

For old clients using the fd_from_pixmap entrypoint, make sure we set stride and size correctly. Noticed by inspection. Signed-off-by: Daniel Stone --- dri3/dri3_screen.c | 2 ++ 1 file changed, 2 insertions(+) Sorry, accidentally sent the previous without having

[PATCH xserver 2/2] dri3: Set stride and size for old clients

For old clients using the fd_from_pixmap entrypoint, make sure we set stride and size correctly. Noticed by inspection. Signed-off-by: Daniel Stone --- dri3/dri3_screen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dri3/dri3_screen.c b/dri3/dri3_screen.c index

[PATCH xserver 1/2] modesetting: Don't reuse iterator in nested loop

drmmode_crtc_set_mode has a loop nested inside another loop, where both of them were using 'i' as the loop iterator. Rename it to avoid an infinite loop. Signed-off-by: Daniel Stone Reported-by: Michel Dänzer ---

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

There's also some journalctl output in the bug report On 5 April 2018 at 11:06, Mike Lothian wrote: > Hi > > I'm attaching the core dumps (4GB uncompressed, 7MB XZ compressed) > > Might still be too big for the list > > Cheers > > Mike > > On 5 April 2018 at 09:33, Daniel

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

Hi Mike, On 5 April 2018 at 09:03, Mike Lothian wrote: > I got different behavior with modesetting and the intel ddx I can try with the Intel DDX later on today. > Both didn't render anything, but I think one was crashing over and > over (I think systemd kept restarting it

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

Hi I got different behavior with modesetting and the intel ddx Both didn't render anything, but I think one was crashing over and over (I think systemd kept restarting it in quick succession) I only remember that because when I switched VTs it made it almost impossible to type anything as it

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

Hi Mike, On 5 April 2018 at 07:10, Mike Lothian wrote: > I've just tested with those patches, it still doesn't work without that revert > > If you're testing this on kwin can you make sure you're using one of > the OpenGL options on the renderer rather than XRender I'm

Re: Bug 105851 Xserver 1.20 RC2+ issues with Kwin + Present 1.2

Hi I've just tested with those patches, it still doesn't work without that revert If you're testing this on kwin can you make sure you're using one of the OpenGL options on the renderer rather than XRender Thanks Mike On 4 April 2018 at 17:17, Daniel Stone wrote: > Hi