[PATCH xserver 8/9] xfree86: Create EDID atom from the root window callback

2016-01-06 Thread Adam Jackson
Signed-off-by: Adam Jackson --- hw/xfree86/ddc/ddcProperty.c | 31 +-- 1 file changed, 9 insertions(+), 22 deletions(-) diff --git a/hw/xfree86/ddc/ddcProperty.c b/hw/xfree86/ddc/ddcProperty.c index 66e7ba8..1b3f36a 100644 --- a/hw/xfree86/ddc/ddcProperty.c +++ b/hw

[PATCH xserver 7/9] xfree86: Remove a never-hit diagnostic message

2016-01-06 Thread Adam Jackson
Practically speaking, the EDID major version is never not 1. Signed-off-by: Adam Jackson --- hw/xfree86/ddc/ddcProperty.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/hw/xfree86/ddc/ddcProperty.c b/hw/xfree86/ddc/ddcProperty.c index a31e9c7..66e7ba8

[PATCH xserver 0/9] Rewrite root window property setup

2016-01-06 Thread Adam Jackson
Leo's patch to fix the EDID atom leak is probably correct, in the sense that it fixes the leak, but xf86RegisterRootWindowProperty is fairly ugly to begin with so I'd rather see it eliminated. This series adds a generic callback for screen finalization and ports xfree86 to it. Since dixChangeWind

[PATCH xserver 9/9] xfree86: Remove xf86RegisterRootWindowProperty

2016-01-06 Thread Adam Jackson
All consumers have been ported to the root window callback, so this can all be nuked. Signed-off-by: Adam Jackson --- hw/xfree86/common/xf86.h| 7 hw/xfree86/common/xf86Globals.c | 1 - hw/xfree86/common/xf86Helper.c | 75 - hw/xfree86

[PATCH xserver 5/9] xfree86: Remove some leftovers from DisplayID support

2016-01-06 Thread Adam Jackson
Signed-off-by: Adam Jackson --- hw/xfree86/ddc/ddcProperty.c | 10 ++ hw/xfree86/ddc/edid.h| 1 - 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/xfree86/ddc/ddcProperty.c b/hw/xfree86/ddc/ddcProperty.c index fc63f0e..c51c3e6 100644 --- a/hw/xfree86/ddc

Re: [PATCH xserver v2] Fix uninitialized variable warnings reported by clang

2016-01-06 Thread Adam Jackson
On Wed, 2016-01-06 at 07:00 +0100, Thomas Klausner wrote: > Hello Adam! > > > If it's not too much trouble, please use git-send-email --in-reply-to > > for followup patches like this. > > Thanks, I didn't know about this. I'll use it in the future. And > thanks for the macro fix, it looks good to

[PATCH xserver] os: Failure to remove a non-existent log file is not an error

2016-01-06 Thread Adam Jackson
Signed-off-by: Adam Jackson --- os/log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/os/log.c b/os/log.c index 6168d59..91e55a5 100644 --- a/os/log.c +++ b/os/log.c @@ -218,7 +218,7 @@ LogFilePrep(const char *fname, const char *backup, const char *idstring

Re: [PATCH xserver] os: Failure to remove a non-existent log file is not an error

2016-01-06 Thread Adam Jackson
On Wed, 2016-01-06 at 08:11 -0800, Alan Coopersmith wrote: > Reviewed-by: Alan Coopersmith remote: I: patch #69572 updated using rev 6dcb73375e0ce389315d55587623eb84e9d13543. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver    862cbf4..6dcb733  mas

Re: [PATCH v2 3/8] randr: Add ability to turn PRIME sync off

2016-01-12 Thread Adam Jackson
On Tue, 2016-01-05 at 13:56 -0800, Alex Goins wrote: > If the user wishes to enable or disable PRIME synchronization after PRIME > has already been set up, they can run 'xrandr --output --set > "PRIME Synchronization" <0 or 1>' at any time, it will trigger a modeset, > tear down and setup PRIME i

Re: [PATCH xserver] os: Treat ssh as a non-local client (v3)

2016-01-12 Thread Adam Jackson
On Thu, 2015-12-17 at 16:41 +0900, Michel Dänzer wrote: > From: Adam Jackson > > By the time we get to ComputeLocalClient, we've already done > NextAvailableClient → ReserveClientIds → DetermineClientCmd (assuming > we're built with #define CLIENTIDS), so we can look up

Re: [PATCH] glx: don't force version == 2.0 for ES2 GLX context creation

2016-01-20 Thread Adam Jackson
On Tue, 2016-01-19 at 10:06 -0500, Ilia Mirkin wrote: > dEQP tests request a specific version. The EXT spec has been updated to > allow other versions, so allow anything >= 2.0 to be requested. (Comic book guy voice) Actually... >  case GLX_CONTEXT_ES2_PROFILE_BIT_EXT: The spec says: >

Re: [PATCH] glx: don't force version == 2.0 for ES2 GLX context creation

2016-01-20 Thread Adam Jackson
On Wed, 2016-01-20 at 14:53 -0500, Ilia Mirkin wrote: > That said, if you believe the only thing that needs to be done to (on > the X server side) support ES1 with GLX is to remove that return, > more than happy to send another patch that always lets it succeed. I think letting any ES version suc

[PATCH xserver] glx: Fix GLX_EXT_create_context_es2_profile support

2016-01-20 Thread Adam Jackson
nable es2_profile. Signed-off-by: Adam Jackson --- glx/createcontext.c| 31 ++- glx/extension_string.c | 1 + glx/extension_string.h | 1 + glx/glxdri2.c | 4 +++- glx/glxdriswrast.c | 2 ++ 5 files changed, 13 insertions(+), 26 deletions(-) diff

Re: [PATCH xserver] glx: Fix GLX_EXT_create_context_es2_profile support

2016-01-21 Thread Adam Jackson
On Wed, 2016-01-20 at 15:50 -0500, Adam Jackson wrote: > As of v4 of this extension, any GLES version number may be requested (to > enable GLES3 and later). To comply with this, simply remove the API > version checks and leave it to the DRI driver to validate. This happens > to also

Re: [PATCH v2 3/8] randr: Add ability to turn PRIME sync off

2016-01-26 Thread Adam Jackson
On Mon, 2016-01-25 at 19:17 -0800, Alex Goins wrote: > Hey Adam, > > I recently got around to implementing this when putting the v3 patch set > together (with some changes of my own,) and I'm finding that it harms the user > experience significantly. > > It's sort of annoying that you currently h

Re: [PATCH 1/1] Initialize pci_dev

2016-01-27 Thread Adam Jackson
On Fri, 2016-01-22 at 00:26 +, Pascal Terjan wrote: > Else it is read before initialization if XSERVER_LIBPCIACCESS is not defined > or location.type is not BUS_PCI. > > Noticed when I got a segfault where it was 0x1 while doing some tests on arm. > > Signed-off-by: Pascal Terjan remote: I:

[PATCH xserver] modesetting: Require sufficiently new libdrm

2016-01-27 Thread Adam Jackson
Bugzilla: https://bugs.freedesktop.org/93883 Signed-off-by: Adam Jackson --- configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index ac3bb64..312fc69 100644 --- a/configure.ac +++ b/configure.ac @@ -2035,8 +2035,7 @@ if test "x

Re: [PATCH xserver] dri2: Sync i915_pci_ids.h and i965_pci_ids.h from mesa

2016-01-27 Thread Adam Jackson
On Wed, 2016-01-27 at 13:47 +0100, Andreas Boll wrote: > I've verified that i915_pci_ids.h and i965_pci_ids.h match with > current mesa master 19ae5de981e014 > > Reviewed-by: Andreas Boll remote: I: patch #71718 updated using rev 50ca286d79f6304b972ea74487308e7794a170fb. remote: I: 1 patch(es)

Re: [PATCH 3/5] xephyr: Remove DRI1

2016-01-28 Thread Adam Jackson
On Wed, 2016-01-27 at 17:40 -0800, Eric Anholt wrote: > Adam Jackson writes: > > > This only worked if the backend server supported DRI1, which is > > stunningly unlikely these days. > > Patches 1-3 are: > > Reviewed-by: Eric Anholt Pushed, thanks. > I ha

[PATCH xserver 0/3] Accounting fixes for ResQueryClientPixmapBytes

2016-02-02 Thread Adam Jackson
In (attempting to) track down a memory leak, I found that the pixmap byte accounting code in the Resource extension was wildly overreporting. This series tries to fix things up, and even deletes some code in the process. Sadly it does not fix any leaks. Xext/xres.c | 96 ++---

[PATCH xserver 3/3] res: Account for GLXPixmap references too

2016-02-02 Thread Adam Jackson
GLX_EXT_tetxure_from_pixmap operates on a GLXPixmap, which takes a reference on the backing pixmap; that GLXPixmap might be long-lived, so we should account for it in ResQueryClientPixmapBytes. Signed-off-by: Adam Jackson --- glx/glxext.c | 19 +++ 1 file changed, 19 insertions

[PATCH xserver 1/3] res: Simplify QueryClientPixmapBytes

2016-02-02 Thread Adam Jackson
bytes that way. This might be slightly slower since we're calling the size func once for every resource. On the other hand, it might be slightly faster since we only walk the resource table once instead of 3-5 times. Probably a wash, and not really a performance path in any case. Signed-

[PATCH xserver 2/3] res: Fix accounting of redirected window pixmaps for Composite

2016-02-02 Thread Adam Jackson
split 2/3 to xcompmgr and 1/3 to the server-client. Nothing to be done about that, and at least this way we're not over-accounting. Signed-off-by: Adam Jackson --- composite/compext.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/composite/compex

Re: [PATCH xserver 1/3] res: Simplify QueryClientPixmapBytes

2016-02-03 Thread Adam Jackson
On Wed, 2016-02-03 at 21:34 +1100, Keith Packard wrote: > Adam Jackson writes: > > > I suspect this code predates the common resource hooks for computing > > sizes.  It's ugly in any case since the Resource extension shouldn't > > need to know which extensio

Re: [PATCH kdrive/ephyr v7 3/9] kdrive: introduce input hot-plugging support for udev and hal backends (#33140)

2016-02-08 Thread Adam Jackson
On Fri, 2015-12-11 at 11:43 -0200, Laércio de Sousa wrote: > +void > +systemd_logind_release_fd(int _major, int _minor, int fd) > +{ > +} > + > +void > +systemd_logind_vtenter(void) > +{ > +} This introduces a warning: kdrive.c:1217:1: warning: no previous prototype for 'systemd_logind_release_f

Re: [PATCH kdrive/ephyr v7 4/9] kdrive: update evdev keyboard LEDs (#22302)

2016-02-08 Thread Adam Jackson
On Fri, 2015-12-11 at 11:43 -0200, Laércio de Sousa wrote: > From: Mikhail Krivtsov > > When one hits {Num,Caps,Scroll}Lock key on a Xephyr's keyboard, > keyboard itself works as expected but LEDs are not updated > and always stay in off. > > Currently logical LEDs are propagated to physical key

Re: [PATCH kdrive/ephyr v7 5/9] kdrive: add options to set default XKB properties

2016-02-08 Thread Adam Jackson
On Fri, 2015-12-11 at 11:43 -0200, Laércio de Sousa wrote: > This patch introduces convenient command-line options -xkbrules, > -xkbmodel, -xkblayout, -xkbvariant, and -xkboptions, to set default > values for these properties. > > These options can be handful in cases where corresponding values ca

Re: [PATCH kdrive/ephyr v7 0/9] Xephyr input hot-plugging support and other additions for single-GPU multi-seat

2016-02-08 Thread Adam Jackson
On Fri, 2015-12-11 at 11:43 -0200, Laércio de Sousa wrote: > This is the v7 of patch series which provides some missing parts > for full single-GPU multi-seat support in Xephyr. The main difference > to v6 is that now ephyr input driver for kdrive won't be loaded > in multi-seat mode, i.e. if -sea

Re: [PATCH rendercheck 3/5] Use ELF sections to make test setup easier.

2016-02-08 Thread Adam Jackson
want to move their test logic into > their test files. Bit of an understatement, it only converts two of fourteen tests. Series looks good though: Reviewed-by: Adam Jackson - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http:

Re: [PATCH xserver 2/4] dri2: Split resource tracking for DRI2Drawable and references to them

2016-02-08 Thread Adam Jackson
On Wed, 2016-02-03 at 09:54 +, Chris Wilson wrote: > @@ -203,6 +203,11 @@ DRI2AllocateDrawable(DrawablePtr pDraw) >  if (pPriv == NULL) >  return NULL; >   > +if (!AddResource(pDraw->id, dri2DrawableRes, pPriv)) { > +free(pPriv); > +return NULL; > +} > + >  

Re: [PATCH xserver 1/4] dri2: Only invalidate the immediate Window upon SetWindowPixmap

2016-02-08 Thread Adam Jackson
On Wed, 2016-02-03 at 15:36 +0200, Ville Syrjälä wrote: > On Wed, Feb 03, 2016 at 09:54:43AM +, Chris Wilson wrote: > > All callers of SetWindowPixmap will themselves be traversing the Window > > heirachy updating the backing Pixmap of each child and so we can forgo > > doing the identical trav

Re: [PATCH] xwayland: Clear pending cursor frame callbacks on pointer enter

2016-02-08 Thread Adam Jackson
On Fri, 2016-02-05 at 07:54 +0800, Jonas Ådahl wrote: > > On Feb 5, 2016 12:53 AM, "Rui Matos" wrote: > > > > The last cursor frame we commited before the pointer left one of our > > surfaces might not have been shown. In that case we'll have a cursor > > surface frame callback pending which we n

Re: [PATCH] Fix XineramaQueryScreens for reverse prime

2016-02-08 Thread Adam Jackson
On Mon, 2016-02-08 at 14:17 +1000, Dave Airlie wrote: > On 4 February 2016 at 23:06, Jan Burgmeier > wrote: > > Bugzilla: https://bugs.freedesktop.org/92313 > > Reviewed-by: Dave Airlie > > though it might be nice to have some more info from the bug in the > commit message. Pushed with a sligh

[PATCH xserver] os: unifdef STREAMSCONN

2016-02-08 Thread Adam Jackson
Removed from xtrans in 2012, and never wired up in the modular build anyway. Signed-off-by: Adam Jackson --- os/access.c | 17 - os/connection.c | 4 ++-- os/utils.c | 4 ++-- os/xdmauth.c| 2 +- os/xdmcp.c | 44

Re: [PATCH xserver] autogen: Set a default subject prefix for patches

2016-02-08 Thread Adam Jackson
On Mon, 2016-01-18 at 13:09 -0800, Eric Anholt wrote: > This doesn't work unless you have NOCONFIGURE set, because of "exec". > If you move it up above that block, it's: > > Reviewed-by: Eric Anholt Done: To ssh://git.freedesktop.org/git/xorg/xserver    7bb64d8..a722d61  master -> master - aj

Re: [PATCH xserver 4/4] dri2: Unblock Clients on Drawable release

2016-02-08 Thread Adam Jackson
On Wed, 2016-02-03 at 16:02 +0200, Ville Syrjälä wrote: > On Wed, Feb 03, 2016 at 09:54:46AM +, Chris Wilson wrote: > > If the Window is destroyed by another client, such as the window > > manager, the original client may be blocked by DRI2 awaiting a vblank > > event. When this happens, DRI2Dr

Re: [PATCH xserver 2/2] dri3: Refuse to work for remote clients (v2)

2016-02-09 Thread Adam Jackson
On Tue, 2016-02-09 at 13:08 +0100, poma wrote: > Why wait so long, why this could not get in xserver 1.18.1? I do my best to merge patches as they get reviewed, but I don't claim to be perfect. If you're giving an r-b and you think it's good enough to be merged, please cc me. - ajax

[PATCH xserver] dri2: Use the work queue to manage client sleeps

2016-02-10 Thread Adam Jackson
torn down state that AttendClient wants to modify. Using ClientSleep instead of IgnoreClient puts a wakeup function on a workqueue, and the queue will be cleared for us in CloseDownClient before (non-neverretain) resource teardown. Cc: Chris Wilson Cc: Ville Syrjälä Signed-off-by: Adam Jackson

Re: [PATCH v2] Add hybrid full-size/empty-clip mode to SetRootClip

2016-02-22 Thread Adam Jackson
> This patch introduces a hybrid mode, where we update winSize and > borderSize for the root window, enabling sprite confinement to work > correctly, but keep the clip emptied so exposures are never generated. > > Signed-off-by: Daniel Stone > Tested-by: Olivier Fourdan > Cc

Re: [PATCH kdrive/evdev] kdrive/evdev: update keyboard LEDs (#22302)

2016-02-22 Thread Adam Jackson
On Mon, 2016-02-15 at 11:32 -0200, Laércio de Sousa wrote: > Implement missing parts in kdrive evdev driver for > correct update of evdev keyboard LEDs. Hah! I like how this was there and just not wired up. > +if (!ke) { > +ErrorF("Can't update LEDs of disabled evdev keyboard %s.\n",

Re: [PATCH] dri2: add virtio-gpu pci ids

2016-02-22 Thread Adam Jackson
On Tue, 2016-02-16 at 10:41 +1000, Dave Airlie wrote: > On 13 February 2016 at 07:52, Marc-André Lureau > wrote: > > Add virtio-gpu legacy + 1.0 pci ids, allowing them to use > > modesetting + glamor with dri2. > > Reviewed-by: Dave Airlie remote: I: patch #73717 updated using rev 5627708e5f44

Re: [PATCH xserver 1/2] xwayland: Prefix shm tmp file names with xwayland

2016-02-22 Thread Adam Jackson
On Fri, 2016-02-19 at 15:08 +0800, Jonas Ådahl wrote: > Prefix the temporary file names used for allocating pixmaps with > "xwayland-" instead of "weston-". This makes it less confusing while > looking at the file names of the currently open fds of the Xwayland > process. > > Signed-off-by: Jonas

Re: [PATCHv2] modesetting: Add common widescreen resolutions

2016-02-22 Thread Adam Jackson
On Mon, 2016-02-22 at 11:41 -0500, Alex Deucher wrote: > On Sun, Feb 21, 2016 at 6:12 AM, Adel Gadllah wrote: > > Stolen from the intel ddx driver, see: > > https://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=26fd6bec > > https://bugs.freedesktop.org/show_bug.cgi?id=37858 > > > >

Re: [PATCH xserver] Fix build on Cygwin by ensuring WIN32 check triggers only on MinGW

2016-02-22 Thread Adam Jackson
On Mon, 2016-02-22 at 16:20 +, Jon Turney wrote: > The type of fd_mask was changed in Cygwin 2.4.0 headers from 'long' to > 'unsigned > long'.  This exposes an existing problem with winauth.c, which includes > Xwindows.h (which includes windows.h, which defines WIN32), before including > osdep

Re: [PATCH v2] kdrive/evdev: update keyboard LEDs (#22302)

2016-02-22 Thread Adam Jackson
On Mon, 2016-02-22 at 16:04 -0300, Laércio de Sousa wrote: > @@ -442,10 +442,13 @@ EvdevKbdEnable(KdKeyboardInfo * ki) >  static void >  EvdevKbdLeds(KdKeyboardInfo * ki, int leds) >  { > -/*struct input_event event; > +struct input_event event; >  Kevdev *ke; >   > -ki

Re: [PATCH xserver 3/3] present: Only requeue if target MSC is not reached after an unflip

2016-02-25 Thread Adam Jackson
On Thu, 2016-02-25 at 09:49 +, Chris Wilson wrote: > On Wed, Feb 24, 2016 at 04:52:59PM +0900, Michel Dänzer wrote: > > From: Michel Dänzer > > > > While present_pixmap decrements target_msc by 1 for present_queue_vblank, > > it leaves the original vblank->target_msc intact. So incrementing t

Re: [PATCH kdrive/ephyr v2] kdrive/ephyr: map host X server's keymap into Xephyr, if supported

2016-02-25 Thread Adam Jackson
On Thu, 2016-02-25 at 07:10 -0300, Laércio de Sousa wrote: > diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr/ephyr.c > index a272882..fa76765 100644 > --- a/hw/kdrive/ephyr/ephyr.c > +++ b/hw/kdrive/ephyr/ephyr.c > @@ -47,7 +47,6 @@ extern Bool ephyr_glamor; >   >  KdKeyboardInfo *ephyrKbd;

Re: [PULL] hw/xwin patches

2016-02-29 Thread Adam Jackson
On Mon, 2016-02-29 at 14:17 +, Jon Turney wrote: > The following changes since commit b4ac7b142fa3c536e9b283cfd34b94d82c03aac6: > >   present: Only requeue if target MSC is not reached after an unflip > (2016-02-25 10:18:04 -0500) > > are available in the git repository at: > >   git://peop

Re: [PATCH xserver 2/2] dri2: Allow many blocked clients per-drawable

2016-02-29 Thread Adam Jackson
On Fri, 2016-02-12 at 11:59 +, Chris Wilson wrote: > This patch was motivated by the need to fix the use-after-free in > dri2ClientWake, but in doing so removes an arbitrary restriction that > limits DRI2 to only blocking the first client on each drawable. In order > to fix the use-after-free,

Re: [PATCH xserver v2] xwayland: add glamor Xv adaptor

2016-02-29 Thread Adam Jackson
On Mon, 2016-02-22 at 08:26 +0100, Olivier Fourdan wrote: > +#define ENCODER_WIDTH  8192 > +#define ENCODER_HEIGHT 8192 Uh oh... > +pe->width = ENCODER_WIDTH; > +pe->height = ENCODER_HEIGHT; Boo. Should set this to glGetInteger(GL_MAX_TEXTURE_SIZE) I think? - ajax _

Re: [PATCH 00/12] Add vidmod extension to xwayland

2016-02-29 Thread Adam Jackson
On Tue, 2016-02-16 at 02:44 -0500, Olivier Fourdan wrote: > Hi all, > > Small reminder, anyone to do a review of the series? Looks good to me, might as well land this and see if any issues arise. remote: I: patch #72703 updated using rev 341f3bccafde71754a9ed2303df9908e509c6d31. remote: I: patc

Re: [PULL] Reviewed DRI3 & Present patches

2016-03-01 Thread Adam Jackson
On Tue, 2016-03-01 at 12:45 +0900, Michel Dänzer wrote: > Hi Keith / Adam, > > > the following changes since commit 6070a749d953951bacbfb149c5c36451293aad35: > >   xwayland: add partial xvidmode extension support (2016-02-29 16:29:17 -0500) > > are available in the git repository at: > >   git

Re: [PATCH] xwayland: fix a crash on output removal

2016-03-01 Thread Adam Jackson
On Tue, 2016-03-01 at 03:20 -0500, Olivier Fourdan wrote: > Hi Adam, Keith, > > I think we'll need this patch in both branches master and 1.18 to fix > a segfault in Xwayland on output removal (that one is completely my > fault). > > Was discussed with Daniel who suggested the fix on irc some tim

Re: [PATCH kdrive/ephyr v8 0/4] Xephyr input hot-plugging support and other additions for single-GPU multi-seat

2016-03-01 Thread Adam Jackson
rences to v7 are the following: > > * Some fixes and clean-ups in patch that introduces hot-plugging feature, >   following discussions with Adam Jackson, Peter Hutterer, >   and Emil Velikov. > >   - During tests, I realized that some issues regarding input > hot-plugging

Re: [PATCH kdrive/ephyr v3] kdrive/ephyr: map host X server's keymap into Xephyr, if supported

2016-03-01 Thread Adam Jackson
On Thu, 2016-02-25 at 16:37 -0300, Laércio de Sousa wrote: > Currently Xephyr doesn't inherit host X server's keymap, which > may lead to keymap mismatches when using a non-US keyboard in a > window inside Xephyr. This patch makes Xephyr change its keymap > to match host X server's one (unless XKB

Re: [PATCH] vidmode: build without xf86vidmodeproto

2016-03-01 Thread Adam Jackson
On Tue, 2016-03-01 at 17:03 +0100, Olivier Fourdan wrote: > git commit f175cf45: > >   vidmode: move to a separate library of its own > > introduced a regression where the xserver would not build when > xf86vidmodeproto is not installed even if the configure option > "--disable-xf86vidmode" is sp

[PATCH xserver 1/5] xv: Fix unchecked AddResource

2016-03-01 Thread Adam Jackson
Signed-off-by: Adam Jackson --- Xext/xvmain.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Xext/xvmain.c b/Xext/xvmain.c index 0c6f25b..3a02634 100644 --- a/Xext/xvmain.c +++ b/Xext/xvmain.c @@ -844,7 +844,8 @@ XvdiSelectVideoNotify(ClientPtr client, DrawablePtr

[PATCH xserver 2/5] dri1: Fix unchecked AddResource

2016-03-01 Thread Adam Jackson
Signed-off-by: Adam Jackson --- hw/xfree86/dri/dri.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/xfree86/dri/dri.c b/hw/xfree86/dri/dri.c index 875c9cc..0046e52 100644 --- a/hw/xfree86/dri/dri.c +++ b/hw/xfree86/dri/dri.c @@ -1032,7 +1032,8 @@ DRICreateContext

Re: [PATCH] xv: fix double free in AddResource failure case

2016-03-02 Thread Adam Jackson
On Tue, 2016-03-01 at 21:39 +0100, Julien Cristau wrote: > XvdiDestroyVideoNotifyList already frees the list if AddResource fails, > so don't do it twice.  And set tpn->client to NULL explicitly to avoid > confusing uninitialized memory with a valid value. remote: I: patch #75511 updated using rev

Re: [PATCH xserver 2/5] dri1: Fix unchecked AddResource

2016-03-02 Thread Adam Jackson
On Tue, 2016-03-01 at 21:30 +0100, Julien Cristau wrote: > On Tue, Mar  1, 2016 at 14:09:30 -0500, Adam Jackson wrote: > > > Signed-off-by: Adam Jackson > > --- > >  hw/xfree86/dri/dri.c | 8 +--- > >  1 file changed, 5 insertions(+), 3 deletions(-) > >

Re: [PATCH xserver] xwayland: Correctly detect whether posix_fallocate exists

2016-03-08 Thread Adam Jackson
On Tue, 2016-03-08 at 14:15 +0100, Julien Cristau wrote: > On Tue, Mar  8, 2016 at 20:05:33 +0800, Jonas Ådahl wrote: > > > We had HAVE_POSIX_FALLOCATE checks, but no such macros were ever > > defined anywhere. This commit makes it so that this macro is defined if > > the posix_fallocate is detect

Re: [PATCH xserver 0/9] double frees in AddResource failure paths

2016-03-08 Thread Adam Jackson
On Tue, 2016-03-08 at 00:30 +0100, Rémi Cardona wrote: > Le 07/03/2016 23:20, Julien Cristau a écrit : > > Hi, > > > > prompted by Adam's recent fixes for unchecked AddResource, I've been > > looking at the failure paths, and found a number of places where it > > looks like we're freeing things tw

Re: [PATCH xserver] build: Enable vidmode independently from Xorg

2016-03-08 Thread Adam Jackson
On Fri, 2016-03-04 at 16:24 +0100, Rui Matos wrote: > This allows building Xwayland without Xorg and still include the > vidmode extension. > > v2: Use PKG_CHECK_EXISTS instead of PKG_CHECK_MODULES remote: I: patch #75875 updated using rev 40a164b8f4e720b0d6ebf228ee175eb397ffeec2. remote: I: 1 p

Re: [PATCH] modesetting: add support for background none.

2016-03-08 Thread Adam Jackson
On Wed, 2016-02-10 at 15:45 +1000, Dave Airlie wrote: > From: Dave Airlie > > This adds support using glamor for background None. > > loosely based off the amdgpu code. relies on the > glamor_finish code. > > Signed-off-by: Dave Airlie NAK: > +void > +drmmode_copy_fb(ScrnInfoPtr pScrn, drmm

Re: [PATCH] glamor: Fix XvPutImage when src_y != 0

2016-03-08 Thread Adam Jackson
On Wed, 2016-02-10 at 16:40 +0100, Hans de Goede wrote: > We already take src_y into account when uploading the src data by > starting at the top line of the src data when uploading. > > Adjust src_y accordingly when rendering. > > Signed-off-by: Hans de Goede remote: I: patch #73155 updated us

Re: [PATCH xserver 2/2] glamor: Source pictures are always depth 32

2016-03-08 Thread Adam Jackson
On Tue, 2016-02-23 at 17:19 +0900, Michel Dänzer wrote: > From: Michel Dänzer > > We were using the destination pixmap depth to determine the source > picture format. > > Fixes incorrect text rendering with some MATE desktop GTK3 themes. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?i

Re: [PULL] Reviewed cursor changes

2016-03-09 Thread Adam Jackson
On Wed, 2016-03-09 at 16:51 +0900, Michel Dänzer wrote: > Hi Keith / Adam, > > > the following changes since commit a3e681eafa5355b8bb3b099d47983f14f0d5e197: > >   glamor: Source pictures are always depth 32 (2016-03-08 15:17:19 -0500) > > are available in the git repository at: > >   git://pe

[PATCH] xv: Build left-shift constants from ints not longs

2016-03-09 Thread Adam Jackson
ask;; ^ Signed-off-by: Adam Jackson --- Xv.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Xv.h b/Xv.h index ef3f786..f662df6 100644 --- a/Xv.h +++ b/Xv.h @@ -59,8 +59,8 @@ typedef XID XvEncodingID; #define XvInput 0 #define XvOut

Re: [PATCH xserver v3] xwayland: add glamor Xv adaptor

2016-03-09 Thread Adam Jackson
On Tue, 2016-03-08 at 10:15 -0500, Olivier Fourdan wrote: > Hi Adam, > > I had posted a revisited version using GL_MAX_TEXTURE_SIZE to > determine the encoder size as per your review last week, is there > anything else that needs rework? This adds a warning, but I don't think that's your fault:

Re: [PATCH] Add Compose sequence for U+1F4A9.

2016-03-09 Thread Adam Jackson
On Wed, 2016-03-09 at 14:35 +0100, Daniel Albers wrote: > Signed-off-by: Daniel Albers Merged, thanks: remote: I: patch #76361 updated using rev e1011b9e2f6c82255959cf3cc1d8cda402ded0a9. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/lib/libX11    6d7bb0

Re: [PULL] hw/xwin cleanup patches

2016-03-09 Thread Adam Jackson
On Wed, 2016-03-09 at 16:31 +, Jon Turney wrote: > The following changes since commit 24042b4e367803dd64f3fcdc1bef7b2bf36c4145: > >   modesetting: Allow CRTC transforms to actually take effect (2016-03-09 > 16:46:13 +0900) > > are available in the git repository at: > >   git://people.freed

Re: [PATCH xserver] glamor: do not build Xv support when --disable-xv

2016-03-09 Thread Adam Jackson
On Wed, 2016-03-09 at 16:45 +0100, Olivier Fourdan wrote: > Signed-off-by: Olivier Fourdan Merged this and the xwayland xv support: remote: E: failed to find patch for rev da7724d3d277c6c8a814881785b716896802629a. remote: I: patch #76376 updated using rev 25ce263fd88684be9370025f93ba3a2bfc72ff

Re: [PATCH] xv: Build left-shift constants from ints not longs

2016-03-09 Thread Adam Jackson
On Wed, 2016-03-09 at 10:59 -0500, Olivier Fourdan wrote: > Reviewed-by: Olivier Fourdan remote: I: patch #76365 updated using rev 723881f31d65353e80660e6d8cd9785e6ec1b430. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/proto/videoproto    3841508..72388

Re: [PATCH xserver 00/12] glamor_picture.c total rewrite

2016-03-10 Thread Adam Jackson
On Mon, 2016-02-01 at 13:58 -0800, Eric Anholt wrote: > I started incrementally cleaning up glamor_picture.c after being > surprised by its behavior during the last series, and ended up with a > total rewrite.  There will be some small losses in acceleration paths > for GLES2, but since GLES2 hasn'

[PATCH xserver 2/4] glx: Add GLX_SCREEN to the GetDrawableAttributes response

2016-03-10 Thread Adam Jackson
libglvnd would like to use this to map from drawable to screen, so it can know which driver to dispatch to. Refer to the spec proposal here: https://lists.freedesktop.org/archives/mesa-dev/2016-March/109543.html Signed-off-by: Adam Jackson --- glx/glxcmds.c | 3 ++- 1 file changed, 2

[PATCH xserver 3/4] glx: Implement GLX_EXT_stereo_tree

2016-03-10 Thread Adam Jackson
This is correct as it is, but only because we know no DRI drivers implement stereo. v2: Use new ATTRIB macro Reviewed-by: James Jones Signed-off-by: Adam Jackson --- glx/extension_string.c | 1 + glx/extension_string.h | 1 + glx/glxcmds.c | 10 +- 3 files changed, 11

[PATCH xserver 1/4] glx: Macroize building the attribute list in DoGetDrawableAttributes

2016-03-10 Thread Adam Jackson
No functional change, just a little easier to read and harder to get wrong. Signed-off-by: Adam Jackson --- glx/glxcmds.c | 38 +++--- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 6eb3541..65d0739 100644

[PATCH xserver 4/4] glx: Implement GLX_EXT_fbconfig_packed_float

2016-03-10 Thread Adam Jackson
The tokens for this are already defined by GLX_ARB_fbconfig_float, which we already support, so just add the extension to the list and let the driver provide those configs if it wants. Signed-off-by: Adam Jackson --- glx/extension_string.c | 1 + glx/extension_string.h | 1 + glx/glxdri2.c

Re: [PATCH xserver 1/4] glx: Macroize building the attribute list in DoGetDrawableAttributes

2016-03-10 Thread Adam Jackson
On Thu, 2016-03-10 at 11:45 -0800, Eric Anholt wrote: > > I think some compilers/static checkers will whine unless this is a do { > ... } while (0) macro, becauuse of the "stray" semicolons we end up with > otherwise.  With that changed, > > Reviewed-by: Eric Anholt Did this (and Julien's #unde

Re: [PATCH xserver] glamor: Make context current in glamor_pixmap_fbo_cache_put

2016-03-11 Thread Adam Jackson
On Fri, 2016-03-11 at 15:48 +1000, Dave Airlie wrote: > On 11 March 2016 at 13:21, Michel Dänzer wrote: > > > > From: Michel Dänzer > > > > Without this, we may be manipulating the context of another screen. > > > > In a system with two GPUs using glamor, this fixes lots of > > > > (EE) glamo

Re: [PATCH 1/2] present: fail flipping if we have any slave outputs.

2016-03-11 Thread Adam Jackson
On Thu, 2016-03-03 at 14:25 -0800, Keith Packard wrote: > Dave Airlie writes: > > > > > Due to the way present currently works, we don't ever > > check with the secondary adapters if we can flip at all. > > > > We shouldn't flip if the secondary adapters are attached > > to the pixmap currently

[ANNOUNCE] xorg-server 1.18.2

2016-03-11 Thread Adam Jackson
a few new keyboard layouts Full change list below. Many thanks to all for fixes and code review. --- Adam Jackson (11):   xfree86: Build parser for DRI config file subsection unconditionally   autogen: Set a default subject prefix for patches   dri2: Use the work queue to manage

Re: [PATCH:xf86-video-s3] When checking malloc for success, it helps to use == NULL, instead of =

2016-03-14 Thread Adam Jackson
On Sat, 2016-03-12 at 11:02 -0800, Alan Coopersmith wrote: > Fixes gcc 5.3 compiler warning: > s3_bios.c: In function 'find_bios_string': > s3_bios.c:49:2: warning: suggest parentheses around assignment used as > truth value [-Wparentheses] >   if (bios = NULL) > ^ > > [Tested by compiling

Re: [PATCH:makedepend] Use do { ... } while(0) idiom to make debug() macro safer

2016-03-14 Thread Adam Jackson
On Sat, 2016-03-12 at 10:15 -0800, Alan Coopersmith wrote: > Cleans up several -Wempty-body warnings from gcc 5.3 > > Signed-off-by: Alan Coopersmith Reviewed-by: Adam Jackson - ajax ___ xorg-devel@lists.x.org: X.Org development Archi

Re: [PATCH xserver] Xext/vidmode: Reduce verbosity of GetModeLine debug messages

2016-03-14 Thread Adam Jackson
On Mon, 2016-03-14 at 09:15 +0100, Olivier Fourdan wrote: > > @@ -662,11 +662,11 @@ ProcVidModeDeleteModeLine(ClientPtr client) > >   bytes_to_int32(sizeof(xXF86VidModeDeleteModeLineReq)); > >   } > >   if (len != stuff->privsize) { > > -LogMessage(X_INFO, "req_len = %l

Re: [PATCH xserver] Xext/vidmode: Reduce verbosity of GetModeLine debug messages

2016-03-14 Thread Adam Jackson
On Mon, 2016-03-14 at 10:41 -0400, Adam Jackson wrote: > On Mon, 2016-03-14 at 09:15 +0100, Olivier Fourdan wrote: > > > > > > > > > @@ -662,11 +662,11 @@ ProcVidModeDeleteModeLine(ClientPtr client) > > >   bytes_to_int

[PATCH rendercheck 2/4] Be valgrind-clean

2016-03-14 Thread Adam Jackson
Signed-off-by: Adam Jackson --- main.c | 16 +++- t_gtk_argb_xbgr.c| 6 ++ t_libreoffice_xrgb.c | 1 + tests.c | 20 +++- 4 files changed, 37 insertions(+), 6 deletions(-) diff --git a/main.c b/main.c index 4cec99b..0d3d146 100644

[PATCH rendercheck 1/4] triangles: Fix tests for conjoint and disjoint ops

2016-03-14 Thread Adam Jackson
The expected destination color needs to vary by op in the same way as for the base ops. Takes us from 1170 tests passed of 1710 total to 1710/1710 on Xvfb. Signed-off-by: Adam Jackson --- t_triangles.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/t_triangles.c b/t_triangles.c index

[PATCH rendercheck 3/4] Don't fail to find the a8r8g8b8 format pointlessly

2016-03-14 Thread Adam Jackson
Without this, trying to test eg. just r5g6b5 would fail, because we'd ignore anything we didn't whitelist. Signed-off-by: Adam Jackson --- tests.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/tests.c b/tests.c index cca96b4..9c8adaf 100644 ---

[PATCH rendercheck 4/4] Enable a few more formats

2016-03-14 Thread Adam Jackson
On a standard Xvfb configuration, this means a4, and both rgb orders of each of a4r4g4b4 and x4r4g4b4. Signed-off-by: Adam Jackson --- tests.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests.c b/tests.c index 9c8adaf..22cbfd4 100644 --- a/tests.c +++ b/tests.c

Re: [PATCH rendercheck 1/4] triangles: Fix tests for conjoint and disjoint ops

2016-03-14 Thread Adam Jackson
On Mon, 2016-03-14 at 12:24 -0700, Eric Anholt wrote: > Adam Jackson writes: > > > > > The expected destination color needs to vary by op in the same way as > > for the base ops. Takes us from 1170 tests passed of 1710 total to > > 1710/1710 on Xvfb. > These 4 a

Re: [PATCH] glamor: swizzle RED to 0 for alpha textures.

2016-03-18 Thread Adam Jackson
On Wed, 2016-03-16 at 07:46 +0200, Timo Aaltonen wrote: > 16.03.2016, 02:45, Dave Airlie kirjoitti: > > > > From: Dave Airlie > > > > I'm pretty sure Eric suspected this could cause a problem, and > > we couldn't find a test. Well loading feedly in firefox seems > > to trigger badness that this

[PATCH xserver 8/8] glx: Advertise GLX 1.4 unconditionally

2016-03-21 Thread Adam Jackson
Signed-off-by: Adam Jackson --- glx/glxcmds.c| 11 +++ glx/glxdri2.c| 12 glx/glxdriswrast.c | 3 --- glx/glxext.c | 2 -- glx/glxscreens.c | 12 glx/glxscreens.h | 11 --- glx/glxserver.h

[PATCH xserver 1/8] glx: Remove default server glx extension string

2016-03-21 Thread Adam Jackson
This existed only to be strdup'd and then immediately freed. Signed-off-by: Adam Jackson --- glx/glxdri2.c| 2 -- glx/glxdriswrast.c | 2 -- glx/glxscreens.c | 20 +--- hw/xquartz/GL/indirect.c | 2 -- hw/xwin/glx/indirect.c | 2 -- 5

[PATCH xserver 2/8] xwin/glx: Drop GLWIN_NO_WGL_EXTENSIONS hack

2016-03-21 Thread Adam Jackson
This doesn't seem very useful, and we're about to implement 1.4 across the board, so some WGL extensions will become required. Signed-off-by: Adam Jackson --- hw/xwin/glx/indirect.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/xwin/glx/indirect.c b/hw/xwin/glx/

[PATCH xserver 3/8] {xwin, xquartz}/glx: Always enable GLX_{ARB, SGIS}_multisample

2016-03-21 Thread Adam Jackson
This is enabled unconditionally in the GLX core. For xwin, if the backend doesn't support WGL_ARB_multisample, there will simply be no fbconfigs that support it. Signed-off-by: Adam Jackson --- hw/xquartz/GL/indirect.c | 3 --- hw/xwin/glx/indirect.c | 24 ++-- 2

[PATCH xserver 0/8] Advertise GLX 1.4 for all DDXes

2016-03-21 Thread Adam Jackson
This is _mostly_ cleanup, but it does have some semantic changes. It seems CGL does not actually have a MakeCurrent call that lets you specify separate read and draw surfaces, so that's never in fact worked, and as a result xquartz technically can't even implement GLX 1.3 (or EGL!). But I suspect z

[PATCH xserver 6/8] xwin/glx: Assume WGL_ARB_make_current_read exists

2016-03-21 Thread Adam Jackson
enable GLX 1.4 unconditionally. Signed-off-by: Adam Jackson --- hw/xwin/glx/indirect.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/hw/xwin/glx/indirect.c b/hw/xwin/glx/indirect.c index 626238f..220ad7e 100644 --- a/hw/xwin/glx/indirect.c ++

[PATCH xserver 4/8] xwin/glx: Always enable GLX_SGIX_pbuffer

2016-03-21 Thread Adam Jackson
usage is pretty rare in any case, the same implementation strategy could be taken for the xwin glx engine too. Signed-off-by: Adam Jackson --- hw/xwin/glx/indirect.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/xwin/glx/indirect.c b/hw/xwin/glx/indirect.c in

[PATCH xserver 5/8] xquartz/glx: Error out for MakeContextCurrent(draw != read)

2016-03-21 Thread Adam Jackson
CGL doesn't have a way to express this directly, unlike EGL WGL and GLX. It might be implementable, but it's never actually worked, and it's a fairly niche feature so we're better off throwing an error if someone attempts it. Signed-off-by: Adam Jackson --- hw/xquartz/GL/i

<    4   5   6   7   8   9   10   11   12   13   >