Re: 答复: [PATCH]new driver for siliconmotion

2012-07-16 Thread Dave Airlie
On Fri, Jul 13, 2012 at 12:48 PM, Matt Turner wrote: > On Wed, Jul 11, 2012 at 7:17 PM, Aaron.Chen 陈俊杰 > wrote: >> Hi Matt, >> >> Thank you for your review. We really appreciate that you've pick out so many >> issues we need to improve. It seems that we still have a lot of work to do >> to mat

Re: pull request: output and offload complete tree

2012-07-18 Thread Dave Airlie
On Tue, Jul 17, 2012 at 10:30 PM, Michal Suchanek wrote: > On 16 July 2012 21:09, Dave Airlie wrote: >> On Mon, Jul 16, 2012 at 11:28 PM, Michal Suchanek wrote: >>> Hello, >>> >>> can this be used to start an X server with dummy driver as output and >

Re: pull request: output and offload complete tree

2012-07-18 Thread Dave Airlie
On Wed, Jul 18, 2012 at 7:49 PM, Dave Airlie wrote: > On Tue, Jul 17, 2012 at 10:30 PM, Michal Suchanek wrote: >> On 16 July 2012 21:09, Dave Airlie wrote: >>> On Mon, Jul 16, 2012 at 11:28 PM, Michal Suchanek >>> wrote: >>>> Hello, >>>> &g

Re: [PATCH 1/3] cw: Remove

2012-07-19 Thread Dave Airlie
On Fri, Jul 20, 2012 at 5:00 AM, Adam Jackson wrote: > XAA was the only consumer. > > Signed-off-by: Adam Jackson Hell yes, Reviewed-by: Dave Airlie ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-d

Re: [PATCH 2/3] xfree86: Drop some dead XAA decls from SDK headers

2012-07-19 Thread Dave Airlie
On Fri, Jul 20, 2012 at 5:00 AM, Adam Jackson wrote: > Signed-off-by: Adam Jackson Required for 1.13 definitely. may need some more driver updates, thuogh. Dave. > --- > hw/xfree86/common/xaarop.h | 43 --- > 1 files changed, 0 insertions(+), 43 dele

[PATCH] libXrandr: add support for provider objects.

2012-07-19 Thread Dave Airlie
From: Dave Airlie This adds the client side libXrandr support for randr 1.4, and provider objects. Signed-off-by: Dave Airlie --- include/X11/extensions/Xrandr.h | 101 src/Makefile.am |4 +- src/Xrandr.c| 65 +++- src/XrrProvider.c

[PATCH] glx: drop GLX_LIBS from X server and workaround sdksyms.

2012-07-24 Thread Dave Airlie
From: Dave Airlie We've had reports of two copies of the GLX bits, one in the server and one in libglx.so causing problems, I didn't understand why the X server needed a copy so drop it, however then we have to fix a missing GlxExtensionInit that comes from sdksyms, so work around it

[PATCH] glx: drop GLX_LIBS from X server and workaround sdksyms.

2012-07-25 Thread Dave Airlie
From: Dave Airlie We've had reports of two copies of the GLX bits, one in the server and one in libglx.so causing problems, I didn't understand why the X server needed a copy so drop it, however then we have to fix a missing GlxExtensionInit that comes from sdksyms, so work around it

[PATCH] randr: fix xinerama output for output slaves

2012-07-25 Thread Dave Airlie
From: Dave Airlie This fixes the xinerama geometry when output slaves are enabled. Tested with xdpyinfo -ext XINERAMA before after slave added. Signed-off-by: Dave Airlie --- randr/rrxinerama.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/randr

[PATCH] randr: add slave support to ProcRRSelectInput

2012-07-25 Thread Dave Airlie
From: Dave Airlie This needed to send events for the slave crtcs/outputs. Pointed out by Keith. Signed-off-by: Dave Airlie --- randr/rrdispatch.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/randr/rrdispatch.c b/randr/rrdispatch.c index 7fbc9f0..820c180 100644 --- a

[PATCH 2/3] dri2: free slave pixmap on app exit

2012-08-03 Thread Dave Airlie
From: Dave Airlie When the drawable disappears we need to free the prime master/slave combos. This fixes a leak after a prime app is run. Signed-off-by: Dave Airlie --- hw/xfree86/dri2/dri2.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2

[PATCH 1/3] pixmap: have slave pixmap take a reference on master pixmap

2012-08-03 Thread Dave Airlie
From: Dave Airlie Since the free routines free the master pixmap then the slave, we should be taking a reference when we bind them together. Fixes a use-after-free when resizing a primed gears. Signed-off-by: Dave Airlie --- dix/pixmap.c | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 3/3] dri2: fix master pixmap free and reset pointer

2012-08-03 Thread Dave Airlie
From: Dave Airlie These are two minor changes, one to reset the pointer to NULL, after freeing the pixmaps, one to make sure we use the right API for the master pixmap, though I doubt it'll ever really matter. Signed-off-by: Dave Airlie --- hw/xfree86/dri2/dri2.c | 3 ++- 1 file chang

pull req - prime pixmap fixes

2012-08-06 Thread Dave Airlie
ac09a4a091a43188241365152e1244fd8fd93ee7: dri2: fix master pixmap free and reset pointer (2012-08-07 08:25:45 +1000) Dave Airlie (3): pixmap: have slave pixmap take a reference on master pixmap dri2: free slave pixmap on app exit dri2: fix

Re: [PATCH 1/3] Only free Render filter names on last screen close

2012-08-12 Thread Dave Airlie
ed, ugly but effective, maybe in the future we can make some sort of notifier systems to hook into for global objects to be freed at certain times, But otherwise, Reviewed-by: Dave Airlie > > Signed-off-by: Keith Packard > --- > render/filter.c |5 - > 1 file changed,

Re: [PATCH 2/3] Close GPU screens before core screens

2012-08-12 Thread Dave Airlie
ad. Reviewed-by: Dave Airlie > > Signed-off-by: Keith Packard > --- > dix/main.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/dix/main.c b/dix/main.c > index 42f517d..fb935c9 100644 > --- a/dix/main.c > +++ b/dix/mai

Re: [PATCH 3/3] Kludge -- Call RandR screen before cleaning up xf86 crtcs

2012-08-14 Thread Dave Airlie
NULL at that point, bad things happen. > > This patch "knows" that the core RandR close screen is underneath the > xf86 randr close screen function, and so makes sure it gets called > first. Yeah its pretty kludgey but probably the best solution for now. Reviewed-by: Dave

[PATCH] xf86/crtc: don't free config->name

2012-08-23 Thread Dave Airlie
From: Dave Airlie This is set by pre_init not screen init, so if we free it here and then recycle the server, we lose all the providers. I think we need to wrap FreeScreen here to do this properly, will investigate for 1.14 most likely, safer to just leak this on server exit for now. Signed

[PATCH] dix: free default colormap before screen deletion

2012-08-23 Thread Dave Airlie
From: Dave Airlie If we don't free this here, it gets freed later in the resource cleanups, however it then looks up up pmap->pScreen, which we freed already in this function. So free the default colormap when we should. This fixes a bug after a couple of hotplug cycles when you try to

Re: [PATCH] intel_display.c: make acpi_video last in backlight_interfaces

2012-08-26 Thread Dave Airlie
On Sun, Aug 26, 2012 at 9:43 PM, Alon Levy wrote: > ACPI is meant as a fallback, so it should be last. eh no, acpi is never the fallback, its always the preferred way. Dave. > > This allows my Lenovo T510 to reach the minimal backlight (switched > off), by using intel_backlight instead of acpi.

[PATCH 1/3] config/udev: add wrapper around check if server is not seat 0

2012-08-26 Thread Dave Airlie
From: Dave Airlie this is a simple clean-up that is useful to stop further propogation of this construct. Signed-off-by: Dave Airlie --- config/udev.c |4 ++-- include/hotplug.h |2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/config/udev.c b/config/udev.c

[PATCH 2/3] config/udev: respect seat for hotplugged video devices.

2012-08-26 Thread Dave Airlie
From: Dave Airlie This respects the seat tag for hotplugged video devices at X start. Signed-off-by: Dave Airlie --- config/udev.c |4 1 file changed, 4 insertions(+) diff --git a/config/udev.c b/config/udev.c index adac273..89b6e57 100644 --- a/config/udev.c +++ b/config/udev.c

[PATCH 3/3] xf86: fix multi-seat video device support.

2012-08-26 Thread Dave Airlie
From: Dave Airlie If we are not seat 0 the following apply: don't probe any bus other than platform don't probe any drivers other than platform assume the first platform device we match on the bus is the primary GPU. This just adds checks in the correct places to ensure this, and w

Re: [PATCH] tests: move GCC diagnostics pragma outside of function

2012-08-28 Thread Dave Airlie
On Wed, Aug 29, 2012 at 9:11 AM, Peter Hutterer wrote: > This is a a gcc 4.6+ feature. > > signal-logging.c:210: error: #pragma GCC diagnostic not allowed inside > functions > > Signed-off-by: Peter Hutterer Required for tinderbox and EL6 builds. Reviewed-by: Dave Airlie

Re: [PATCH] int10: fix pci_device_read_rom usage

2012-08-29 Thread Dave Airlie
turn value of > pci_device_read_rom() and of the supplied BIOS size. > > Debian bug#686153 > > Signed-off-by: Julien Cristau Reviewed-by: Dave Airlie > --- > hw/xfree86/int10/generic.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a

pull req (review req in disguise)

2012-09-02 Thread Dave Airlie
ssh://people.freedesktop.org/~airlied/xserver for-keithp for you to fetch changes up to 055c02e66a5702259db2988828ad78c7954a596e: xf86: fix multi-seat video device support. (2012-09-03 13:37:07 +1000) Dave Airlie (5): xf86/crtc: don't f

[PATCH] xf86: call enter/leave VT for gpu screens as well

2012-09-02 Thread Dave Airlie
From: Dave Airlie Otherwise we can't do fast user switch properly for multiple GPUs. Signed-off-by: Dave Airlie --- hw/xfree86/common/xf86Events.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/xfree86/common/xf86Events.c b/hw/xfree86/common/xf86Events.c index 47

[pull req] updated fixes from me

2012-09-03 Thread Dave Airlie
itory at: git://people.freedesktop.org/~airlied/xserver for-keithp for you to fetch changes up to 0db936a5b7125d9b73633733cb34e5e4b72f01e8: xf86: call enter/leave VT for gpu screens as well (2012-09-04 16:16:17 +1000) Dave Airl

Re: pull req (review req in disguise)

2012-09-03 Thread Dave Airlie
>> config/udev: add wrapper around check if server is not seat 0 > > Make this look like a function call please. Otherwise, it looks like > it's just referencing a global variable. done in the new updated pull I just sent. > >> xf86: fix multi-seat video device support. > > This looks

[PATCH] dri2: invalidate drawable after sharing pixmap

2012-09-05 Thread Dave Airlie
From: Dave Airlie After we share the pixmap, the backing storage may have changed, and we need to invalidate and buffers pointing at it. This fixes GL compositors and prime windows lacking contents initially. Signed-off-by: Dave Airlie --- hw/xfree86/dri2/dri2.c | 74

Re: [PATCH 27/29] dri2: add initial prime support. (v1.2)

2012-09-06 Thread Dave Airlie
On Thu, Sep 6, 2012 at 10:21 PM, Chris Wilson wrote: > On Thu, 06 Sep 2012 13:17:50 +0100, Chris Wilson > wrote: >> On Thu, 5 Jul 2012 21:30:34 +0100, Dave Airlie wrote: >> > +static void dri2_copy_region(DrawablePtr pDraw, RegionPtr pRegion, >> > +

Re: [PATCH:randrproto 06/12] spec: correct sub-code values for RRProvider*Notify event encoding

2012-09-06 Thread Dave Airlie
On Sat, Sep 1, 2012 at 3:28 PM, Alan Coopersmith wrote: > These values match the RRNotify_* definitions in randrproto.h and > don't overlap with the RROutput*Notify codes from RandR 1.2. > > Signed-off-by: Alan Coopersmith Reviewe

[PATCH] xf86: return NULL for compat output if no outputs.

2012-09-09 Thread Dave Airlie
From: Dave Airlie With outputless GPUs showing up we crash here if there are not outputs try and recover with a bit of grace. Signed-off-by: Dave Airlie --- hw/xfree86/modes/xf86Crtc.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/xfree86/modes/xf86Crtc.c b/hw/xfree86/modes

[PATCH] xf86/platform: scan pci after probing devices

2012-09-09 Thread Dave Airlie
From: Dave Airlie This solves a race if we are trying to dynamically power off secondary GPUs. Its not the greatest fix ever but it probably as good as we can do for now. The GPU probing causes the devices to be powered up, then when we scan the PCI bus we get the correct information from the

[PATCH] reference patch: autobind GPUs to the screen,

2012-09-11 Thread Dave Airlie
From: Dave Airlie This isn't for merging, ideally now that randr exposes providers, the desktop environments would start to add support for them, so when they appear they DE would bind/unbind them etc. However until that glorious future arrives I've written an autoconfigure patch. I&

[PATCH] config/udev: ignore change on drm devices

2012-09-13 Thread Dave Airlie
-by: Dave Airlie --- config/udev.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/config/udev.c b/config/udev.c index 03aca28..2adb613 100644 --- a/config/udev.c +++ b/config/udev.c @@ -300,9 +300,15 @@ wakeup_handler(pointer data, int err, pointer read_mask

Re: [PATCH] xf86: return NULL for compat output if no outputs.

2012-09-16 Thread Dave Airlie
On Mon, Sep 10, 2012 at 5:11 PM, Chris Wilson wrote: > On Mon, 10 Sep 2012 11:30:01 +1000, Dave Airlie wrote: >> From: Dave Airlie >> >> With outputless GPUs showing up we crash here if there are not outputs >> try and recover with a bit of grace. > > With this

more mostly unreviewed fixes

2012-09-16 Thread Dave Airlie
) Dave Airlie (5): dri2: invalidate drawable after sharing pixmap xf86: return NULL for compat output if no outputs. xf86/platform: scan pci after probing devices config/udev: ignore change on drm devices xf86: fix multi-seat video device support. config

Re: [PATCH] xf86: return NULL for compat output if no outputs.

2012-09-17 Thread Dave Airlie
On Mon, Sep 17, 2012 at 4:47 PM, Chris Wilson wrote: > On Mon, 17 Sep 2012 09:48:13 +1000, Dave Airlie wrote: >> On Mon, Sep 10, 2012 at 5:11 PM, Chris Wilson >> wrote: >> > On Mon, 10 Sep 2012 11:30:01 +1000, Dave Airlie wrote: >> >> From: Dave Airl

pull request : fedora fixes.

2012-09-18 Thread Dave Airlie
://people.freedesktop.org/~airlied/xserver for-keithp for you to fetch changes up to f991ec4f2a903986bdfa99bce23098e2d2b0a886: xf86: fix compat output selection for no output GPUs (2012-09-19 10:56:50 +1000) Dave Airlie (3

Re: more mostly unreviewed fixes

2012-09-18 Thread Dave Airlie
On Mon, Sep 17, 2012 at 1:47 PM, Keith Packard wrote: > Dave Airlie writes: > >> dri2: invalidate drawable after sharing pixmap > > Merged. >f0bad69..22746df master -> master > >> xf86: return NULL for compat output if no outputs. > > I d

Re: pull request : fedora fixes.

2012-09-18 Thread Dave Airlie
8:50 +1000) ---- Dave Airlie (3): xf86/platform: scan pci after probing devices config/udev: ignore change on drm devices xf86: fix multi-seat video device support. (v2) Keith Packard (1): xf86: fix compat output selection for no output GPUs config/udev.c

git pull - ickle dri patch

2012-09-19 Thread Dave Airlie
This patch has gone around long enough and seem to not make it. Dave. The following changes since commit 70e5766874a919039678bb2ed75f2ccea0cb4345: xf86: fix multi-seat video device support. (v2) (2012-09-19 15:48:50 +1000) are available in the git repository at: ssh://people.freedesktop.or

brokenness of dri1

2012-09-25 Thread Dave Airlie
In a further effort to show how little testing outside developers we get, I tried to check dri1 :-) Its been broken in a subtlle manner thanks to Keith at faeebead7bfcc78535757ca7acc1faf7554c03b7 which was back in the 1.8 days. It was then noticeably broken by Daniel in 459c6da0f907ba33d733c7e62a

Re: brokenness of dri1

2012-09-25 Thread Dave Airlie
On Wed, Sep 26, 2012 at 3:43 PM, Dave Airlie wrote: > In a further effort to show how little testing outside developers we > get, I tried to check dri1 :-) > > Its been broken in a subtlle manner thanks to Keith at > faeebead7bfcc78535757ca7acc1faf7554c03b7 which was back in

[PATCH] dri1: fix dri1 startup since 459c6da0f907ba33d733c7e62a116184ba2f14e5

2012-09-25 Thread Dave Airlie
From: Dave Airlie This commit regresses dri1 since it moves the drmSetServerInfo from being called at module load time to extension init time. However DRIScreenInit relies on this being called before it gets control. This patches moves the call into DRIScreenInit and seems to work here. Signed

Re: [PATCH 0/3] Implement randr 1.4 events.

2013-10-07 Thread Dave Airlie
tput or crtc get > changed in output provider screen. Seem fine to me, Reviewed-by: Dave Airlie Dave. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 0/3] Implement randr 1.4 events.

2013-10-10 Thread Dave Airlie
On Thu, Oct 10, 2013 at 8:55 PM, Michal Srb wrote: > On Tuesday 08 of October 2013 15:11:04 Guillem Jover wrote: >> Hi! >> >> On Mon, 2013-10-07 at 13:26:30 +0300, Michal Srb wrote: >> […] >> >> > 6 files changed, 143 insertions(+) >> > mode change 100644 => 100755 hw/xfree86/common/xf86platform

[git pull] 1.14 randr fixes

2013-10-31 Thread Dave Airlie
) Aaron Plattner (1): xfree86: detach scanout pixmaps when detaching output GPUs Adam Jackson (1): randr: Fix a copypasta bug in CRTC confinement Dave Airlie (4): randr: don't directly set changed bits in randr screen randr: make SetChanged modify the

Re: xserver: Branch 'server-1.14-branch' - 10 commits

2013-11-03 Thread Dave Airlie
>> >> How do I fix this? >> Should I revert that whole merge? Oops, yeah revert the whole merge, I'll resend it with Aaron's suggestions to move things to the end of the structs. Sorry. Dave. ___ xorg-devel@lists.x.org: X.Org development Archives: http:

[git pull] 1.14 randr fixes without ABI breakage

2013-11-04 Thread Dave Airlie
1): randr: Fix a copypasta bug in CRTC confinement Dave Airlie (5): Revert "Merge commit 'f98d6cfa0de41cf33e7555342753897c07af84ef' into server-1.14-branch" randr: don't directly set changed bits in randr screen randr: make SetChanged modify the

Re: [PATCH] xfree86: Prefer fbdev to vesa

2013-11-15 Thread Dave Airlie
On Sat, Nov 16, 2013 at 6:15 AM, Adam Jackson wrote: > On UEFI machines you'd prefer fbdev to grab efifb instead of vesa trying > to initialize and failing in a way we can't unwind from. On BIOS > machines this is harmless: either there is an fbdev driver and it'll > probably be more capable, or

Re: [PATCH 1/1] randr: make RROutputChanged change the main protocol screen not the gpu screen

2013-12-08 Thread Dave Airlie
On Sun, Dec 8, 2013 at 9:08 PM, Alberto Milone wrote: > We only set changes on the main protocol screen as, for example > in RRSetChanged() and RRTellChanged(), therefore we should follow > the same logic when reporting that an output changed in > RROutputChanged(). > > This means that RRTellChang

[PATCH] modesetting: 24bpp are too confusing, shadow our way out.

2014-01-19 Thread Dave Airlie
From: Dave Airlie So we have 2 places where gpus with 24bpp frontbuffers are still in use, cirrus (in qemu) and some early variants of the mgag200 server chips. Currently we seem to get a lot of broken rendering in qt, mesa, gnome if we expose the frontbuffer as 24bpp, nobody seems to test this

Re: [PATCH 07/12] hotplug: Modify OdevAttributes for server-managed fd support

2014-01-28 Thread Dave Airlie
On Tue, Jan 28, 2014 at 6:49 PM, Hans de Goede wrote: > Hi, > > On 01/28/2014 08:01 AM, Dave Airlie wrote: >> On 16 Jan 2014 00:33, "Hans de Goede" wrote: >>> >>> With systemd-logind support, the xserver, rather then the drivers will be >>>

Re: [PATCH] modesetting: 24bpp are too confusing, shadow our way out.

2014-01-28 Thread Dave Airlie
> > We should already be hiding this from clients -- 24bpp front buffer > exposes 32bpp images and shared memory pixmaps. Are you saying that > in-server software rendering to 24bpp object is broken? Well clients doing things direct to the 24bpp window might have issues? I can't tell for sure, it

Re: [PATCH RESEND] xfree86: fix "No devices detected" error for non-seat0 seats (#66851)

2014-01-31 Thread Dave Airlie
On Fri, Jan 31, 2014 at 9:19 PM, Laércio de Sousa wrote: > This fixes a bug that prevents X.Org from starting properly on, > e.g., NVIDIA cards with proprietary drivers, when "-seat" option > is passed with an argument different from "seat0". Do nvidia cards with the binary driver work in other s

Re: [PATCH v2 00/14] Use systemd-logind to manage /dev/... nodes for us

2014-02-10 Thread Dave Airlie
, but I've > not done this yet in this version since I was not sure what others would think > of it. > Hi, odev changes look good to me, so patches 5-9 are Reviewed-by: Dave Airlie I'm not systemd-logind aware enough to know about the rest yet, Well we already have a num

Re: Fixing the kernels backlight API

2014-02-12 Thread Dave Airlie
> > The biggest remaining stumbling block is the backlight API, because opening > the > sysfs files requires root rights. I'll very likely write a little helper for > this > for now, but in the long run it would be good to have a better solution. > > While discussion this in the graphics devroom

Re: [PATCH v2 00/14] Use systemd-logind to manage /dev/... nodes for us

2014-02-18 Thread Dave Airlie
> > Thanks for the review! > >> I'm not systemd-logind aware enough to know about the rest yet, >> >> Well we already have a number of flags from video drivers probing, >> like the needs hw one etc, do you need >> to have a separate capabilities field in the driver? > sorry about delay, I'm not re

[PATCH] randr: fix primary setting of slave outputs

2014-02-20 Thread Dave Airlie
ke it into a/c when slave gpus are in use. Signed-off-by: Dave Airlie --- randr/rroutput.c | 6 +- randr/rrscreen.c | 22 ++ randr/rrxinerama.c | 12 ++-- 3 files changed, 33 insertions(+), 7 deletions(-) diff --git a/randr/rroutput.c b/randr/rroutput.c index f8

Re: [PATCH RESEND] xfree86: fix "No devices detected" error for non-seat0 seats (#66851)

2014-02-26 Thread Dave Airlie
//bugs.freedesktop.org/show_bug.cgi?id=66851 Reviewed-by: Dave Airlie though I'll be on the lookout for any fallout from this. Dave. > > Signed-off-by: Laércio de Sousa > --- > hw/xfree86/common/xf86Bus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

Re: How do we want to deal with 4k tiled displays?

2014-02-27 Thread Dave Airlie
On Tue, Jan 28, 2014 at 1:52 PM, Keith Packard wrote: > "Pierre-Loup A. Griffais" writes: > >> It seems the X server should be responsible for both making sure the two >> halves are laid out properly (right now they're in reverse order) and >> hidden from clients. This database of quirks would id

[PATCH] xserver: fix build since system-logind.h

2014-03-08 Thread Dave Airlie
on tinderbox and irc Signed-off-by: Dave Airlie --- include/systemd-logind.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/systemd-logind.h b/include/systemd-logind.h index 8b09081..06dd031 100644 --- a/include/systemd-logind.h +++ b/include/systemd-logind.h

[PATCH] xserver: fix build since system-logind.h

2014-03-09 Thread Dave Airlie
on tinderbox and irc Reviewed-by: Hans de Goede Reviewed-by: Matthieu Herrb Reviewed-by: Alan Coopersmith Signed-off-by: Dave Airlie --- include/systemd-logind.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/systemd-logind.h b/include/systemd-logind.h index

Re: [PATCH v2 1/2] xf86platformBus: Make doPlatformProbe accept a NULL gdev argument

2014-03-09 Thread Dave Airlie
On Fri, Mar 7, 2014 at 8:34 PM, Hans de Goede wrote: > And use it from xf86platformAddDevice too, instead of directly calling > drvp->platformProbe. > > Signed-off-by: Hans de Goede Looks sane, Reviewed-by: Dave Airlie > --- > hw/xfree86/common/xf86platformBus.c | 14 +++

Re: [PATCH v2 2/2] Require video drivers to report that they support server managed fds

2014-03-09 Thread Dave Airlie
On Fri, Mar 7, 2014 at 8:34 PM, Hans de Goede wrote: > This makes how we handle video drivers identical to what we do for input > drivers, and this should make live easier for old non kms drivers. > > Signed-off-by: Hans de Goede Looks good to me, Reviewed-by: Dave Airlie > --

Re: [PATCH] a lockup in the mga driver

2014-03-13 Thread Dave Airlie
On Fri, Mar 14, 2014 at 8:25 AM, Mikulas Patocka wrote: > Hi David > > Are you maintaining the Xorg mga driver? (you anounced the last update > 1.6.3) Or is someone else maintaining it? Nobody maintains it really, the usermode driver is mostly ignored at this point, I try to look after the kerne

Re: [PATCH 2/2] Fixed driver name in error message about KMS active.

2014-03-17 Thread Dave Airlie
On Mon, Mar 17, 2014 at 10:48 PM, Stefan Dirsch wrote: > Seems some code came from cirrus driver by copy & paste. Fixed > this in error message about device already in use by KMS module. > > Signed-off-by: Stefan Dirsch Both of these ast patches are Reviewed-by: Dave Airlie c

Re: [PATCH 2/2] Fixed driver name in error message about KMS active.

2014-03-17 Thread Dave Airlie
On Tue, Mar 18, 2014 at 9:16 AM, Stefan Dirsch wrote: > On Tue, Mar 18, 2014 at 07:53:30AM +1000, Dave Airlie wrote: >> On Mon, Mar 17, 2014 at 10:48 PM, Stefan Dirsch wrote: >> > Seems some code came from cirrus driver by copy & paste. Fixed >> > this in error

Re: [PATCH] xrandr: document how to disconnect RandR 1.4 providers

2014-03-21 Thread Dave Airlie
t in the > man page. > Look right to me, Reviewed-by: Dave Airlie > Cc: Dave Airlie > Signed-off-by: Aaron Plattner > --- > I plan to make a new release after this change. Dave, did I get the order > right > on the --setprovideroutputsink wording? > > man/xrandr.

Re: Xorg copyright infrigement (was: Re: [PATCH 7/7 v2] Xwayland DDX)

2014-04-01 Thread Dave Airlie
>> +/* >> + * Generate a CVT standard mode from HDisplay, VDisplay and VRefresh. >> + * >> + * These calculations are stolen from the CVT calculation spreadsheet >> written >> + * by Graham Loveridge. He seems to be claiming no copyright and there >> seems to >> + * be no license attached to this

Re: [PATCH] Set a flag property on the root window to say if the X server VT is active

2014-04-03 Thread Dave Airlie
t; Additions. > Signed-off-by: Michael Thayer Seems like it should work okay to me, Reviewed-by: Dave Airlie ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Add a return value to load_cursor_argb() to allow it to report failure

2014-04-03 Thread Dave Airlie
I break, and I probably should have done something like it ages ago when doing -modesetting, Reviewed-by: Dave Airlie ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Add a command line argument for disabling indirect GLX.

2014-04-27 Thread Dave Airlie
On 28 April 2014 03:07, Julien Cristau wrote: > On Sun, Apr 27, 2014 at 10:30:37 -0400, Jasper St. Pierre wrote: > >> I'd be surprised if pretty much any GL application works using the indirect >> GLX extension. It's only specified up to GL 1.4, which was released over 12 >> years ago. >> > GLX 1.

Re: [PATCH v2 0/3] Reworked patches to make non-seat0 X servers work with non-KMS video drivers

2014-04-28 Thread Dave Airlie
are highly recommended to make this solution DM-independent. > Without them, > one needs to pass a custom config file via "-config", which may be unsedirable > or even impossible (e.g. if using GDM), if these settings should be targeted > to > a particular seat only. These

Re: [PATCH] dri2: Fix detection of wrong prime_id in GetScreenPrime.

2014-04-30 Thread Dave Airlie
I thought I reviewed this, Reviewed-by: Dave Airlie On 29 April 2014 20:11, Michal Srb wrote: > No response? It's simple change and fixes client triggered crash... > > On Tuesday April 15 2014 18:54:35 Michal Srb wrote: >> Checking the iterating variable ("slave"

Re: Trying to understand meaning of rrCheckPixmapBounding.

2014-06-10 Thread Dave Airlie
Hi Michael, > I am currectly trying to solve a bug when Xserver doesn't configure correctly > monitor on slaved gpu if the monitor is rotated to left or right. Things get > broken... I think there is a lot worse problems than that one to fix for rotation btw, > I found out that the problem is i

Re: How to fix assert from ProcRRSetProviderOutputSource.

2014-06-10 Thread Dave Airlie
On 5 June 2014 22:59, Michal Srb wrote: > Hi, > > When you have two graphic cards that both have Source Output and Sink Output > capabilities (intel and nouveau for example). It's very easy to flip > parameters of xrandr --setprovideroutputsource and attempt to provide outputs > of the main screen

Re: Request for Evoc proposal draft review.(Shatter support for X server)

2014-06-10 Thread Dave Airlie
On 3 June 2014 04:40, Check Nyah wrote: > Hello, > > I just finished writing the draft of my proposal for Shatter Support for X > server Project(Xinerama replacement) > > I would love to get some feedback and fixes I could make to my proposal > before officially submitting to Evoc Sponsorship. Ok

Re: How do we want to deal with 4k tiled displays?

2014-06-11 Thread Dave Airlie
On 17 January 2014 05:11, Aaron Plattner wrote: > So, monitor manufacturers are starting to make high-resolution displays that > consist of one LCD panel that appears to the PC as two. The one I've got is a > Dell UP2414Q. It shows up to the PC as two DisplayPort 1.2 multistream > devices > tha

Re: Request for Evoc proposal draft review.(Shatter support for X server)

2014-06-25 Thread Dave Airlie
On 13 June 2014 08:06, Check Nyah wrote: > Hello Dave, > > I have the necessary modifications to the proposal as you suggested. I'll > like you to review the modified proposal here: Evoc Proposal > and tell me if there are any further changes I should make. > It seems like a workable plan now, so

Re: [PATCH 1/4] fb: fix screen pixmap leak on server reset

2014-06-26 Thread Dave Airlie
On 27 June 2014 07:15, Keith Packard wrote: > Julien Cristau writes: > >> This breaks Xvfb: >> https://bugs.freedesktop.org/show_bug.cgi?id=80313 >> >> pScreen->devPrivate is NULL, so we crash trying to dereference it in >> FreePixmap(), whereas the free() was a no-op. > > How about we have fb ch

[PATCH] xserver: don't call struct members bool.

2014-07-01 Thread Dave Airlie
From: Dave Airlie When you include files from mesa that might want to use stdbool things get messed up. This is an API break I think and I've no idea what drivers might use this, so we can hold off on it. Signed-off-by: Dave Airlie --- hw/xfree86/common/xf86Opt.h | 2 +- hw/xwin/wincon

Re: x video extension support for MGA G200eW WPCM450

2014-07-07 Thread Dave Airlie
On 8 July 2014 07:10, Alex Deucher wrote: > On Mon, Jul 7, 2014 at 6:40 AM, Raviv wrote: >> Hi, >> >> I'm porting a video application to a new x86 based hardware. >> the video card listed when running lspci is : >> VGA compatible controller: Matrox Graphics, Inc. MGA G200eW WPCM450 (rev 0a) >> >>

Re: Problem compiling X server

2014-07-30 Thread Dave Airlie
On 31 July 2014 03:08, Check Nyah wrote: > Hello Gaetan, > > I've tried Jhbuilder but still having some problems, I'm using the old shell > script, however i'm facing this error with configuring mesa >>>configure: error: libudev-dev required for building DRI > I've tried 'yum install libudev-dev'

Re: [PATCH] modesetting: don't be a GPU screen

2014-08-05 Thread Dave Airlie
NAK. This break output slaving, GPU screen are slave screen for outputs and offloads. Dave. On 6 August 2014 03:59, Rob Clark wrote: > It doesn't actually make any sense for a kms-only ddx. And it causes > problems with non-PCI devices, because some xservers will skip trying to > claim the dev

Re: [PATCH] udev: Do not attempt to remove GPUs for connector updates

2014-08-05 Thread Dave Airlie
f-by: Chris Wilson > Cc: Dave Airlie > --- > config/udev.c | 82 > --- > 1 file changed, 50 insertions(+), 32 deletions(-) > > diff --git a/config/udev.c b/config/udev.c > index 1e4a9d7..dbe32c4 100644 > --- a/c

Re: [PATCH] pixmap: fix reverse optimus support with multiple heads

2014-08-28 Thread Dave Airlie
On 30 July 2013 18:27, Chris Wilson wrote: > On Tue, Jul 30, 2013 at 01:50:48PM +1000, Dave Airlie wrote: >> For doing reverese optimus to multiple outputs on a secondary GPU >> the GPU can store the blits into a large screen pixmap, unfortunately >> this means we need a de

Re: [PATCH] glproto: Fix typo in X_GLXCreateContextAttribsARB definition

2014-09-09 Thread Dave Airlie
pushed, hopefully nothing used it incorrectly :-) Thanks. Dave. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

xserver build failure on tinderbox

2014-09-18 Thread Dave Airlie
I finally got back to trying to resurrect the RHEL6 tinderbox, However the xserver build is broken due to a double definition of DBusConnection http://tinderbox.x.org/builds/2014-09-19-0004/logs/xserver/#build This seems to be due to 480590b90c3966536451d2a2fecc42a66082ed77 dbus-core: Make dbus

[PATCH] xserver: Move 'pragma GCC diagnostic' outside functions

2014-09-18 Thread Dave Airlie
not a string literal, argument types not checked /jhbuild/checkout/xorg/xserver/os/log.c:212: error: #pragma GCC diagnostic not allowed inside functions /jhbuild/checkout/xorg/xserver/os/log.c:214: warning: format not a string literal, argument types not checked etc. Reviewed-by: Dave Airlie

build regression with registry changes

2014-09-19 Thread Dave Airlie
-DROOTLESS_SAFEALPHA -DNO_ALLOCA -c dispatch.c -fno-common -DPIC -o .libs/dispatch.o dispatch.c:421:43: error: implicit declaration of function 'LookupMajorName' is invalid in C99 [-Werror,-Wimplicit-function-declaration,Semantic Issue] XSERVER_REQUEST_START(LookupMajorName(cli

Re: [PATCH] XSERVER_DTRACE needs request names from registry too

2014-09-20 Thread Dave Airlie
ild. > > See: > > http://tinderbox.x.org/builds/2014-09-19-0003/logs/xserver/#build > > Cc: Dave Airlie Reviewed-by: Dave Airlie > Signed-off-by: Keith Packard > --- > include/registry.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a

Re: [PATCH 01/16] xv: Remove dead VIDEO_INVERT_CLIPLIST from the xorg and kdrive DDXes.

2014-09-20 Thread Dave Airlie
On 19 July 2014 04:30, Keith Packard wrote: > Eric Anholt writes: > >> As far as I can see (looking at trees on my disk, plus googling for >> the term), nothing has ever used this flag you need more trees, xf86-video-v4l clearly uses this for something. Dave. ___

tile property contents

2014-10-13 Thread Dave Airlie
Hi, So I've been hacking on mutter and the gnome pieces for tiling, and I've at least fixed mutter locally so maximise windows works and the heads are in the right order. Now I've strung all the pieces together using a single KMS property that X.org propogates, and mutter picks up and propagates

Re: tile property contents

2014-10-14 Thread Dave Airlie
On 14 October 2014 21:40, Thierry Reding wrote: > On Tue, Oct 14, 2014 at 01:23:22PM +1000, Dave Airlie wrote: >> Hi, >> >> So I've been hacking on mutter and the gnome pieces for tiling, and >> I've at least fixed mutter locally so maximise windows works an

Re: tile property contents

2014-10-24 Thread Dave Airlie
>> > > There are also configurations where users configure multiple heads to >> > > drive power walls that they want to be treated as one logical monitor, >> > > similar to the DP MST tiled display case. Normally, those powerwall >> > > configurations don't have any layout information from the mon

Re: [PATCH] mi: fix documentation for miPointerSetPosition

2014-11-11 Thread Dave Airlie
On 12 November 2014 10:30, Peter Hutterer wrote: > Changed when we added barriers, documentation didn't get updated. > > Reported-by: Dave Airlie > Signed-off-by: Peter Hutterer LGTM Reviewed-by: Dave Airlie > --- > mi/mipointer.c | 5 + > 1 file changed, 5 in

Re: Memory leak on 1.15.1?

2014-11-20 Thread Dave Airlie
On 21 November 2014 00:03, Mathieu Slabbinck wrote: > Hi, > > I'm running an x86 Linux system that runs xorg-xserver 1.15.1 with fglrx > driver 14.10.1006.1001. > When the xserver is up and running and I run continuously "xrandr --verbose" > I see the memory gradually piling up. > For example "wat

<    2   3   4   5   6   7   8   9   10   11   >