Re: [PATCH] Fix NO_LOCAL_CLIENT_CRED build

Jon TURNEY writes: > Please consider picking a version you like and applying it, or let me > know how I can make this patch acceptable. I'll just apply your original patch and mark it as reviewed-by me. -- -keith signature.asc Description: PGP signature _

Eric is filling in for X server maintainer until 2 August

I'm going rafting down the grand canyon for the next two weeks, and Eric has graciously volunteered to manage the care and feeding of the X server master branch while I'm away. I'm leaving my laptop at home -- I think it's probably the first time in close to twenty years that I've been away from

Re: [PATCH] os: make sure the clientsWritable fd_set is initialized before use

Alan Coopersmith writes: > For the xserver itself, you mail the patch to Keith with all the reviewed-by > tags added to push it to the master branch (now that he's back from > vacation). Nearly three weeks without a computer. Strange and weird. -- -keith signature.asc Description: PGP signat

Re: [PATCH 2/2] xwayland: Don't (double) destroy input resources in CloseScreen

Adam Jackson writes: > By the time we get here we've already done CloseDownDevices, so on the > second regeneration you get: Merged both (with review). ea03e31..533fb62 master -> master -- -keith signature.asc Description: PGP signature ___ xor

Re: [PATCH] glxproxy: Fix an obvious thinko in QueryExtensionsString

ryExtensionsString(__GLXclientState * cl, GLbyte * pc) > > This is entirely accurate, albeit curiously phrased: swapping some bits > hanging off the end of a null pointer will make Xdmx crash, so from the > perspective of code generation the function will indeed not return. Reviewed-

[PATCH 1/2] dixfont.h: Include fontutil.h before GetGlyphs is #defined

This eliminates the duplicate declaration of dixGetGlyphs when fontutil.h gets included after dixfont.h has defined GetGlyphs as dixGetGlyphs. Signed-off-by: Keith Packard --- include/dixfont.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/dixfont.h b/include/dixfont.h index

[PATCH 2/2] mi: Always initialize edge1 and edge2 in miLineArc

This eliminates a warning generated when miLineArcD is inlined and the compiler can't figure out that edge1 and edge2 are always initialized before being used. Signed-off-by: Keith Packard --- mi/miwideline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mi/miwidelin

Re: [git pull] warnings fixes

Dave Airlie writes: > Dave Airlie (3): > mioverlay.c: remove shadowed pScreen. > rootless: fix warnings due to lack of const keeping. > rootless: rename w->_w to avoid shadow warnings Reviewed and merged. -- -keith signature.asc Description: PGP signature __

Re: [PATCH 2/2] mi: Always initialize edge1 and edge2 in miLineArc

Keith Packard writes: > Signed-off-by: Keith Packard Both of these are Reviewed (by Dave Airlie) and merged. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archi

Re: [git pull] modesetting zaphod heads support

Dave Airlie writes: > Dave Airlie (1): > modesetting: add zaphod support (v3) > > Mario Kleiner (1): > modesetting: Add more missing options to man page. Merged: bca4f4b..7ecdfbf master -> master -- -keith signature.asc Description: PGP signature _

Re: [PATCH] os: make sure the clientsWritable fd_set is initialized before use

Martin Peres writes: > We have been discussing in private with Keith. It seems like the both of > us do not have the time to properly fix the issue. I would say let's > push this fix and get rid of all this complexity later! I really do not > see when I will have the time for it and this patch

Re: [PATCH 2/2] configurable maximum number of clients

Olivier Fourdan writes: > Make the maximum number of clients user configurable, either from the command > line or from xorg.conf > > This patch works by using the MAXCLIENTS (raised to 512) as the maximum > allowed number of clients, but allowing the actual limit to be set by the > user to a lowe

Re: [PATCH] os: make sure the clientsWritable fd_set is initialized before use

Dave Airlie writes: > and maybe pull in the patch series. Yup, thanks for your patience. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://

Re: [PULL] --enable-debug -Wformat fixes

Jon Turney writes: > Jon TURNEY (5): > debug output format fix in xf86Events.c > debug output format fix in TI.c > debug output format fix in DRISwapContext() > debug output format fix in ephyrProcessMouseMotion() > debug output format fix in TouchEventHistoryPush()

[PATCH] Mark ResourceClientBits _X_EXPORT

This function is referenced by modules and drivers, so it needs to be published or the X server will crash when a module attempts to use it. Signed-off-by: Keith Packard --- include/resource.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/resource.h b/include

Re: [PATCH] dix: export ResourceClientBits()

t; ResourceClientBits > > bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91763 > Signed-off-by: Olivier Fourdan Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org developmen

Re: [PATCH] dix: export ResourceClientBits()

Keith Packard writes: >> bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91763 >> Signed-off-by: Olivier Fourdan > > Reviewed-by: Keith Packard Merged. dbfed3a..c74c074 master -> master -- -keith signature.asc Descr

Re: [PATCH] remove bogus \/ escapes

Mark Kettenis writes: >> Signed-off-by: Matthieu Herrb > > Reviewed-by: Mark Kettenis Merged. c74c074..634e357 master -> master -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://

[PATCH libXfont] Eliminate calls back to X server or font server functions by name

, and the package config file is now xfont_2.pc. All of the installed headers remain the same as the original library; there's now a new include file, libxfont_2.h, which defines the X server and Font server interfaces. Signed-off-by: Keith Packard --- Makefile.am

[PATCH] Switch to the libXfont_2 API.

This new libXfont API eliminates exposing internal X server symbols to the font library, replacing those with a struct full of the entire API needed to use that library. Signed-off-by: Keith Packard --- configure.ac | 2 +- dix/dixfonts.c | 67

Re: [PATCH libXfont] Eliminate calls back to X server or font server functions by name

Julien Cristau writes: > On Wed, Sep 2, 2015 at 00:15:06 -0700, Keith Packard wrote: > >> +#ifndef _LIBXFONT_H_ >> +#define _LIBXFONT_H_ > > Include the 2 from the filename in the guard macro's name? Yeah. I just renamed it before pushing out the patch and missed a

Re: [PATCH libXfont] Eliminate calls back to X server or font server functions by name

Matt Turner writes: >> +#include > > I don't know where this header is supposed to be (maybe it's supposed > to be libxfont_2.h?), but it's not there and causes a build failure. > Simply removing the #include lets it compile without warnings. Yeah, I refactored the includes and now this f

Re: [PATCH libXfont] Eliminate calls back to X server or font server functions by name

Emil Velikov writes: > There are very few projects that use underscore as above. The most > common approach is libXfont-2, although some prefer libXfont2. I'm easy; libXfont2 is probably a better plan than introducing punctuation into the name. Thanks for your feedback! -- -keith signature.a

[PATCH libXfont] Eliminate calls back to X server or font server functions by name (v2)

being larger than it would otherwise be. v2: Rename to libXfont2 instead of libXfont_2 as suggested by Emil Velikov Fix whitespace in stubs/atom.c, which was moved from util/ Signed-off-by: Keith Packard --- Makefile.am | 7 +- configure.ac | 4 +- in

[PATCH] Switch to the libXfont2 API (v2)

This new libXfont API eliminates exposing internal X server symbols to the font library, replacing those with a struct full of the entire API needed to use that library. v2: Use libXfont2 instead of libXfont_2 Signed-off-by: Keith Packard --- configure.ac | 2 +- dix/dixfonts.c | 66

Re: [PATCH libXfont] Eliminate calls back to X server or font server functions by name (v2)

Emil Velikov writes: > From a very quick look, only fontstruct.h seems to be used. If truly > so, one can rework it (rename or fold into libxfont2.h, rename the > symbols ?) and drop the rest from libXfontinclude_HEADERS. fontstruct.h comes from proto/fontsproto However, fontutil.h does come fr

Re: [PATCH] dmx: Fix the build

Jon TURNEY writes: > ./../dix/.libs/libdix.a(pixmap.o): In function `PixmapStartDirtyTracking': > xorg/xserver/dix/pixmap.c:194: undefined reference to `RRTransformCompute' > > I'm not quite sure how 0db457b fixes this > > Move RANDR_LIB to after DIX_LIB, so the reference to RRTransformCompute in

Re: [PATCH libXfont] Eliminate calls back to X server or font server functions by name (v2)

Emil Velikov writes: > Had a long hard look at the Archlinux repos and did not see (m)any > libxfont users outside of xserver. Would you/others know if they're > still a thing or they share the same faith as the print server :-) There really shouldn't be any other than the X font utilities (bdft

Re: [PATCH libXfont] Eliminate calls back to X server or font server functions by name (v2)

Alan Coopersmith writes: > mkfontdir is now a wrapper around mkfontscale which doesn't use libXfont, > just libfontenc & libfreetype. Oh, nice. I hadn't realized that. > bdftopcf could probably be similarly rewritten to use FreeType directly. We'd have to provide pcfWriteFont for it, presumabl

[PATCH] fonts: Continue when font calls return Suspended more than once

the code to its previous behaviour, which permitted multiple Suspended returns and simply waited for the client to be signaled again so that the callback could continue processing the request. Signed-off-by: Keith Packard Cc: Adam Jackson --- dix/dixfonts.c | 21 - 1 f

Re: [PATCH] privates: Clear screen-specific keys during CloseScreen

Aaron Plattner writes: > The modesetting driver corrupts memory when used after a server regeneration > because not enough memory is allocated for its pixmap privates. This happens > because its call to dixRegisterScreenSpecificPrivateKey() does nothing because > key->initialized is still TRUE f

Re: [PATCH v2] privates: Clear screen-specific keys during CloseScreen

Aaron Plattner writes: > The modesetting driver corrupts memory when used after a server regeneration > because not enough memory is allocated for its pixmap privates. This happens > because its call to dixRegisterScreenSpecificPrivateKey() does nothing because > key->initialized is still TRUE f

Re: [PATCH v3] privates: Clear screen-specific keys during CloseScreen

zed before CloseScreen and add a call to > dixFreeScreenSpecificPrivates() for GPU screens. > > v2: Just set key->initialized to FALSE and move > dixFreeScreenSpecificPrivates() > calls to after CloseScreen. > > v3: Move dixFreeScreenSpecificPrivates() calls back to just before >

[PATCH xserver 02/24] Xext/xselinux: Warning fixes

There's a 'const char *' adventure here that I'm mostly ignoring; some client information gets const poisoned. Worked around by adding a couple of casts. Ick. Added an _X_ATTRIBUTE_PRINTF to SELinuxLog. Ignore a couple of unused return values. Signed-off-by: Keit

[PATCH xserver 08/24] os: Implement support for NotifyFd X_NOTIFY_WRITE

This adds the ability to be notified when a file descriptor is available for writing. Signed-off-by: Keith Packard --- os/WaitFor.c| 30 -- os/connection.c | 40 +++- os/io.c | 8 os/osdep.h | 5 - 4

[PATCH xserver 09/24] dix: Move InitFonts up above screen initialization

ResetFontPrivateIndex inside InitFonts. Signed-off-by: Keith Packard --- dix/dixfonts.c | 2 ++ dix/main.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 300bf04..19db141 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -1809,6

[PATCH xserver 21/24] hw/xfree86: Use NotifyFd for device and other input fd wakeups

Remove code in xf86Wakeup for dealing with device and other input and switch to using the new NotifyFd interface. Signed-off-by: Keith Packard --- hw/xfree86/common/xf86Events.c | 67 -- 1 file changed, 26 insertions(+), 41 deletions(-) diff --git a/hw

[PATCH xserver 15/24] kdrive/ephyr: Use NotifyFd for XCB connection input

Eliminates polling every 20ms for device input. Signed-off-by: Keith Packard --- hw/kdrive/ephyr/ephyr.c | 10 +- hw/kdrive/ephyr/ephyr.h | 3 --- hw/kdrive/ephyr/hostx.c | 6 ++ hw/kdrive/ephyr/hostx.h | 2 ++ hw/kdrive/ephyr/os.c| 1 - 5 files changed, 17 insertions(+), 5

[PATCH xserver 07/24] os: Add NotifyFd interfaces

void RemoveNotifyFd(int fd); RemoveNotifyFd may be called from the notify function. Signed-off-by: Keith Packard --- include/os.h| 13 os/WaitFor.c| 4 +++ os/connection.c | 93 + os/osdep.h | 5 os/osinit.c

[PATCH xserver 01/24] fonts: Continue when font calls return Suspended more than once

the code to its previous behaviour, which permitted multiple Suspended returns and simply waited for the client to be signaled again so that the callback could continue processing the request. Signed-off-by: Keith Packard Cc: Adam Jackson --- dix/dixfonts.c | 21 - 1 f

[PATCH xserver 13/24] hw/kdrive: Use NotifyFd interface for kdrive/linux APM monitoring

Replace the block/wakeup handlers with a NotifyFd callback Signed-off-by: Keith Packard --- hw/kdrive/linux/linux.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/hw/kdrive/linux/linux.c b/hw/kdrive/linux/linux.c index 73a8169..a52bdef 100644 --- a/hw

[PATCH xserver 10/24] dix: Switch to the libXfont2 API (v2)

This new libXfont API eliminates exposing internal X server symbols to the font library, replacing those with a struct full of the entire API needed to use that library. v2: Use libXfont2 instead of libXfont_2 Signed-off-by: Keith Packard --- Xext/xf86bigfont.c | 4 +- configure.ac

[PATCH xserver 16/24] modesetting: Use NotifyFd for drm event monitoring

Replace the block/wakeup handlers with a NotifyFd callback. Signed-off-by: Keith Packard --- hw/xfree86/drivers/modesetting/vblank.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/vblank.c b/hw/xfree86/drivers/modesetting

[PATCH xserver 23/24] Remove readmask from screen block/wakeup handler

With no users of the interface needing the readmask anymore, we can remove it from the argument passed to these functions. Signed-off-by: Keith Packard --- composite/compalloc.c | 4 ++-- dix/dixutils.c | 14 ++ exa/exa.c

[PATCH xserver 17/24] hw/xwayland: Use NotifyFd handler to monitor wayland socket

Replace the block/wakeup handler with a NotifyFd callback instead. Signed-off-by: Keith Packard --- hw/xwayland/xwayland.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index bc92beb..685e352 100644 --- a

[PATCH xserver 03/24] Xext, os: Remove OS-internal usages within XACE and XSELinux

These extensions were accessing internal OS functions and structures. Expose the necessary functionality to them and remove their use of osdep.h Signed-off-by: Keith Packard --- Xext/xace.c | 13 ++--- Xext/xselinux_hooks.c | 1 - include/os.h | 7 +++ os

[PATCH xserver 11/24] config: Use NotifyFd for dbus interface

This uses the NotifyFd interface to monitor the dbus socket rather than a block/wakeup handler. Signed-off-by: Keith Packard --- config/dbus-core.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/config/dbus-core.c b/config/dbus-core.c index 8351ea4

[PATCH xserver 12/24] config: Use NotifyFd interface for udev

This uses the NotifyFd interface to monitor the udev file descriptor rather than adding another block/wakeup handler Signed-off-by: Keith Packard --- config/udev.c | 45 - 1 file changed, 16 insertions(+), 29 deletions(-) diff --git a/config/udev.c b

[PATCH xserver 05/24] os/xdmcp: Remove dead 'restart' code

from the server some time before XFree86 4.3.99.16, so the remaining bits of code have been dead for over a decade, and no-one ever noticed. Signed-off-by: Keith Packard --- os/xdmcp.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/os/xdmcp.c b/os/xdmcp.c index

[PATCH xserver 22/24] os: Use NotifyFd interface for listen descriptors

Replace the custom path for dealing with new incoming connections with the general-purpose NotifyFd API. Signed-off-by: Keith Packard --- include/os.h| 3 -- os/WaitFor.c| 4 --- os/connection.c | 104 +++- 3 files changed, 42

[PATCH xserver 19/24] os/xdmcp: Replace xdmcp block/wakeup handlers with timer and NotifyFd

This removes the block and wakeup handlers and replaces them with a combination of a NotifyFd callback and timers. Signed-off-by: Keith Packard --- os/xdmcp.c | 114 +++-- 1 file changed, 36 insertions(+), 78 deletions(-) diff --git a/os

[PATCH xserver 24/24] Remove fd_set from Block/Wakeup handler API

This removes the last uses of fd_set from the server interfaces outside of the OS layer itself. Signed-off-by: Keith Packard --- Xext/sleepuntil.c | 17 +++-- Xext/sync.c | 12 ++-- dix/dixfonts.c | 7 +++ dix

[PATCH xserver 14/24] hw/kdrive: Use NotifyFd for kdrive input devices

This switches the kdrive code to use FD notification for input devices, rather than the block and wakeup handlers. Signed-off-by: Keith Packard --- hw/kdrive/src/kinput.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/kdrive/src/kinput.c b

[PATCH xserver 04/24] Remove non-smart scheduler. Don't require setitimer.

This allows the server to call GetTimeInMillis() after each request is processed to avoid needing setitimer. -dumbSched now turns off the setitimer. Signed-off-by: Keith Packard --- configure.ac| 2 +- dix/dispatch.c | 17 +++-- include/dix-config.h.in | 3

[PATCH xserver 00/24] Eliminate fd_set from non-OS code

Here's the latest version of the patch set to make the non-OS bits of the X server stop using fd_set. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver 20/24] render: Use OsTimer for animated cursor timing

This replaces the block/wakeup handlers with an OsTimer. This also avoids problems with performing rendering during the wakeup handler. Signed-off-by: Keith Packard --- render/animcur.c | 57 +--- 1 file changed, 30 insertions(+), 27 deletions

[PATCH xserver 18/24] Xext/xselinux: Use NotifyFd interface

Replace block/wakeup handlers with SetNotifyFd. Much nicer now. Signed-off-by: Keith Packard --- Xext/xselinux_hooks.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/Xext/xselinux_hooks.c b/Xext/xselinux_hooks.c index d9f2f68..2d85928 100644 --- a/Xext

[PATCH xserver 06/24] os/xdmcp: Just send XDMCP keepalive packets once every three minutes

select masks easier. Signed-off-by: Keith Packard --- os/xdmcp.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/os/xdmcp.c b/os/xdmcp.c index b1ee5d2..7939b41 100644 --- a/os/xdmcp.c +++ b/os/xdmcp.c @@ -84,8 +84,6 @@ static int req_socklen; static

Re: [PATCH xserver 10/24] dix: Switch to the libXfont2 API (v2)

Daniel Martin writes: > And this. Those renamings don't look necessary. > Do they otherwise conflict with something, I don't see atm.? Yes, these are all defined in fontproto.h, which is included in the fontsproto module, so I had to use new names for them as they are no longer part of the API.

Re: [PATCH xserver 15/24] kdrive/ephyr: Use NotifyFd for XCB connection input [v2]

n wrapper. From 7e824b6f85b9ed81d29864685177fc7c5e659d42 Mon Sep 17 00:00:00 2001 From: Keith Packard Date: Sun, 20 Sep 2015 14:44:29 +0100 Subject: [PATCH xserver 15/24] kdrive/ephyr: Use NotifyFd for XCB connection input [v2] Eliminates polling every 20ms for device input. v2: rename ephyrPoll to ephyrXcbNotify and fix the

Re: [PATCH xserver 00/24] Eliminate fd_set from non-OS code

Daniel Martin writes: > Thanks for those cleanups. I've skimmed through the patches and found > two nit-picks. Though, this doesn't stand a Reviewed-by. Thanks for taking a look. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lis

Re: [PATCH xserver 23/24] Remove readmask from screen block/wakeup handler

Mark Kettenis writes: > This, of course, has impact on pretty much all the drivers. Many use > compat-api.h and could probably be fixed by adding an additional > stanza there. But somebody still needs to do that work. A few actually use the block and wakeup handlers to manage additional file d

Re: [PATCH] rootless: Fix bogus handling of broken root clip

>data); > > So that'd crash if you ever got there. RegionNull will do almost the > same thing only without the free(), so let's do that instead; it might > still not be an entirely sane way to recover, but it at least won't > crash. > > Sig

Re: [PATCH xwayland] xwayland: Always update the wl_pointer cursor on pointer focus

Jonas Ådahl writes: > In Wayland, a client (in this case XWayland) should set the cursor > surface when it receives pointer focus. Not doing this will leave the > curser at whatever it was previously. It seems like it would be far simpler to just remember the last cursor set down in the xwayland

Re: [PATCH xserver 07/24] os: Add NotifyFd interfaces

Alan Coopersmith writes: > On 09/20/15 11:16 PM, Keith Packard wrote: >> This provides a callback-based interface to monitor file >> descriptors beyond the usual client and device interfaces. >> >> Modules within the server using file descriptors for reading

Re: [PATCH xwayland] xwayland: Always update the wl_pointer cursor on pointer focus

Jonas Ådahl writes: > The reason I didn't do this was that we'd send duplicate set_cursor > requests when the cursor actually did change. What the patch does is > make it so that the path that actually does change the cursor when it > changes according to the X server always does it when needed i

Re: [PATCH xwayland] xwayland: Always update the wl_pointer cursor on pointer focus

Jonas Ådahl writes: > Sure, if relying on mipointer doing this is fine then why not. Yeah, there are lots of places where the original API design from 1987 doesn't make much sense in 2015. Who would have thought? > I'd still need to add the 'invalidate' state to mipointer.c here though > (see b

Re: [RFC] [PATCH] Extend block and wakeup handling to cover writes as well

Pierre Ossman writes: > Ping. Still in the list? :) Did you see my recent patches that add a new API for file descriptor monitoring? -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://l

Re: [PATCH xwayland 1/2] events: Stop tracking current cursor ourself

viewed-by: Keith Packard ` -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

Jonas Ådahl writes: > As mentioned, a different approach would be to work-around the issue in > xwayland, but I consider such a solution more hacky than this. Please let > me know what you think. All you need do in xwayland is smash pSpriteCursor to some other value, like ((CursorPtr) (intptr_t)

Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

Jonas Ådahl writes: > On Tue, Sep 29, 2015 at 09:49:46AM -0700, Keith Packard wrote: >> Jonas Ådahl writes: >> >> > As mentioned, a different approach would be to work-around the issue in >> > xwayland, but I consider such a solution more hacky than this. Pleas

Re: [PATCH xwayland 2/2 v2] xwayland: Always update the wl_pointer cursor on pointer focus

Jonas Ådahl writes: > Yes, otherwise we'd crash in miPointerUpdateSprite when trying to access > pCursor->bits. pSpriteCursor, not pCursor. -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: h

Re: [PATCH xquartz 02/10] randr: Correct a miscall of abs() to instead call fabs()

Alan Coopersmith writes: > Long long ago, the xserver's include/misc.h had: > #define abs(a) ((a) > 0 ? (a) : -(a)) > which worked for code like this, but git history says that was removed in > XFree86 4.3.0.1 (commit d568221710959cf in the current xserver git repo) > and we've just been sloppy e

Re: [PATCH xquartz 08/10] osinit: Silence -Wunused-variable warnings

Jeremy Huddleston Sequoia writes: > I thought we required C99 now. Was I mistaken in that? If not, I'm > fine with just leaving it as is and ignoring the warning. We're not (yet) allowing mixed declarations and code. To get rid of the warning (a good idea), you'll just need to duplicate the #i

Re: [PATCH] glamor: fix crash when drawing nothing

Rob Clark writes: > On Wed, Oct 14, 2015 at 8:10 PM, Eric Anholt wrote: >> Rob Clark writes: >> >>> For example, in the PolyFillRect() path w/ nrect==0, we end up in >>> glamor_get_vbo_space(size=0): >> >> I wonder instead if we shouldn't just have glamor_get_vbo_space() return >> NULL on size

X server commit process

smith - security * Peter Hutterer - input * Adam Jackson - xfree86 backend * Keith Packard- misc All of us will also pick up minor patches throughout the tree and get them merged. We still have a requirement that each patch be marked as Reviewed-by: and include a Signed-off-by: line, and ne

Re: X server commit process

Jeremy Huddleston Sequoia writes: > What is the current process for pulling into release branches? Are > the breakdowns the same, or is someone specific going to manage > release branches? We didn't discuss making any changes, and I think we can probably leave that up to the branch managers if

Re: [PATCH xserver 1/5] glamor: Handle GL_OUT_OF_MEMORY when allocating texture images.

Eric Anholt writes: > +if (glGetError() == GL_OUT_OF_MEMORY) { It seems like you'll need to call this in a loop in case multiple error bits are set? And, don't you need to call this (repeatedly) before the function which might generate an error in case there was an existing error pending?

Re: [PATCH xserver 1/5] glamor: Handle GL_OUT_OF_MEMORY when allocating texture images.

Eric Anholt writes: > I think it's a safe enough assumption that we're not generating non-OOM > errors. And, now that we're logging errors, we should get reports of > them sooner than we used to. Would it be sensible to wrap the glGetError call like this? GLenum glamor_check_gl_oom() {

Re: [PATCH evdev] Only map x and y to axes 0 and 1

92856 > > Signed-off-by: Peter Hutterer Reviewed-by: Keith Packard (who was surprised that "if (mapping == i) i++;" already existed in the code for no good reason until now). -- -keith signature.asc Description: PGP signature ___

Re: [PATCH xf86-input-libinput 3/3] Split mixed pointer/keyboard devices into two separate X devices

se was quite clear until I got to this, but I waded through and this looks fine too :-) Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archiv

[PATCH xserver 10/20] kdrive/ephyr: Use NotifyFd for XCB connection input [v2]

Eliminates polling every 20ms for device input. v2: rename ephyrPoll to ephyrXcbNotify and fix the API so it can be used directly for SetNotifyFd. Thanks to Daniel Martin Signed-off-by: Keith Packard Cc: Daniel Martin --- hw/kdrive/ephyr/ephyr.c | 6 -- hw/kdrive/ephyr/ephyr.h

[PATCH xserver 07/20] config: Use NotifyFd interface for udev

This uses the NotifyFd interface to monitor the udev file descriptor rather than adding another block/wakeup handler Signed-off-by: Keith Packard --- config/udev.c | 45 - 1 file changed, 16 insertions(+), 29 deletions(-) diff --git a/config/udev.c b

[PATCH xserver 02/20] os: Add NotifyFd interfaces

void RemoveNotifyFd(int fd); RemoveNotifyFd may be called from the notify function. Signed-off-by: Keith Packard --- include/os.h| 13 os/WaitFor.c| 4 +++ os/connection.c | 93 + os/osdep.h | 5 os/osinit.c

[PATCH xserver 09/20] hw/kdrive: Use NotifyFd for kdrive input devices

This switches the kdrive code to use FD notification for input devices, rather than the block and wakeup handlers. Signed-off-by: Keith Packard --- hw/kdrive/src/kinput.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/kdrive/src/kinput.c b

[PATCH xserver 08/20] hw/kdrive: Use NotifyFd interface for kdrive/linux APM monitoring

Replace the block/wakeup handlers with a NotifyFd callback Signed-off-by: Keith Packard --- hw/kdrive/linux/linux.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/hw/kdrive/linux/linux.c b/hw/kdrive/linux/linux.c index 73a8169..a52bdef 100644 --- a/hw

[PATCH xserver 03/20] os: Implement support for NotifyFd X_NOTIFY_WRITE

This adds the ability to be notified when a file descriptor is available for writing. Signed-off-by: Keith Packard --- os/WaitFor.c| 30 -- os/connection.c | 40 +++- os/io.c | 8 os/osdep.h | 5 - 4

[PATCH xserver 20/20] mi: Remove miPointerRec from API

This moves the definition of miPionterRec from mipointrst.h to mipointer.c so that it is no longer visible in the API, allowing it to be changed while the API/ABI is frozen. Signed-off-by: Keith Packard --- mi/mipointer.c | 12 mi/mipointrst.h | 12 2 files changed

[PATCH xserver 12/20] hw/xwayland: Use NotifyFd handler to monitor wayland socket

Replace the block/wakeup handler with a NotifyFd callback instead. Signed-off-by: Keith Packard --- hw/xwayland/xwayland.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c index e31becf..bea2164 100644 --- a

[PATCH xserver 01/20] Remove non-smart scheduler. Don't require setitimer.

This allows the server to call GetTimeInMillis() after each request is processed to avoid needing setitimer. -dumbSched now turns off the setitimer. Signed-off-by: Keith Packard --- configure.ac| 2 +- dix/dispatch.c | 17 ++--- include/dix-config.h.in | 3

[PATCH xserver 18/20] Remove readmask from screen block/wakeup handler

With no users of the interface needing the readmask anymore, we can remove it from the argument passed to these functions. Signed-off-by: Keith Packard --- composite/compalloc.c | 4 ++-- dix/dixutils.c | 14 ++ exa/exa.c

[PATCH xserver 05/20] dix: Switch to the libXfont2 API (v2)

This new libXfont API eliminates exposing internal X server symbols to the font library, replacing those with a struct full of the entire API needed to use that library. v2: Use libXfont2 instead of libXfont_2 Signed-off-by: Keith Packard --- Xext/xf86bigfont.c | 4 +- configure.ac

[PATCH xserver 13/20] Xext/xselinux: Use NotifyFd interface

Replace block/wakeup handlers with SetNotifyFd. Much nicer now. Signed-off-by: Keith Packard --- Xext/xselinux_hooks.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/Xext/xselinux_hooks.c b/Xext/xselinux_hooks.c index d9f2f68..2d85928 100644 --- a/Xext

[PATCH xserver 04/20] dix: Move InitFonts up above screen initialization

ResetFontPrivateIndex inside InitFonts. Signed-off-by: Keith Packard --- dix/dixfonts.c | 2 ++ dix/main.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 300bf04..19db141 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -1809,6

[PATCH xserver 14/20] os/xdmcp: Replace xdmcp block/wakeup handlers with timer and NotifyFd

This removes the block and wakeup handlers and replaces them with a combination of a NotifyFd callback and timers. Signed-off-by: Keith Packard --- os/xdmcp.c | 114 +++-- 1 file changed, 36 insertions(+), 78 deletions(-) diff --git a/os

[PATCH xserver 06/20] config: Use NotifyFd for dbus interface

This uses the NotifyFd interface to monitor the dbus socket rather than a block/wakeup handler. Signed-off-by: Keith Packard --- config/dbus-core.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/config/dbus-core.c b/config/dbus-core.c index 8351ea4

[PATCH xserver 16/20] hw/xfree86: Use NotifyFd for device and other input fd wakeups

Remove code in xf86Wakeup for dealing with device and other input and switch to using the new NotifyFd interface. Signed-off-by: Keith Packard --- hw/xfree86/common/xf86Events.c | 67 -- 1 file changed, 26 insertions(+), 41 deletions(-) diff --git a/hw

[PATCH xserver 19/20] Remove fd_set from Block/Wakeup handler API

This removes the last uses of fd_set from the server interfaces outside of the OS layer itself. Signed-off-by: Keith Packard --- Xext/sleepuntil.c | 17 +++-- Xext/sync.c | 12 ++-- dix/dixfonts.c | 7 +++ dix

[PATCH xserver 17/20] os: Use NotifyFd interface for listen descriptors

Replace the custom path for dealing with new incoming connections with the general-purpose NotifyFd API. Signed-off-by: Keith Packard --- include/os.h| 3 -- os/WaitFor.c| 4 --- os/connection.c | 104 +++- 3 files changed, 42

[PATCH xserver 11/20] modesetting: Use NotifyFd for drm event monitoring

Replace the block/wakeup handlers with a NotifyFd callback. Signed-off-by: Keith Packard --- hw/xfree86/drivers/modesetting/vblank.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/hw/xfree86/drivers/modesetting/vblank.c b/hw/xfree86/drivers/modesetting

<    1   2   3   4   5   6   7   8   9   10   >