Before 704a867f8fb7652a8b7d5569bbe44e188457db4e, when XORG is false,
libxservertest.la was not ever linked and only built by 'make check'.
Remove it (and its XSERVER_LIBS dependency) to fix the build errors
likely caused by ordering of its libraries.
Signed-off-by: Mihail Konev
Mihail Konev (3):
tests: Fix guards for ld -wrap
tests: Fix guards for xfree86 tests
tests: Remove what was libxservertest.la for !XORG
test/Makefile.am | 126 ---
test/tests.c | 17
2 files changed, 45 insertions(+), 98
Commit ead5064581665ff40c177dd1b447949f1420e209 missed that most of
tests are xfree86-specific, making them being built unconditionally.
Signed-off-by: Mihail Konev
---
test/Makefile.am | 40 ++--
test/tests.c | 17 ++---
2 files changed, 32
1 deletion(-)
>
Should be another libxservertest.la_LIBADD -> tests_LDADD breakage.
(The static library was acting like ld's --begin-group ... --end-group
for all its LIBADD-s).
Reviewed-by: Mihail Konev
___
xorg-devel@lists.x.org: X.Org development
Archiv
On Wed, Jan 25, 2017 at 09:28:21AM +0500, Mihail Konev wrote:
> On Mon, Jan 23, 2017 at 07:15:46PM +0200, Martin Peres wrote:
> > Classic GNU ld resolves symbol dependencies only forward, while GOLD
> > seems to work regardless of the specified library order.
> >
> >
On Wed, Jan 25, 2017 at 09:28:21AM +0500, Mihail Konev wrote:
> (The static library was acting like ld's --begin-group ... --end-group
> for all its LIBADD-s).
Wrong, this would only apply to .a libraries; but *_SYS_LIBS in question
are all "-l*"-s.
Instead, libtool was re
Split and rebased on top of 7617a0a1 version attached.
Fixes build failures occuring when not building xfree86 DDX.
Works for XWin ./configure --enable-static=yes
Works for ./configure --disable-xorg
>From 2949b5229dc6557dd12f1b9c12a10b12d7ab97fd Mon Sep 17 00:00:00 2001
From: Mihail Konev
D
v6: Fix commit descriptions - explain failures, and do not
duplicate 'git log -L'.
I could reorder libxservertest.la libraries if it's better to do so,
it just looks time-consuming.
>From 0490a7874b9385f6e076596e0834167357b3e229 Mon Sep 17 00:00:00 2001
From: Mihail Konev
Date
v7: add regressed-by lines
>From c55acff0f1c9bd67ec67119979589b4982a934d3 Mon Sep 17 00:00:00 2001
From: Mihail Konev
Date: Mon, 16 Jan 2017 23:55:36 +0500
Subject: [PATCH v7 xserver 1/3] tests: Fix guards for ld -wrap
Fixes XQuartz build.
Regressed-in: 23f6dbc96e47be6cbeed78cc9ef303987c3e2
ld.gold ignores --as-needed
(Observable by: make -C test tests V=1 CFLAGS='-v')
Fixes: b1a69863 ("tests: shuffle around the linking order")
Signed-off-by: Mihail Konev
---
Ubuntu patches gcc builtin -specs= file (the gcc -dumpspec),
but gold ignores the arg.
test/Makefile
Actually those *_SYS_LIBS are missing from LIBADD's in other makefiles,
and libtool does no reordering.
As the original patch then needs to be reverted anyway,
maybe merging the fix would be noisy.
On Thu, Feb 02, 2017 at 10:04:03AM +0500, Mihail Konev wrote:
> ld.gold ignores --a
und the linking order")
Signed-off-by: Mihail Konev
---
Tested with all --enable-... except for:
werror, strict-compilation, config-hal, xselinux, xwin, xquartz
"make -C test tests" works, only Xdmx fails to link :)
hw/xfree86/dri/Makefile.am | 2 ++
miext/sync/Makefile.a
On Thu, Feb 02, 2017 at 10:40:07PM +0500, Mihail Konev wrote:
> It is worth noting, that it was not ld.bfd that scanning in one
> direction, but rather ld.gold ignoring the --as-needed flag
> (which, at the time of testing, was built-in into gcc -dumpspecs).
>
> Reproducible-by: ma
On Thu, Feb 02, 2017 at 10:40:07PM +0500, Mihail Konev wrote:
> It is worth noting, that it was not ld.bfd that scanning in one
:) , please edit
___
xorg-devel@lists.x.org: X.Org development
Archi
Regressed-in: bb9128fd ("present: disable page flip")
Signed-off-by: Mihail Konev
---
Maybe there should be #ifdef-s instead - I only bisected :)
randr/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/randr/Makefile.am b/randr/Makefile.am
index 90dc9ec9aac4..90aa1289f
On Fri, Feb 03, 2017 at 10:08:03AM +0900, Michel Dänzer wrote:
> On 03/02/17 06:57 AM, Mihail Konev wrote:
> > Regressed-in: bb9128fd ("present: disable page flip")
> > Signed-off-by: Mihail Konev
> > ---
> > Maybe there should be #ifdef-s instead - I only bi
On Fri, Feb 03, 2017 at 10:08:03AM +0900, Michel Dänzer wrote:
> On 03/02/17 06:57 AM, Mihail Konev wrote:
> > Regressed-in: bb9128fd ("present: disable page flip")
> > Signed-off-by: Mihail Konev
> > ---
> > Maybe there should be #ifdef-s instead - I only bi
On Mon, Jan 16, 2017 at 02:47:26PM -0500, Adam Jackson wrote:
> On Sat, 2017-01-14 at 15:19 +0500, Mihail Konev wrote:
> > Commit ead5064581665ff40c177dd1b447949f1420e209 missed that xi1/
> > and xi2/ were conditioned on XORG, and made xfree86-only tests to be
> > built uncon
; this broke
in e50da50118408a195d4d2e1b39817fe7c4447c56.
Somehow this does not result in multiple definition errors.
Fixes: 3ef16dfb ("dmx: fix linking")
Reported-by: Byeong-ryeol Kim
Signed-off-by: Mihail Konev
---
This requires 3ef16dfb to be reverted first.
Seems to be a sufficient "emulation" of lib
On Thu, Feb 09, 2017 at 10:48:14AM +0500, Mihail Konev wrote:
> this patch looks to be making more sense than per-OS adjustments
(In the sense it does record "A depends on B", whereas reordering does
not, while being a "per-OS-adjustment" too).
_
original RANDR with RENDER or also PRESENT as
"...LIBDIX... PRESENT RANDR RENDER ..." would give the original
HashGlyph error.
Regressed-in: 3ef16dfb ("dmx: fix linking")
Suggested-by: Michel Dänzer
Reported-by: Byeong-ryeol Kim
Signed-off-by: Mihail Konev
---
I was probably
On Thu, Feb 09, 2017 at 11:16:20AM +0500, Mihail Konev wrote:
> per-OS-adjustments
Sorry for the screaming; it was not OS/toolchain, but
./configure --enable-dmx --with-dtrace=no
With it, there are no custom-built os.O/dix.O, and libtool
does not reorder them in front of everything else
in configure, not in every makefile.
Tests seemed to work the visibility around by appending libos.la;
do it unconditionally.
For Xdmx, also revert the now-errorneous 3ef16dfb ("dmx: fix linking").
Fixes: 49a26681 ("Add DTrace probe points")
Fixes: 3ef16dfb ("dmx: fix linking&
Tiny portability addition:
diff --git a/configure.ac b/configure.ac
index efe38883125b..9310160c8b7a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -73,6 +73,7 @@ dnl version-config.h covers the version numbers so they can
be bumped without
dnl forcing an entire recompile.x
AC_CONFIG_HEADERS(i
: 49a26681 ("Add DTrace probe points")
Fixes: 3ef16dfb ("dmx: fix linking")
Reported-by: Byeong-ryeol Kim
Signed-off-by: Mihail Konev
---
Simpler fix that does the same no-*.O, but another way.
(Forgot to mention the libtool's move of .O in the previous patch).
This does a
lso remove dtrace lib from dix/, as only the os/ one was used.
Fixes: 49a26681 ("Add DTrace probe points")
Fixes: 3ef16dfb ("dmx: fix linking")
Reported-by: Byeong-ryeol Kim
Signed-off-by: Mihail Konev
---
v2:
- remove dtrace lib
- fix the with-dtrace build for tests, as done i
Cyrillic combinations mirror the Qwerty-Jcuken keyboard layout.
Also add Cyrillic sequences for hryvnia sign.
Submitted-by: Victor V. Kustov
Reviewed-by: Victor V. Kustov
Signed-off-by: Mihail Konev
---
v6:
Follow Victor's suggestions:
Change "=" to "-".
Do not to
Log of searching for "ld -r" attached, in case it is of any help.
On Fri, Feb 10, 2017 at 10:47:29AM +0500, Mihail Konev wrote:
>
> The dtrace-in-a-separate-dir is preferrable, IMO:
> - allows for another dtrace-like additional-objects-compiler
> - cleaner makefile
> - s
Changing the To: field unintendedly changed recipients, so resending
this as a notification, even through it becomes quite a flood.
On Sat, Feb 11, 2017 at 04:15:19AM +0500, Mihail Konev wrote:
> Log of searching for "ld -r" attached, in case it is of any help.
>
> On Fri, Fe
igure --enable-dmx --with-dtrace=no" build.
Fixes: 49a26681 ("Add DTrace probe points")
Fixes: 3ef16dfb ("dmx: fix linking")
Reported-by: Byeong-ryeol Kim
Signed-off-by: Mihail Konev
---
Compatible with Solaris, adds comments about ld.
Not --disable-xorg ready.
co
Previously, if sdksyms.sh was failing, the incorrect sdksyms.c
would stay, breaking subsequent build attempts.
Signed-off-by: Mihail Konev
---
Needed this on Solaris due to missing awk -> gawk symlink.
hw/xfree86/Makefile.am | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
d
bilities.
This fixes the "autoreconf -i" warnings.
Automake cannot (re)generate per-object '.Plo' makefile that records
the dependencies, if it is in another dir (now that the .Plo is in a
'subdirectory', i.e. ../xyz dir).
Work this around by symlinking the source files.
On Fri, Feb 17, 2017 at 04:08:45AM +0500, Mihail Konev wrote:
> Don't know whether mi/miinitext.c is better #included instead,
> sending as-is.
>
They are all probably better included instead.
___
xorg-devel@lists.x.org: X.Org develo
On Mon, Feb 13, 2017 at 11:01:39PM -0800, Alan Coopersmith wrote:
> > On 02/ 9/17 09:47 PM, Mihail Konev wrote:
> >> Libtool was moving the *.O libraries in front of all others on
> >> the gcc command line, which was necessiating "ld -r"
> >> (so that s
On Sat, Feb 18, 2017 at 01:24:19PM +0500, Mihail Konev wrote:
> On Mon, Feb 13, 2017 at 11:01:39PM -0800, Alan Coopersmith wrote:
> > > On 02/ 9/17 09:47 PM, Mihail Konev wrote:
> > >> Libtool was moving the *.O libraries in front of all others on
> > >
On Tue, Feb 21, 2017 at 05:48:19PM +0100, walter harms wrote:
> >
>
> XSyncValueSubtract is doing as expected,
> XSyncValue is the simulation of 64bitvalues on 32bit.
> see this in hex:
> 10001
> -2
> 0 = 4294967295 in .lo
>
Kind of - it errorneously returns
1
On Wed, Feb 22, 2017 at 12:28:19AM +0500, Mihail Konev wrote:
>
> Kind of - it errorneously returns
>
> 1 0001
> -0 0002
> 1
>
Oh.
This shouldn't matter in this case, as only is used.
Offtop, sorry.
Mihail
__
On Wed, Feb 22, 2017 at 12:28:19AM +0500, Mihail Konev wrote:
>
> E.g. there is a typo in XSyncValue.lo definition - it should be uint
> instead.
Also wrong, the entire post was wrong, it was typo in my source.
Mihail
___
xorg-devel@lists.x.o
Regressed-in: 39c548da0cf0522ad246630605b96751ab6d39c0
Signed-off-by: Mihail Konev
---
This fixes out-of-source XQuartz build.
hw/xquartz/Makefile.am | 2 +-
hw/xquartz/xpr/Makefile.am | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/xquartz/Makefile.am b/hw/xquartz
Signed-off-by: Mihail Konev
---
This allows running "make distcheck" as a non-root.
(Although the resulting DESTDIR includes the path to source tree *twice* ;)
hw/xquartz/mach-startup/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xquartz/ma
Signed-off-by: Mihail Konev
---
Not that this matters, but makes the distcheck not to fail.
hw/xfree86/Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am
index 85bd0bed0e58..00f0ee116d68 100644
--- a/hw/xfree86/Makefile.am
+++ b/hw
Extracted from "[Patchset] Single makefile".
Mihail Konev (7):
configure.ac: only stub sdksyms.dep as needed
sdksyms: fix export word indexing
hw/xfree86: add suid wrapper to uninstall target
hw/xquartz: add missing destdir
hw/xquartz: fix path to pseudoramiX headers
Fixes the file not being cleaned with --disable-xorg.
Signed-off-by: Mihail Konev
---
This is for "make distcheck" not to fail after adding "--disable-xorg" to
DISTCHECK_CONFIGURE_FLAGS in Makefile.am.
configure.ac | 4 +++-
1 file changed, 3 insertions(+), 1 delet
Mihail Konev (7):
configure.ac: only stub sdksyms.dep as needed
sdksyms: fix export word indexing
hw/xfree86: add suid wrapper to uninstall target
hw/xquartz: add missing destdir
hw/xquartz: fix path to pseudoramiX headers
os-support/solaris: add asm to gitignore
configure.ac: use
Signed-off-by: Mihail Konev
---
hw/xfree86/os-support/solaris/.gitignore | 1 +
1 file changed, 1 insertion(+)
create mode 100644 hw/xfree86/os-support/solaris/.gitignore
diff --git a/hw/xfree86/os-support/solaris/.gitignore
b/hw/xfree86/os-support/solaris/.gitignore
new file mode 100644
Introduced-in: b1dac41fb3853ca8182048ea57b88b6e84ecceb3
Releaved-in: 3dad57b121fdf001e75fffa7e3007a9a0a154f67
Signed-off-by: Mihail Konev
---
No comment.
I beleive this to be fixing https://bugs.freedesktop.org/show_bug.cgi?id=100048
It also fixes build on Solaris and NetBSD, and so is probably
put where the source is, not the makefile),
thus retaining the CFLAGS and other settings as before.
Explicitly distribute hw/xfree86/os-support/shared/, as other dirs
now wouldn't do that implicitly by referencing source files from it.
Signed-off-by: Mihail Konev
---
This adds one new fil
This was originally done in order to use subdir-objects to prevent automake
warnings (I didn't have the idea of .include.c files at the moment).
Here for rather illustrative purposes, as well as benchmarking against the
meson.
Makes moving the library assignments out of configure.ac for speed of
sim2.txz
Description: Binary data
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
as defined
here
os/Makefile.am:2: while processing program 'os.O'
Rebase upon fde5cd78 ("tests: Fix guards for ld -wrap") to be safe (no
change).
Reword.
Fixes "./configure --enable-dmx --with-dtrace=no" build.
Reported-by: Byeong-ryeol Kim
Fixes: 3e
y: Byeong-ryeol Kim
Fixes: 3ef16dfb ("dmx: fix linking")
Fixes: 49a26681 ("Add DTrace probe points")
Signed-off-by: Mihail Konev
---
configure.ac| 9 ++---
dix/Makefile.am | 13 +++--
os/Makefile.am | 13 -
3 files changed, 17 insertions(+), 18
Cyrillic combinations mirror the Qwerty-Jcuken keyboard layout.
Add also sequences for hryvnia sign.
Un-clash the dead_currency screwed up (me) in d9e340613077.
Submitted-by: Victor V. Kustov
Build-tested-by: Jon Turney
Signed-off-by: Mihail Konev
---
nls/en_US.UTF-8/Compose.pre | 14
Signed-off-by: Mihail Konev
---
nls/Makefile.am | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/nls/Makefile.am b/nls/Makefile.am
index 57665fff4282..c0f0d0c7181f 100644
--- a/nls/Makefile.am
+++ b/nls/Makefile.am
@@ -24,7 +24,7 @@ locale.alias
Signed-off-by: Mihail Konev
---
nls/Makefile.am | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/nls/Makefile.am b/nls/Makefile.am
index 0c544f6cf88f..57665fff4282 100644
--- a/nls/Makefile.am
+++ b/nls/Makefile.am
@@ -44,9 +44,13 @@ endif HAVE_PERL
# Per-locale
This performs verification "on change", and prints errors out.
Before, it was "make check; cat nls/test-suite.log".
Mihail Konev (2):
nls: Factor out the lists of locale files
nls: Verify Compose at build
nls/Makefile.am | 26 +-
1 file changed,
Fixes out-of-source XQuartz build.
Fixes: 39c548da ("XQuartz: Fix build with moved pseudoramiX")
Signed-off-by: Mihail Konev
---
v2: Reword. Add missing Cc.
hw/xquartz/Makefile.am | 2 +-
hw/xquartz/xpr/Makefile.am | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
Fixes --enable-suid-wrapper distcheck.
Signed-off-by: Mihail Konev
---
v2: Add missing ifdef. Reword.
hw/xfree86/Makefile.am | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am
index 85bd0bed0e58..9e1b58485764 100644
--- a/hw/xfree86
le:670: recipe for target 'posix_tty.include.lo' failed
make: *** [posix_tty.include.lo] Error 1
Mihail Konev (7):
configure.ac: only stub sdksyms.dep as needed
sdksyms: fix typo in export keyword index
hw/xfree86: add suid wrapper to uninstall target
configure.ac: add missing xquartz destdir
the build breaks.
Fixes: b1dac41f ('Use libtool convenience libraries and better "symbol" table')
Signed-off-by: Mihail Konev
---
v2: Figure out what exactly happens. Reword.
hw/xfree86/sdksyms.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/x
Signed-off-by: Mihail Konev
---
hw/xfree86/os-support/solaris/.gitignore | 1 +
1 file changed, 1 insertion(+)
create mode 100644 hw/xfree86/os-support/solaris/.gitignore
diff --git a/hw/xfree86/os-support/solaris/.gitignore
b/hw/xfree86/os-support/solaris/.gitignore
new file mode 100644
put where the source is, not the makefile),
thus retaining the CFLAGS and other settings as before.
Explicitly distribute hw/xfree86/os-support/shared/, as other dirs
now wouldn't do that implicitly by referencing source files from it.
Signed-off-by: Mihail Konev
---
v2: fix empty line i
Fixes DESTDIR not being included in x11appdir, allowing to run distcheck
as non-root.
Signed-off-by: Mihail Konev
---
v2: Move DESTDIR to configure. Add missing Cc.
configure.ac | 4 ++--
hw/xquartz/bundle/Makefile.am | 8
2 files changed, 6 insertions(+), 6 deletions
Fixes the file not being cleaned with --disable-xorg, for such a
distcheck not to fail.
Signed-off-by: Mihail Konev
---
v2: Reword.
configure.ac | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index ac11e65728e8..3196e42df16a 100644
--- a
ly preferrable, at least
because configure does not currently contain any DESTDIR occurences.
> Reviewed-by: Jeremy Sequoia
>
> > On Apr 4, 2017, at 4:49 PM, Mihail Konev wrote:
> >
> > Fixes DESTDIR not being included in x11appdir, allowing to run distcheck
> > as no
On Wed, Apr 05, 2017 at 04:49:39AM +0500, Mihail Konev wrote:
> v2 (Emil Velikov):
> 2/7: Figure out what exactly happens.
> 3/7: Add missing ifdef.
> 5/7: Move DESTDIR to configure.
>Add missing Cc.
> 1-5/7: Reword.
>
> The 7/7 has also been suggeste
c41f ('Use libtool convenience libraries and better "symbol" table')
Signed-off-by: Mihail Konev
---
v2a: Fix GCC 4 paragraph: "when extern and type are on the same line" ->
"expansion is put on a single line".
hw/xfree86/sdksyms.sh | 2 +-
1 file change
On Thu, Apr 06, 2017 at 05:14:22AM +0500, Mihail Konev wrote:
>
> v2a: Fix GCC 4 paragraph: "when extern and type are on the same line" ->
> "expansion is put on a single line".
>
v2 was the correct one, sorry.
Wrongly assumed there are no declaratio
On Thu, Apr 06, 2017 at 09:37:02PM +0300, Ran Benita wrote:
> On Sun, Apr 02, 2017 at 10:27:28PM +0500, Mihail Konev wrote:
> > Signed-off-by: Mihail Konev
> > ---
> > nls/Makefile.am | 18 +++---
> > 1 file changed, 11 insertions(+), 7 deletions(-
101 - 168 of 168 matches
Mail list logo
