Re: how to turn source code into debian compatible driver

2014-04-24 Thread Pekka Paalanen
On Wed, 23 Apr 2014 15:23:52 + James Robb ja...@gearedinteractive.ca wrote: Hello, I have download this file: http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/snapshot/xf86-input-synaptics-1.7.99.1.tar.gz under the impression it is the packaged code I need to compile the

Re: [PATCH] present: Queue flips for later execution. Begging for review.

2014-06-04 Thread Pekka Paalanen
On Tue, 03 Jun 2014 20:08:21 -0700 Keith Packard kei...@keithp.com wrote: Michel Dänzer mic...@daenzer.net writes: At least the waiting for the pixmap to become idle part should be perfectly possible in the X server? One of three possible ways: 1) Blocking kernel call waiting for

Re: [PATCH] present: Queue flips for later execution. Begging for review.

2014-06-04 Thread Pekka Paalanen
On Wed, 04 Jun 2014 10:39:18 +0200 Christian König deathsim...@vodafone.de wrote: Am 04.06.2014 09:03, schrieb Pekka Paalanen: On Tue, 03 Jun 2014 20:08:21 -0700 Keith Packard kei...@keithp.com wrote: Michel Dänzer mic...@daenzer.net writes: At least the waiting for the pixmap

Re: [PATCH] modesetting: Support native primary plane rotation

2014-07-09 Thread Pekka Paalanen
On Wed, 9 Jul 2014 08:00:21 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: With the advent of universal drm planes and the introduction of generic plane properties for rotations, we can query and program the hardware for native rotation support. NOTE: this depends upon the next release

Re: [PATCH] modesetting: Support native primary plane rotation

2014-07-09 Thread Pekka Paalanen
of libdrm to remove one opencoded define. v2: Use enum to determine primary plane, suggested by Pekka Paalanen. Use libobj for replacement ffs(), suggested by walter harms Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Pekka Paalanen ppaala...@gmail.com Cc: walter harms wha

Re: [PATCH] modesetting: Support native primary plane rotation

2014-07-10 Thread Pekka Paalanen
On Wed, 9 Jul 2014 11:02:59 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: On Wed, Jul 09, 2014 at 12:57:12PM +0300, Pekka Paalanen wrote: On Wed, 9 Jul 2014 09:19:08 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: With the advent of universal drm planes and the introduction

What use do swap interval 1 and OML_sync_control divisor and remainder have?

2014-01-24 Thread Pekka Paalanen
Hi, I am investigating what kind of Wayland protocol extensions would be needed to support proper presentation timing. Looking at existing works, I am wondering about two things whether they have any real use. Where is swap interval (e.g. eglSwapInterval) greater than one useful? Intervals 0 and

Re: [Mesa-dev] What use do swap interval 1 and OML_sync_control divisor and remainder have?

2014-01-28 Thread Pekka Paalanen
Hi Ian and Jason On Mon, 27 Jan 2014 12:26:23 -0700 Ian Romanick i...@freedesktop.org wrote: On 01/24/2014 04:32 AM, Pekka Paalanen wrote: Hi, I am investigating what kind of Wayland protocol extensions would be needed to support proper presentation timing. Looking at existing works

Re: misc fixes for VC4

2015-01-04 Thread Pekka Paalanen
On Sat, 3 Jan 2015 16:10:21 -0500 Rob Clark robdcl...@gmail.com wrote: On Sat, Jan 3, 2015 at 12:35 PM, Keith Packard kei...@keithp.com wrote: Rob Clark robdcl...@gmail.com writes: hmm, what minimum gl and gles version do we need to expose instanced drawing? Or any other useful

Re: [PATCH xwayland] xwayland: implement repeat_info event

2015-08-17 Thread Pekka Paalanen
On Mon, 17 Aug 2015 11:37:37 +0200 Marek Chalupa mchqwe...@gmail.com wrote: xwayland windows ignored any key repeating settings advertised by a compositor Signed-off-by: Marek Chalupa mchqwe...@gmail.com --- hw/xwayland/xwayland-input.c | 34 -- 1 file

Re: [PATCH v3 xwayland] xwayland: implement repeat_info event

2015-08-20 Thread Pekka Paalanen
On Thu, 20 Aug 2015 07:43:51 +0200 Marek Chalupa mchqwe...@gmail.com wrote: xwayland windows ignored any key repeating settings advertised by a compositor v2. don't hardcode version 4 of seat use AutoRepeatModeOn/Off v3. use min(version, 4) when binding seat Signed-off-by: Marek

Re: [PATCH v2 xwayland] xwayland: implement repeat_info event

2015-08-19 Thread Pekka Paalanen
On Wed, 19 Aug 2015 11:00:09 +0200 Marek Chalupa mchqwe...@gmail.com wrote: xwayland windows ignored any key repeating settings advertised by a compositor v2. don't hardcode version 4 of seat use AutoRepeatModeOn/Off Signed-off-by: Marek Chalupa mchqwe...@gmail.com ---

Re: List display device names

2015-11-11 Thread Pekka Paalanen
On Wed, 11 Nov 2015 22:06:12 + Emil Velikov wrote: > Hi Tom, > > On 11 November 2015 at 13:31, Tom Deseyn wrote: > > Hi all, > > > > To configure X I need to know the display device names (e.g. DFP-0). I get > > these by looking at the

Re: [PATCH 1/2] xwayland: Update screen size on output removal

2015-11-15 Thread Pekka Paalanen
On Fri, 13 Nov 2015 17:57:22 +0100 Olivier Fourdan wrote: > When unplugging an output, it's still listed in xrandr and the size > of the root window still includes the removed output. > > The XRandR output should be destroyed when its Wayland counterpart is > destroyed and

Re: annarchy disk space

2015-10-14 Thread Pekka Paalanen
On Wed, 14 Oct 2015 01:31:58 -0700 Jeremy Huddleston Sequoia wrote: > I noticed some errors in my git post commit hooks just now. It looks like > annarchy is out of space on / > > $ git push -f... > remote: mail: /tmp/mail.Rs7Ah02H: No space left on device > >

Re: State of Wayland

2015-09-18 Thread Pekka Paalanen
On Thu, 17 Sep 2015 10:27:13 -0400 (EDT) Olivier Fourdan wrote: > Hi Bryce, > > cc'ing xorg-devel as well, see below, I would like to help with xwayland. > > - Original Message - > > I've assembled a blog post with a run-down of our current status on > > Wayland -

Re: [PATCH] xserver: Fix configure.ac check for libsystemd/-daemon

2015-12-03 Thread Pekka Paalanen
if libsystemd-daemon is > available]) > - REQUIRED_LIBS="$REQUIRED_LIBS libsystemd-daemon" > + REQUIRED_LIBS="$REQUIRED_LIBS $systemd_daemon_lib" > fi > AM_CONDITIONAL([HAVE_SYSTEMD_DAEMON], [test "x$HAVE_SYSTEMD_DAEMON" = >

Re: [PATCH xserver 1/5] glamor: Handle GL_OUT_OF_MEMORY when allocating texture images.

2015-11-18 Thread Pekka Paalanen
On Wed, 18 Nov 2015 09:57:02 -0800 Eric Anholt wrote: > Keith Packard writes: > > > Eric Anholt writes: > > > >> I think it's a safe enough assumption that we're not generating non-OOM > >> errors. And, now that we're logging errors, we

Re: [PATCH xserver 2/2] xwayland: Call eglBindAPI after eglInitialize

2016-06-03 Thread Pekka Paalanen
egl_display, , )) { > ErrorF("eglInitialize() failed\n"); > return; > } > > +eglBindAPI(EGL_OPENGL_API); > + > version = eglQueryString(xwl_screen->egl_display, EGL_VERSION); > ErrorF("glamor: EGL version %s:\n", v

Re: [PATCH] xwayland: Use drm buffers for cursors if available

2016-02-05 Thread Pekka Paalanen
On Thu, 4 Feb 2016 18:10:04 +0100 Rui Matos wrote: > This should be both more efficient and avoid the file descriptor > exhaustion issue that can happen with shm buffers if we're asked to > realize more cursors than the file descriptor limit. > > Signed-off-by: Rui Matos

Re: [PATCH] xwayland: Use drm buffers for cursors if available

2016-02-05 Thread Pekka Paalanen
On Fri, 5 Feb 2016 13:13:16 +0100 Rui Tiago Cação Matos <tiagoma...@gmail.com> wrote: > On Fri, Feb 5, 2016 at 9:42 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: > > Btw. Rui, is there a reason to keep the shm pool fd open after a > > wl_buffer has been created from

Re: [PATCH] xwayland: Close the shm fd as early as possible

2016-02-05 Thread Pekka Paalanen
o that > we can destroy the shm pool and close the fd before being asked to > create more. > --- > > On Fri, Feb 5, 2016 at 1:53 PM, Pekka Paalanen <ppaala...@gmail.com> wrote: > > You don't need the fd or the pool to write into the buffer, or attach > > and

Re: [PATCH] xwayland: Only request cursor frame events if the surface is visible

2016-02-03 Thread Pekka Paalanen
On Tue, 2 Feb 2016 21:06:33 +0100 Rui Matos wrote: > If the wayland compositor hides our cursor surface (e.g. because the > pointer moved over a different wayland client) before our last > submitted buffer gets a chance to be displayed, no frame event will be > sent and

Re: [PATCH] xwayland: Clear pending cursor frame callbacks on pointer enter

2016-02-04 Thread Pekka Paalanen
so that we can > continue submitting new cursor frames. > > Signed-off-by: Rui Matos <tiagoma...@gmail.com> > --- > > On Wed, Feb 3, 2016 at 9:30 AM, Pekka Paalanen <ppaala...@gmail.com> wrote: > > Xwayland commits a wl_buffer to a cursor wl_surface with a frame > &

Re: Which version x.org xserver got rid of ClockRanges?

2016-02-15 Thread Pekka Paalanen
On Tue, 16 Feb 2016 05:48:26 +0100 "Kevin Brace" wrote: > Hi, > > I just want some clarifications on ClockRange and ClockRanges. > I will like to know which version of x.org xserver got rid of > ClockRanges type. I was compiling OpenChrome on Ubuntu and Lubuntu > 10.04, and

Re: Which version x.org xserver got rid of ClockRanges?

2016-02-19 Thread Pekka Paalanen
On Tue, 16 Feb 2016 23:12:27 +0100 "Kevin Brace" <kevinbr...@gmx.com> wrote: > Hi Pekka, > > Can I include your name in the commit I will put into OpenChrome shortly? > It will look like this. > > Suggested-by: Pekka Paalanen <"Your e-mail">

Re: Proposal for Anti-Keystroke Fingerprinting at the Display Server Level

2016-03-24 Thread Pekka Paalanen
On Wed, 23 Mar 2016 23:49:03 +0100 ban...@openmailbox.org wrote: > == Attack Description == > > Keystroke fingerprinting works by measuring how long keys are pressed > and the time between presses. Its very high accuracy poses a serious > threat to anonymous users.[1] > > This tracking

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

2016-03-08 Thread Pekka Paalanen
On Tue, 8 Mar 2016 11:08:45 +0100 Hans de Goede <hdego...@redhat.com> wrote: > Hi, > > On 08-03-16 10:15, Pekka Paalanen wrote: > > On Mon, 7 Mar 2016 19:25:54 +0100 > > Hans de Goede <hdego...@redhat.com> wrote: > > > >> Hi, > >>

Re: [PATCH xserver 0/2] RFC: Sync key repeat with Wayland compositor

2016-03-08 Thread Pekka Paalanen
On Mon, 7 Mar 2016 19:25:54 +0100 Hans de Goede wrote: > Hi, > > On 07-03-16 19:23, Hans de Goede wrote: > > Hi, > > > > On 07-03-16 18:44, Olivier Fourdan wrote: > >> Key repeat is handled by the X server, but for Wayland, the key > >> press/release events need to be

Re: [PATCH rendercheck 3/5] Use ELF sections to make test setup easier.

2016-04-04 Thread Pekka Paalanen
On Sun, 03 Apr 2016 01:20:41 -0700 Jeremy Huddleston Sequoia wrote: > The use of __attribute(section()), __start_test_section, and > __stop_test_section is not portable. Could you please follow this up > with a change that allows rendercheck to continue to function on >

Re: [xserver-xorg][PATCH 1/1] xwayland: ftruncate if posix_fallocate fails

2016-04-25 Thread Pekka Paalanen
On Mon, 25 Apr 2016 15:47:09 +0300 Ian Ray wrote: > On a slow system that is configured with SMART_SCHEDULE_POSSIBLE, large > posix_fallocate() requests may be interrupted by the SmartScheduleTimer > (SIGALRM) continuously. Fallback to ftruncate if posix_fallocate fails. > >

Re: [xserver-xorg][PATCH 1/1] xwayland-shm: block signals during fallocate

2016-04-28 Thread Pekka Paalanen
nonymous_file(off_t size) > return -1; > > #ifdef HAVE_POSIX_FALLOCATE > +OsBlockSignals(); > do { > ret = posix_fallocate(fd, 0, size); > } while (ret == EINTR); > +OsReleaseSignals(); > > if (ret != 0) { > close

Re: [xserver-xorg][PATCH 1/1] xwayland: ftruncate if posix_fallocate fails

2016-04-26 Thread Pekka Paalanen
On Tue, 26 Apr 2016 15:58:47 +0300 Ian Ray <ian@ge.com> wrote: > On Mon, Apr 25, 2016 at 04:49:07PM +0300, Pekka Paalanen wrote: > > On Mon, 25 Apr 2016 15:47:09 +0300 > > Ian Ray <ian@ge.com> wrote: > > > > > On a slow system that is conf

Re: [PATCH xwayland] xwayland-shm: fortify fallocate against EINTR

2016-04-25 Thread Pekka Paalanen
On Mon, 25 Apr 2016 11:33:00 +0200 Marek Chalupa wrote: > If posix_fallocate or ftruncate is interrupted by signal > while working, we return -1 as fd and the allocation process > returns BadAlloc error. That causes xwayland clients to abort > with 'BadAlloc (insufficient

Re: [PATCH xwayland] xwayland-shm: fortify fallocate against EINTR

2016-04-25 Thread Pekka Paalanen
On Mon, 25 Apr 2016 15:56:58 +0300 Ian Ray <ian@ge.com> wrote: > On Mon, Apr 25, 2016 at 02:40:31PM +0200, Marek Chalupa wrote: > > > > On 04/25/16 12:20, Pekka Paalanen wrote: > > > On Mon, 25 Apr 2016 11:33:00 +0200 > > > Ma

Re: [xserver-xorg][PATCH 1/1] xwayland: ftruncate if posix_fallocate fails

2016-04-26 Thread Pekka Paalanen
On Tue, 26 Apr 2016 16:46:03 +0200 (CEST) Mark Kettenis <mark.kette...@xs4all.nl> wrote: > > Date: Tue, 26 Apr 2016 15:58:47 +0300 > > From: Ian Ray <ian@ge.com> > > > > On Mon, Apr 25, 2016 at 04:49:07PM +0300, Pekka Paalanen wrote: > > > On

Re: [PATCH xserver 1/2] xwayland: Move sprite invalidation logic into mipointer

2016-05-19 Thread Pekka Paalanen
changed, 22 insertions(+), 8 deletions(-) Hi, FWIW as I'm so not familiar with Xserver code nor even compile-tested this, but still looks good to me: Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> for both patches. Thanks, pq > diff --git a/hw/xwayland/xwayland-input.c b

Re: [xserver-xorg][PATCH V2 1/1] xwayland-shm: block signals during fallocate

2016-05-25 Thread Pekka Paalanen
on > + * slow systems where the smart scheduler's SIGALRM prevents > + * large allocation attempts from ever succeeding. > + */ > +OsBlockSignals(); > do { > ret = posix_fallocate(fd, 0, size); > } while (ret == EINTR); > +OsR

Re: [PATCH xserver] xwayland: Update RR state on wl_output.done instead of wl_output.mode

2016-07-15 Thread Pekka Paalanen
On Wed, 13 Jul 2016 19:19:09 +0200 Rui Matos wrote: > Otherwise if the geometry changes but the mode doesn't we end up with > the previous geometry from RR's point of view. > > Fixes https://bugzilla.gnome.org/show_bug.cgi?id=768710 > > Signed-off-by: Rui Matos

Re: [PATCH libX11] XFree will accept NULL as argument

2016-08-16 Thread Pekka Paalanen
On Tue, 16 Aug 2016 11:56:50 +0100 Eric Engestrom wrote: > On Mon, Aug 15, 2016 at 07:18:14PM +0200, walter harms wrote: > > since Xfree is a define for free() > > Xlibint.h:#define Xfree(ptr) free((ptr)) > > > > Xfree will accept NULL and do nothing. > > > > the

Re: [PATCH libX11] XFree will accept NULL as argument

2016-08-16 Thread Pekka Paalanen
On Tue, 16 Aug 2016 17:49:24 +0300 Pekka Paalanen <ppaala...@gmail.com> wrote: > On Tue, 16 Aug 2016 11:56:50 +0100 > Eric Engestrom <eric.engest...@imgtec.com> wrote: > > > On Mon, Aug 15, 2016 at 07:18:14PM +0200, walter harms wrote: > > > since Xfree is a

Re: [PATCH xserver] xwayland: replace hardcoded function name with __func__ in error msg

2017-02-06 Thread Pekka Paalanen
> xwl_output = calloc(1, sizeof *xwl_output); > if (xwl_output == NULL) { > -ErrorF("create_output ENOMEM\n"); > +ErrorF("%s ENOMEM", __func__); > return NULL; > } > Reviewed-by: Pekka Paalanen <pekka.paala...@col

Re: [PATCH v7 xserver] tests: fixes for non-enable-xorg build

2017-02-17 Thread Pekka Paalanen
On Tue, 31 Jan 2017 20:16:35 +0500 Mihail Konev wrote: > v7: add regressed-by lines Hi, current xserver master branch fails for me using: ./configure --disable-docs --disable-devel-docs --enable-xwayland --disable-{xorg,xvfb,xnest,xquartz,xwin} --enable-debug xfree86.c:30:18:

Re: [PATCH xserver v2 5/5] xwayland: use _XWAYLAND_ALLOW_COMMITS property

2017-02-17 Thread Pekka Paalanen
On Thu, 19 Jan 2017 12:28:02 +0200 Pekka Paalanen <ppaala...@gmail.com> wrote: > On Wed, 18 Jan 2017 10:42:22 -0500 (EST) > Olivier Fourdan <ofour...@redhat.com> wrote: > > > Hi Pekka, > > > > - Original Message - > > > h

Re: [PATCH xserver v2 5/5] xwayland: use _XWAYLAND_ALLOW_COMMITS property

2017-01-19 Thread Pekka Paalanen
On Wed, 18 Jan 2017 10:42:22 -0500 (EST) Olivier Fourdan wrote: > Hi Pekka, > > - Original Message - > > here is an update on the Weston side: > > https://lists.freedesktop.org/archives/wayland-devel/2017-January/032712.html > > > > The related Weston patches

[PATCH xserver v3 5/5] xwayland: use _XWAYLAND_ALLOW_COMMITS property

2017-01-17 Thread Pekka Paalanen
From: Pekka Paalanen <pekka.paala...@collabora.co.uk> The X11 window manager (XWM) of a Wayland compositor can use the _XWAYLAND_ALLOW_COMMITS property to control when Xwayland sends wl_surface.commit requests. If the property is not set, the behaviour remains what it was. XWM uses the pr

Re: [PATCH xserver v2 5/5] xwayland: use _XWAYLAND_ALLOW_COMMITS property

2017-01-18 Thread Pekka Paalanen
On Thu, 12 Jan 2017 16:27:10 +0200 Pekka Paalanen <ppaala...@gmail.com> wrote: > On Tue, 3 Jan 2017 04:31:39 -0500 (EST) > Olivier Fourdan <ofour...@redhat.com> wrote: > > > Hi, > > > > - Original Message - > > > On Fri,

Re: [RFC PATCH xserver] xwayland: RFC Disable glamor with an env var?

2017-03-02 Thread Pekka Paalanen
On Wed, 1 Mar 2017 17:45:11 +0100 Olivier Fourdan wrote: > Hi all, > > I am seeing quite a few Xwayland crashes related to glamor. > > Various issues, could be with glamor itself or with the drivers (like the > issues I witness with nv30), whatever. > > To investigate

Re: [RFC PATCH xserver] xwayland: RFC Disable glamor with an env var?

2017-03-02 Thread Pekka Paalanen
On Thu, 2 Mar 2017 05:47:10 -0500 (EST) Olivier Fourdan wrote: > Hi Pekka, > > > I understand the attractiveness of adding an override, bypassing the > > compositors like this. But, essentially it is just that: a > > configuration bypass. > > True. > > > I would prefer

Re: weird Xwayland and compositor deadlock issue [WAS: [PATCH xserver v2] xwayland: handle EAGAIN and EINTR gracefully]

2016-09-14 Thread Pekka Paalanen
On Tue, 13 Sep 2016 12:04:14 -0400 (EDT) Olivier Fourdan wrote: > Hi Pekka, > > - Original Message - > > Hi Olivier, > > > > I don't have any solution for you. The interactions between the Wayland > > compositor and Xwayland are known to be very easily deadlockable

Re: [PATCH xserver v3] xwayland: handle EAGAIN on Wayland fd

2016-09-15 Thread Pekka Paalanen
On Wed, 14 Sep 2016 18:20:10 +0200 Olivier Fourdan wrote: > wl_display_flush() can fail with EAGAIN and Xwayland would make this a > fatal error. > > When this happens, it means that Xwayland has flooded the Wayland file > descriptor, either because the Wayland compositor

Re: weird Xwayland and compositor deadlock issue [WAS: [PATCH xserver v2] xwayland: handle EAGAIN and EINTR gracefully]

2016-09-19 Thread Pekka Paalanen
n > timestamps, and I doubt we can fix that without breaking multiple, multiple > clients. > > The only thing I can think of for that is, again, the Wayland-in-X11 > solution: an X11 extension that delivers the timestamp with every response > and event from the server so we don't block on a

Re: [PATCH xserver] configure: Enable glamor when building just Xwayland

2016-11-23 Thread Pekka Paalanen
t; = xyes; then > - GLAMOR=yes > - fi > - if test "x$XEPHYR" = xyes; then > + if echo "$XORG" "$XEPHYR" "$XWAYLAND" | grep -q yes ; then > GLAMOR=yes > fi > fi Hi Adam, thanks for th

[PATCH xserver] xwayland: fix order of calloc() args

2016-11-22 Thread Pekka Paalanen
From: Pekka Paalanen <pekka.paala...@collabora.co.uk> The definition by the manual is: calloc(size_t nmemb, size_t size) Swap the arguments of calloc() calls to be the right way around. Presumably this makes no functional difference, but better follow the spec. Signed-off-by:

Re: [PATCH wayland] doc: start documenting Xwayland

2016-11-22 Thread Pekka Paalanen
On Tue, 22 Nov 2016 09:20:48 + Daniel Stone <dan...@fooishbar.org> wrote: > Hi, > Hi Daniel, nice comments, I'll revise the patch later. Some replies below. > On 21 November 2016 at 15:06, Pekka Paalanen > <pekka.paala...@collabora.co.uk> wrote: > > On M

[RFC xserver 3/3] Xwayland: use _XWAYLAND_ALLOW_COMMITS property

2016-11-24 Thread Pekka Paalanen
From: Pekka Paalanen <pekka.paala...@collabora.co.uk> The X11 window manager (XWM) of a Wayland compositor can use the _XWAYLAND_ALLOW_COMMITS property to control when Xwayland sends wl_surface.commit requests. If the property is not set, the behaviour remains what it was. XWM uses the pr

[RFC xserver 2/3] xwayland: fix 'buffer' may be used uninitialized warning

2016-11-24 Thread Pekka Paalanen
From: Pekka Paalanen <pekka.paala...@collabora.co.uk> Fix the following warning due to --disable-glamor: CC Xwayland-xwayland.o In file included from /home/pq/local/include/wayland-client.h:40:0, from xwayland.h:35, from xwayland.c:26: xway

[RFC xserver 0/3] Allow XWM to control Xwayland commits

2016-11-24 Thread Pekka Paalanen
From: Pekka Paalanen <pekka.paala...@collabora.co.uk> Hi, this is probably the first time I'm sending patches for the xserver, so pointing out API misuse, coding style issues etc. would be appreciated. The last patch also has some XXX comments with questions. The first patch, refac

[RFC xserver 1/3] xwayland: refactor into xwl_window_post_damage()

2016-11-24 Thread Pekka Paalanen
From: Pekka Paalanen <pekka.paala...@collabora.co.uk> Refactor xwl_screen_post_damage() and split the window specific code into a new function xwl_window_post_damage(). This is a pure refactoring, there are no behavioral changes. An assert is added to xwl_window_post_damage() to ensure

Re: [RFC xserver 0/3] Allow XWM to control Xwayland commits

2016-11-28 Thread Pekka Paalanen
On Fri, 25 Nov 2016 12:30:18 +0200 Pekka Paalanen <ppaala...@gmail.com> wrote: > On Fri, 25 Nov 2016 03:47:56 -0500 (EST) > Olivier Fourdan <ofour...@redhat.com> wrote: > > > Hi Pekka, > > > > > this is probably the first time I'm sending patches

Re: [PATCH wayland] doc: start documenting Xwayland

2016-11-21 Thread Pekka Paalanen
On Mon, 21 Nov 2016 14:31:43 +0200 Pekka Paalanen <ppaala...@gmail.com> wrote: > From: Pekka Paalanen <pekka.paala...@collabora.co.uk> > > This is a rough intro to what Xwayland is and does, with just one > implementation detail so far (Window identification).

[PATCH xserver v2 5/5] xwayland: use _XWAYLAND_ALLOW_COMMITS property

2016-12-09 Thread Pekka Paalanen
From: Pekka Paalanen <pekka.paala...@collabora.co.uk> The X11 window manager (XWM) of a Wayland compositor can use the _XWAYLAND_ALLOW_COMMITS property to control when Xwayland sends wl_surface.commit requests. If the property is not set, the behaviour remains what it was. XWM uses the pr

[PATCH xserver v2 4/5] xwayland: fix 'buffer' may be used uninitialized warning

2016-12-09 Thread Pekka Paalanen
From: Pekka Paalanen <pekka.paala...@collabora.co.uk> Fix the following warning due to --disable-glamor: CC Xwayland-xwayland.o In file included from /home/pq/local/include/wayland-client.h:40:0, from xwayland.h:35, from xwayland.c:26: xway

[PATCH xserver v2 1/5] dix: Pass the whole property into deliverPropertyNotifyEvent

2016-12-09 Thread Pekka Paalanen
From: Adam Jackson <a...@redhat.com> Instead of just the atom. No functional change. Signed-off-by: Adam Jackson <a...@redhat.com> Signed-off-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> --- dix/property.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deleti

[PATCH xserver v2 3/5] xwayland: refactor into xwl_window_post_damage()

2016-12-09 Thread Pekka Paalanen
From: Pekka Paalanen <pekka.paala...@collabora.co.uk> Refactor xwl_screen_post_damage() and split the window specific code into a new function xwl_window_post_damage(). This is a pure refactoring, there are no behavioral changes. An assert is added to xwl_window_post_damage() to ensure

[PATCH xserver v2 2/5] dix: Add a callback chain for window property state change

2016-12-09 Thread Pekka Paalanen
From: Adam Jackson <a...@redhat.com> This will be used by in-server features that need to react to property changes. The first one will be _XWAYLAND_ALLOW_COMMITS. Signed-off-by: Adam Jackson <a...@redhat.com> [Pekka: add commit message body] Signed-off-by: Pekka Paalanen

[PATCH xserver v2 0/5] Allow XWM to control Xwayland commits

2016-12-09 Thread Pekka Paalanen
From: Pekka Paalanen <pekka.paala...@collabora.co.uk> Hi, this is v2 of _XWAYLAND_ALLOW_COMMITS property support in Xwayland to allow the window manager to control when wl_surface.commits occur. The first revision was posted here: https://lists.x.org/archives/xorg-devel/2016-November/05191

Re: [RFC xserver 0/3] Allow XWM to control Xwayland commits

2016-12-07 Thread Pekka Paalanen
On Mon, 05 Dec 2016 16:43:24 -0500 Adam Jackson <a...@nwnk.net> wrote: > (apologies for being so slow to get to this thread, this is great stuff) > > On Mon, 2016-11-28 at 15:47 +0200, Pekka Paalanen wrote: > > > Hi, > > > > having read the above two sp

[PATCH xserver] test: fix distributing scripts

2016-12-07 Thread Pekka Paalanen
From: Pekka Paalanen <pekka.paala...@collabora.co.uk> Fix the following error on 'make distcheck': make[6]: *** No rule to make target 'scripts/xvfb-piglit.sh', needed by 'scripts/xvfb-piglit.sh.log'. Stop. make[6]: Leaving directory '/home/pq/git/xserver/xorg-server-1.19.99.1/_build/su

Re: [PATCH xserver v2 5/5] xwayland: use _XWAYLAND_ALLOW_COMMITS property

2017-01-12 Thread Pekka Paalanen
On Tue, 3 Jan 2017 04:31:39 -0500 (EST) Olivier Fourdan <ofour...@redhat.com> wrote: > Hi, > > - Original Message - > > On Fri, 2016-12-09 at 14:24 +0200, Pekka Paalanen wrote: > > > From: Pekka Paalanen <pekka.paala...@collabora.co.uk> >

Re: [PATCH xserver v2 5/5] xwayland: use _XWAYLAND_ALLOW_COMMITS property

2017-01-12 Thread Pekka Paalanen
On Mon, 02 Jan 2017 16:17:27 -0500 Adam Jackson <a...@nwnk.net> wrote: > On Fri, 2016-12-09 at 14:24 +0200, Pekka Paalanen wrote: > > From: Pekka Paalanen <pekka.paala...@collabora.co.uk> > > > > The X11 window manager (XWM) of a Wayland compositor can us

Re: [RFC xserver 3/3] Xwayland: use _XWAYLAND_ALLOW_COMMITS property

2016-12-05 Thread Pekka Paalanen
On Thu, 24 Nov 2016 15:40:37 +0200 Pekka Paalanen <ppaala...@gmail.com> wrote: > From: Pekka Paalanen <pekka.paala...@collabora.co.uk> > > The X11 window manager (XWM) of a Wayland compositor can use the > _XWAYLAND_ALLOW_COMMITS property to control when Xwayland s

Re: [RFC xserver 3/3] Xwayland: use _XWAYLAND_ALLOW_COMMITS property

2016-12-05 Thread Pekka Paalanen
On Mon, 5 Dec 2016 14:03:04 +0200 Pekka Paalanen <ppaala...@gmail.com> wrote: > On Thu, 24 Nov 2016 15:40:37 +0200 > Pekka Paalanen <ppaala...@gmail.com> wrote: > > > From: Pekka Paalanen <pekka.paala...@collabora.co.uk> > > > > The X11 window

Re: [RFC xserver 3/3] Xwayland: use _XWAYLAND_ALLOW_COMMITS property

2016-12-05 Thread Pekka Paalanen
On Mon, 5 Dec 2016 09:59:46 -0500 (EST) Olivier Fourdan wrote: > Hi Pekka, > > > [...] > > Patches 1 and 2 OTOH would be ready for merging on my behalf. > > Yes, I think the two first patches are fine. Hi Olivier, thank you for the reviews! > > Olivier asked about

Re: [RFC xserver 0/3] Allow XWM to control Xwayland commits

2016-12-01 Thread Pekka Paalanen
On Wed, 30 Nov 2016 15:12:54 -0500 Owen Taylor wrote: > Hi Pekka, > > I don't have a lot of of commentary to add here. Certainly getting the > frame-sync protocols right does require integration between Xwayland and > the compositing manager. I don't think there's that

Re: [PATCH rendercheck 0/5] Convert to meson.

2017-03-27 Thread Pekka Paalanen
On Sun, 26 Mar 2017 23:40:34 +0200 walter harms wrote: > Am 24.03.2017 22:13, schrieb Mark Kettenis: > >> From: Eric Anholt > >> Date: Fri, 24 Mar 2017 13:17:45 -0700 > >> > >> Having bitten off a bit more than I can chew in 3 days with the X > >> Server

Re: [PATCH 1/2] Introduce keyboard grabbing protocol for Xwayland

2017-04-03 Thread Pekka Paalanen
On Mon, 3 Apr 2017 09:47:50 -0400 (EDT) Olivier Fourdan wrote: > Hi Quentin, > > > I think it may be worth it to add a little safety net: > > “Compositors are required to restrict this interface to Xwayland alone, > > and raise a protocol error for native Wayland clients.”

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-07 Thread Pekka Paalanen
On Thu, 06 Apr 2017 20:02:23 -0700 Keith Packard wrote: > Michel Dänzer writes: > > > When no such special client (Steam?) is running, the desktop environment > > will try to use the HMD anyway, right? So the expected use case would be > > for the user to

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-10 Thread Pekka Paalanen
On Sun, 09 Apr 2017 10:27:31 -0700 Keith Packard <kei...@keithp.com> wrote: > Pekka Paalanen <ppaala...@gmail.com> writes: > > > we need some kind of a database to recognize HMDs in any case, right? > > It would be best if the database was shared, so that everyon

Re: [PATCH xserver] xwayland: clear cursor frame callback

2017-03-06 Thread Pekka Paalanen
gt;pointer_enter_serial, NULL, 0, 0); > +clear_frame_callback(xwl_seat); > +xwl_seat->cursor_needs_update = FALSE; > return; > } > Hi, the rationale sounds good to me, and the code looks fine though I have not checked the surrounding code no

Re: Second Feedback request for my GSoC project to improve Present support in Xwayland

2017-08-10 Thread Pekka Paalanen
On Mon, 7 Aug 2017 17:36:27 +0900 Michel Dänzer wrote: > On 04/08/17 06:57 PM, Roman Gilg wrote: > > On Fri, Aug 4, 2017 at 8:44 AM, Michel Dänzer > > wrote: > > > > On 03/08/17 09:11 PM, Roman Gilg wrote: > > >

Re: Second Feedback request for my GSoC project to improve Present support in Xwayland

2017-08-10 Thread Pekka Paalanen
On Thu, 3 Aug 2017 14:11:25 +0200 Roman Gilg wrote: > On Wed, Aug 2, 2017 at 11:36 AM, Michel Dänzer wrote: > > > On 02/08/17 03:53 AM, Roman Gilg wrote: > > > > > > Another more serious problem would be, if an application only uses a > > > fixed

Re: Second Feedback request for my GSoC project to improve Present support in Xwayland

2017-08-11 Thread Pekka Paalanen
On Tue, 1 Aug 2017 20:53:02 +0200 Roman Gilg wrote: > > Summary: > > > (1) Deactivate queued presentation support for now (until we know which > kind of Wayland protocol to use for). > (2) Per window flipping when the pixmap flipping window region equals the

Re: [PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

2017-08-14 Thread Pekka Paalanen
On Sat, 12 Aug 2017 03:45:39 +0200 Roman Gilg <subd...@gmail.com> wrote: > On Thu, Aug 10, 2017 at 2:49 PM, Pekka Paalanen <ppaala...@gmail.com> wrote: > > Assuming the theory is sound, how about you kept the old names and > > semantics of xwl_window_get() and xwl_wi

Re: [PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

2017-08-10 Thread Pekka Paalanen
On Sun, 6 Aug 2017 20:03:47 +0200 Roman Gilg wrote: > Calling xwl_window_from_window means looping through the window ancestor > chain whenever it is called on a child window or on an automatically > redirected window. > > Since these properties and the potential ancestor's

Re: [RFC PATCH v2] Add xdg-output protocol

2017-07-12 Thread Pekka Paalanen
On Fri, 7 Jul 2017 04:21:57 -0400 (EDT) Olivier Fourdan wrote: > Hi Pekka, > > > it's very hard for me to wrap my head around this, so the below may > > sound a bit harsh, sorry. I don't mean to rant, but I feel there is > > something fundamental amiss. I am diving back

Re: [RFC PATCH v2] Add xdg-output protocol

2017-07-18 Thread Pekka Paalanen
protocol proposal. This discussion has taken off in an academic direction about everything surrounding the protocol proposal. > On Wed, Jul 12, 2017 at 12:07:29PM +0300, Pekka Paalanen wrote: > > On Fri, 7 Jul 2017 04:21:57 -0400 (EDT) > > Olivier Fourdan <ofour...@redhat.com>

Re: [RFC PATCH v3] Add xdg-output protocol

2017-07-18 Thread Pekka Paalanen
ry="height of the mode in global compositor space"/> Replace "mode" with a more appropriate word or remove it. Mode refers to the hardware video mode, and I think it is a bit confusing to talk about size of a mode in global compositor space, even though it is accurate. > + > + > + >

Re: [PATCH v4] Add xdg-output protocol

2017-07-20 Thread Pekka Paalanen
ze which describe > the output position and size in the global compositor space. > > Signed-off-by: Olivier Fourdan <ofour...@redhat.com> > Reviewed-by: Jonas Ådahl <jad...@gmail.com> > Acked-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> > --- > v2: use

Re: Request for feedback for my GSoC project to improve Present support in Xwayland

2017-07-24 Thread Pekka Paalanen
On Mon, 24 Jul 2017 04:07:11 +0200 Roman Gilg wrote: > Hi, > > I'm working for my GSoC project on a better Present integration in > Xwayland. This should improve performance as well as minimize tearing. My > mentor is Daniel Stone and the starting point was my work on KWin

Re: [RFC PATCH wayland-protocols] Introduce logical output protocol for Xwayland

2017-06-30 Thread Pekka Paalanen
On Fri, 30 Jun 2017 04:38:07 -0400 (EDT) Olivier Fourdan wrote: > Hi Jonas, > > > On Thu, Jun 29, 2017 at 04:44:34PM +0200, Olivier Fourdan wrote: > > > This introduces a new protocol for the compositor to describe outputs > > > size in a logical way for Xwayland. > >

Re: [PATCH xserver] xfree86: link to libinput(4) from the xorg.conf man page

2017-07-04 Thread Pekka Paalanen
rmansuffix__), > +.BR libinput (__drivermansuffix__), > .BR mousedrv (__drivermansuffix__), > .BR mutouch (__drivermansuffix__), > .BR penmount (__drivermansuffix__), Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Thanks, pq pgpZoQ2L2VPRc.pgp Description: OpenPGP d

Re: [RFC PATCH wayland-protocols] Introduce logical output protocol for Xwayland

2017-07-03 Thread Pekka Paalanen
On Mon, 3 Jul 2017 04:42:52 -0400 (EDT) Olivier Fourdan wrote: > So, 3 possibilities so far: > > 1. Add the logical output in wl_output >Looked like a good idea initially, not so much on further > consideration. pro: It's just an additional event to a existing >

Re: [RFC PATCH v2] Add xdg-output protocol

2017-07-06 Thread Pekka Paalanen
On Tue, 4 Jul 2017 14:13:43 +0200 Olivier Fourdan wrote: > This protocol aims at describing outputs in way which is more in line > with the concept of an output on desktop oriented systems. > > Some information are more specific to the concept of an output for a > desktop

Re: [RFC PATCH v2] Add xdg-output protocol

2017-07-06 Thread Pekka Paalanen
Hi Olivier, it's very hard for me to wrap my head around this, so the below may sound a bit harsh, sorry. I don't mean to rant, but I feel there is something fundamental amiss. I am diving back into the high-level design which is fairly separated from the xdg_output interface. On Thu, 6 Jul 2017

Re: [PATCH] xwayland: Avoid repeatedly looping through window ancestor chain

2017-08-23 Thread Pekka Paalanen
vention is in xserver, would this warrant a comment somewhere explaining what exactly is in each Window's wl_window_private_key private as not all Windows that have it set actually own it. Another thing is maybe the long lines would need splitting. But anyway, the patch looks good to me, so

Re: [PATCH xserver 2/2] meson: Fix CLOCK_MONOTONIC test

2017-05-12 Thread Pekka Paalanen
xserver build succeeds now, just a few screenfuls of compiler warnings, no errors. For both patches: Tested-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Thanks, pq pgp9x0lQwNYHS.pgp Description: OpenPGP digital signature ___ xorg-devel@list

Re: [PATCH xserver 2/2] Replace all checks for 'linux' macro with '__linux__'

2017-05-11 Thread Pekka Paalanen
e the latter specifically) let the Meson build continue much further than before for me. Therefore: Tested-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> The next issue I hit is: -- [12:24:30] ~/build/xserver -- (wayland) pq@eldfell $ meson ~/git/xserver --prefix "$WLD" -Dc_std

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-05-09 Thread Pekka Paalanen
On Mon, 08 May 2017 08:29:30 -0700 Keith Packard <kei...@keithp.com> wrote: > Pekka Paalanen <ppaala...@gmail.com> writes: > > > Thinking again, I believe we have to have a way to override > > database entries somehow. If we ship catch-all entries for, say, > &g

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-05-04 Thread Pekka Paalanen
On Wed, 03 May 2017 19:04:38 -0700 Keith Packard <kei...@keithp.com> wrote: > Pekka Paalanen <ppaala...@gmail.com> writes: > > > do you mean to list all kinds of display devices in the database? I was > > assuming it would list only HMDs, so not in database would i

  1   2   >