Re: [PATCH 1/2] modesetting: add support for background none.

On Tue, May 03, 2016 at 06:54:56AM +1000, Dave Airlie wrote: > From: Dave Airlie > > This adds support using glamor for background None. > > loosely based off the amdgpu code. relies on the > glamor_finish code. > > Acked-by: Eric Anholt > Signed-off-by:

Re: [PATCH xserver 1/4] dix: Push UpdateCurrentTimeIf down out of the main loop

roughput. > > Instead, push the call down to the requests that need it; basically, > grab processing and event generation. > > Cc: Chase Douglas <chase.doug...@canonical.com> > Cc: Peter Hutterer <peter.hutte...@who-t.net> > Signed-off-by: Adam Jackson <a...@redhat.com>

Re: [PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ in signedness [-Wpointer-sign]

On Sat, Apr 30, 2016 at 11:08:34PM +0200, walter harms wrote: > > > Am 29.04.2016 03:03, schrieb Alan Coopersmith: > > On 04/28/16 04:43 PM, Peter Hutterer wrote: > >> fixing this isn't going to do much, and adding fake statements neither. > >> to fix the compile

Re: [PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ in signedness [-Wpointer-sign]

On Thu, Apr 28, 2016 at 06:03:05PM -0700, Alan Coopersmith wrote: > On 04/28/16 04:43 PM, Peter Hutterer wrote: > > fixing this isn't going to do much, and adding fake statements neither. > > to fix the compiler warnings you could do something like: > > > > #d

Re: [PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ in signedness [-Wpointer-sign]

On Thu, Apr 28, 2016 at 04:53:46PM +0200, walter harms wrote: > > > Am 27.04.2016 07:04, schrieb Alan Coopersmith: > > On 04/26/16 07:31 AM, walter harms wrote: > >> > >> fix signess warning by casting > >> Signed-off-by: walter harms > >> > >> > >> --- > >> src/ModMap.c | 4

Results of the 2016 Election to the X.Org BoD & Vote on the By-Law Changes

Committee Peter Hutterer Daniel Vetter Martin Peres Rob Clark signature.asc Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/lis

[PATCH synaptics] eventcomm: fix typo checking for two-finger scrolling

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/eventcomm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/eventcomm.c b/src/eventcomm.c index 5f55141..9c9a036 100644 --- a/src/eventcomm.c +++ b/src/eventcomm.c @@ -710,7 +710,7 @@ EventReadH

[PATCH evdev] Prevent buffer overrun accessing btn_labels

We go up to BTN_JOYSTICK, hence group can have a value of up to including 15. The actual btn_labels only has 6 elements though. Found by coverity. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/evdev.c

[PATCH xserver] xfree86: add support for MatchIsTabletPad

The tablet pads have been separate kernel devices for a while now and libwacom has labelled them with the udev ID_INPUT_TABLET_PAD for over a year now. Add a new MatchIsTabletPad directive to apply configuration options specifically to the Pad part of a tablet. Signed-off-by: Peter Hutterer

[PATCH xf86-input-libinput] conf: rename to 60-libinput.conf

libinput down to 60 and bump wacom up. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- Makefile.am | 2 +- conf/60-libinput.conf | 28 conf/90-libinput.conf | 28 3 files changed, 29 insertions(+), 29 del

Re: [PATCH xf86-input-libinput] Add tablet pad support

On Fri, Apr 22, 2016 at 11:01:03AM -0700, Jason Gerecke wrote: > On Thu, Apr 21, 2016 at 10:25 PM, Peter Hutterer > <peter.hutte...@who-t.net> wrote: > > On Fri, Apr 22, 2016 at 12:07:27PM +1000, Peter Hutterer wrote: > >> > Also, on a somewhat-related note: I'm no

Re: [PATCH xf86-input-libinput] Add tablet pad support

On Fri, Apr 22, 2016 at 12:07:27PM +1000, Peter Hutterer wrote: > > Also, on a somewhat-related note: I'm noticing that having > > xf86-input-libinput and xf86-input-wacom installed alongside each > > other results in some pretty annoying driver priority issues. I've got &g

Re: [PATCH xf86-input-libinput] Add tablet pad support

On Wed, Apr 20, 2016 at 04:05:14PM -0700, Jason Gerecke wrote: > On Sun, Apr 17, 2016 at 9:18 PM, Peter Hutterer > <peter.hutte...@who-t.net> wrote: > > Modelled to be mostly compatible to the xf86-input-wacom driver behavior. > > The > > pad gets 7 axes, the

Re: [RFC xwayland] Pointer warp emulation

On Wed, Apr 13, 2016 at 06:07:51PM +0800, Jonas Ådahl wrote: > With Wayland, the X server is no longer in control of the pointer > position, and as such, clients warping the pointer has no effect. This > causes many applications (mostly games) to fail to function properly, as > they depend on the

[PATCH xf86-input-libinput] Add tablet pad support

events (which are a bitshifted value), libinput normalizes it and we just expand this back into an integer range. Let's see how we go with this. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.c | 151 +

Re: [PATCH] Remove unused libdir setting from xbitmaps.pc

On Wed, Apr 13, 2016 at 11:16:08PM -0700, Alan Coopersmith wrote: > Signed-off-by: Alan Coopersmith <alan.coopersm...@oracle.com> Acked-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > xbitmaps.pc.in | 1 - > 1 file changed, 1 deletion(-) > &g

Re: [PATCH xserver] Xi: don't deliver emulated motion events for non-emulating touches

On Wed, Mar 09, 2016 at 12:13:22PM +1000, Peter Hutterer wrote: > The touchpoint knows whether it should be emulating or not and we have a check > for that later. Check for this before we generate the event and try to deliver > it, lest we trigger a bug warning. > > https://bugz

Re: [PATCH xserver] xkb: fix SlowKeys release/reject beeps

On Tue, Mar 08, 2016 at 03:42:42PM +1000, Peter Hutterer wrote: > Wrong use of the mask here caused a beep whenever a key was rejected but also > when it was released after being accepted. Fix the mask to check for the > correct enabled controls. > > Signed-off-by: Peter Hutter

Re: [PATCH inputproto] specs: Set TZ=UTC before calling asciidoc

On Thu, Mar 31, 2016 at 03:00:16PM +0200, Andreas Boll wrote: > 2016-03-30 6:26 GMT+02:00 Peter Hutterer <peter.hutte...@who-t.net>: > > On Fri, Dec 11, 2015 at 10:49:33AM +0100, Andreas Boll wrote: > >> Set TZ=UTC before calling asciidoc to make the embedded dates inv

Re: [PATCH inputproto] specs: Set TZ=UTC before calling asciidoc

On Fri, Dec 11, 2015 at 10:49:33AM +0100, Andreas Boll wrote: > Set TZ=UTC before calling asciidoc to make the embedded dates invariant > to timezones in order to make the package build reproducibly. quick check shows that the date embedded includes a timestamp with seconds granularity. So unless

EXTENDED: 2016 X.Org Board of Directors Elections Nomination period is NOW

elected from the membership. Each year, an election is held to bring the total number of directors to eight. The four members receiving the highest vote totals will serve as directors for two year terms. The directors who received two year terms starting in 2015 were Peter Hutterer, Martin Peres

Reminder: 2016 X.Org Board of Directors Elections Nomination period is NOW

of directors elected from the membership. Each year, an election is held to bring the total number of directors to eight. The four members receiving the highest vote totals will serve as directors for two year terms. The directors who received two year terms starting in 2015 were Peter Hutterer, Martin

[PATCH xserver] Xi: don't deliver emulated motion events for non-emulating touches

The touchpoint knows whether it should be emulating or not and we have a check for that later. Check for this before we generate the event and try to deliver it, lest we trigger a bug warning. https://bugzilla.redhat.com/show_bug.cgi?id=1282252 Signed-off-by: Peter Hutterer <peter.hutte...@

[PATCH xserver] xkb: fix SlowKeys release/reject beeps

Wrong use of the mask here caused a beep whenever a key was rejected but also when it was released after being accepted. Fix the mask to check for the correct enabled controls. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- xkb/xkbAccessX.c | 5 - 1 file changed, 4 inse

Reminder: 2016 X.Org Board of Directors Elections Nomination period is NOW

of directors elected from the membership. Each year, an election is held to bring the total number of directors to eight. The four members receiving the highest vote totals will serve as directors for two year terms. The directors who received two year terms starting in 2015 were Peter Hutterer, Martin

2016 Elections to the X.Org Board of Directors and Approval to Changes of the X.Org By Laws

The X.Org Foundation is holding elections for - The Board of Directors - Adoption of changes to the By Laws. Election Schedule = Nomination period Start: Feb 24 00:00 UTC Nomination period End: Mar 15 23:59 UTC (3 weeks) Deadline of X.Org membership application

Re: [PATCH kdrive/ephyr v7 3/9] kdrive: introduce input hot-plugging support for udev and hal backends (#33140)

On Thu, Feb 11, 2016 at 08:23:55AM -0200, Laércio de Sousa wrote: > 2016-02-11 0:56 GMT-02:00 Peter Hutterer <peter.hutte...@who-t.net>: > > > we don't have a 1:1 mapping between devices and fd (e.g. wacom devices all > > hang off a single fd). Even the fd itself is a DDX

Re: [PATCH kdrive/ephyr v7 3/9] kdrive: introduce input hot-plugging support for udev and hal backends (#33140)

On Thu, Feb 11, 2016 at 04:10:23PM -0200, Laércio de Sousa wrote: > 2016-02-11 8:23 GMT-02:00 Laércio de Sousa < > laercioso...@sme-mogidascruzes.sp.gov.br>: > > > 2016-02-11 0:56 GMT-02:00 Peter Hutterer <peter.hutte...@who-t.net>: > > > >> we don't have

Re: [PATCH kdrive/ephyr v7 3/9] kdrive: introduce input hot-plugging support for udev and hal backends (#33140)

On Mon, Feb 08, 2016 at 02:45:43PM -0500, Adam Jackson wrote: > On Fri, 2015-12-11 at 11:43 -0200, Laércio de Sousa wrote: > > > +void > > +systemd_logind_release_fd(int _major, int _minor, int fd) > > +{ > > +} > > + > > +void > > +systemd_logind_vtenter(void) > > +{ > > +} > > This introduces

Re: [PATCH kdrive/ephyr v7 4/9] kdrive: update evdev keyboard LEDs (#22302)

On Fri, Dec 11, 2015 at 11:43:09AM -0200, Laércio de Sousa wrote: > From: Mikhail Krivtsov > > When one hits {Num,Caps,Scroll}Lock key on a Xephyr's keyboard, > keyboard itself works as expected but LEDs are not updated > and always stay in off. > > Currently logical

Re: [PATCH kdrive/ephyr v7 5/9] kdrive: add options to set default XKB properties

On Tue, Feb 09, 2016 at 10:23:05AM -0200, Laércio de Sousa wrote: > Em 9 de fev de 2016 02:24, "Peter Hutterer" <peter.hutte...@who-t.net> > escreveu: > > when we introduced the udev config backend we mostly agreed that we > weren't > > going to use u

Re: [PATCH kdrive/ephyr v7 5/9] kdrive: add options to set default XKB properties

On Tue, Feb 09, 2016 at 04:59:54PM +0100, Julien Cristau wrote: > On Tue, Feb 9, 2016 at 14:23:59 +1000, Peter Hutterer wrote: > > > On Mon, Feb 08, 2016 at 10:00:21PM -0200, Laércio de Sousa wrote: > > > Em 8 de fev de 2016 17:54, "Adam Jackson" <a...@nwnk.

Re: [PATCH kdrive/ephyr v7 5/9] kdrive: add options to set default XKB properties

On Mon, Feb 08, 2016 at 10:00:21PM -0200, Laércio de Sousa wrote: > Em 8 de fev de 2016 17:54, "Adam Jackson" escreveu: > > How are you in a scenario where you can pass these values to Xephyr on > > the command line, but can't modify the udev properties? > Well... What I really

Re: [PATCH kdrive/ephyr v7 5/9] kdrive: add options to set default XKB properties

On Fri, Dec 11, 2015 at 11:43:10AM -0200, Laércio de Sousa wrote: > This patch introduces convenient command-line options -xkbrules, > -xkbmodel, -xkblayout, -xkbvariant, and -xkboptions, to set default > values for these properties. > > These options can be handful in cases where corresponding

Re: [PATCH kdrive/ephyr v7 5/9] kdrive: add options to set default XKB properties

On Tue, Feb 09, 2016 at 05:40:26AM -0200, Laércio de Sousa wrote: > Em 9 de fev de 2016 02:24, "Peter Hutterer" <peter.hutte...@who-t.net> > escreveu: > > > > On Fri, Dec 11, 2015 at 11:43:10AM -0200, Laércio de Sousa wrote: > > > This patch introduce

[PATCH xf86-input-libinput 2/4] Add support for the airbrush tool axes

Same axes as the pen, but axis number 6 is the wheel (which really is a slider) Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.c | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/src/xf86libinp

[PATCH xf86-input-libinput 1/4] Add support for tablet tools

-driver-specific properties. Configuration clients like gnome-settings-daemon will need to change to handle new properties, to be added as we go along. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.c | 370 -

[PATCH xf86-input-libinput 4/4] Support art pen rotation

The art pen is a normal pen, but it does provide a rotation axis. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/src/xf86libinput.c b/src/xf86libinput.c index d

[PATCH xf86-input-libinput 3/4] Support the mouse/lens tool

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.c | 45 + 1 file changed, 45 insertions(+) diff --git a/src/xf86libinput.c b/src/xf86libinput.c index 477ec5c..d41826a 100644 --- a/src/xf86libinput.c +++

[PATCH xf86-input-libinput 0/4] Add tablet support

Almost exactly the same patchset as sent earlier, with two patches squashed together for simplicity and a minor fix. http://lists.freedesktop.org/archives/xorg-devel/2015-December/048084.html This works in the gimp, but not yet with the GNOME control center (since that relies on wacom-specific

Re: [PATCH:xdm] Remove non-existent cpp resource from man page

On Fri, Jan 29, 2016 at 07:04:28AM +0100, Matthieu Herrb wrote: > On Thu, Jan 28, 2016 at 09:02:06AM -0800, Alan Coopersmith wrote: > > From what I can see in the ancient X Consortium archives, the cpp > > resource was added in X11R4 and documented but never actually used, > > and removed in X11R5

[PATCH xf86-input-libinput] Add property/option for enabling/disabling tap-n-drag

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- include/libinput-properties.h | 6 +++ man/libinput.man | 8 src/xf86libinput.c| 94 +++ 3 files changed, 108 insertions(+) diff --git a/include/li

Re: [PATCH libX11 v2] XKB: fix XkbGetKeyboardByName with Xming server

`!xcb_xlib_extra_reply_data_left' failed. > Aborted > > Check if there is some extra data left at the end of > XkbGetKeyboardByName() and discard that data if any is found. > > Many thanks to Peter Hutterer <peter.hutte...@who-t.net> for finding the > root cause

Re: [PATCH libX11 v3] XKB: fix XkbGetKeyboardByName with Xming server

`!xcb_xlib_extra_reply_data_left' failed. > Aborted > > Check if there is some extra data left at the end of > XkbGetKeyboardByName() and discard that data if any is found. > > Many thanks to Peter Hutterer <peter.hutte...@who-t.net> for finding the > root cause

Re: [PATCH 2/2] release.sh: Don't quit on dry runs if tarball already uploaded

> option." > + elif [ "x$DRY_RUN" = "xyes" ]; then > + echo "Warning: tarball $tar_name is already uploaded to > $hostname." > else > echo "Error: tarball $tar_name already exists on $hostname.

[PATCH evdev 2/2] Don't reset the other axis on wheel emulation scroll buildup

a roughly vertical motion we won't get over the threshold anyway. https://bugs.freedesktop.org/show_bug.cgi?id=93617 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/emuWheel.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/src/emuWheel.c

[PATCH evdev 1/2] Restore wheel emulation for absolute devices

abs_value is always valied, we can copy its value into old_vals, so that wheel emulation can calculate the delta correctly. https://bugs.freedesktop.org/show_bug.cgi?id=93617 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/evdev.c | 17 ++--- 1 file changed, 14 inse

[PATCH dummy] Switch to using dixChangeWindowProperty

eb36924ead40564325aa56d54a973dc8fb4eae83 removed ChangeWindowProperty from the server. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/dummy_driver.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/dummy_driver.c b/src/dummy_driver.c index 4

[PATCH evdev] man: add a warning that wheel emu inertia must be set and it isn't inertia

of to 2000 units and that results in 200 scroll events. That's a bit excessive. Related to: https://bugs.freedesktop.org/show_bug.cgi?id=93617 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- man/evdev.man | 13 + 1 file changed, 13 insertions(+) diff --git a/man/evdev

Re: [PATCH xkbcomp] When a file contains several maps, look for a default map

On Wed, Jan 06, 2016 at 09:32:52PM +0100, Benno Schulenberg wrote: > From: Ran Benita > > Rather than always taking the first one in the file. This is exactly the > intended use of the 'default' flag. > > Note that pretty much the same code is duplicated in xkbcomp.c when >

Re: interfacing new touchpad driver with Xorg synaptics

On Sat, Dec 26, 2015 at 03:04:43PM -0800, Richard Pospesel wrote: > Hi, > > I'm working on a touchpad kernel driver (in the psmouse module) for BYD > touchpads. However, Xorg always selects the evdev 'pointer' driver (not > even the evdev 'touhpad' driver). I've browsed through other touchpad >

Re: [PATCH xserver 7/9] dix: Reallocate touchpoint buffer at input event time

On Thu, Dec 17, 2015 at 04:11:42PM -0800, Keith Packard wrote: > Now that input is threaded, malloc can be used at event time to resize > the touchpoint buffer as needed.x still not happy with the for (;;) instead of a while (1) but Reviewed-by: Peter Hutterer <peter.hutte...@who-t.ne

Re: [PATCH xserver 8/9] xfree86: Use threaded input mechanism

On Thu, Dec 17, 2015 at 04:11:43PM -0800, Keith Packard wrote: > Switch the XFree86 DDX over to threaded input > > Signed-off-by: Keith Packard <kei...@keithp.com> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > hw/xfree86/common/

Re: [PATCH xserver 9/9] kdrive: Use threaded input

On Thu, Dec 17, 2015 at 04:11:44PM -0800, Keith Packard wrote: > Signed-off-by: Keith Packard <kei...@keithp.com> Acked-by: Peter Hutterer <peter.hutte...@who-t.net> > --- > hw/kdrive/src/kinput.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > &

Re: [PATCH xserver 2/9] Remove SIGIO support for input [v2]

rked with calls > to stub functions input_lock/input_unlock so that we don't lose this > information. > > xfree86 SIGIO support is reworked to use internal versions of > OsBlockSIGIO and OsReleaseSIGIO. > > v2: Don't change locking order (Peter Hutterer) > > Signe

Re: [PATCH xserver 4/9] Create a threaded mechanism for input [v3]

On Thu, Dec 17, 2015 at 04:11:39PM -0800, Keith Packard wrote: > The current SIGIO signal handler method, used at generation of input events, > has a bunch of oddities. This patch introduces an alternative way using a > thread, which is used to select()s all input device file descriptors. drop

Re: [PATCH xserver 5/9] Disable input thread code with --disable-input-thread. RECURSIVE_MUTEX support

EFAULT=yes ;; > -*) > - THREAD_DEFAULT=no ;; > esac > + seems a bit odd to use a case statement for a basic check. can we use a simple if here? (ignore this if a later patch changes this bit) rest Acked-by: Peter Hutterer <peter.hutte...@who-t.net>, but I'm not sure on the d

Re: [PATCH xserver 6/9] mi: Grow event queue while reading events

ueue.dropped % QUEUE_DROP_BACKTRACE_FREQUENCY > == 0 && > + miEventQueue.dropped / QUEUE_DROP_BACKTRACE_FREQUENCY <= > + QUEUE_DROP_BACKTRACE_MAX) { > +ErrorFSigSafe("[mi] EQ overflow continuing. %zu events have > been " >

Re: [PATCH xf86-input-libinput] Drain the fd after opening

On Wed, Dec 16, 2015 at 11:14:28PM +0100, walter harms wrote: > > > Am 16.12.2015 01:15, schrieb Peter Hutterer: > > Make sure we discard any events that may have been enqueued before we > > re-opened the fd. Specifically, if we're using systemd-logind the fd remains >

[PATCH v2 xf86-input-libinput] Drain the fd after opening

. This is not the case when VT-switching, in that case logind closes the fd for us. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- Changes to v1: - check the fd before calling xf86FlushInput, otherwise we mess up errno src/xf86libinput.c | 7 ++- 1 file changed, 6 insertions

[PATCH xf86-input-libinput] Drain the fd after opening

applies to a device being disabled via the protocol, on VT switch logind closes the fd and we don't see enqueued events. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/xf86libinput.c b/src/xf86libi

Re: [PATCH xserver] xfree86: add NoMatchFoo directives for InputClass sections

On Fri, Dec 11, 2015 at 09:58:34AM +0100, Benjamin Tissoires wrote: > Hi Peter, > > On Fri, Dec 11, 2015 at 12:58 AM, Peter Hutterer > <peter.hutte...@who-t.net> wrote: > > InputClass sections use various MatchFoo directives to decide which device > > to > &g

Re: [PATCH xserver 1/8] Add stubs to input.h

On Wed, Dec 09, 2015 at 03:12:35PM -0800, Keith Packard wrote: > --- > include/input.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/include/input.h b/include/input.h > index d8bd9c6..5bc60f0 100644 > --- a/include/input.h > +++ b/include/input.h > @@ -712,4 +712,10 @@ extern

[PATCH xserver] xfree86: add NoMatchFoo directives for InputClass sections

Identifier "libinput for tablets" MatchIsTablet "true" NoMatchDriver "wacom" Driver "libinput" EndSection The above only assigns libinput to tablet devices if wacom isn't already assigned to this device, making it possible to select a specific

Re: [PATCH xserver 6/6] dix: Reallocate touchpoint buffer at input event time

On Wed, Dec 09, 2015 at 11:46:37AM -0800, Keith Packard wrote: > Peter Hutterer <peter.hutte...@who-t.net> writes: > > > > this hunk took me a while, wouldn't it be easier do do something like: > > do { > >for (i = 0, ...) { > >

Re: [PATCH xserver 2/6] Remove SIGIO support.

On Wed, Dec 09, 2015 at 11:13:14AM -0800, Keith Packard wrote: > Peter Hutterer <peter.hutte...@who-t.net> writes: > > >> /* Call PIE here so we don't try to dereference a device that's > >> * already been removed. */ > >> -OsBlock

Re: [PATCH] sync: Don't allow creating a system counter before sync is initialized

FakeClientID(0), initial); > +SyncCounter *pCounter = SyncCreateCounter(NULL, FakeClientID(0), > initial); > > if (pCounter) { > SysCounterInfo *psci; > -- > 2.5.0 in that case you can remove the RTCounter == 0 check in SyncExtens

Re: [PATCH xserver 6/6] dix: Reallocate touchpoint buffer at input event time

On Tue, Dec 08, 2015 at 03:44:54PM -0800, Keith Packard wrote: > Now that input is threaded, malloc can be used at event time to resize > the touchpoint buffer as needed.x > --- > dix/touch.c | 89 > + > 1 file changed, 30

Re: [PATCH xserver 2/6] Remove SIGIO support.

On Tue, Dec 08, 2015 at 03:44:50PM -0800, Keith Packard wrote: > This removes all of the SIGIO handling support throughout the X > server, preparing the way for using threads for input handling > instead. > > Places calling OsBlockSIGIO and OsReleaseSIGIO are marked with calls > to stub functions

Re: xserver: Branch 'master' - 16 commits

On Tue, Dec 08, 2015 at 09:56:45AM -0800, Keith Packard wrote: > Michel Dänzer writes: > > > This commit broke input for me with xf86-input-libinput. No keyboard or > > mouse input is received. There are no errors in the log file. > > > > xf86-input-evdev works. > > Ok, I

Re: [PATCH 5/5] glxproxy: Silence shadowed-variable warnings

On Tue, Dec 08, 2015 at 04:05:55PM -0500, Adam Jackson wrote: > Signed-off-by: Adam Jackson <a...@redhat.com> Series Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > hw/dmx/glxProxy/glxsingle.c | 5 +++-- > 1 file changed, 3 insertions(+),

Re: Deliver input events only to window owner

On Thu, Dec 03, 2015 at 02:55:22AM -0600, Keith Packard wrote: > Peter Hutterer <peter.hutte...@who-t.net> writes: > > > that's going to be fun to work out. raw events are delivered to the root > > window only so you don't really know which client they get delivere

Re: Deliver input events only to window owner

On Thu, Dec 03, 2015 at 01:51:35AM -0600, Keith Packard wrote: > Peter Hutterer <peter.hutte...@who-t.net> writes: > > > note that this does not handle XI2 raw keyboard events, they will need to be > > handled as well. > > Hrm. So, there's a problem here -- raw e

Re: Deliver input events only to window owner

On 2/12/2015 18:15 , Keith Packard wrote: Peter Hutterer <peter.hutte...@who-t.net> writes: looks correct, and it would also be fairly trivial to add test cases for this to XIT. I didn't check the spec for the exact wording, but either way we should add it. Reviewed-by: Peter Hu

Re: Disabling RECORD by default

On 2/12/2015 18:12 , Keith Packard wrote: Peter Hutterer <peter.hutte...@who-t.net> writes: disable _the_ XTEST extension? in at least two places. One comment, just to be annoying: I'd prefer this split in two patches, with the second one just toggling the true/false switch for

[PATCH/WIP xf86-input-libinput 3/3] Hotplug a new tablet tool device on proximity in

wacom-driver-specific properties. Configuration clients like gnome-settings-daemon will need to change to handle new properties, to be added as we go along. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.c | 366 ++

[PATCH/WIP xf86-input-libinput 1/3] Change creating subdevices to something more generic

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/src/xf86libinput.c b/src/xf86libinput.c index ee2165a..e20d821 100644 --- a/src/xf86libinput.c +++

[PATCH/WIP xf86-input-libinput 2/3] Allow hotplugging a device immediately

This splits the hotplugging code up so we can use it through a callback but also as an immediate call that gives us back the device just hotplugged. Also added is the ability to add extra options to the device. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.

Re: Disabling RECORD by default

o patches, with the second one just toggling the true/false switch for RECORD and having the git subject line of "Disable RECORD by default". Makes it much easier to find in the log than hiding it in the first paragraph. Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> otherw

Re: Deliver input events only to window owner

> enum EventDeliveryState rc; > > rc = DeliverEventToWindowMask(pDev, pWin, pEvents, count, filter, > -- > 2.6.1 looks correct, and it would also be fairly trivial to add test cases for this to XIT. I didn't check the spec for the exact wording, but either w

Re: Hiding keyboard state

e sure you're not missing out on any shortcuts the event delivery code may take somewhere. I don't think there are any, but... Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> also, as I wrote in the other email this breaks syndaemon's disable-while-typing feature, especially together

Re: [PATCH keyboard 3/3] Remove support for X input ABI < 12

On Thu, Nov 26, 2015 at 10:22:59PM +0500, Alexandr Shadchin wrote: > On Wed, Nov 25, 2015 at 07:19:48AM +1000, Peter Hutterer wrote: > > On Tue, Nov 24, 2015 at 12:46:44PM +0500, Alexandr Shadchin wrote: > > > Signed-off-by: Alexandr Shadchin <alexandr.shadc...@gmail.com&

Re: [PATCH xserver] kdrive/UnregisterFd: Fix off by one

he confusion by moving the decrement behind the end > if the copy loop. > > Signed-off-by: Egbert Eich <e...@suse.de> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> Cheers, Peter > --- > hw/kdrive/src/kinput.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH keyboard 3/3] Remove support for X input ABI < 12

On Tue, Nov 24, 2015 at 12:46:44PM +0500, Alexandr Shadchin wrote: > Signed-off-by: Alexandr Shadchin do you have follow-up patches that require these changes? I'm ok merging this set if it makes follow-ups easier, but a patchset just to remove functionality seems a

Re: [PATCHv3] build: Fix systemd-daemon compile/linker flags

On Thu, Nov 19, 2015 at 04:04:30PM +0200, Jussi Kukkonen wrote: > * Dont add systemd to REQUIRED_LIBS (this lead to build failure when > libsystemd is available but libsystemd-daemon is not) > * Only use systemd compile and linker flags where needed (libxtrans) > * Try libsystemd (>= 210) first

Re: [PATCHv3] build: Fix systemd-daemon compile/linker flags

On Mon, Nov 23, 2015 at 12:07:33AM +, Emil Velikov wrote: > On 22 November 2015 at 23:37, Peter Hutterer <peter.hutte...@who-t.net> wrote: > > On Thu, Nov 19, 2015 at 04:04:30PM +0200, Jussi Kukkonen wrote: > >> * Dont add systemd to REQUIRED_LIBS (this le

[PATCH xserver] xfree86: fix minor memory leak

xf86*StrOption returns a strdup Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- hw/xfree86/common/xf86Xinput.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/common/xf86Xinput.c b/hw/xfree86/common/xf86Xinput.c index a5b0568..c56a2b9

[PATCH xf86-input-libinput] Replace the "fd" option when enabling dependent devices

tion so that the server can request logind to close the fd. That only works if the "fd" option is correct, otherwise the server asks logind to close the epollfd and everyone is unhappy. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- I had to revert the patch shortly afte

Re: [PATCH v2] configure.ac: Use libsystemd in REQUIRED_LIBS check

On Tue, Nov 17, 2015 at 10:39:48AM +0200, Jussi Kukkonen wrote: > REQUIRED_LIBS needs to be set to the correct systemd library, > otherwise the later check will either fail or use the wrong > pc file. > > Signed-off-by: Jussi Kukkonen > --- > > > Changes since v1: > *

[PATCH v2 xf86-input-libinput 2/4] Copy the device capabilities to the X driver struct

And use those copied caps instead of the direct device capability calls. No functional changes at this point, this is preparation work for selectively disabling capabilities on a device. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- No changes to v1 src/xf86libinput.

[PATCH v2 xf86-input-libinput 4/4] Split mixed pointer/keyboard devices into two separate X devices

hen the first shared device is enabled, and remove it accordingly. [1] https://bugs.freedesktop.org/show_bug.cgi?id=49950 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- Changes to v1: - completely different approach, instead of merely duplicating the device and dropping events

[PATCH v2 xf86-input-libinput 3/4] Add a helper function for the driver context initialization

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- New patch in v2 src/xf86libinput.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/src/xf86libinput.c b/src/xf86libinput.c index b1b1943..bc6e677 100644 --- a/src/xf86libinput.c

Re: [PATCH xf86-input-libinput 3/3] Split mixed pointer/keyboard devices into two separate X devices

On Thu, Nov 12, 2015 at 10:27:05AM +1000, Peter Hutterer wrote: > The server struggles with devices that are both, the protocol (especially XI2) > requires a fairly strict separation of pointer vs keyboard devices. Though the > server has a couple of hacks to route events correct

[PATCH xf86-input-libinput 2/3] Copy the device capabilities to the X driver struct

And use those copied caps instead of the direct device capability calls. No functional changes at this point, this is preparation work for selectively disabling capabilities on a device. Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.

[PATCH xf86-input-libinput 1/3] Split type_name detection out into a helper function

No functional changes Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/src/xf86libinput.c b/src/xf86libinput.c index 95e2d20..be0ec5d 100644 ---

[PATCH xf86-input-libinput 3/3] Split mixed pointer/keyboard devices into two separate X devices

Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --- src/xf86libinput.c | 109 ++--- 1 file changed, 103 insertions(+), 6 deletions(-) diff --git a/src/xf86libinput.c b/src/xf86libinput.c index 3c00879..b27721f 100644 --- a/src/xf86libi

[PATCH evdev] Only map x and y to axes 0 and 1

, y) on every button click. Avoid this by simply mapping any axis other than x/y to at least axis 3, and make sure we only override the MT 0/1 axes when we actually have MT axes. https://bugs.freedesktop.org/show_bug.cgi?id=92856 Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net> --

Re: [PATCH v3] Also dump passive grabs on XF86LogGrabInfo

On Fri, Nov 06, 2015 at 12:43:14AM -0800, Michael Stapelberg wrote: > Signed-off-by: Michael Stapelberg > --- thanks, I've merged this locally now but we're pretty close to the 1.18 release, so better to merge critical fixes only at this point. I'll push this in asap after

Re: [PATCH xkbcomp] symbols: increase the warning level for shortening a key type

On Fri, Nov 06, 2015 at 10:37:44AM +0100, Benno Schulenberg wrote: > > On Fri, Nov 6, 2015, at 08:25, Peter Hutterer wrote: > > On Thu, Nov 05, 2015 at 04:21:14PM +0100, Benno Schulenberg wrote: > > > A patch that actually fixes the bug that causes this warning to print

Re: [PATCH xkbcomp] symbols: increase the warning level for shortening a key type

On Thu, Nov 05, 2015 at 04:21:14PM +0100, Benno Schulenberg wrote: > > On Tue, Nov 3, 2015, at 00:06, Peter Hutterer wrote: > > Any use of the german keyboard layout or anything else using > > level3(ralt_switch) produces the warning > > Type "ONE_LEVEL"

<    1   2   3   4   5   6   7   8   9   10   >