[PATCH libxkbcommon 0/2] Use flex and bison features

These patches break yacc and lex compatibility mainly for removing the global state from the parser, which I think is expected given that this is a library. This is my first patch to this list, so a few disclaimers: - I hope it's the right list. - I couldn't figure out the coding style (there

[PATCH libxkbcommon 1/2] Use bison-generated header instead of tokens.h

Bison can generate all necessary definitions itself; there is no need to maintain a hand written file for that. Signed-off-by: Ran Benita ran...@gmail.com --- src/xkbcomp/.gitignore |1 + src/xkbcomp/Makefile.am |4 +- src/xkbcomp/action.c |1 - src/xkbcomp/compat.c |1

[PATCH libxkbcommon 2/2] Make parser and scanner reentrant

All global state is removed from the parser and scanner. This makes use of the standard facilities in Bison and Flex for reentrant/pure scanner/lexer and location tracking. Signed-off-by: Ran Benita ran...@gmail.com --- src/xkbcomp/compat.c |3 +- src/xkbcomp/keytypes.c |3 +- src

Re: [PATCH libxkbcommon 0/2] Use flex and bison features

On Fri, Feb 24, 2012 at 10:16:39AM -0500, Gaetan Nadon wrote: On 12-02-23 07:58 PM, Ran Benita wrote: - I couldn't figure out the coding style (there seems to be use of *all* of them...), so I just tried to match the surroundings. - I've been using libxkbcommon for some time and I have

Re: [PATCH libxkbcommon 0/2] Use flex and bison features

On Fri, Feb 24, 2012 at 06:56:28PM -0500, Gaetan Nadon wrote: On 12-02-24 02:25 PM, Ran Benita wrote: On Fri, Feb 24, 2012 at 10:16:39AM -0500, Gaetan Nadon wrote: On 12-02-23 07:58 PM, Ran Benita wrote: - I couldn't figure out the coding style (there seems to be use of *all* of them

[PATCH libxkbcommon 00/11] Fix all compiler warnings

With this series applied libxkbcommon is compiled without warnings on gcc and clang, using the default CWARNFLAGS. I had also ran clang-analyzer and fixed all the warnings there. The patches should be independent so if any of them are problematic they can be dropped. Thanks, Ran [PATCH

[PATCH libxkbcommon 01/11] Remove unused debug #defines

Signed-off-by: Ran Benita ran...@gmail.com --- src/xkbcomp/parseutils.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/xkbcomp/parseutils.h b/src/xkbcomp/parseutils.h index dbaf683..dea25e6 100644 --- a/src/xkbcomp/parseutils.h +++ b/src/xkbcomp/parseutils.h @@ -36,17 +36,6

[PATCH libxkbcommon 02/11] Remove unused includes of tokens.h

Signed-off-by: Ran Benita ran...@gmail.com --- src/xkbcomp/action.c |1 - src/xkbcomp/compat.c |1 - src/xkbcomp/expr.c |1 - src/xkbcomp/geometry.c |1 - src/xkbcomp/indicators.c |1 - src/xkbcomp/keycodes.c |1 - src/xkbcomp/keymap.c |1 - src

[PATCH libxkbcommon 03/11] Remove ancient compatibility check

Other headers include malloc just fine. Signed-off-by: Ran Benita ran...@gmail.com --- makekeys/makekeys.c |3 --- 1 file changed, 3 deletions(-) diff --git a/makekeys/makekeys.c b/makekeys/makekeys.c index c4142ec..21d70f5 100644 --- a/makekeys/makekeys.c +++ b/makekeys/makekeys.c @@ -33,9

[PATCH libxkbcommon 04/11] makekeys: make buf local to main()

All the functions already accept it as a parameter. This clears -Wshadow warnings. Signed-off-by: Ran Benita ran...@gmail.com --- makekeys/makekeys.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/makekeys/makekeys.c b/makekeys/makekeys.c index 21d70f5..751b719 100644

[PATCH libxkbcommon 05/11] makekeys: clear const and shadow warnings

The name 'index' is used by the standard library, so use 'ndx' like some other files. Signed-off-by: Ran Benita ran...@gmail.com --- makekeys/makekeys.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/makekeys/makekeys.c b/makekeys/makekeys.c index

[PATCH libxkbcommon 06/11] Remove unneeded assignments and variables

Signed-off-by: Ran Benita ran...@gmail.com --- src/geom.c |1 - src/maprules.c |2 -- src/xkbcomp/alias.c|1 - src/xkbcomp/geometry.c |6 +- src/xkbcomp/keymap.c |2 +- 5 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/geom.c b

[PATCH libxkbcommon 07/11] Fix possible null dereferences

Fix all reported null dereferences from clang-analyzer. There seems to be one false negative (in file indicators.c), but it is fixed anyway. Signed-off-by: Ran Benita ran...@gmail.com --- src/geom.c |1 + src/xkb.c|5 ++--- src/xkbcomp/alias.c |2

[PATCH libxkbcommon 08/11] Fix all constness warnings

These are all trivial/obvious fixes which clear a bunch of warnings. Signed-off-by: Ran Benita ran...@gmail.com --- src/keysym.c |2 +- src/maprules.c | 44 src/text.c | 29 +++-- src

[PATCH libxkbcommon 09/11] Fix an incorrect sizeof

Signed-off-by: Ran Benita ran...@gmail.com --- src/xkbcomp/geometry.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xkbcomp/geometry.c b/src/xkbcomp/geometry.c index fb5eef2..18f41e6 100644 --- a/src/xkbcomp/geometry.c +++ b/src/xkbcomp/geometry.c @@ -367,7 +367,7

[PATCH libxkbcommon 10/11] Fix warnings in scanner and parser

Signed-off-by: Ran Benita ran...@gmail.com --- src/xkbcomp/parseutils.h |8 +--- src/xkbcomp/xkbparse.y |2 ++ src/xkbcomp/xkbscan.l| 17 + 3 files changed, 12 insertions(+), 15 deletions(-) diff --git a/src/xkbcomp/parseutils.h b/src/xkbcomp/parseutils.h

[PATCH libxkbcommon 11/11] Fix remaining warnings

Signed-off-by: Ran Benita ran...@gmail.com --- src/xkbcomp/geometry.c |8 src/xkbcomp/symbols.c |2 +- src/xkbcomp/utils.h|2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/xkbcomp/geometry.c b/src/xkbcomp/geometry.c index 18f41e6..bb3a891 100644

[PATCH libxkbcommon] Use yacc-generated header instead of tokens.h

The yacc implementation can generate all the necessary token definitions itself; there is no need to maintain a hand written file for that. Signed-off-by: Ran Benita ran...@gmail.com --- Resending this one as suggested by Gaetan Nadon. Should apply cleanly after the other fix patches. Tested

Re: [PATCH libxkbcommon 03/11] Remove ancient compatibility check

On Sat, Feb 25, 2012 at 06:23:48PM +, Daniel Stone wrote: BTW, that was purged from the libX11 copy in March 2009, so it may be worth checking just how far out of sync libxkbcommon has gotten with the code it was copied from and which everyone has been using in the meantime. Indeed,

[PATCH libxkbcommon 1/4] makekeys: Fix build/target word size mismatch when cross-compiling

...@fooishbar.org Signed-off-by: Ran Benita ran...@gmail.com --- makekeys/makekeys.c |5 +++-- src/keysym.c|2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/makekeys/makekeys.c b/makekeys/makekeys.c index 567843b..a25a4a6 100644 --- a/makekeys/makekeys.c +++ b

[PATCH libxkbcommon 2/4] When makekeys fails to find a good hash, print error instead of divide-by-zero

This matches commit 78a894231ae8ec4959007b6d9b8d2a15d6333a1e from libX11: Signed-off-by: Alan Coopersmith alan.coopersm...@sun.com Signed-off-by: Ran Benita ran...@gmail.com --- makekeys/makekeys.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/makekeys/makekeys.c b

[PATCH libxkbcommon 3/4] makekeys: Receive the keysym files as arguments

the vendor syms to be manually synchronised with XKeysymDB. Signed-off-by: Daniel Stone dan...@fooishbar.org Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com Signed-off-by: Ran Benita ran...@gmail.com --- configure.ac | 25 makekeys/Makefile.am |3

[PATCH libxkbcommon 4/4] makekeys: update to match the rest of libX11 makekeys

test is changed to match libX11 behavior, i.e. XKeysymToString(0x1008FE20) - XF86Ungrab as opposed to XF86_Ungrab. Signed-off-by: Ran Benita ran...@gmail.com --- makekeys/makekeys.c | 174 +-- src/keysym.c| 14 + test/xkey.sh

[PATCH libxkbcommon 1/4 v2] makekeys: Fix build/target word size mismatch when cross-compiling

get mismatches upon running X, and some LSB test failures (xts5). Use an unsigned 32-bit integer on all platforms. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com Reviewed-by: Daniel Stone dan...@fooishbar.org Signed-off-by: Ran Benita ran...@gmail.com --- v2

Re: [PATCH libxkbcommon 08/11] Fix all constness warnings

On Sun, Feb 26, 2012 at 03:30:42PM +0100, walter harms wrote: Am 25.02.2012 11:13, schrieb Ran Benita: @@ -578,9 +578,13 @@ MakeMultiDefs(XkbRF_MultiDefsPtr mdefs, XkbRF_VarDefsPtr defs) static void FreeMultiDefs(XkbRF_MultiDefsPtr defs) { - if (defs-options) free(defs-options

Re: [PATCH libxkbcommon 08/11] Fix all constness warnings

On Tue, Feb 28, 2012 at 07:04:31PM +, Daniel Stone wrote: Hi, On 28 February 2012 18:27, Ran Benita ran...@gmail.com wrote: Running the following semantic patch: @@ expression E; @@ - if (E != NULL) -     free(E); + free(E); Gives this: [...] And probably doesn't

[libxkbcommon] Pull request - many changes

at: g...@github.com:bluetech/libxkbcommon.git fixes-cont for you to fetch changes up to e4b4d6b0510075fe62234f66185bf619c70fc126: Fix Could not resolve keysym errors (2012-03-04 00:04:04 +0200) Ran Benita (46): Remove

Re: [libxkbcommon] Pull request - many changes

On Sat, Mar 10, 2012 at 02:00:46PM +, Daniel Stone wrote: Hi Ran, On 3 March 2012 22:40, Ran Benita ran...@gmail.com wrote: [I know the normal procedure is to send the patches for review in reasonable chunks to the list, however I won't have time the following weeks, and I don't want

[PATCH libxkbcommon] Add xkb_key_get_action API

By which one can tell when to switch groups, etc. Signed-off-by: Ran Benita ran...@gmail.com --- This would allow me to delete some duplicate code in the application and would make me a happy camper for a while. Wasn't sure about a couple of things: - Should the by_level API be exposed (the _syms

[PULL libxkbcommon] Some more fixes and minor enhancements

There's some unrelated groups of commits here. I've tried to arrange them such that they can be picked selectively if needed. The following commits are simple bug fixes and cleanup: Mention xkb_state_new can return NULL Properly free xkb_state's Fix latin8 upper/lower case check

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

On Tue, Mar 27, 2012 at 02:59:13PM +0100, Daniel Stone wrote: Hi Ran, On 24 March 2012 15:24, Ran Benita ran...@gmail.com wrote: There's some unrelated groups of commits here. I've tried to arrange them such that they can be picked selectively if needed. Great stuff, thanks. I've

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

On Wed, Mar 28, 2012 at 07:07:57PM +0100, Daniel Stone wrote: Hi, On 27 March 2012 14:59, Daniel Stone dan...@fooishbar.org wrote: In terms of what I have coming up, aside from the context API and vmod merging, I've got a branch that actually adds multiple-keysym support that I just need

Re: [PATCH libxkbcommon] Add xkb_key_get_action API

On Tue, Mar 27, 2012 at 02:27:49PM +0100, Daniel Stone wrote: On 24 March 2012 15:03, Ran Benita ran...@gmail.com wrote: - Some way to update the state according to a given led state, i.e. say  the app is starting with the Caps Lock led on, I'd like to update the  modifier state according

[PULL libxkbcommon] Bug fixes and test changes

) Ran Benita (30): Fairly straightforward fixes, I think they should all be good, but should be cherry-pickable (hope my rebasing didn't mess that up). Move AC_USE_SYSTEMS_EXTENSIONS before AM_INIT_AUTOMAKE Fix compiler warnings Set xorg-macros CFLAGS correctly Fix

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

On Mon, Apr 02, 2012 at 12:04:25PM +0100, Daniel Stone wrote: Hi, On 1 April 2012 16:31, Ran Benita ran...@gmail.com wrote: Also, I might as well mention that I rather like the following interface from the libabc demo library (it's public domain): https://git.kernel.org/?p=linux/kernel

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

is actually to do it as we're doing it now, believe it or not. autotools makes me sad sometimes. Didn't know that; good that you caught it. As for the rest - On 11 April 2012 19:58, Ran Benita ran...@gmail.com wrote: On Mon, Apr 02, 2012 at 12:04:25PM +0100, Daniel Stone wrote: Right, so

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

On Wed, May 09, 2012 at 06:20:35PM +0100, Daniel Stone wrote: On 9 May 2012 16:13, Ran Benita ran...@gmail.com wrote: On Tue, May 08, 2012 at 05:35:23PM +0100, Daniel Stone wrote: Thanks a bunch for all your last changes too, I've merged everything except the DFLT_XKB_CONFIG_ROOT change

Re: [PULL libxkbcommon] Some more fixes and minor enhancements

On Wed, May 09, 2012 at 12:10:57PM -0400, Kristian Høgsberg wrote: Hi Ran, Hi. Let me just point you to this branch as well: http://cgit.freedesktop.org/~krh/libxkbcommon/log/?h=keysyms I've been talking with Daniel about this in IRC, but I thought you might want to take a look too.

[PATCH libxkbcommon 1/2] Move XKB_KEY_NoSymbol to xkbcommon-keysyms.h

This avoids a couple of special cases in the code, and is more consistent. Since anyone who includes xkbcommon.h also gets xkbcommon-keysyms.h, and anyone who include xkbcommon-keysyms.h would want NoSymbol anyway, there's no down side. Signed-off-by: Ran Benita ran...@gmail.com --- Note

[PATCH libxkbcommon 2/2] Remove configure check for X11 keysym files

enough to run git diff before git commit). And the defaults should be fine too. Signed-off-by: Ran Benita ran...@gmail.com --- Makefile.am |9 - configure.ac | 23 --- 2 files changed, 8 insertions(+), 24 deletions(-) diff --git a/Makefile.am b/Makefile.am index

[PULL libxkbcommon] Small fixes and cleanups

to beccc375095c921b8c212b0f992ae88c87ca95ca: Don't run the benchmark by default (2012-05-20 20:31:19 +0300) Ran Benita (9): Fix configure check for xkbparse.c instead of parser.c Fix a memleak Various static analyzer fixes

[PATCH libX11] nls: always use XCOMM instead of # for comments in Compose.pre files

Lines starting with # are considered as preprocessor directives in the .pre files. Fixes warnings like: stdin:3:0: error: invalid preprocessing directive #Khmer Signed-off-by: Ran Benita ran...@gmail.com --- nls/km_KH.UTF-8/Compose.pre | 2 +- nls/sr_CS.UTF-8/Compose.pre | 32

Re: [PATCH 3/3] xkbcomp: Add missing flag support and correct modifier handling of ISOLock

On Sat, Feb 15, 2014 at 05:34:16PM +0100, wettstein...@solnet.ch wrote: +{neither, (XkbSA_LockNoLock | XkbSA_LockNoUnlock)}, You didn't add it, but I do wonder what neither is good for, it renders the action rather useless, no? I added it for consistency to other actions, but if

Re: [PATCH] libxkbfile: Add missing support for NoLock and NoUnlock flags

...@solnet.ch Reviewed-By: Ran Benita ran...@gmail.com --- src/xkbtext.c | 48 ++-- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/src/xkbtext.c b/src/xkbtext.c index b5d4750..bf992e4 100644 --- a/src/xkbtext.c +++ b/src/xkbtext.c

Re: [PATCH] libxkbfile: Add support for genKeyEvent flag

On Sat, Feb 15, 2014 at 05:35:29PM +0100, Andreas Wettstein wrote: ActionMessage has an optional flag genKeyEvent. This change makes sure this flag is printed when it is set. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch Reviewed-By: Ran Benita ran...@gmail.com Ran --- src

Re: [PATCH] xkbcomp Fix missing support for affect and incorrect modifier handling for ISOLock

Wettstein wettstein...@solnet.ch Thanks for respinning. Reviewed-By: Ran Benita ran...@gmail.com Ran --- action.c | 52 +--- 1 file changed, 37 insertions(+), 15 deletions(-) diff --git a/action.c b/action.c index 4623c0c..dd89a1c 100644

Re: [PATCH] xkb: Add missing support for NoLock and NoUnlock flag output

...@solnet.ch This duplication with xkbfile really sucks.. Reviewed-By: Ran Benita ran...@gmail.com --- xkb/xkbtext.c | 48 ++-- 1 file changed, 46 insertions(+), 2 deletions(-) diff --git a/xkb/xkbtext.c b/xkb/xkbtext.c index fdf1d17..5d5f842 100644

Re: [PATCH] xkb: Add support for genKeyEvent flag output

On Sat, Feb 15, 2014 at 05:36:35PM +0100, Andreas Wettstein wrote: ActionMessage has an optional flag genKeyEvent. This change makes sure this flag is printed when it is set. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch Reviewed-By: Ran Benita ran...@gmail.com --- xkb

Re: [PATCH] xkb: Support NoLock and NoUnlock for LockControls

On Sat, Feb 15, 2014 at 05:37:08PM +0100, Andreas Wettstein wrote: The XKB protocol specification demands support for these flags. Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- xkb/xkbActions.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff

Re: [PATCH] xkb: Suppress autorepeat for Set and Lock of Mods, Groups, and Controls

On Sat, Feb 15, 2014 at 05:36:51PM +0100, Andreas Wettstein wrote: The autorepeat for these actions was not correctly implemented, as the key repeat would be mistakenly interpreted as key releases. Rather than fixing this, this change simply disables autorepeat for Set/Lock actions, for two

Re: [PATCH libX11] Compose.man: fix escaped hexadecimal char description

On Sun, Feb 16, 2014 at 07:53:33PM -0500, James Cloos wrote: RB == Ran Benita ran...@gmail.com writes: RB But the grammar in the parser and the implementation say: RB ESCAPED_CHAR ::= ('\\' | '\' | OCTAL | HEX ) RB HEX ::= '\' (x|X) HEX_CHAR [HEX_CHAR]] RB HEX_CHAR

Re: [PATCH REVISED] xkb: Support NoLock and NoUnlock for LockControls

). Anyway, though a bit hard to see, this change covers all bases correctly according to the spec, and the below hunks are good as well, so: Reviewed-By: Ran Benita ran...@gmail.com Thanks, Ran filter-filter = _XkbFilterControls; filter-upAction = *pAction; @@ -772,7 +772,10

Re: Adding multiple characters by a single keypress in X11 with XKB.

On Sun, Feb 23, 2014 at 07:58:27AM +0600, An-Najmus Saqib wrote: Dear Xorg Volunteers, I use a third-party software for Bengali typing in Windows named Avro Keyboard. It provides a graphical keyboard layout editor (only in windows-version, linux version supports only phonetic bengali

[PATCH libXau] Constify XauGetBestAuthByAddr type_names argument

The type names are merely accessed, not changed. So make it const to avoid warnings in other projects (like libxcb) which pass in a static table of string literals. Signed-off-by: Ran Benita ran...@gmail.com --- AuGetBest.c | 2 +- include/X11/Xauth.h | 2 +- man/Xau.man | 2

Re: [patch] xkbcomp: fixing an age-old warning

for MergeReplace, and be consistent with MergeKeys (which uses the same condition as `clobber` to pick the key type). (And while you're here, a tab slipped in). With that you can add: Reviewed-by: Ran Benita ran...@gmail.com (and hope it ever gets applied :) Ran { resultSyms

Re: [patch] xkbcomp: fixing an age-old warning

On Thu, Sep 11, 2014 at 01:36:24AM +0300, Ran Benita wrote: On Tue, Sep 09, 2014 at 10:37:18PM +0200, Benno Schulenberg wrote: Hi, For many keyboard layouts, starting X produces the following warning: Warning: Type ONE_LEVEL has 1 levels, but RALT has 2 symbols

Re: [patch] xkbcomp: fixing an age-old warning

On Thu, Sep 11, 2014 at 10:18:52PM +0200, Benno Schulenberg wrote: On Thu, Sep 11, 2014, at 13:01, Ran Benita wrote: Actually I'm not so sure. The current behavior of a key-group override is per-symbol, e.g. override key FOO { [ NoSymbol, B, C ]; }; Means

[PATCH xlocale-config 1/6] New module

The files (besides README) were adapted from libX11 as of commit 6101b967b641355dd863fd1ce52c6a7d58bcbe68. Signed-off-by: Ran Benita ran...@gmail.com --- .gitignore | 82 ++ COPYING | 942 +++ Makefile.am | 11 + README

[PATCH xlocale-config 3/6] Hook up nls/ to the build

of these itself, so the resulting files are the same. Signed-off-by: Ran Benita ran...@gmail.com --- Makefile.am | 4 configure.ac| 38 +- cpprules.in | 30 ++ m4/ax_define_dir.m4 | 49

xlocale-config

This set of patches splits the locale data (the nls/ directory and a couple of related patches) from Xlib to a separate repository, xlocale-config (the insparation is xkeyboard-config which I think has worked out well). Xlib is made to depend on xlocale-config. The reason for doing this is to be

[PATCH xlocale-config 4/6] Import compose and localedb specs from libX11

Copied (almost) verbatim from libX11 as of commit 6101b967b641355dd863fd1ce52c6a7d58bcbe68. The added Makefile.am files had extraneous SUBDIRS entries removed. Signed-off-by: Ran Benita ran...@gmail.com --- specs/.gitignore| 5 + specs/Makefile.am | 24

[PATCH xlocale-config 2/6] Import nls/ from libX11

This is a verbatim copy of the nls/ directory from libX11 as of commit 6101b967b641355dd863fd1ce52c6a7d58bcbe68. Signed-off-by: Ran Benita ran...@gmail.com --- nls/.gitignore | 12 + nls/C/Compose.pre |0 nls/C/XI18N_OBJS|8

[PATCH 1/4] build: use xlocale-config for things which have moved there

The nls/ directory and the compose and localedb specs were split to a separate repository, xlocale-config. The locale directory path (usually /usr/share/X11/locale) is now obtained from the xlocale-config pkg-config file. Signed-off-by: Ran Benita ran...@gmail.com --- Makefile.am

[PATCH xlocale-config 5/6] Hook up specs/ to the build

Adapted from libX11 as of commit 6101b967b641355dd863fd1ce52c6a7d58bcbe68. Signed-off-by: Ran Benita ran...@gmail.com --- Makefile.am | 2 +- configure.ac | 11 ++- docbook.am | 105 +++ 3 files changed, 116 insertions(+), 2

[PATCH xlocale-config 6/6] Add pkg-config file

Besides the usual stuff, a xlocaledatadir variable is added; this is very useful for programs who wish to use the files without doing guesswork or requiring explicit configure flags. Signed-off-by: Ran Benita ran...@gmail.com --- Makefile.am | 3 +++ configure.ac | 3

[PATCH 3/4] Remove specs/i18n/compose and specs/i18n/localedb

These specs have moved to a separate repository, xlocale-config. Signed-off-by: Ran Benita ran...@gmail.com --- specs/i18n/compose/.gitignore | 2 - specs/i18n/compose/Makefile.am | 20 - specs/i18n/compose/compose-chart.pl | 388 -- specs/i18n/compose/docbook-nl.am

[PATCH 4/4] Remove cpprules.in

It was only used in nls/, which was removed. Signed-off-by: Ran Benita ran...@gmail.com --- cpprules.in | 30 -- 1 file changed, 30 deletions(-) delete mode 100644 cpprules.in diff --git a/cpprules.in b/cpprules.in deleted file mode 100644 index 03d6701..000

[PATCH 2/4] Remove nls/ directory

The locale configuration has moved to a separate repository, xlocale-config. Signed-off-by: Ran Benita ran...@gmail.com --- nls/.gitignore | 12 - nls/C/Compose.pre |0 nls/C/XI18N_OBJS|8 - nls/C/XLC_LOCALE.pre

[PATCH modular] Add xlocale-config module

Signed-off-by: Ran Benita ran...@gmail.com --- build.sh | 1 + xorg.modules | 13 + 2 files changed, 14 insertions(+) diff --git a/build.sh b/build.sh index 6eac65d..7b41112 100755 --- a/build.sh +++ b/build.sh @@ -1022,6 +1022,7 @@ build_all_modules() { build xcb util

Re: xlocale-config

On Sun, Sep 14, 2014 at 11:44:33PM +0300, Ran Benita wrote: This set of patches splits the locale data (the nls/ directory and a couple of related patches) from Xlib to a separate repository, Oops - this meant to say couple of specs. And the non-prefixed patches are meant for libX11. And one

Re: Translating XkbApplyMappingChange() et al. to xcb-xkb

On Fri, Oct 17, 2014 at 03:39:17PM -0300, Laércio de Sousa wrote: Hi there! I'm currently working on a full XCB backend for xf86-video-nested driver. I'm able to translate all Xlib-related code in file xlibclient.c to XCB, except some Xkb related parts which force me to maintain a minimal

Re: [PATCH xserver 1/1] list: Use offsetof() to determine member offsets within a structure

On Tue, Aug 28, 2012 at 11:59:34PM -0700, Jeremy Sequoia wrote: On 08/28/12, Peter Hutterer peter.hutte...@who-t.net wrote: -#define __container_of(ptr, sample, member) \ -    (void *)((char *)(ptr) \ - 

[PATCH libxkbfile] Fix check for appending '|' character when applying rules

of '+', it won't have any effect. Since '|' is practically never used, this wasn't noticed. Signed-off-by: Ran Benita ran...@gmail.com --- src/maprules.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/maprules.c b/src/maprules.c index 81102a3..606b150 100644 --- a/src/maprules.c

[PATCH xserver] xkb: fix check for appending '|' character when applying rules

of '+', it won't have any effect. Since '|' is practically never used, this wasn't noticed. Signed-off-by: Ran Benita ran...@gmail.com --- xkb/maprules.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xkb/maprules.c b/xkb/maprules.c index c6900ec..131853e 100644 --- a/xkb/maprules.c

[PATCH inputproto 1/2] specs: XI2: make event/request name formatting consistent

None of the other have ':' there. Signed-off-by: Ran Benita ran...@gmail.com --- This is just to make scraping the file with a script easier. specs/XI2proto.txt | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/specs/XI2proto.txt b/specs/XI2proto.txt index 76d7695

[PATCH inputproto 2/2] specs: XI2: add titles to requests/events and show them in TOC

You often want to quickly jump to the specification of a specific request/event, so add them to the table of contents to allow for that. This also provides the reader with a quick glance at what the protocol looks like. Signed-off-by: Ran Benita ran...@gmail.com --- specs/XI2proto.txt | 57

Re: [PATCH libxkbcommon 2/2] build: Require xorg macros 1.16

On Fri, Oct 26, 2012 at 12:51:56AM +0100, Damien Lespiau wrote: From: Damien Lespiau damien.lesp...@intel.com For XORG_TESTSET_CFLAG and XORG_MEMORY_CHECK_FLAGS. Thanks, I will take both patches through my tree so they won't get lost. Ran Signed-off-by: Damien Lespiau

Re: [PATCH:libX11] unifdef XKB_IN_SERVER

On Fri, Mar 01, 2013 at 11:41:07PM -0800, Alan Coopersmith wrote: Leftovers from XKB files that were previously shared between the client and server code, but aren't any more. Hi Alan, Would you be averse to doing the same for other XKB-related defines? The server currently uses some files

[PATCH xkbcomp] When a file contains several maps, look for a default map (#69950)

://bugs.freedesktop.org/show_bug.cgi?id=69950 Signed-off-by: Ran Benita ran...@gmail.com --- misc.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/misc.c b/misc.c index 4990a74..848ed8c 100644 --- a/misc.c +++ b/misc.c @@ -82,41 +82,62

Re: [xkb] Do XkbKSIsLower() and XkbKSIsUpper() matter?

On Sat, Oct 26, 2013 at 02:04:55PM -0700, Alan Coopersmith wrote: Does anyone know of any reason to waste time on this function? Can we just delete it altogther now? (libxkbfile is undocumented, and was originally considered private API, but we know software like GNOME has used it in the

Re: [PATCH:libxkbfile 1/4] unifdef -UXKB_IN_SERVER

On Sat, Oct 26, 2013 at 02:09:59PM -0700, Alan Coopersmith wrote: Xserver has its own copy of this code now, so we don't need to keep an unused copy in libxkbfile too. Entire series looks good to me and server still compiles and goes through xkbcomp OK. You can go further with the first patch

Re: [PATCH:libxkbcommon] Make XkbFileCreate argument types match between header implementation

On Fri, Nov 08, 2013 at 05:08:35PM -0800, Alan Coopersmith wrote: Fixes build failure with Solaris Studio compilers: src/xkbcomp/ast-build.c, line 492: identifier redeclared: XkbFileCreate current : function(..., enum xkb_map_flags) previous: function(..., unsigned int) :

Re: [PATCH 2/8] -pendantic is too pendantic

On Wed, Nov 06, 2013 at 07:45:39PM -0800, Keith Packard wrote: Many system headers have warnings when compiled with this flag. This was already committed, but how about changing to AC_CC_C99 instead? pedantic _can_ be useful for XCB imo, e.g. the enum too big for an int thing. Also, the code

Re: [PATCH 2/8] -pendantic is too pendantic

Hi Gaetan, On Tue, Nov 26, 2013 at 07:02:23PM -0500, Gaetan Nadon wrote: On 13-11-26 06:33 PM, Ran Benita wrote: This was already committed, but how about changing to AC_CC_C99 instead? Pardon me as I am out of context. The xserver module is configured with AC_PROG_CC_C99 that gets pulled

[PATCH libX11 2/2] nls: remove duplicate Hebrew compose sequences

Some of the hebrew keysyms come in different spellings, but are just aliases, so the sequences are duplicates. Remove the ones which keysymdef.h marks 'deprecated'. Signed-off-by: Ran Benita ran...@gmail.com --- nls/en_US.UTF-8/Compose.pre | 10 -- 1 file changed, 10 deletions(-) diff

[PATCH libX11 1/2] nls: remove duplicate 'ohorn' and 'uhorn' compose sequences

), there is no need to have both names. Remove the unicode literal ones. Signed-off-by: Ran Benita ran...@gmail.com --- nls/en_US.UTF-8/Compose.pre | 20 1 file changed, 20 deletions(-) diff --git a/nls/en_US.UTF-8/Compose.pre b/nls/en_US.UTF-8/Compose.pre index 7314d7f..5434425 100644

[PATCH libX11 0/2] Remove duplicate compose sequences

I was playing with en_US.UTF-8 file a bit. These patches fix the issues I found while constructing the trie. Happily the sequences are all prefix-free, so there are only some duplicates to remove. Ran Benita (2): nls: remove duplicate 'ohorn' and 'uhorn' compose sequences nls: remove

Re: [PATCH 0/3] xkb: Fix ISOLock

Hi Andreas, On Thu, Jan 23, 2014 at 09:00:11PM +0100, wettstein...@solnet.ch wrote: The goal of the following patches is to make ISOLock work. The most severe issues addressed were in the server, where the code used the incorrect byte to look for the affect flags, and where the ClearLocks

[PATCH libX11] Remove dead USE_OWN_COMPOSE-protected code

The build doesn't provide any way to define this option. It also refers to files (imComp.h) and functions (e.g. XimCompInitTables(), XimCompProcessSym()) which are not found anywhere, and the ordinary Compose implementation in xim doesn't use any of it. Signed-off-by: Ran Benita ran...@gmail.com

Re: [PATCH 3/3] xkbcomp: Add missing flag support and correct modifier handling of ISOLock

might want to address, but: Reviewed-By: Ran Benita ran...@gmail.com Signed-off-by: Andreas Wettstein wettstein...@solnet.ch --- action.c | 102 ++- 1 file changed, 62 insertions(+), 40 deletions(-) diff --git a/action.c b

Re: [PATCH 2/3] libxkbfile: Add a few missing flags the output of the xkb layout

On Thu, Jan 23, 2014 at 08:39:55PM +0100, Andreas Wettstein wrote: Output affect flags for control locks, modifier locks, and ISOLock. Output flag genKeyEvent flag for message actions. Do not generate output for any of these if the flags have their default setting, to avoid problems of

Re: [PATCH 1/3] xkb: Several fixes to ISOLock and a few related changes.

On Thu, Jan 23, 2014 at 08:39:49PM +0100, Andreas Wettstein wrote: Several fixes to ISOLock: - Use the proper byte to access the affect flags. - When changing a Set/Latch action to a Lock action, also change the flags for the action. - Respect NoLock/NoUnlock. - Add the missing

[PATCH libX11 2/2] compose: fix the description of modifiers in compose sequences

` and `modifier` in parseline() in imLcPrs.c, which are eventually matched as `ev-state modifier_mask == modifier`). Also explicitly list the accepted modifier names, since they are not standard (e.g. Ctrl instead of Control). Signed-off-by: Ran Benita ran...@gmail.com --- man/Compose.man| 16

[PATCH libX11 1/2] xkb: fix misleading comment about consumed modifiers

In the spec and the man page the `mods_rtrn` argument is described as backfilled with unconsumed modifiers but actually it is backfilled with the *consumed* modifiers. This is also mentioned a few lines below in each case. Signed-off-by: Ran Benita ran...@gmail.com --- I made the context big

Re: Multiple Key Repeat

On Sat, Apr 04, 2015 at 03:17:29AM +0200, Vasil Zlatanov wrote: Currently when you hold down two keys at the same time on the keyboard, say for instance 'g' and '0' only the second key is repeated, producing g000.. or 0ggg... On Microsoft Windows (given the right keyboard) if you press 'g' and

Re: Hiding keyboard state

On Mon, Nov 23, 2015 at 11:04:10AM -0800, Keith Packard wrote: > > One of the many security holes in X is that any application can monitor > the state of the keyboard device by querying the list of pressed keys on > a regular basis. Here's a simple patch which makes that request report > only key

Re: New composers for local languages in Togo

On Tue, Jan 19, 2016 at 01:16:40AM +0100, Mats Blakstad wrote: > I've opened this ticket: > https://bugs.freedesktop.org/show_bug.cgi?id=93660 > > I need some feedback to be able to upload a final verion! > > How should the composer be formatted. Now each composer is added like this: > > *

Re: [PATCH kdrive/ephyr] kdrive/ephyr: map host X server's keymap into Xephyr, if supported

On Tue, Feb 23, 2016 at 07:58:04AM -0300, Laércio de Sousa wrote: > Currently Xephyr doesn't inherit host X server's keymap, which > may lead to keymap mismatches when typing in a window inside > Xephyr. If host X server supports XKB extension, this patch > uses xcb-xkb to apply its keymap in

Re: Debugging keyboard overlay+xbindkeys

On Thu, Nov 03, 2016 at 01:22:03PM +0100, Mariusz Mazur wrote: > What I did: > 1. Switched the overlay key to act as a modifier. > interpret Overlay1_Enable+AnyOfOrNone(all) { > -action= LockControls(controls=Overlay1); > +action= SetControls(controls=Overlay1); > > 2. Bound

Re: [RFC libX11 2/2] nls: Verify Compose at build

On Sun, Apr 02, 2017 at 10:27:28PM +0500, Mihail Konev wrote: > Signed-off-by: Mihail Konev > --- > nls/Makefile.am | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/nls/Makefile.am b/nls/Makefile.am > index 57665fff4282..c0f0d0c7181f

  1   2   >