Re: [PATCH libX11] config: Add an option to initialize threads by default.

for instance, you will see that it is close to impossible to track from a stack trace of 80 functions whether XInitThreads() is called properly or not. At the same time, it's not a big deal to maintain the support Rami made in libX11. So why not? Acked-by: Tiago Vignatti tiago.vigna...@nokia.com

Re: [PATCH libX11] config: Add an option to initialize threads by default.

On 01/31/2011 04:06 PM, ext Julien Cristau wrote: On Mon, Jan 31, 2011 at 15:12:29 +0200, Tiago Vignatti wrote: On 01/31/2011 01:13 PM, ext Julien Cristau wrote: On Mon, Jan 31, 2011 at 12:46:56 +0200, Rami Ylimäki wrote: This change makes it possible to guard a system against a missing

[PATCH] xorg: remove unused assigned values all over the server

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- The first hunk is the most bizarre found and a bit harder to review. For this, I didn't want to change the logic from the original and seems the functioning is not correct. Xext/xtest.c |5 + Xi/getprop.c

[PATCH] dix: remove unused debug code

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/dixfonts.c | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index d8f1529..316a8a5 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -66,10 +66,6 @@ Equipment

[PATCH] dix: remove unused macro

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/dixfonts.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 316a8a5..71689cf 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -70,8 +70,6 @@ Equipment Corporation

[PATCH 02/11] mi: fix memory leak in miInitVisuals

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- mi/micmap.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mi/micmap.c b/mi/micmap.c index 41e0300..7448ef8 100644 --- a/mi/micmap.c +++ b/mi/micmap.c @@ -564,6 +564,8 @@ miInitVisuals(VisualPtr *visualp

[PATCH 04/11] xi: fix memory leak in ProcXListProperties and ProcXIListProperties

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xi/xiproperty.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Xi/xiproperty.c b/Xi/xiproperty.c index 83ce930..b55e7f3 100644 --- a/Xi/xiproperty.c +++ b/Xi/xiproperty.c @@ -904,8 +904,8

[PATCH 01/11] xfree86: dri2: fix memory leak in DRI2AddDrawableRef

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/dri2/dri2.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index 9ca378f..53f1e33 100644 --- a/hw/xfree86/dri2/dri2.c +++ b/hw/xfree86/dri2/dri2.c

[PATCH 03/11] xi: fix memory leak in ProcXIQueryDevice

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xi/xiquerydevice.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Xi/xiquerydevice.c b/Xi/xiquerydevice.c index 8b54211..8b69904 100644 --- a/Xi/xiquerydevice.c +++ b/Xi/xiquerydevice.c @@ -107,8 +107,10

[PATCH 07/11] Xi: fix memory leak in ProcXGetSelectedExtensionEvents

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xi/getselev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Xi/getselev.c b/Xi/getselev.c index 09a53f4..7304738 100644 --- a/Xi/getselev.c +++ b/Xi/getselev.c @@ -152,8 +152,8

[PATCH 09/11] xfree86: fix memory leak in xf86ConfigFbEntity

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c index 1a5bf8a..62395ae 100644 --- a/hw/xfree86/common/xf86Helper.c

[PATCH 11/11] xfree86: fix memory leak in xf86LoadModules

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Init.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86Init.c b/hw/xfree86/common/xf86Init.c index e664ce4..d81303e 100644 --- a/hw/xfree86/common/xf86Init.c +++ b/hw

[PATCH 05/11] mi: fix memory leak in miFillUniqueSpanGroup

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- mi/mispans.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mi/mispans.c b/mi/mispans.c index 53539e5..92f0d02 100644 --- a/mi/mispans.c +++ b/mi/mispans.c @@ -458,6 +458,8 @@ void miFillUniqueSpanGroup

[PATCH 10/11] xfree86: fix memory leak in configLayout

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Config.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c index 4b897a1..82754fc 100644 --- a/hw/xfree86/common/xf86Config.c

[PATCH 06/11] dix: fix memory leak in SetDefaultFontPath

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/dixfonts.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 71689cf..793ce08 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -1815,8 +1815,10 @@ SetDefaultFontPath

[PATCH 08/11] fb: fix memory leak in fbOverlayFinishScreenInit

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- fb/fboverlay.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/fb/fboverlay.c b/fb/fboverlay.c index 7fca89c..99985a5 100644 --- a/fb/fboverlay.c +++ b/fb/fboverlay.c @@ -390,12 +390,16

Re: [PATCH] dix: remove unused debug code

Hi, On 03/25/2011 04:42 PM, ext Mark Kettenis wrote: From: Tiago Vignattitiago.vigna...@nokia.com Date: Fri, 25 Mar 2011 16:31:41 +0200 Sorry, but what gives you the authority to say this debug code isn't useful? The code inside DEBUG is deliberately useless and the one in FONTDEBUG could

Re: [PATCH 04/11] xi: fix memory leak in ProcXListProperties and ProcXIListProperties

On 03/26/2011 01:34 AM, ext Nicolas PENINGUY wrote: On Fri, 2011-03-25 at 20:41 +0200, Tiago Vignatti wrote: diff --git a/Xi/xiproperty.c b/Xi/xiproperty.c index 83ce930..b55e7f3 100644 --- a/Xi/xiproperty.c +++ b/Xi/xiproperty.c @@ -904,8 +904,8 @@ ProcXListDeviceProperties (ClientPtr client

Re: [PATCH 11/11] xfree86: fix memory leak in xf86LoadModules

On 03/26/2011 01:02 AM, ext Nicolas PENINGUY wrote: On Fri, 2011-03-25 at 20:41 +0200, Tiago Vignatti wrote: diff --git a/hw/xfree86/common/xf86Init.c b/hw/xfree86/common/xf86Init.c index e664ce4..d81303e 100644 --- a/hw/xfree86/common/xf86Init.c +++ b/hw/xfree86/common/xf86Init.c @@ -1433,6

[PATCHv2 03/13] xorg: remove unused pointer values all over the server

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xext/xtest.c |5 + Xi/getprop.c |2 +- Xi/getselev.c |4 ++-- hw/xfree86/common/xf86Config.c |4 ++-- mi/midispcur.c | 10 +- mi

[PATCHv2 06/13] xi: fix memory leak in ProcXIQueryDevice

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- Xi/xiquerydevice.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Xi/xiquerydevice.c b/Xi/xiquerydevice.c index 8b54211..8b69904 100644 --- a/Xi/xiquerydevice.c

[PATCHv2 05/13] mi: fix memory leak in miInitVisuals

Free the pointers inside miInitVisuals, so the callers of this function (fboverlay.c and fbscreen.c) don't need to worry with deallocation in the case of failure. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- fb/fbscreen.c |4 mi/micmap.c |2 ++ 2 files changed, 2

[PATCHv2 04/13] xfree86: dri2: fix memory leak and free resources properly

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- hw/xfree86/dri2/dri2.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index 9ca378f..10be599 100644

[PATCHv2 02/13] dix: remove unused macro

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/dixfonts.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 316a8a5..71689cf 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -70,8 +70,6 @@ Equipment Corporation

[PATCHv2 07/13] mi: fix memory leak in miFillUniqueSpanGroup

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- mi/mispans.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mi/mispans.c b/mi/mispans.c index 53539e5..21ba4da 100644 --- a/mi/mispans.c +++ b/mi/mispans.c

[PATCHv2 11/13] xfree86: fix memory leak in xf86ConfigFbEntity

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- hw/xfree86/common/xf86Helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c index 1a5bf8a

[PATCHv2 01/13] dix: remove unused debug code

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net --- dix/dixfonts.c | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index d8f1529..316a8a5 100644 --- a/dix/dixfonts.c

[PATCHv2 09/13] Xi: fix memory leak in ProcXGetSelectedExtensionEvents

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xi/getselev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Xi/getselev.c b/Xi/getselev.c index 09a53f4..7304738 100644 --- a/Xi/getselev.c +++ b/Xi/getselev.c @@ -152,8 +152,8

[PATCHv2 13/13] xfree86: fix memory leak in xf86LoadModules

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Init.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86Init.c b/hw/xfree86/common/xf86Init.c index e664ce4..d81303e 100644 --- a/hw/xfree86/common/xf86Init.c +++ b/hw

[PATCHv2 10/13] fb: fix memory leak in fbOverlayFinishScreenInit

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- fb/fboverlay.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/fb/fboverlay.c b/fb/fboverlay.c index 7fca89c..45e6370 100644 --- a/fb/fboverlay.c +++ b/fb

[PATCHv2 08/13] dix: fix memory leak in SetDefaultFontPath

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- dix/dixfonts.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 71689cf..fbac124 100644 --- a/dix/dixfonts.c +++ b/dix

[PATCHv2 12/13] xfree86: fix memory leaks in configLayout

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Config.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c index 4b897a1..5fd5eb8 100644 --- a/hw/xfree86

[PATCHv3 03/14] xorg: remove unused pointer values all over the server

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xext/xtest.c |5 + Xi/getprop.c |2 +- Xi/getselev.c |4 ++-- hw/xfree86/common/xf86Config.c |4 ++-- mi/midispcur.c | 10 +- mi

[PATCHv3 02/14] dix: remove unused macro

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/dixfonts.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 316a8a5..71689cf 100644 --- a/dix/dixfonts.c +++ b/dix/dixfonts.c @@ -70,8 +70,6 @@ Equipment Corporation

[PATCHv3 04/14] xfree86: dri2: fix memory leak and free resources properly

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- hw/xfree86/dri2/dri2.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c index 9ca378f..10be599 100644

[PATCHv3 05/14] mi: fix memory leak in miInitVisuals

Free the pointers inside miInitVisuals, so the callers of this function (fboverlay.c and fbscreen.c) don't need to worry with deallocation in the case of failure. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- fb/fbscreen.c |4 mi/micmap.c |2 ++ 2 files changed, 2

[PATCHv3 01/14] dix: remove unused debug code

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net --- dix/dixfonts.c | 12 1 files changed, 0 insertions(+), 12 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index d8f1529..316a8a5 100644 --- a/dix/dixfonts.c

[PATCHv3 07/14] mi: fix memory leak in miFillUniqueSpanGroup

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- mi/mispans.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/mi/mispans.c b/mi/mispans.c index 53539e5..21ba4da 100644 --- a/mi/mispans.c +++ b/mi/mispans.c

[PATCHv3 09/14] Xi: fix memory leak in ProcXGetSelectedExtensionEvents

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xi/getselev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Xi/getselev.c b/Xi/getselev.c index 09a53f4..7304738 100644 --- a/Xi/getselev.c +++ b/Xi/getselev.c @@ -152,8 +152,8

[PATCHv3 06/14] xi: fix memory leak in ProcXIQueryDevice

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- Xi/xiquerydevice.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Xi/xiquerydevice.c b/Xi/xiquerydevice.c index 8b54211..8b69904 100644 --- a/Xi/xiquerydevice.c

[PATCHv3 12/14] xfree86: fix memory leaks in configLayout

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Thanks Nicolas Peninguy for helping with this one! I hope now it's okay... and by the way, I found a similar problem in the same file when deallocating a pointer on configInputDevices; see the following patch (13/14). hw/xfree86/common

[PATCHv3 08/14] dix: fix memory leak in SetDefaultFontPath

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- dix/dixfonts.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dix/dixfonts.c b/dix/dixfonts.c index 71689cf..fbac124 100644 --- a/dix/dixfonts.c +++ b/dix

[PATCHv3 14/14] xfree86: fix memory leak in xf86LoadModules

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Alan, I guess you can S-o-b this one? hw/xfree86/common/xf86Init.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/common/xf86Init.c b/hw/xfree86/common/xf86Init.c index e664ce4..0b36163 100644

[PATCHv3 11/14] xfree86: fix memory leak in xf86ConfigFbEntity

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- hw/xfree86/common/xf86Helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86Helper.c b/hw/xfree86/common/xf86Helper.c index 1a5bf8a

[PATCHv3 10/14] fb: fix memory leak in fbOverlayFinishScreenInit

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- fb/fboverlay.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/fb/fboverlay.c b/fb/fboverlay.c index 7fca89c..45e6370 100644 --- a/fb/fboverlay.c +++ b/fb

[PATCHv3 13/14] xfree86: fix bad free configInputDevices

introduced in e1165632bdfbd720889ed1adf5f7ab338032c0ee. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Config.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c index

[PATCH 02/10] os: fix memory leak in Popen

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- os/utils.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/os/utils.c b/os/utils.c index f47177f..74fe841 100644 --- a/os/utils.c +++ b/os/utils.c @@ -1315,6 +1315,7 @@ Popen(char *command, char *type

[PATCH 04/10] dix: fix memory leak in AllocShared

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/colormap.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dix/colormap.c b/dix/colormap.c index 188378b..0e1feb6 100644 --- a/dix/colormap.c +++ b/dix/colormap.c @@ -2105,6 +2105,7 @@ AllocShared (ColormapPtr

[PATCH 03/10] dix: fix memory leak in AllocPseudo

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/colormap.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dix/colormap.c b/dix/colormap.c index 2e9a806..188378b 100644 --- a/dix/colormap.c +++ b/dix/colormap.c @@ -1879,6 +1879,7 @@ AllocPseudo (int client

[PATCH 01/10] os: use DebugF for debugging

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- os/utils.c | 18 -- 1 files changed, 4 insertions(+), 14 deletions(-) diff --git a/os/utils.c b/os/utils.c index a365aca..f47177f 100644 --- a/os/utils.c +++ b/os/utils.c @@ -1256,10 +1256,7 @@ System(char *command

[PATCH 06/10] xfree86: loader: fix memory leaks in LoaderListDirs

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/loader/loadmod.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c index eaa99e8..f304d0a 100644 --- a/hw/xfree86/loader/loadmod.c +++ b/hw

[PATCH 10/10] render: fix memory leaks in ProcRenderCompositeGlyphs

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- render/render.c | 25 - 1 files changed, 12 insertions(+), 13 deletions(-) diff --git a/render/render.c b/render/render.c index 8ff8ee6..c5da6d7 100644 --- a/render/render.c +++ b/render/render.c @@ -1372,8

[PATCH 05/10] xi: fix memory leak in AddExtensionClient

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xi/exevents.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Xi/exevents.c b/Xi/exevents.c index c7089bb..6923f6a 100644 --- a/Xi/exevents.c +++ b/Xi/exevents.c @@ -1631,14 +1631,18 @@ AddExtensionClient

[PATCH 07/10] mi: fix memory leak in miZeroLine

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- mi/mizerline.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/mi/mizerline.c b/mi/mizerline.c index 07cfbe1..7077b51 100644 --- a/mi/mizerline.c +++ b/mi/mizerline.c @@ -157,9 +157,11 @@ miZeroLine

[PATCH 09/10] xkb: fix memory leak in XkbDDXListComponent

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- xkb/ddxList.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/xkb/ddxList.c b/xkb/ddxList.c index 9623cb6..3d301d8 100644 --- a/xkb/ddxList.c +++ b/xkb/ddxList.c @@ -222,8 +222,10 @@ char tmpname[PATH_MAX

Re: [PATCH] mi: Remove unused overlay support

attached then? It makes no differene if some driver would ever start use it by pulling back in server, but it won't clutter mi until then. Acked-by: Tiago Vignatti tiago.vigna...@nokia.com Tiago ___ xorg-devel@lists.x.org: X.Org development Archives

Re: [PATCH] mi: Remove unused overlay support

On 03/29/2011 08:40 PM, ext Aaron Plattner wrote: I disagree. mi is a toolkit of machine-independent driver support routines. While I understand that X needs to advance forward and gain features, I don't think it should turn its back on its loyal professional workstation heritage either. we

Re: [PATCHv3 13/14] xfree86: fix bad free configInputDevices

On 03/30/2011 04:18 PM, ext Dan Nicholson wrote: On Tue, Mar 29, 2011 at 8:08 AM, Tiago Vignatti tiago.vigna...@nokia.com wrote: introduced in e1165632bdfbd720889ed1adf5f7ab338032c0ee. Actually, it would have been an earlier commit since Peter just moved this code to a convenience function

Re: [PATCH 06/10] xfree86: loader: fix memory leaks in LoaderListDirs

On 03/30/2011 02:46 AM, ext Nicolas PENINGUY wrote: On Tue, 2011-03-29 at 18:12 +0300, Tiago Vignatti wrote: +++ b/hw/xfree86/loader/loadmod.c @@ -556,6 +558,9 @@ LoaderListDirs(const char **subdirlist, const char **patternlist) } if (listing) listing[n] = NULL

Re: [PATCH 02/10] os: fix memory leak in Popen

On 03/30/2011 02:10 AM, ext Nicolas PENINGUY wrote: On Tue, 2011-03-29 at 18:12 +0300, Tiago Vignatti wrote: +++ b/os/utils.c @@ -1315,6 +1315,7 @@ Popen(char *command, char *type) /* Ignore the smart scheduler while this is going on */ old_alarm = OsSignal(SIGALRM, SIG_IGN

[PATCHv2 2/2] xfree86: loader: use one exit code only for readability

No functional changes. Spaghetti code for win! \o/ Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/loader/loadmod.c | 34 ++ 1 files changed, 14 insertions(+), 20 deletions(-) diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader

[PULL] xserver leaks

f9834d312e3059073e8ad77d9f9d57cb9d96e1e5: Dave Airlie (1): fb: cleanup fbChangeWindowAttributes are available in the git repository at: ssh+git://vigna...@people.freedesktop.org/~vignatti/xserver for-keith Tiago Vignatti (23): dix: remove unused debug code dix: remove unused macro

Re: [PULL] xserver leaks

Hi Jeremy, On 04/04/2011 01:50 PM, ext Tiago Vignatti wrote: Tiago Vignatti (23): dix: remove unused debug code dix: remove unused macro xorg: remove unused pointer values all over the server xfree86: dri2: fix memory leak and free resources properly mi: fix

[PATCH 3/5] dix: set pointer to NULL after freeing at CloseDevice

It will fix two possible cases of use after free in RemoveDevice. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/devices.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dix/devices.c b/dix/devices.c index 534931c..0288e15 100644 --- a/dix/devices.c

[PATCH 1/5] xfree86: xv: fix double free in xf86XVFreeAdaptor

instead the number of attributes. Such pointer will be deallocated when xf86XVFreeAdaptor is called first and will not let the code re-run in the following calls. This is a bit similar how the surroundings code is already doing. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw

[PATCH 5/5] dix: don't free stranger pointers inside AllocARGBCursor

). Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/cursor.c|5 + dix/dispatch.c | 12 +--- render/render.c | 12 +--- 3 files changed, 19 insertions(+), 10 deletions(-) diff --git a/dix/cursor.c b/dix/cursor.c index 72a7609..c191c1e 100644 --- a/dix

[PATCH 2/5] xfree86: xv: set pointers to NULL in xf86XVFreeAdaptor

-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86xv.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/common/xf86xv.c b/hw/xfree86/common/xf86xv.c index f87af4c..b46dfef 100644 --- a/hw/xfree86/common/xf86xv.c +++ b/hw/xfree86/common/xf86xv.c

[PATCH 4/5] os: fix use after free in EstablishNewConnections

In the case of failure on AllocNewConnection, new_trans_conn cannot be dereferenced because it's already freed. Swapping the order of this logic fix the changes introduced in 04956b80431169e0ae713a3e6ba4cdc157ce3a66. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com CC: Jeremy Huddleston

[PATCH v2] xfree86: loader: use one exit code only for readability

No functional changes. Spaghetti code for the win! \o/ Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Nicolas Peninguy n...@lostgeeks.org --- hw/xfree86/loader/loadmod.c | 32 1 files changed, 12 insertions(+), 20 deletions(-) diff --git

Re: [PATCH 4/5] os: fix use after free in EstablishNewConnections

On 04/04/2011 09:54 PM, ext Jeremy Huddleston wrote: I just pushed them. I'll cherry-pick this fix into stable once Keith adds it to master. okay, thanks Jeremy. So I guess I got a r-b for this one? :) On Apr 4, 2011, at 10:54 AM, Tiago Vignatti wrote: In the case of failure

Re: [PATCH 3/5] dix: set pointer to NULL after freeing at CloseDevice

On 04/05/2011 03:14 PM, ext Simon Thum wrote: On 04/04/2011 07:54 PM, Tiago Vignatti wrote: It will fix two possible cases of use after free in RemoveDevice. Signed-off-by: Tiago Vignattitiago.vigna...@nokia.com --- dix/devices.c |1 + 1 files changed, 1 insertions(+), 0 deletions

Re: [PATCH dix] dix: Added a flat acceleration profile that provides a linear pointer response.

On 04/05/2011 03:41 PM, ext Daniel Stone wrote: Hi, On Tue, Apr 05, 2011 at 02:07:33PM +0200, Simon Thum wrote: Well, it's an RFC by Peter at the moment, AFAIK not much to read. I'll add a bit to my idea FYC. The concept would probably use pixman and list.h-lists and look something like: So,

Re: [PATCH 3/5] dix: set pointer to NULL after freeing at CloseDevice

On 04/05/2011 03:54 PM, ext Simon Thum wrote: On 04/05/2011 01:27 PM, Tiago Vignatti wrote: On 04/05/2011 03:14 PM, ext Simon Thum wrote: On 04/04/2011 07:54 PM, Tiago Vignatti wrote: It will fix two possible cases of use after free in RemoveDevice. Signed-off-by: Tiago Vignattitiago.vigna

Re: [PATCH dix] dix: Added a flat acceleration profile that provides a linear pointer response.

On 04/05/2011 04:05 PM, ext Daniel Stone wrote: On Tue, Apr 05, 2011 at 03:45:58PM +0300, Tiago Vignatti wrote: On 04/05/2011 03:41 PM, ext Daniel Stone wrote: I ask mainly because we already have a very extensively-engineered pointer acceleration architecture, where 90% of the code could

Re: On complexifigurability

Daniel, On 04/05/2011 05:51 PM, ext Daniel Stone wrote: On Tue, Apr 05, 2011 at 04:30:38PM +0300, Tiago Vignatti wrote: But my point is (well, always was) to chop off the server internal modules in parts so we can have a lean implementation for different purposes and cover everyone's desires

[PULL] use-after-free fixes for xserver

Tiago Vignatti (5): xfree86: loader: use one exit code only for readability xfree86: xv: fix double free in xf86XVFreeAdaptor xfree86: xv: set pointers to NULL in xf86XVFreeAdaptor os: fix use after free in EstablishNewConnections dix: don't free stranger pointers inside

Re: [PATCH 1/2] dri2: Handle calloc() failure

On 04/12/2011 05:37 PM, ext ville.syrj...@nokia.com wrote: From: Ville Syrjäläville.syrj...@nokia.com Don't access invalid memory if calloc() fails to allocate the buffers array. Signed-off-by: Ville Syrjäläville.syrj...@nokia.com Reviewed-by: Tiago Vignatti tiago.vigna...@nokia.com

Re: [PATCH 2/2] dri2: Pass out_count by value to update_dri2_drawable_buffers()

On 04/12/2011 05:37 PM, ext ville.syrj...@nokia.com wrote: From: Ville Syrjäläville.syrj...@nokia.com update_dri2_drawable_buffers() doesn't modify out_count, so pass it by value. Signed-off-by: Ville Syrjäläville.syrj...@nokia.com Reviewed-by: Tiago Vignatti tiago.vigna...@nokia.com

Re: [PATCH] test: remove glib dependency

. g_test_run replaced with a simple return 0. Signed-off-by: Peter Huttererpeter.hutte...@who-t.net Acked-by: Tiago Vignatti tiago.vigna...@nokia.com Tiago ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg

Re: [PATCH 1/3] xfree86: drop linux libc5 support from the SIGIO code

Reviewed-by: Tiago Vignatti tiago.vigna...@nokia.com Tiago ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/3] xfree86: Remove unused xf86AssertBlockedSIGIO

development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel Seems block and unblock procedures are always explicit called and there won't be a state where we may need to check for an unknown state: Reviewed-by: Tiago Vignatti tiago.vigna

Re: [PATCH 3/3] xfree86: Add a conservative SIGIO handler path

On Thu, Oct 14, 2010 at 06:49:06PM +0200, ext Adam Jackson wrote: Instead of actually processing input in the handler, the conservative path just raises enough of a dispatch exception to bomb out of request processing and handle input instead. ajax, I understand the rationale but would be

Re: [PATCH 2/3] xfree86: Remove unused xf86AssertBlockedSIGIO

On Thu, Oct 14, 2010 at 09:29:33PM +0200, ext Aaron Plattner wrote: On Thu, Oct 14, 2010 at 12:19:49PM -0700, Adam Jackson wrote: On Thu, 2010-10-14 at 12:12 -0700, Aaron Plattner wrote: On Thu, Oct 14, 2010 at 09:49:05AM -0700, Adam Jackson wrote: Signed-off-by: Adam Jackson

Re: [PATCH] os: Delete the XDM client when a connection is closed.

On Mon, Oct 18, 2010 at 06:25:48PM +0200, ext Michał Górny wrote: This patch introduces a concept of ClientPtr tracking in the xdm auth code. It makes sure that the xdm authentication data for a particular client is removed immediately when the client disconnects, making the semi-random client

Re: [PATCH v3 1/2] dix: Add facilities for client ID tracking.

On Tue, Oct 05, 2010 at 09:55:59AM +0200, ext Rami Ylim�ki wrote: On 10/02/2010 02:00 AM, Jesse Adkins wrote: +AC_ARG_ENABLE(clientids, AS_HELP_STRING([--disable-clientids], [Build Xorg with client ID tracking (default: enabled)]), [CLIENTIDS=$enableval], [CLIENTIDS=yes])

[PATCH] dix: delete logo hack screen saver

Protocol doesn't mention about screen saver with logo being required and people are already using more intelligent ways to draw screen saver themes. So consider -logo as deprecated option, deleting its code. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/globals.c|4

[PATCH] dix: advance parent window pointer when no node is found

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/window.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dix/window.c b/dix/window.c index 4a47dd5..b9d5b1e 100644 --- a/dix/window.c +++ b/dix/window.c @@ -3658,8 +3658,9 @@ WindowParentHasDeviceCursor

[PATCH v2] dix: delete logo hack screen saver

Protocol doesn't mention about screen saver with logo being required and people are already using more intelligent ways to draw screen saver themes. So consider -logo as deprecated option, deleting its code. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Mikhail Gusarov

Re: XDS2010 videos on youtube

On Sat, Oct 23, 2010 at 07:44:44PM +0200, ext Matt Dew wrote: For those interested, I took videos of the presentations at XDS2010 with my little Canon camera. I've posted them to youtube. search for XDS2010 and you'll see the new low-def ones next to Michael's (from phoronix.com) high-def

[PATCH v2] dix: advance parent window pointer when no node is found

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Signed-off-by: Pauli Nieminen ext-pauli.niemi...@nokia.com --- dix/window.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dix/window.c b/dix/window.c index 1913030..edb146e 100644 --- a/dix/window.c +++ b/dix

Re: [PATCH] [RFC] xinerama: attempt to unify the two protocol implementations.

On Tue, Oct 26, 2010 at 06:27:39PM +0200, ext Alan Coopersmith wrote: Dave Airlie wrote: From: Dave Airlie airl...@redhat.com randr and panoramiX have had two separate copies of this code for long enough, this patch sets up a separate xinerama protocol that both randr and

[PATCH] dix: adds support for none root window background

: http://lists.freedesktop.org/archives/xorg-devel/2010-June/009755.html Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- dix/window.c |6 ++ include/opaque.h |1 + include/scrnintstr.h |5 + os/utils.c |3 +++ 4 files changed, 15 insertions

[PATCH 00/15] xserver: cleanup and standardize startup options

your review! Tiago Vignatti (15): os: remove superfluous -br option xfree86: xwin: do not parse -xf86config cmd line option xfree86: remove unused -s option xfree86: xquartz: remove superfluous -showconfig option dix: xfree86: remove superfluous +br simplifying backing store support

[PATCH 04/15] xfree86: xquartz: remove superfluous -showconfig option

It's there since the first cvs revision there for compatibility reasons. Therefore time to deprecate it now. -version does the same job. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Init.c|2 +- hw/xfree86/doc/man/Xorg.man.pre |8 hw

[PATCH 02/15] xfree86: xwin: do not parse -xf86config cmd line option

We have already -config for the same purpose, which is documented and doing the proper job. Therefore remove superfluous -xf86config option. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- hw/xfree86/common/xf86Init.c |2 +- hw/xwin/winprocarg.c |3 +-- 2 files changed

[PATCH 07/15] os: xinerama: remove hack and undocumented -disablexineramaextension option

We are not supposed to hack the server to address client issues (see bug #1846 for more details). This reverts commit cdc15e22. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- Xext/panoramiX.c |8 include/globals.h |4 os/utils.c|7 --- 3 files

[PATCH 09/15] os: remove superfluous -I option

We don't need it. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- os/utils.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/os/utils.c b/os/utils.c index 3a8e9cf..e9280bb 100644 --- a/os/utils.c +++ b/os/utils.c @@ -478,7 +478,6 @@ void UseMsg(void

[PATCH 13/15] os: standardize option to enabling/disabling extensions

+extension - -enableext -extension - -disableext Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- os/utils.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/os/utils.c b/os/utils.c index 0a4fca4..2f6eb0c 100644 --- a/os/utils.c +++ b/os/utils.c @@ -517,8

[PATCH 12/15] os: remove superfluous v option

screen saver is blanking by default already. Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- os/utils.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/os/utils.c b/os/utils.c index 2482ca1..0a4fca4 100644 --- a/os/utils.c +++ b/os/utils.c @@ -507,7 +507,6

[PATCH 14/15] os: rename and document -pogo option

Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com --- os/utils.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/os/utils.c b/os/utils.c index 2f6eb0c..6a70509 100644 --- a/os/utils.c +++ b/os/utils.c @@ -517,6 +517,7 @@ void UseMsg(void) ErrorF(-dumbSched

  1   2   3   4   5   6   >