Re: [PATCH xserver] modesetting: always set a hardware cursor when requested to load one.

On Wed, Sep 28, 2016 at 12:05 PM, Michel Dänzer wrote: > On 27/09/16 10:54 PM, Michael Thayer wrote: >> On 27.09.2016 12:06, Hans de Goede wrote: >>> On 23-09-16 10:20, Hans de Goede wrote: On 09/16/2016 06:52 PM, Michael Thayer wrote: > When the X server asks us to

Re: [RESEND,v4] xfree86: Immediately handle failure to set HW cursor

Hi Hans, apologies for the delayed reply! On Thu, Sep 1, 2016 at 11:24 PM, Hans de Goede <hdego...@redhat.com> wrote: > Hi, > > On 22-06-16 10:48, Alexandre Courbot wrote: >> >> There is currently no reliable way to report failure to set a HW >> cursor. Stil

[PATCH RESEND v4] xfree86: Immediately handle failure to set HW cursor

::ShowCursorCheck hook variants that return booleans. This allows to propagate errors up to xf86CursorSetCursor(), which can then fall back to using the SW cursor immediately. Signed-off-by: Alexandre Courbot <acour...@nvidia.com> Reviewed-by: Keith Packard <kei...@keithp.com> Cc: Mi

Re: [PATCH RESEND xserver v3] xfree86: Immediately handle failure to set HW cursor

Friendly ping, as it would be very nice to see this merged! On Fri, May 13, 2016 at 7:36 PM, Alexandre Courbot <acour...@nvidia.com> wrote: > On 05/13/2016 01:04 AM, Adam Jackson wrote: >> >> On Thu, 2016-05-12 at 16:04 +0900, Alexandre Courbot wrote: >>> >>

Re: [PATCH RESEND xserver v3] xfree86: Immediately handle failure to set HW cursor

On 05/13/2016 01:04 AM, Adam Jackson wrote: On Thu, 2016-05-12 at 16:04 +0900, Alexandre Courbot wrote: There is currently no reliable way to report failure to set a HW cursor. Still such failures can happen if e.g. the MODE_CURSOR DRM ioctl fails (which currently happens at least

[PATCH RESEND xserver v3] xfree86: Immediately handle failure to set HW cursor

::ShowCursorCheck hook variants that return booleans. This allows to propagate errors up to xf86CursorSetCursor(), which can then fall back to using the SW cursor immediately. Signed-off-by: Alexandre Courbot <acour...@nvidia.com> Cc: Michael Thayer <michael.tha...@oracle.com> --- Hoping to se

Re: [PATCH xserver v3] xfree86: Immediately handle failure to set HW cursor

Friendly ping - does this patch look good now? On Thu, Apr 7, 2016 at 3:48 PM, Alexandre Courbot <acour...@nvidia.com> wrote: > There is currently no reliable way to report failure to set a HW > cursor. Still such failures can happen if e.g. the MODE_CURSOR DRM > ioctl fails (

Re: [PATCH xserver] configure.ac: Keep environment CFLAGS when testing

Any review for this? Without it I cannot cross compile for ARM with a dedicated SYSROOT, so I suspect it might be useful to others as well... ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info:

[PATCH xserver v3] xfree86: Immediately handle failure to set HW cursor

::ShowCursorCheck hook variants that return booleans. This allows to propagate errors up to xf86CursorSetCursor(), which can then fall back to using the SW cursor immediately. Signed-off-by: Alexandre Courbot <acour...@nvidia.com> Cc: Michael Thayer <michael.tha...@oracle.com> --- Chan

Re: [PATCH xserver v2] xfree86: Immediately handle failure to set HW cursor

Hello Michael, On 04/06/2016 02:40 AM, Michael Thayer wrote: On 04.04.2016 22:09, Michael Thayer wrote: Hello, Please excuse the top posting. Tested this in a dual-head non-mirrored virtual machine and hit the following problem: xf86CursorSetCursor() in hw/xfree86/ramdac/xf86Cursor.c calls

[PATCH xserver v2] xfree86: Immediately handle failure to set HW cursor

::ShowCursorCheck hook variants that return booleans. This allows to propagate errors up to xf86CursorSetCursor(), which can then fall back to using the SW cursor immediately. Signed-off-by: Alexandre Courbot <acour...@nvidia.com> --- Changes since v1: - Keep the old hooks unchanged to pr

Re: [PATCH xserver] xfree86: Immediately handle failure to set HW cursor

Hi Michel, On 03/28/2016 07:01 PM, Michel Dänzer wrote: On 28.03.2016 18:35, Alexandre Courbot wrote: On 03/23/2016 06:14 PM, Michael Thayer wrote: Looks good at first quick glance (I am away from the computer a bit over the Easter weeks, I will take another look when I am back). One thing I

Re: [PATCH xserver] xfree86: Immediately handle failure to set HW cursor

Hi Michael, On 03/23/2016 06:14 PM, Michael Thayer wrote: Looks good at first quick glance (I am away from the computer a bit over the Easter weeks, I will take another look when I am back). One thing I can say immediately though: when I submitted similar patches a while back, Keith had the

[PATCH xserver] configure.ac: Keep environment CFLAGS when testing

for stuff. Signed-off-by: Alexandre Courbot <acour...@nvidia.com> --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index dff06efdc35b..0ee49363c1f8 100644 --- a/configure.ac +++ b/configure.ac @@ -880,7 +880,7 @@ if test "x$

Re: [PATCH xserver] Switch to SW cursor right after HW cursor failure

On 03/18/2016 07:31 PM, Michael Thayer wrote: Hello Alex, On 18.03.2016 10:42, Alexandre Courbot wrote: Hello Michael, On 03/18/2016 06:09 PM, Michael Thayer wrote: In that context, see this patch to Modesetting which I send a couple of weeks ago, which should incidentally also fix your

[PATCH xserver] xfree86: Immediately handle failure to set HW cursor

hooks return a boolean. This allows to propagate errors up to xf86CursorSetCursor(), which makes it fall back to using the SW cursor immediately. Signed-off-by: Alexandre Courbot <acour...@nvidia.com> --- hw/xfree86/drivers/modesetting/drmmode_display.c | 11 +++ hw/xfree86/modes/xf86

Re: [PATCH xserver] Switch to SW cursor right after HW cursor failure

Hello Michael, On 03/18/2016 06:09 PM, Michael Thayer wrote: In that context, see this patch to Modesetting which I send a couple of weeks ago, which should incidentally also fix your issue: https://patchwork.freedesktop.org/patch/75985/ I applied your patch, but sadly it didn't fix my

[PATCH xserver] Switch to SW cursor right after HW cursor failure

the cursor immediately. Signed-off-by: Alexandre Courbot <acour...@nvidia.com> --- hw/xfree86/ramdac/xf86Cursor.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/xfree86/ramdac/xf86Cursor.c b/hw/xfree86/ramdac/xf86Cursor.c index c061b8028ca8..08868ffb2459 100644 --