On Feb 1, 2017 9:23 AM, "Arthur Huillet" <arthur.huil...@free.fr> wrote:
On Wed, 1 Feb 2017 09:12:47 -0800
Jamey Sharp <ja...@minilop.net> wrote:
> I'm a little confused by the notes in the commit message about whether
this
> is legal. I don't know why it shoul
I don't love this either, but it's Xlib; there's little there to love. ;-)
I don't see anything fundamentally wrong with this approach.
I'm a little confused by the notes in the commit message about whether this
is legal. I don't know why it should be considered legal to use a Display
from a
with this. Just need to prepare this for posting
on the XCB list.)
Cheers,
Chris
On 12/20/14 21:27, Jamey Sharp wrote:
We've talked about doing the xserver equivalent of XCB for years--that is,
auto-generating the protocol serialization and deserialization code from
XCB's machine-readable
We've talked about doing the xserver equivalent of XCB for years--that is,
auto-generating the protocol serialization and deserialization code from
XCB's machine-readable descriptions of the X protocol and extensions.
Considering the recent CVEs in that code, I think it's time. So I want to
On Sep 26, 2014 7:52 AM, Laércio de Sousa
laercioso...@sme-mogidascruzes.sp.gov.br wrote:
Now I've started playing with xf86-video-nested and Xephyr code, trying
to merge as much code as possible. It's still in an embrionary stage, so I
want to ask you some questions:
* Is there an official
On Wed, Jun 04, 2014 at 06:58:47PM +0200, Sedat Dilek wrote:
How do I see if DRI3 is enabled for mesa on my SandyBridge intel-gfxcard?
glxinfo log-file attached...
$ LC_ALL=C LIBGL_DEBUG=verbose glxinfo 2 /dev/null /tmp/glxinfo.txt
You threw out the information you wanted by
Xephyr could wrap CloseScreen after initializing kdrive, couldn't it? I
haven't looked carefully at that code, so I dunno.
Regardless:
Reviewed-by: Jamey Sharp ja...@minilop.net
On Wed, Jun 04, 2014 at 10:00:45PM -0700, Keith Packard wrote:
The usual mechanism for freeing a damage structure
On Wed, Jun 04, 2014 at 09:07:22AM -0300, Laércio de Sousa wrote:
Hello there!
Some time ago I've wrotten asking for current status of xf86-video-nested
development. I believe that, for a more robust single-card multiseat setup
with systemd-logind, a real Xorg server with some kind of nested
:41PM -0400, Jasper St. Pierre wrote:
And on the other side, you have people like me who simply want to replace
all video drivers with -modesetting, and all input drivers with libinput :)
On Wed, Jun 4, 2014 at 12:16 PM, Jamey Sharp ja...@minilop.net wrote:
On Wed, Jun 04, 2014 at 09:07:22AM
[We should probably have moved this conversation to the piglit list when
it shifted to discussing these new OML_sync_control tests.]
On Wed, May 14, 2014 at 04:12:32PM +0100, Chris Wilson wrote:
On Wed, May 14, 2014 at 06:49:10AM -0700, Jamey Sharp wrote:
On Wed, May 14, 2014 at 01:31:14PM
On Wed, May 14, 2014 at 01:31:14PM +0100, Chris Wilson wrote:
On Tue, May 13, 2014 at 09:20:45AM -0700, Jamey Sharp wrote:
Yeah, we have new tests that haven't quite been merged yet as we're
addressing Eric's review comments. Our current version, revised
yesterday,
is available
On Tue, May 13, 2014 at 12:01 AM, Chris Wilson ch...@chris-wilson.co.uk wrote:
On Mon, May 12, 2014 at 06:30:47PM -0700, Jamey Sharp wrote:
According to Chris Wilson, the Intel driver has a horrifying kludge to
get triple-buffering despite the swap_limit being set to only allow
double
On May 13, 2014 12:57 AM, Chris Wilson ch...@chris-wilson.co.uk wrote:
=0 ickle:/usr/src/piglit$ ./bin/glx-oml-sync-control-getmscrate
PIGLIT: {'result': 'pass' }
=0 ickle:/usr/src/piglit$ ./bin/glx-oml-sync-control-waitformsc
PIGLIT: {'result': 'pass' }
=0 ickle:/usr/src/piglit$
of their SwapLimit setting, it must be safe.
Signed-off-by: Jamey Sharp ja...@minilop.net
Signed-off-by: Theo Hill theo0...@gmail.com
Cc: Chris Wilson ch...@chris-wilson.co.uk
Cc: Eric Anholt e...@anholt.net
Cc: Matt Dew mar...@osource.org
---
hw/xfree86/dri2/dri2.c | 2 +-
1 file changed, 1
On Sat, May 10, 2014 at 02:55:11PM +0200, Uli Schlachter wrote:
On 10.05.2014 00:21, otay...@redhat.com wrote:
From: Owen W. Taylor otay...@fishsoup.net
When XCB owns the X socket, dpy-request is not updated, so
NextRequest() and XNextRequest() return the wrong value. There's
nothing
not to
be made an example of by angry users and distros.) I can't tell
whether any other compiler supports this attribute, so it might be that
only the run-time log entries can be made to work on other compilers.
Signed-off-by: Jamey Sharp ja...@minilop.net
Cc: Theo Hill theo0...@gmail.com
---
hw
it using swap_interval
as usual.
Signed-off-by: Jamey Sharp ja...@minilop.net
Signed-off-by: Theo Hill theo0...@gmail.com
---
hw/xfree86/dri2/dri2.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c
index 729a323..962f40c 100644
These two patches together clean up commit b180e439, which has been in
xserver releases since 1.9. That commit was attempting to fix an
OML_sync_control spec compliance bug; these finish the job.
I'd like to suggest that, once these patches are merged to master, they
also be included in any
reason since it was
introduced.
Signed-off-by: Jamey Sharp ja...@minilop.net
Signed-off-by: Theo Hill theo0...@gmail.com
---
hw/xfree86/dri2/dri2.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/hw/xfree86/dri2/dri2.c b/hw/xfree86/dri2/dri2.c
index 962f40c..76708ca
For the series, with the exception of patch 1/8:
Reviewed-by: Jamey Sharp ja...@minilop.net
Patch 1 uses assert incorrectly, as we discussed on IRC.
Jamey
On Fri, Apr 18, 2014 at 3:21 PM, Keith Packard kei...@keithp.com wrote:
Here's a set of 8 tiny patches which eliminate warnings
Reviewed-by: Jamey Sharp ja...@minilop.net
Jamey
On Fri, Apr 18, 2014 at 4:19 PM, Keith Packard kei...@keithp.com wrote:
Check return value from fgets and strchr instead of assuming they
worked.
[v2]
Don't do any necessary work inside the assert call.
Also make sure the return value
I haven't understood enough of the implementation to see how to fix
this, but I can reliably crash Xephyr this way:
hw/kdrive/ephyr/Xephyr :1 -screen 1024x768 -glamor
DISPLAY=:1 x11perf -shmputxy10
Without the -glamor option to Xephyr, the x11perf command runs
successfully. I'm testing on
Looks good to me!
Reviewed-by: Jamey Sharp ja...@minilop.net
On Oct 5, 2013 5:05 AM, Egbert Eich e...@freedesktop.org wrote:
From: Radek Doulik r...@novell.com
When an Xnest instance is not viewable it will crash when a client in
that instance calls GetImage. This is because the Xnest server
Hmm. XInitThreads wasn't designed to be used this way. For instance,
initializing thread support isn't thread-safe, for fairly obvious
reasons.
This patch might mask more bugs than it causes, and thereby be a net
win. But it seems equally likely to turn out the other way.
I'd suggest an awful
On Fri, Jul 12, 2013 at 11:16:16PM +0100, Daniel Stone wrote:
On 12 July 2013 22:40, Jamey Sharp ja...@minilop.net wrote:
Hmm. XInitThreads wasn't designed to be used this way. For instance,
initializing thread support isn't thread-safe, for fairly obvious
reasons.
This patch might mask
On Fri, Jul 12, 2013 at 05:09:00PM -0700, Alan Coopersmith wrote:
On 07/12/13 03:16 PM, Daniel Stone wrote:
The immediate provocation was the Mali GLES/EGL implementation, which
uses multiple threads itself, and thus relies on XInitThreads having
been called somewhere; so if you ever use that
Since every other XTHREADS check in that earlier patch uses #ifdef, it
looks like it was just a mistake.
For this fix:
Reviewed-by: Jamey Sharp ja...@minilop.net
Jamey
On 06/ 2/13 11:49 AM, Thomas Klausner wrote:
---
src/XlibInt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Reviewed-by: Jamey Sharp ja...@minilop.net
On Fri, Jun 07, 2013 at 09:32:31AM -0700, Alan Coopersmith wrote:
The XListPixmapFormats arguments was being shown with XImageByteOrder's
name and return types. Appears to have been a glitch in the nroff -
docbook conversion.
Reported-by: ZHANG
It seems to me that the change to GetReqExtra should indeed be merged. I
think now we're just debating what to do with any possibly-hazardous
callers. Kees, perhaps you could split the patch?
Regarding the rest, I like Alan's comments, and would add:
On Jun 6, 2013 9:17 PM, Alan Coopersmith
idea. A comment at
the declaration of outfile() about the lifetime of the result would be
nice though.
- If not, meh, it won't leak so much it's a serious problem.
Either way:
Reviewed-by: Jamey Sharp ja...@minilop.net
+ sprintf(out, %s/%s, path, fn);
+
+done:
+ free(resfile
I can't give this a full review, but off-hand it seems like a good idea
to me!
Changing the max hash size should probably be a separate commit with a
commit message justifying it.
There's some precedent for putting common data structures in shared code
in xserver, notably include/list.h.
They're defined in the X11 core protocol specification:
http://www.x.org/releases/X11R7.7/doc/xproto/x11protocol.html#Common_Types
I believe CARD is short for cardinal, as in cardinal numbers.
Regarding X vs. Lisp: I've been told that the X design decision to make
XIDs 29 bits wide was because
I confess I'm missing the context here, but it sounds like this should be a
runtime check, not build-time... shouldn't it?
Jamey
On Apr 21, 2013 10:19 AM, Alan Coopersmith alan.coopersm...@oracle.com
wrote:
On 04/20/13 11:28 AM, Gaetan Nadon wrote:
On 13-04-20 01:08 PM, Alan Coopersmith
Seems like a good plan to me.
Reviewed-by: Jamey Sharp ja...@minilop.net
On Tue, Mar 12, 2013 at 09:40:16AM -0700, Robert Morell wrote:
Otherwise this file is emitted in every unit that includes it.
Signed-off-by: Robert Morell rmor...@nvidia.com
---
This reduces the size of a debug Xorg
On Thu, Feb 28, 2013 at 09:06:07AM +1000, Peter Hutterer wrote:
* leave the current window of 3/2/1-ish months for the different
devel stages
* leave the requirement for a reviewed-by
* one RM, calling the shots for when releases are made and generally
being the reviewer of last resort and
On Fri, Feb 15, 2013 at 09:35:00AM +1000, Peter Hutterer wrote:
diff --git a/include/os.h b/include/os.h
index c7108a5..2bdbf95 100644
--- a/include/os.h
+++ b/include/os.h
@@ -655,6 +655,12 @@ FatalError(const char *f, ...)
_X_ATTRIBUTE_PRINTF(1, 2)
_X_NORETURN;
+/* XXX: DO NOT
On Tue, Jan 08, 2013 at 09:53:45AM -0500, Timothy Meade wrote:
Maybe I'm missing something, auto detecting if VT switch is needed means
introducing an inconsistencty. Dummy and evdev can both work without
allocating a VT, and there are cases where that may be useful, such as
debugging a server
On Tue, Apr 3, 2012 at 4:41 AM, Jon TURNEY jon.tur...@dronecode.org.uk wrote:
On 27/03/2012 05:09, Jamey Sharp wrote:
However, our capstone project that just finished was a start toward
replacing the XQuartz DDX with a stock Xorg server and a special
client, and I'm hoping that XWin can go
On 3/26/12, Alan Coopersmith alan.coopersm...@oracle.com wrote:
On 03/26/12 09:07 PM, Jamey Sharp wrote:
Maybe I have it right this time: On Debian, there's no problem,
because /usr/bin/X is a trivial suid wrapper and /usr/bin/Xorg is not
installed suid. Solaris and other Unixes could take
On 3/27/12, Mark Kettenis mark.kette...@xs4all.nl wrote:
Date: Tue, 27 Mar 2012 06:03:03 -0700
From: Jamey Sharp ja...@minilop.net
The key is to have a *non*-suid copy of the server available for those
who don't need root privs for their configuration. In that mode all
options can
2012/3/26 Sérgio Basto ser...@serjux.com:
in other day I saw /usr/bin/xvfb-run is in use on building
miro-4.0.6-2.fc16
how we test X in a server without displays ?
Use xf86-video-dummy with the Xorg DDX.
I use
/usr/bin/Xvfb
Xvfb :1 -fbdir /var/tmp/
export DISPLAY=:1
sdl-gnash
On Mon, Mar 26, 2012 at 4:31 PM, Keith Packard kei...@keithp.com wrote:
On Mon, 26 Mar 2012 16:13:46 -0700, Jeremy Huddleston jerem...@apple.com
wrote:
Most functionality of these servers can be provide by Xorg with either
the nested or dummy video driver.
+1 for deleting these obsolete
On Mon, Mar 26, 2012 at 5:09 PM, Chase Douglas
chase.doug...@canonical.com wrote:
On 03/26/2012 04:55 PM, Jamey Sharp wrote:
xf86-video-dummy doesn't have an equivalent to -fbdir, but it looks
like you aren't actually making use of the mmap'd framebuffer in
/var/tmp/. So this case should work
On Mon, Mar 26, 2012 at 6:01 PM, Alan Coopersmith
alan.coopersm...@oracle.com wrote:
On 03/26/12 04:13 PM, Jeremy Huddleston wrote:
These need to die. This removes 30K lines of code from xorg-server. It
must be good!
Most functionality of these servers can be provide by Xorg with either
On 3/22/12, Chase Douglas chase.doug...@canonical.com wrote:
On 03/22/2012 09:25 PM, Peter Hutterer wrote:
This patch introduces a new define __XSERVER__ that we can use in the sdk
headers. Obviously the real integration will be a tad harder as there are
other headers that are installed
Well, I'm in favor, for whatever that's worth. :-)
Jamey
On Thu, Mar 22, 2012 at 9:25 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
This is just a quickfire patch to show the principle, it has not been tested
much. Plus, it's more of an idea right now, not sure if I'll find the time
to
On Fri, Mar 16, 2012 at 4:39 AM, Chris Wilson ch...@chris-wilson.co.uk wrote:
If when bug hunting you trigger a server regeneration after enabling a
pnning mode without moving the nice, you cause a flurry of valgrind
warnings:
I really wanted to read that as pwning. I take it you meant
panning
A small detail:
On 3/14/12, Peter Hutterer peter.hutte...@who-t.net wrote:
static void
IdleTimeWakeupHandler (pointer pCounter, int rc, pointer LastSelectMask)
{
-SyncCounter *counter = IdleTimeCounter;
+SyncCounter *counter = pCounter;
...
@@ -2814,7 +2817,7 @@
For the series v2: Looks good!
Reviewed-by: Jamey Sharp ja...@minilop.net
Although I'd suggest dropping the unnecessary cast I pointed out in patch 6.
Jamey
On 3/14/12, Peter Hutterer peter.hutte...@who-t.net wrote:
Previously, we only had one idle alarm that was triggered for all devices
This series seems like a good idea to me! I have a few review comments though:
Patch 1 seems strange. Shouldn't the counters themselves get freed at
reset? If they are, shouldn't that lead to the number of counters
reaching 0?
I guess the input ABI should get bumped for the patch that stores
On Wed, Mar 14, 2012 at 4:30 PM, Peter Hutterer
peter.hutte...@who-t.net wrote:
On Wed, Mar 14, 2012 at 09:01:13AM -0700, Jamey Sharp wrote:
This series seems like a good idea to me! I have a few review comments
though:
Patch 1 seems strange. Shouldn't the counters themselves get freed
The #ifndef in log.c looks wrong, but otherwise, sure, why not? With that fixed:
Reviewed-by: Jamey Sharp ja...@minilop.net
On 3/13/12, Peter Hutterer peter.hutte...@who-t.net wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Just a nice-to-have, makes grep a tad easier
For both Block for other threads in _XUserLockDisplay and Restore
Xlib semantics of blocking on user lock from _XReadEvents:
Reviewed-by: Jamey Sharp ja...@minilop.net
Although, in Restore Xlib semantics, it would be nice if you'd fix
up the It appears that classic Xlib respected user locks
On Sat, Mar 10, 2012 at 4:04 PM, Keith Packard kei...@keithp.com wrote:
On Sat, 10 Mar 2012 14:31:52 -0800, Jamey Sharp ja...@minilop.net wrote:
Although, in Restore Xlib semantics, it would be nice if you'd fix
up the It appears that classic Xlib respected user locks comment. I
think
On Wed, Mar 7, 2012 at 8:21 PM, Peter Hutterer peter.hutte...@who-t.net wrote:
Alt+SysReq+R sets the console to raw mode. Re-enable raw mode when
VT-switching back to the server.
This commit message is confusing me. When VT-switching to the server,
you want to set the console to the same mode
I've pushed this patch; thanks!
I'll let you and Jeremy sort out the libX11 side.
Jamey
On Sun, Feb 19, 2012 at 01:43:54PM +0100, Julien Cristau wrote:
Signed-off-by: Julien Cristau jcris...@debian.org
---
src/xcb_util.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
On Sat, Feb 18, 2012 at 05:21:24PM +, Jon TURNEY wrote:
Casting a (const char *) to (caddr_t) to assign to iovec.io_base
seems pointless. caddr_t isn't used anywhere else in xcb or libX11
According to the libxcb git history, I replaced (caddr_t) with (char *)
in 2006 to help DragonFly and
This should be fixed by commit ead968a4300c0adeff89b9886e888b6d284c75cc,
already on master--right?
Jamey
On Mon, Jan 30, 2012 at 03:32:19PM -0200, Daniel d'Andrada wrote:
This is another enabler for making it possible to run Xorg without
root privileges.
The -config parameter in Xorg
On Wed, Jan 18, 2012 at 03:05:41PM +1100, Daniel Stone wrote:
commit 3811d1b85b71c1f8bd0b3c8269e0f7d388a51c2b
Author: Daniel Stone dan...@fooishbar.org
Date: Wed Jan 18 15:01:09 2012 +1100
Remove XAA
It hasn't worked for over four years. No-one's even come close to
On Thu, Jan 19, 2012 at 03:43:39PM +1100, Daniel Stone wrote:
On 19 January 2012 04:03, Jamey Sharp ja...@minilop.net wrote:
I love this. It invalidates some of my outstanding patches in the best
possible way. But... could you explain (preferably in the commit
message) what evidence you
I sure don't see any reason not to merge that.
Reviewed-by: Jamey Sharp ja...@minilop.net
On Tue, Dec 20, 2011 at 07:49:47PM -0800, Jeremy Huddleston wrote:
dispatch.h was leftover from an earlier implementation and is no longer
needed, so remove it since including it causes a build failure
On Wed, Dec 21, 2011 at 06:47:07PM -0800, Bryce Harrington wrote:
Begin refactoring the xrandr command line tool's internals into a
utility library. This is to provide a higher level abstraction for
configuring multiple monitors.
With the coming complexities of hybrid graphics, 2 heads, and
On Mon, Dec 19, 2011 at 03:17:54PM +0700, Antoine Martin wrote:
On 10/24/2011 06:26 PM, Jamey Sharp wrote:
Off-hand, I'd guess nobody has implemented RANDR support in
xf86-video-dummy. But since I don't know what drivers need to do
for that, for all I know there could be some generic
Reviewed-by: Jamey Sharp ja...@minilop.net
On 12/17/11, Jeremy Huddleston jerem...@apple.com wrote:
Signed-off-by: Jeremy Huddleston jerem...@apple.com
---
configure.ac |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/configure.ac b/configure.ac
index 518eb06
Welp, I'm happy!
Reviewed-by: Jamey Sharp ja...@minilop.net
On Fri, Dec 16, 2011 at 10:28:31AM +1000, Peter Hutterer wrote:
For future touch points, we need positionSprite to calculate the coordinates
but we don't want to actually change the cursor position for non-emulating
touches
Could you have a look at my patches to do this, from October? I believe
Keith just wanted an ABI bump before merge, but I'd run out of time by
then, and now I assume it's too late for this cycle.
They're still sitting on my reviewed branch:
On Mon, Oct 17, 2011 at 02:06:55PM -0700, Keith Packard wrote:
On Wed, 5 Oct 2011 08:30:56 -0700, Jamey Sharp ja...@minilop.net wrote:
Alright, the pixmap hooks have weird undocumented constraints, and
maybe we'll figure out something clever someday. Meanwhile, would you
please merge
This patch obviously doesn't change any behavior, but wouldn't it be
more clear to just factor out the beginning of positionSprite to a
computeSpritePosition or something?
I suppose there's a later patch that justifies this approach, but I
can't help thinking that returning early by adding
On 12/14/11, Antoine Martin anto...@nagafix.co.uk wrote:
On 11/11/2011 08:59 AM, Jamey Sharp wrote:
Or use a modern implementation like x11vnc that uses COMPOSITE so it
doesn't need any server-side code at all. :-) That's the approach
we're trying to adopt in this new project.
This approach
For the series:
Reviewed-by: Jamey Sharp ja...@minilop.net
Nice work. :-)
On Sun, Dec 11, 2011 at 10:16:13AM -0800, Alan Coopersmith wrote:
Removes 422 lines of warning messages from the xserver build when
using gcc 4.5.2 on Solaris 11 with the latest xorg-macros set of
warning flags
Sure, that makes sense.
Reviewed-by: Jamey Sharp ja...@minilop.net
On 11/23/11, Alan Coopersmith alan.coopersm...@oracle.com wrote:
Commit f9e3a2955d2ca7 removing the MAXSCREEN limit left the screen
number too unlimited, and allowed any positive int for a screen number:
Xvfb :1 -screen
f0d50cc6651dce3a8a3cd3fb84210aa92b139763:
Fix vesa's VBE PanelID interpretation (2011-11-06 16:41:44 -0800)
are available in the git repository at:
git://anongit.freedesktop.org/~jamey/xserver no-regen
Jamey Sharp (3):
InitRootWindow: Use ChangeWindowAttributes instead of duplicating
background None,
while ChangeWindowAttributes unconditionally trusted bgNoneRoot.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
dix/window.c | 44 +---
1 files changed, 9 insertions(+), 35 deletions(-)
diff --git a/dix/window.c b/dix/window.c
index
to a constant 1.
Eliminating all the ugly code that's conditional on serverGeneration is
left as a later exercise. This patch should simply improve reliability
when the server resets.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
This patch is generated with `diff -w`, so the patch's indentation
just waiting to happen.
Signed-off-by: Jamey Sharp ja...@minilop.net
---
dix/window.c | 74 +++--
1 files changed, 35 insertions(+), 39 deletions(-)
diff --git a/dix/window.c b/dix/window.c
index 44bfa18..c87020d 100644
--- a/dix/window.c
+++ b
On Wed, Nov 16, 2011 at 02:36:45PM +0100, walter harms wrote:
Am 15.11.2011 23:49, schrieb Rob Clark:
+nformats = (rep.length / sizeof(*formats)) * 4;
+formats = malloc(nformats * sizeof(*formats));
i do not understand the 4 here. do you mean:
(rep.length /
Reviewed-by: Jamey Sharp ja...@minilop.net
On Mon, Nov 14, 2011 at 09:04:18AM -0800, Keith Packard wrote:
On Tue, 8 Nov 2011 10:47:44 -0800, Jamey Sharp ja...@minilop.net wrote:
And can I persuade you to just inline this directly into its only call
site, below, in Dispatch? I don't think
On 11/11/11, Ratin rat...@gmail.com wrote:
On Thu, Nov 10, 2011 at 12:57 PM, Jamey Sharp ja...@minilop.net wrote:
What application is it? Does it make X requests from more than one
thread?
Hi Jamey, Thanks for the insightful question. Its a bit complex video
wall application ... [interesting
Just to let you all know: Getting students to build xf86-video-nested
worked out well, so we're starting another X-related PSU Capstone
project. This time Jeremy is joining Josh and me as project sponsors.
The goal this time around is to replace the XQuartz DDX. We'll run the
stock xfree86 DDX
On 11/10/11, Alan Hourihane al...@fairlite.co.uk wrote:
On 11/10/11 23:40, Peter Hutterer wrote:
I wonder how much effort it would be to write a xf86-video-vnc that runs
on xfree86 ddx.
That would be interesting to try, and there's some library out there
for quickly building a VNC server into
You're welcome to throw my reviewed-by on this patch, with the caveat
that not only have I not tested it, but I haven't investigated the issue
it's trying to address, either. But it seems like an improvement to the
code regardless of any bugs it might fix.
I'd suggest a couple minor edits,
On Thu, Nov 03, 2011 at 07:30:52AM +1000, Peter Hutterer wrote:
On Wed, Nov 02, 2011 at 11:23:55AM -0700, Jamey Sharp wrote:
The best option, of course, is to ensure that no bug can occur. Peter,
what about making the length argument take 4-byte units, dividing in the
callers
On Wed, Nov 02, 2011 at 05:32:24AM -0700, Dan Nicholson wrote:
On Oct 27, 2011 4:26 AM, Peter Hutterer peter.hutte...@who-t.net wrote:
On Thu, Oct 27, 2011 at 10:41:06AM +0200, walter harms wrote:
Am 27.10.2011 09:55, schrieb Jamey Sharp:
On Thu, Oct 27, 2011 at 09:15:54AM +0200, walter
For the series:
Reviewed-by: Jamey Sharp ja...@minilop.net
Thanks!
On Thu, Oct 27, 2011 at 02:21:25PM +1000, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
Changes to v1:
- a few comment fixes, whitespace fixes to better align the code with the
rest
On Thu, Oct 27, 2011 at 09:15:54AM +0200, walter harms wrote:
Am 27.10.2011 06:21, schrieb Peter Hutterer:
+void *_XGetRequest(Display *dpy, CARD8 type, size_t len)
+{
+xReq *req;
+
+WORD64ALIGN
+
+if (dpy-bufptr + len dpy-bufmax)
+ _XFlush(dpy);
+
+if (len
I pretty much approve whole-heartedly of this patch, but I have a couple
nits to ask that you fix.
On Tue, Oct 25, 2011 at 01:37:56PM +1000, Peter Hutterer wrote:
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
include/X11/Xlibint.h | 51
On Mon, Oct 24, 2011 at 05:20:29PM +0700, Antoine Martin wrote:
Whenever an xpra client connects to a server I want to resize the dummy
xserver to match the client's resolution exactly.
...
Failed to change the screen configuration!
Off-hand, I'd guess nobody has implemented RANDR support in
=linux.intel@lists.x.org
[mailto:xorg-devel-bounces+zhigang.gong=linux.intel@lists.x.org] On
Behalf Of Eric Anholt
Sent: Thursday, October 20, 2011 11:32 PM
To: Jamey Sharp; Zhigang Gong; Jeremy Huddleston
Cc: xorg-devel@lists.x.org
Subject: Re: [Pull v2] Glamor - fixed build
On Wed, Oct 19, 2011 at 10:47:17AM -0700, Jeremy Huddleston wrote:
Actually, I retract this. I didn't intend to do it originally, but
now that it's done, meh.
If you change your mind:
Reviewed-by: Jamey Sharp ja...@minilop.net
But I, for one, am perfectly happy with meh. :-)
I think we
On Wed, Oct 19, 2011 at 11:20:54AM -0700, Jeremy Huddleston wrote:
On Oct 19, 2011, at 1:02 AM, Zhigang Gong wrote:
Just as I said above. Your thought do make sense. Currently glamor
implements some GL based rendering functions. And in the long term,
we may merge those functions into cairo
On Wed, Oct 19, 2011 at 05:01:45PM +0100, Dave Airlie wrote:
From: Dave Airlie airl...@redhat.com
This code had an off-by-one and would allow writing one past the end of
the callbacks array.
I think you mean reading one past the end? I don't see any bad pointer
writes here, though I'm only
Reviewed-by: Jamey Sharp ja...@minilop.net
I haven't tested it, nor do I have mind-reading powers, but I think
this logic means what you think it means. Thanks for the revisions.
Jamey
On 10/19/11, Dave Airlie airl...@gmail.com wrote:
From: Adam Jackson a...@redhat.com
So on RHEL5 anaconda
On Mon, Oct 17, 2011 at 09:19:02AM +1000, Peter Hutterer wrote:
On Fri, Oct 14, 2011 at 06:42:02PM +0200, Jamey Sharp wrote:
The GetReq family of macros is so evil. I'm not going to go so far as
to NAK this patch or anything, but please consider whether you can
implement this as a proper
Reviewed-by: Jamey Sharp ja...@minilop.net
Since this has gone through so many changes I tried to carefully
re-review the whole thing, and it still looks good to me. Thanks,
Antoine!
We don't actually put xserver: in the commit message for a server
patch, though. It wouldn't be wrong to tag
On Mon, Oct 17, 2011 at 02:06:55PM -0700, Keith Packard wrote:
On Wed, 5 Oct 2011 08:30:56 -0700, Jamey Sharp ja...@minilop.net wrote:
Alright, the pixmap hooks have weird undocumented constraints, and
maybe we'll figure out something clever someday. Meanwhile, would you
please merge
The GetReq family of macros is so evil. I'm not going to go so far as
to NAK this patch or anything, but please consider whether you can
implement this as a proper function or something. Perhaps:
void *XGetReq(CARD8 reqType, size_t sz);
(I think the other macros could be re-implemented on top of
On 10/6/11, Michal Suchanek hramr...@centrum.cz wrote:
I would like to check this out but how do I tell this actually works?
Xephyr and Xvfb already run as non-root, Xorg needs device access to
run which will likely fail as non-root.
The motivation for Antoine's patch is the xf86-video-dummy
Alright, the pixmap hooks have weird undocumented constraints, and
maybe we'll figure out something clever someday. Meanwhile, would you
please merge the other three commits?
Thanks,
Jamey
On 10/3/11, Jamey Sharp ja...@minilop.net wrote:
On Mon, Oct 03, 2011 at 12:01:23PM -0700, Keith Packard
On Mon, Oct 03, 2011 at 03:13:09PM -0700, Jamey Sharp wrote:
On Mon, Oct 03, 2011 at 12:01:23PM -0700, Keith Packard wrote:
On Wed, 28 Sep 2011 13:57:27 -0700, Jamey Sharp ja...@minilop.net wrote:
Hi Keith! Here's some reviewed code deletion (hooray!) and the fix to
make kdrive build
On Tue, Oct 04, 2011 at 10:41:48AM +0100, Chris Wilson wrote:
On Sat, 1 Oct 2011 23:08:45 -0700, Jamey Sharp ja...@minilop.net wrote:
Jamey Sharp (3):
Have FreePixmap call screen hooks, not the other way around.
Introduce CreatePixmap, allocating a header and calling screen
1 - 100 of 566 matches
Mail list logo
