Alright, the pixmap hooks have weird undocumented constraints, and maybe we'll figure out something clever someday. Meanwhile, would you please merge the other three commits?
Thanks, Jamey On 10/3/11, Jamey Sharp <ja...@minilop.net> wrote: > On Mon, Oct 03, 2011 at 12:01:23PM -0700, Keith Packard wrote: >> On Wed, 28 Sep 2011 13:57:27 -0700, Jamey Sharp <ja...@minilop.net> wrote: >> > Hi Keith! Here's some reviewed code deletion (hooray!) and the fix to >> > make kdrive build again after the last pull. >> >> There was a comment requesting that FreePixmap be renamed >> 'UnreferencePixmap' or some such? > > Yeah, and I'm not opposed. (Although I'm hoping for a better name > choice...) It's probably a good idea to change the names anyway so any > unfixed callers are detected at compile time. > > Would you pull the rest of my reviewed patches in the meantime though? I > have a lot of patches that depend on the clipping changes going in, and > the missing .gitignore entry keeps bugging me. > > The following changes since commit 6378d0233d21088b6429755627b4253859892c72: > > Merge remote-tracking branch 'herrb/master' (2011-10-03 13:56:06 -0700) > > are available in the git repository at: > > git://anongit.freedesktop.org/~jamey/xserver reviewed > > Jamey Sharp (3): > test: .gitignore the binary for xfree86.c. > Quit wrapping ChangeClip, CopyClip, and DestroyClip in GCFuncs. > Make GC clientClip always be a region. > > Xext/panoramiX.c | 32 ------ > dix/gc.c | 64 ++++++++++--- > doc/Xserver-spec.xml | 76 +-------------- > exa/exa.c | 48 --------- > exa/exa_accel.c | 18 ++-- > exa/exa_priv.h | 6 +- > exa/exa_unaccel.c | 6 +- > fb/fbgc.c | 3 - > hw/dmx/dmxgc.c | 115 +++++++--------------- > hw/dmx/dmxgc.h | 3 - > hw/kdrive/src/kxv.c | 2 +- > hw/xfree86/common/xf86VGAarbiter.c | 31 +------ > hw/xfree86/common/xf86VGAarbiterPriv.h | 4 - > hw/xfree86/common/xf86xv.c | 2 +- > hw/xfree86/shadowfb/shadow.c | 35 ------- > hw/xfree86/xaa/xaaBitBlt.c | 4 +- > hw/xfree86/xaa/xaaGC.c | 31 ------ > hw/xnest/GC.c | 170 > +++++--------------------------- > hw/xnest/XNGC.h | 4 - > hw/xwin/wingc.c | 42 -------- > include/gc.h | 2 +- > include/gcstruct.h | 25 ++--- > mi/mibitblt.c | 4 +- > mi/micopy.c | 4 +- > mi/miexpose.c | 2 +- > mi/migc.c | 74 +-------------- > mi/migc.h | 16 --- > mi/mioverlay.c | 2 +- > miext/cw/cw.c | 52 +--------- > miext/damage/damage.c | 31 ------ > miext/rootless/rootlessGC.c | 29 ------ > render/mirect.c | 2 +- > test/.gitignore | 1 + > xfixes/region.c | 27 ++---- > 34 files changed, 164 insertions(+), 803 deletions(-) > _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
