Re: [EXTERNAL] - trouble with Xace receive hook

2024-02-02 Thread Peter Harris
). Then you can look up the extension-specific event in evtype. Assuming the extension is XInput, in this case you have an XI_RawMotion (17) instead of a DestroyNotify (17). Peter Harris

Re: [EXTERNAL] - [Xlib] Ignoring BadAccess errors

2021-04-21 Thread Peter Harris
untrusted context, which returned exactly when client is untrusted and not for any other reasons Sorry, I'm afraid I can't help with this part. Peter Harris ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-

RE: [EXTERNAL] - Re: [PATCH xserver 2/2] os: Add epoll-like port implementation for Solaris

2019-09-23 Thread Peter Harris
On 2019-09-23 Alan Coopersmith wrote: > On 10/12/17 1:48 PM, Peter Harris wrote: > > x11perf -noop with 200 xlogos connected is slightly faster with ports: > > > >before after Operation > > -- -

RE: [EXTERNAL] - [PATCH xorgproto] Add DPMSInfoNotify event

2018-10-02 Thread Peter Harris
e "modern" way to add events to extensions is called "generic events". Xcb has . I'm not sure how Xlib works. See the Present extension for a recent example that uses generic events. Peter Harris ___ xorg-devel@lists.x.org: X.O

[PATCH xserver] composite: Fix use-after-free in compReparentWindow

2018-02-22 Thread Peter Harris
If an implicitly redirected window is unredirected by the reparent operation, cw will be a stale pointer. Signed-off-by: Peter Harris <phar...@opentext.com> --- composite/compwindow.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/composite/compwindow.c b/com

RE: [PATCH xserver 3/3] render: Fix default picture format initialization

2018-02-22 Thread Peter Harris
isn't useful most of the time, but maybe it makes sense for PutImage-then-convert-in-the-server an x8r8g8b8 image to x2r10g10b10 without needing a second (not-depth-30) pixmap? Peter Harris ___ xorg-devel@lists.x.org: X.Org development Archives: http://li

Re: [PATCH util/macros] Drop -fno-strict-aliasing from XORG_CWARNFLAGS

2017-12-14 Thread Peter Harris
ode cleanliness, not necessarily performance. The risk if we don't make this change is to those of us with non-gcc compilers (that don't have -fno-strict-aliasing or an equivalent as an option). Replacing -fno-strict-aliasing with -Werror=strict-aliasing is a step in the right direction. Peter Harris --

[PATCH xserver] composite: Propagate damagedDescendants when reparented

2017-12-14 Thread Peter Harris
a window is reparented. Signed-off-by: Peter Harris <phar...@opentext.com> --- composite/compalloc.c | 21 + composite/compint.h| 2 ++ composite/compwindow.c | 5 + 3 files changed, 20 insertions(+), 8 deletions(-) diff --git a/composite/compalloc.c b/com

[PATCH xserver 2/2] os: Add epoll-like port implementation for Solaris

2017-10-12 Thread Peter Harris
x11perf -noop with 200 xlogos connected is slightly faster with ports: before after Operation -- - 1840.0 1920.0 (1.04) X protocol NoOperation Signed-off-by: Peter Harris <phar...@opentext.com> --- i

[PATCH xserver 1/2] os: Add epoll-like pollset implementation for AIX

2017-10-12 Thread Peter Harris
599.0 (1.04) X protocol NoOperation Signed-off-by: Peter Harris <phar...@opentext.com> --- include/meson.build | 1 + os/ospoll.c | 146 +++- 2 files changed, 146 insertions(+), 1 deletion(-) diff --git a/include/meson.b

Re: [PATCH xserver v2] meson: Fix epoll detection

2017-08-14 Thread Peter Harris
On 2017-08-14 4:45 PM, Keith Packard wrote: > Peter Harris <phar...@opentext.com> writes: >> -#if !HAVE_OSPOLL && HAVE_EPOLL_CREATE1 >> +#if !HAVE_OSPOLL && defined(HAVE_EPOLL_CREATE1) > > Should be using defined for HAVE_OSPOLL as well? H

Re: [PATCH xserver] meson: Fix epoll detection

2017-08-11 Thread Peter Harris
On 2017-08-11 5:50 AM, Peter Hutterer wrote: > On Tue, Aug 08, 2017 at 11:16:13AM -0400, Peter Harris wrote: >> The epoll code depends on epoll_create1, not epoll_create. >> >> The trinary " ? 1 : false" is used because HAVE_EPOLL_CREATE1 is tested >> w

[PATCH xserver] meson: Fix epoll detection

2017-08-08 Thread Peter Harris
The epoll code depends on epoll_create1, not epoll_create. The trinary " ? 1 : false" is used because HAVE_EPOLL_CREATE1 is tested with #if instead of #ifdef. Signed-off-by: Peter Harris <phar...@opentext.com> --- include/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 d

Re: [PATCH xserver] glx: Erase glx client private before using

2017-08-03 Thread Peter Harris
et(addr, '\0', global_keys[type].offset); (where addr is "privates"). > I could easily be convinced that this is a bug and that > _dixAllocateObjectWithPrivates should clear the entire object and > privates out, as I was also surprised to see this. I could easily be convinced that client structures are re-used

Re: [EXTERNAL] - Re: [PATCH xserver 4/4] meson: Detect strlcat/strlcpy/reallocarray in libbsd

2017-05-10 Thread Peter Harris
On 2017-05-10 3:26 PM, Adam Jackson wrote: > On Wed, 2017-05-10 at 10:11 +0100, Eric Engestrom wrote: >> On Tuesday, 2017-05-09 19:39:47 -0400, Peter Harris wrote: >>> +#if defined HAVE_LIBBSD && defined HAVE_REALLOCARRAY >> >> nit: most of the codebase us

[PATCH xserver 4/4] meson: Detect strlcat/strlcpy/reallocarray in libbsd

2017-05-09 Thread Peter Harris
If we're linking with libbsd anyway, we might as well use the functions it provides instead of compiling our replacements. Signed-off-by: Peter Harris <phar...@opentext.com> --- include/meson.build | 6 +++--- include/os.h| 6 ++ 2 files changed, 9 insertions(+), 3 deletions(-)

[PATCH xserver 2/4] meson: Detect more functions

2017-05-09 Thread Peter Harris
Set HAVE_REALLOCARRAY, HAVE_SIGACTION, HAVE_STRCASESTR, HAVE_STRLCAT, HAVE_STRLCPY, HAVE_TIMINGSAFE_MEMCMP, and BUSFAULT. Signed-off-by: Peter Harris <phar...@opentext.com> --- include/meson.build | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/include/meson

[PATCH xserver 1/4] meson: Detect arc4random_buf

2017-05-09 Thread Peter Harris
Signed-off-by: Peter Harris <phar...@opentext.com> --- include/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/include/meson.build b/include/meson.build index 761f158d7..d032fb37f 100644 --- a/include/meson.build +++ b/include/meson.build @@ -98,6 +98,7 @@ conf_da

[PATCH xserver 3/4] meson: Only detect each function once

2017-05-09 Thread Peter Harris
Use conf_data outside of include/ to avoid re-running detection of the same functions. Signed-off-by: Peter Harris <phar...@opentext.com> --- os/meson.build | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/os/meson.build b/os/meson.build index 724

[PATCH xserver 0/4] A few meson fixes

2017-05-09 Thread Peter Harris
Mostly I was annoyed at the unused return value warning from the non-arc4random path. I noticed a few other minor things while I was in there. Peter Harris (4): meson: Detect arc4random_buf meson: Detect more functions meson: Only detect each function once meson: Detect

Re: [PATCH xserver v2] Fix id in error when resource does not exist

2016-10-06 Thread Peter Harris
On 2016-10-06 1:07 PM, Adam Jackson wrote: > On Thu, 2016-09-29 at 11:17 -0400, Peter Harris wrote: >> Always set client->errorValue before returning an error. > > As sensible as this seems, I think it's wrong. I ran across something > similar a few years ago: > > ht

[PATCH xserver v2] Fix id in error when resource does not exist

2016-09-29 Thread Peter Harris
>bad_value != BAD_VALUE) { printf("Error: Got 0x%X, expected 0x%X\n", err->bad_value, BAD_VALUE); return 1; } printf("Success! Got expected bad value of 0x%X\n", BAD_VALUE); return 0; } Signed-off-by: Peter Harris <phar...@opentext.com> --- v2 chang

[PATCH xserver] Fix id in error when resource does not exist

2016-09-28 Thread Peter Harris
Always set client->errorValue before returning an error. Test program: #include #include #include #define BAD_VALUE 0xFACE0FF int main(int argc, char *argv[]) { int screen = 0; xcb_connection_t *c = xcb_connect(NULL, ); if (!c) { printf("Cannot connect\n");

Re: Damage as a DIX notion

2016-09-26 Thread Peter Harris
und that careful use of the _mm_max_epi16/_mm_min_epi16 intrinsics pushes the cost for calculating the bounds of Dot down into the noise. Presumably the non-Intel platforms have something similar in their SIMD instruction sets too, but I'm not sure how "pixman" you want to go on this.

Re: [PATCH xserver] FlushAllOutput: Only call FlushCallbacks when actually flushing data

2016-07-11 Thread Peter Harris
fixed. FD_SETSIZE is user controlled, so I can't imagine a problem with massaging fd_set into C99 variable-length-array form: typedef struct xfd_set { u_int fd_count; SOCKET fd_array[]; } xfd_set; and reallocing to taste. Peter Harris -- Open Text

Re: pythonic XCB build error

2016-04-11 Thread Peter Harris
.freedesktop.org/archives/xcb/2016-March/010711.html and https://lists.freedesktop.org/archives/xcb/2016-March/010710.html and surrounding patch sets, they will go into master faster. Thanks, Peter Harris -- Open Text Connectivity Solutions Group Peter Harris

Re: [PATCH] os: Treat ssh as a non-local client

2015-12-08 Thread Peter Harris
reat ssh's X forwarding as if it were > local. Was sshd never updated to take advantage of "dix: Extend initial connection handshake for forwarding proxies"? http://cgit.freedesktop.org/xorg/xserver/commit/?id=78fa121f4097d29458e5453c13473595df06e26e Peter Harris --

Re: [PATCH xserver 01/20] Remove non-smart scheduler. Don't require setitimer.

2015-11-20 Thread Peter Harris
E only has a 4ms resolution so it falls back to reading the HPET every time. That said, this box is an outlier. Every other recent box I can put my hands on has a fast GetTimeInMillis(). Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishtt

Re: [PATCH 2/7] Add 'likely' and 'unlikely' macros

2015-05-15 Thread Peter Harris
-10ubuntu13 Relevant CFLAGS: -m64 -mtune=generic -O2 -flto Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001 phar...@opentext.comToll Free: 1 877 359

[PATCH] Fix border tile origin when background is ParentRelative

2015-05-12 Thread Peter Harris
changed, but miPaintWindow was ignoring the background origin. Found by xts XChangeWindowAttributes-3 Signed-off-by: Peter Harris phar...@opentext.com --- Originally sent in http://lists.x.org/archives/xorg-devel/2015-February/045606.html ; no reviews (for or against) since. mi/miexpose.c | 13

[PATCH] Fix border tile origin when background is ParentRelative

2015-02-13 Thread Peter Harris
changed, but miPaintWindow was ignoring the background origin. Found by xts XChangeWindowAttributes-3 Signed-off-by: Peter Harris phar...@opentext.com --- mi/miexpose.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/mi/miexpose.c b/mi/miexpose.c index fc4dbc0

[PATCH fixesproto] cursor-name is after cursor-image in GetCursorImageAndName

2015-02-03 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- fixesproto.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fixesproto.txt b/fixesproto.txt index 24c782d..6e3811e 100644 --- a/fixesproto.txt +++ b/fixesproto.txt @@ -469,8 +469,8 @@ GetCursorImageAndName

Re: [PATCH xts 2/2] libproto: RcvRep: Don't overwrite memory in QueryFont

2015-01-26 Thread Peter Harris
On 2015-01-21 15:19, Ian Romanick wrote: On 01/20/2015 05:57 PM, Peter Harris wrote: If the server returns a bogus (short) reply to a swapped QueryFont request, RcvRep swaps past the end of its buffer, smashing the heap. Signed-off-by: Peter Harris phar...@opentext.com Given

Re: [PATCH xts 1/2] libproto: Fix buffer read overrun

2015-01-21 Thread Peter Harris
On 2015-01-21 15:21, Ian Romanick wrote: On 01/20/2015 05:57 PM, Peter Harris wrote: Found by -fsanitize=address Signed-off-by: Peter Harris phar...@opentext.com --- xts5/src/libproto/ShowSup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xts5/src/libproto

[PATCH xts 2/2] libproto: RcvRep: Don't overwrite memory in QueryFont

2015-01-20 Thread Peter Harris
If the server returns a bogus (short) reply to a swapped QueryFont request, RcvRep swaps past the end of its buffer, smashing the heap. Signed-off-by: Peter Harris phar...@opentext.com --- xts5/src/libproto/RcvRep.c | 4 1 file changed, 4 insertions(+) diff --git a/xts5/src/libproto

[PATCH xts 1/2] libproto: Fix buffer read overrun

2015-01-20 Thread Peter Harris
Found by -fsanitize=address Signed-off-by: Peter Harris phar...@opentext.com --- xts5/src/libproto/ShowSup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xts5/src/libproto/ShowSup.c b/xts5/src/libproto/ShowSup.c index a05ff7d..b8ba796 100644 --- a/xts5/src/libproto

[PATCH] dix: Fix hang in ConfineToShape

2015-01-19 Thread Peter Harris
If the initial point is more than one pixel left, right, or below the bounding box of the region, ConfineToShape will enter an infinite loop. Avoid the infinite loop by resetting the position to the edge of the bounding box if the initial point is outside the bounding box. Signed-off-by: Peter

[PATCH] Fix overflow of ConnectionOutput-size and -count

2014-11-17 Thread Peter Harris
of writev(fd, iov, 0) [an empty list]. Avoid this situation by killing the client when it has more than INT_MAX unread bytes of data. Signed-off-by: Peter Harris phar...@opentext.com --- Alternatively, we could change -size and -count to long (or ssize_t or ptrdiff_t). os/io.c | 7 --- 1

Re: [PATCH 6/8] dix: Switch window unmap to mark normally instead of UnmapValData

2014-11-17 Thread Peter Harris
Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001 phar...@opentext.comToll Free: 1 877 359 4866 ___ xorg-devel

Re: [PATCH 00/37] Implement backing store's Always mode

2014-10-21 Thread Peter Harris
-backingStore != Always all over the place. For the series, Reviewed-by: Peter Harris phar...@opentext.com Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001 phar

Re: [PATCH 21/37] dix: Drive tree mark/validate on unmap from paintable not viewable

2014-10-20 Thread Peter Harris
) { An extra block here +if (pWin-paintable) { +pWin-valdata = NULL; +pScreen-MarkWindow(pWin); +} appears to fix the crash. I haven't considered the equivalent for UnmapSubwindows yet. Peter Harris -- Open Text Connectivity

Re: [PATCH] fb: Fix Bresenham algorithms for commonly used small segments.

2014-10-16 Thread Peter Harris
every couple of weeks. See also http://wiki.x.org/wiki/Development/Documentation/SubmittingPatches/ Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001 phar

Re: [PATCH] fb: Fix Bresenham algorithms for commonly used small segments.

2014-10-06 Thread Peter Harris
. This patch has the effect of reverting said patch and adding an if in the proper location to catch the out of bounds memory write without causing problems to the overall algorithm. Signed-off-by: Alex Orange crazyca...@gmail.com Reviewed-by: Peter Harris phar...@opentext.com Tested-by: Peter Harris

Re: [PATCH] fb: Fix origin of source picture in fbGlyphs

2014-04-22 Thread Peter Harris
. It appears git ate all the #include lines. The line starts with a #, it must be a comment, right? Sigh. Peter Harris - -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001 phar

Re: [PATCH] fb: Fix origin of source picture in fbGlyphs

2014-04-21 Thread Peter Harris
On 2014-04-21 18:20, Keith Packard wrote: Peter Harris phar...@opentext.com writes: If a source picture doesn't repeat and a mask format is specified, the incorrect calulation of the origin of the glyphs caused the glyphs to not be drawn at all. Noticed when running gtk-demo from RHEL 6.5

[PATCH] composite: Fix memory leak in compCopyWindow

2014-04-16 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- composite/compwindow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/composite/compwindow.c b/composite/compwindow.c index 8824294..9a6b2da 100644 --- a/composite/compwindow.c +++ b/composite/compwindow.c @@ -525,6 +525,7

[PATCH] fb: Fix origin of source picture in fbGlyphs

2014-04-11 Thread Peter Harris
If a source picture doesn't repeat and a mask format is specified, the incorrect calulation of the origin of the glyphs caused the glyphs to not be drawn at all. Noticed when running gtk-demo from RHEL 6.5 and selecting Rotated Text. Signed-off-by: Peter Harris phar...@opentext.com --- fb

Re: [PATCH libXfont] Fix buffer read overrun

2014-04-11 Thread Peter Harris
On 2014-04-07 15:49, Alan Coopersmith wrote: On 04/ 7/14 11:29 AM, Peter Harris wrote: FreeType is only eight bytes long. The atom FreeType\x00\x?? is probably not what the author intended. Reviewed-by: Alan Coopersmith alan.coopersm...@oracle.com Thanks. Pushed. Peter Harris

[PATCH libXfont] Fix buffer read overrun

2014-04-07 Thread Peter Harris
FreeType is only eight bytes long. The atom FreeType\x00\x?? is probably not what the author intended. Signed-off-by: Peter Harris phar...@opentext.com --- src/FreeType/ftfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FreeType/ftfuncs.c b/src/FreeType/ftfuncs.c

Re: [PATCH xts] Drop use of perl's given/when construct

2014-03-21 Thread Peter Harris
On 2014-03-19 04:47, Peter Hutterer wrote: On Tue, Mar 18, 2014 at 11:08:42AM -0400, Peter Harris wrote: The perl mongers have retroactively marked this construct experimental, five and a half years after it was marked stable. http://perldoc.perl.org/perl5180delta.html#The-smartmatch-family

[PATCH xts] Drop use of perl's given/when construct

2014-03-18 Thread Peter Harris
The perl mongers have retroactively marked this construct experimental, five and a half years after it was marked stable. http://perldoc.perl.org/perl5180delta.html#The-smartmatch-family-of-features-are-now-experimental Signed-off-by: Peter Harris phar...@opentext.com --- xts5/bin/xts-config.in

Re: [PATCH] Avoid starting a comment with */*

2014-03-11 Thread Peter Harris
of both (named parameters, and * /* ) already in some of those header files. I just picked one option at random. Thanks for reviewing. Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and Development

[PATCH] Avoid starting a comment with */*

2014-03-10 Thread Peter Harris
Even though -Wcomment doesn't mind it (in gcc or clang), the appearance of */* confuses the syntax highlighter of some editors (eg. vim), and causes warnings in MSVC. Signed-off-by: Peter Harris phar...@opentext.com --- include/callback.h | 18 ++-- include/colormap.h | 16

Re: [PATCH 5/6] Add DRI3

2013-11-06 Thread Peter Harris
. xcb.h already has xcb_ge_event_t. Is this hunk solely for the doc section? Or for the #define XCB_GE 35 ? Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001

Re: [PATCH 1/6] Move the INT64 types in sync.xml to the sync: namespace

2013-11-06 Thread Peter Harris
probably be omitted. For the rest of the changes in this patch, Reviewed-by: Peter Harris phar...@opentext.com Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762

Re: [PATCH 6/6] Add Present protocol specification

2013-11-06 Thread Peter Harris
to be a workaround from before http://cgit.freedesktop.org/xcb/libxcb/commit/?id=45619dc71e9411a526d7c69595cf615b1b1206cf , and should not be necessary with libxcb built from git. Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp

Re: [PATCH 1/6] Move the INT64 types in sync.xml to the sync: namespace

2013-11-06 Thread Peter Harris
On 2013-11-06 13:11, Keith Packard wrote: Peter Harris phar...@opentext.com writes: diff --git a/src/sync.xml b/src/sync.xml index 516d149..ae3bbbc 100644 --- a/src/sync.xml +++ b/src/sync.xml @@ -41,14 +41,14 @@ for licensing information. item name=Events bit5/bit/item /enum - struct

Re: [PATCH 6/6] Add Present protocol specification

2013-11-06 Thread Peter Harris
On 2013-11-06 13:54, Keith Packard wrote: Peter Harris phar...@opentext.com writes: NAK. This field is not on the wire, it is an implementation detail of libxcb. This appears to be a workaround from before http://cgit.freedesktop.org/xcb/libxcb/commit/?id

Re: [PATCH 5/7] Add event queue splitting

2013-11-06 Thread Peter Harris
it be in a separate commit? Peter Harris [1] http://lists.freedesktop.org/archives/xcb/2012-January/007571.html -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001 phar...@opentext.com

Re: [Xcb] [PATCH 5/7] Add event queue splitting

2013-11-06 Thread Peter Harris
, this is out of left field, this is the first I've ever heard of it, can we please have a couple of days to think about it before we ACK it?ed. If we can get an API for this, we can move to pure XCB for GLX, Yeah, that would be awesome. Peter Harris -- Open Text Connectivity

Re: [Xcb] [PATCH 5/7] Add event queue splitting

2013-11-06 Thread Peter Harris
On 2013-11-06 19:55, Josh Triplett wrote: On Wed, Nov 06, 2013 at 02:34:03PM -0500, Peter Harris wrote: On 2013-11-05 19:41, Keith Packard wrote: This allows apps to peel off certain XGE events into separate queues for custom handling. Designed to support the Present extension Signed-off

Re: [PATCH 2/3] composite: Automatically enable backing store support on the screen

2013-09-12 Thread Peter Harris
For the series, Reviewed-by: Peter Harris phar...@opentext.com One minor bikeshed-coloured nit: On 2013-09-12 12:04, Adam Jackson wrote: compRedirectWindow(serverClient, pWin, CompositeRedirectAutomatic); pWin-backStorage = (pointer) (intptr_t) 1

Re: [PATCH xserver] Fix random hangs handling too-big requests

2013-08-12 Thread Peter Harris
On 2013-08-05 16:20, Aaron Plattner wrote: On 07/15/13 16:44, Peter Harris wrote: If a request is too big, input-ignoreBytes is set. When ignoreBytes is set, the number of bytes got now is artificially set to zero so the rest of the server does not process the partial request. Make sure

[PATCH xserver] Don't count RetainPermanent clients twice in security.c

2013-07-15 Thread Peter Harris
If a RetainPermanent client is subsequently killed by a KillClient request, the reference count is decremented twice. This can cause the server to prematurely kill other clients using the same Authorization. Signed-off-by: Peter Harris phar...@opentext.com --- Xext/security.c | 11

[PATCH xserver] Avoid stack smash when drawing dashed lines

2013-07-15 Thread Peter Harris
X.org Bug 54013 https://bugs.freedesktop.org/show_bug.cgi?id=54013 Signed-off-by: Peter Harris phar...@opentext.com --- See https://bugs.freedesktop.org/show_bug.cgi?id=54013 for a test case. mi/miwideline.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mi

[PATCH xserver] Fix random hangs handling too-big requests

2013-07-15 Thread Peter Harris
be assigned to an unrelated client. Signed-off-by: Peter Harris phar...@opentext.com --- os/io.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/os/io.c b/os/io.c index 0d980ab..3f7e3e0 100644 --- a/os/io.c +++ b/os/io.c @@ -451,7 +451,7 @@ ReadRequestFromClient(ClientPtr

Re: [PATCH xts v2] XI/ChangePointerDevice: Fix double-free

2013-07-04 Thread Peter Harris
On 2013-06-28 00:35, Peter Hutterer wrote: I'd probably add the second part of the commit message here as comment, but either way Reviewed-by: Peter Hutterer peter.hutte...@who-t.net Thanks for the review. I added the comment and pushed. Peter Harris -- Open Text

[PATCH compositeproto] Document update field in Unredirect requests

2013-06-18 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- Looks like the spec was missed when this field was added to the headers back in 2003 (the CVS commit now known as 11105d870631fe5f858291fbf167f1da400d7fa9 ). compositeproto.txt |8 ++-- 1 file changed, 6 insertions(+), 2 deletions

Re: [PATCH xts] XI/ChangePointerDevice: Fix double-free

2013-06-11 Thread Peter Harris
that this is not a valid device anyway. v2 incoming. Thanks for the review. Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001 phar...@opentext.com

[PATCH xts] XI/ChangePointerDevice: Check for XOpenDevice failures

2013-06-11 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- xts5/XI/ChangePointerDevice.m | 20 1 file changed, 20 insertions(+) diff --git a/xts5/XI/ChangePointerDevice.m b/xts5/XI/ChangePointerDevice.m index c7cb55f..dfd827a 100644 --- a/xts5/XI/ChangePointerDevice.m +++ b/xts5

[PATCH xts v2] XI/ChangePointerDevice: Fix double-free

2013-06-11 Thread Peter Harris
XCloseDevice frees the device parameter, even if it references an invalid device. Therefore, the device parameter must not be on the stack. Since xts5/XI does not clean up the devices created by Setup_Extension_DeviceInfo, it is safe to XCloseDevice device. Signed-off-by: Peter Harris phar

[PATCH xts] XI/ChangePointerDevice: Fix double-free

2013-06-10 Thread Peter Harris
XCloseDevice frees the device parameter, even if it references an invalid device. Therefore, the device parameter must have been malloc'd. Signed-off-by: Peter Harris phar...@opentext.com --- xts5/XI/ChangePointerDevice.m |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH xts 1/2] xts5/XI: Fix SEGV when double-freeing Display

2013-06-05 Thread Peter Harris
Only XOpenDisplay pairs with XCloseDisplay. The Display pointer returned by opendisplay is self-closing. Signed-off-by: Peter Harris phar...@opentext.com --- XCloseDisplay was formatted with spaces instead of tabs, which implies that it was added later. But the change was pre-git, so I have

[PATCH xts 2/2] XI/ChangeFeedbackControl: Always set f

2013-06-05 Thread Peter Harris
XChangeFeedbackControl will SEGV if the last parameter is NULL. Signed-off-by: Peter Harris phar...@opentext.com --- xts5/XI/ChangeFeedbackControl.m | 21 + 1 file changed, 21 insertions(+) diff --git a/xts5/XI/ChangeFeedbackControl.m b/xts5/XI/ChangeFeedbackControl.m

[PATCH xts] Write results directly to results directory

2013-06-03 Thread Peter Harris
If an installed xtest is run, the user does not normally have write access to the test directory. Writing intermediate files and results directly to the results directory avoids a number of spurious FAILs and UNRESOLVEDs. Signed-off-by: Peter Harris phar...@opentext.com --- xts5/Xlib16

Re: [PATCH xts] Write results directly to results directory

2013-06-03 Thread Peter Harris
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2013-06-03 17:49, Jamey Sharp wrote: Seems like a smart idea and solid patch. I have a couple suggestions you can do with as you please: On Mon, Jun 03, 2013 at 04:33:35PM -0400, Peter Harris wrote: If an installed xtest is run, the user does

[PATCH xts 1/3] Fix automatic configuration of BackingStores

2013-05-31 Thread Peter Harris
xdpyinfo reports NO, WHEN MAPPED or YES, but XT_DOES_BACKING_STORE expects a 0, 1, or 2. Signed-off-by: Peter Harris phar...@opentext.com --- This bumps the minimum version of Perl required up to 5.10. Both RHEL and Debian stable have perl 5.10. Is there anybody out there who runs XTS

[PATCH xts 2/3] Disable ColormapNotify test if implicit colormaps

2013-05-31 Thread Peter Harris
, and the test will report FAIL even though it shouldn't. Signed-off-by: Peter Harris phar...@opentext.com --- xts5/Xlib10/XInstallColormap.m |8 1 file changed, 8 insertions(+) diff --git a/xts5/Xlib10/XInstallColormap.m b/xts5/Xlib10/XInstallColormap.m index cabe836..10d4117 100644

[PATCH xts 3/3] Fix XSetWMSizeHints et al.

2013-05-31 Thread Peter Harris
Xlib, since release 1.1.2, only transmits fields for which the corresponding flags bit is set (to avoid a potential information leak). Set the flags field to include all the fields to be tested. Signed-off-by: Peter Harris phar...@opentext.com --- xts5/Xlib15/XGetWMNormalHints.m

[PATCH xts 1/2] Fix pointer/int warnings in xts5/xim/response.c

2013-05-30 Thread Peter Harris
psd-data.bitmap is never set, but it's better to make sure we never try to free() an XID. Signed-off-by: Peter Harris phar...@opentext.com --- xts5/src/xim/response.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xts5/src/xim/response.c b/xts5/src/xim/response.c

[PATCH xts 2/2] XI: Fix random failures on LP64 platforms

2013-05-30 Thread Peter Harris
It turns out that XID is a 'long' for historical reasons, but the XInput error macros expect a pointer-to-int. Signed-off-by: Peter Harris phar...@opentext.com --- xts5/XI/AllowDeviceEvents.m |2 +- xts5/XI/ChangeDeviceControl.m |2 +- xts5/XI/ChangeFeedbackControl.m

[PATCH xts] Add XInput sections to all

2013-05-29 Thread Peter Harris
Signed-off-by: Peter Harris phar...@opentext.com --- xts5/tet_scen |4 1 file changed, 4 insertions(+) diff --git a/xts5/tet_scen b/xts5/tet_scen index fa13bca..6c32f0a 100644 --- a/xts5/tet_scen +++ b/xts5/tet_scen @@ -186,6 +186,10 @@ all :include:/scenarios/XtE_scen

Re: [RFC][PATCH] Make GetXIDRange O(1) instead of O(N^2)

2013-05-28 Thread Peter Harris
application that would benefit from reusing free IDs can already do so.) Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001 phar...@opentext.comToll

Re: Initial DRI3000 protocol specs available

2013-02-20 Thread Peter Harris
, it easily fits in the two bytes of unused after evtype). Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001 phar...@opentext.comToll Free: 1 877 359

Re: [Xcb] [PATCH] Remove fieldref from sole list in GetIndicatorMap reply

2013-02-19 Thread Peter Harris
On 2013-02-19 15:51, Alan Coopersmith wrote: On 02/19/13 12:47 PM, Peter Harris wrote: I was going to, but I can't locate the XKB protocol spec. There isn't one in xorg/proto/kbproto, and the specs in xorg/lib/libX11 appear to document the Xlib interface only, not the on-wire protocol. I

[PATCH] Set nIndicators in XkbGetIndicatorMap

2013-02-19 Thread Peter Harris
Xlib doesn't use this value (it computes it from the reply length instead) which is why nobody has noticed yet. But the spec http://www.x.org/releases/X11R7.7/doc/kbproto/xkbproto.html says that it should be set. Signed-off-by: Peter Harris phar...@opentext.com --- xkb/xkb.c |1 + 1 files

Re: [Xcb] [PATCH] Remove fieldref from sole list in GetIndicatorMap reply

2013-02-19 Thread Peter Harris
to document the Xlib interface only, not the on-wire protocol. Does anyone happen to know where the XKB proto spec is? I want to read it before I file a bug against the server. Thanks, Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp

Re: [PATCH xts] xts5: include xtrans CFLAGS when building libXst

2013-01-07 Thread Peter Harris
aplatt...@nvidia.com Reviewed-by: Peter Harris phar...@opentext.com Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762 6001 phar...@opentext.comToll

Re: [PATCH xts] Set XT_DISPLAYHOST for remote connections

2013-01-07 Thread Peter Harris
On 2013-01-04 21:12, Aaron Plattner wrote: On 01/02/2013 02:38 PM, Peter Harris wrote: Some tests segfault if XT_DISPLAY is set and XT_DISPLAYHOST is not. Signed-off-by: Peter Harris phar...@opentext.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com Which test? Xlib3/XOpenDisplay

[PATCHv2 xts] Set XT_DISPLAYHOST for remote connections

2013-01-07 Thread Peter Harris
Xlib3/XOpenDisplay may segfault if XT_DISPLAY is set and XT_DISPLAYHOST is not. Signed-off-by: Peter Harris phar...@opentext.com --- This version works with IPv6 literal addresses. XOpenDisplay still parses them incorrectly, but at least it doesn't crash. xts5/bin/xts-config.in |8

[PATCH xts] Set XT_DISPLAYHOST for remote connections

2013-01-02 Thread Peter Harris
Some tests segfault if XT_DISPLAY is set and XT_DISPLAYHOST is not. Signed-off-by: Peter Harris phar...@opentext.com --- xts5/bin/xts-config.in |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/xts5/bin/xts-config.in b/xts5/bin/xts-config.in index 9e30b5f..ce55618

Re: [PATCH xts] Build blowup

2012-12-20 Thread Peter Harris
On 2012-12-19 09:07, Dan Nicholson wrote: On Tue, Dec 18, 2012 at 10:44 AM, Peter Harris phar...@opentext.com wrote: Rename from pixval/blowup to bin/xts-blowup, add Makefile.am, and delete old-style Makefile. --- Was blowup really not ported to the new build system yet, or is there some

[PATCH xts] Build blowup

2012-12-18 Thread Peter Harris
Rename from pixval/blowup to bin/xts-blowup, add Makefile.am, and delete old-style Makefile. --- Was blowup really not ported to the new build system yet, or is there some alternative tool that people use these days? configure.ac|1 + xts5/src/Makefile.am

[PATCH xts] Remove pad adjustments from Xproto/GetImage/PutImage

2012-12-17 Thread Peter Harris
GetImage adjusts the length field incorrectly, and PutImage does not adjust the length field at all. Since the only stored images are those from GetImage, it makes more sense to remove the pad code entirely than to fix it. Signed-off-by: Peter Harris phar...@opentext.com --- Xtest defaults

Re: [PATCH xtest] Allow space in read buffer for CRLF and NUL

2012-12-13 Thread Peter Harris
On 2012-12-06 18:38, Aaron Plattner wrote: Reviewed-by: Aaron Plattner aplatt...@nvidia.com Thanks. Pushed. Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com/ Research and DevelopmentPhone: +1 905 762

[PATCH xtest] Allow space in read buffer for CRLF and NUL

2012-12-04 Thread Peter Harris
tcc will limit output lines to 512 characters not including CRLF. In addition, there needs to be space in the buffer for the trailing NUL that fgets will append. Without this change, xts-report will exit prematurely if it sees a maximum length line. Signed-off-by: Peter Harris phar

Re: [PATCH] Don't count RetainPermanent clients twice in security.c

2012-11-23 Thread Peter Harris
On 2012-11-23 16:44, Peter Harris wrote: If a RetainPermanent client is subsequently killed by a KillClient request, the reference count is decremented twice. This can cause the server to prematurely kill other clients using the same Authorization. Attached is a simple app to demonstrate

[PATCH test/xts] Don't add local paths when the server is remote

2012-08-15 Thread Peter Harris
XT_FONTPATH has to be a valid font path. Also trim at least one remote path from XT_FONTPATH_GOOD, so it isn't the same as XT_FONTPATH. Signed-off-by: Peter Harris phar...@opentext.com --- This works well in my setup. Is anyone relying on xtest font directories being in the same location

Re: [PATCH test/xts] Fix XSendEvent tests

2012-08-15 Thread Peter Harris
On 2012-08-03 17:17, Jeremy Huddleston Sequoia wrote: For the series of 3 patches: Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com Thanks. Pushed. Peter Harris -- Open Text Connectivity Solutions Group Peter Harrishttp://connectivity.opentext.com

[PATCH test/xts] Fix XSendEvent tests

2012-08-01 Thread Peter Harris
doesn't generate GenericEvent. Signed-off-by: Peter Harris phar...@opentext.com --- xts5/Xlib12/XSendEvent.m |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/xts5/Xlib12/XSendEvent.m b/xts5/Xlib12/XSendEvent.m index 26eb5a1..48eec0e 100644 --- a/xts5/Xlib12

  1   2   >