Re: [PATCH] radv: fix depth transitions with layerCount = VK_REMAINING_ARRAY_LAYERS

2017-01-06 Thread Pierre-Loup A. Griffais
lto:ja...@jlekstrand.net>> wrote: Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net <mailto:ja...@jlekstrand.net>> I'll let Dave or Bas push though. :-) On Fri, Jan 6, 2017 at 12:57 PM, Pierre-Loup A. Griffais <pgriff...@valvesoftware.com <mailto:pgriff...

[PATCH] radv: fix depth transitions with layerCount = VK_REMAINING_ARRAY_LAYERS

2017-01-06 Thread Pierre-Loup A. Griffais
Interpreting layerCount literally would try to create billions of image views in radv_process_depth_image_inplace(). Signed-off-by: Pierre-Loup A. Griffais <pgriff...@valvesoftware.com> --- src/amd/vulkan/radv_meta_decompress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: How do we want to deal with 4k tiled displays?

2014-01-27 Thread Pierre-Loup A. Griffais
I see lots of discussion has happened on that front already; sorry for being late to the party. I'm currently wrestling against a Dell UP3214Q, which seems to exhibit all of the problems you refer to. There are many existing binary games out there that most likely will never get touched again

Re: [PATCH xrandr] xrandr: print primary output

2013-01-02 Thread Pierre-Loup A. Griffais
Thanks! On 01/02/2013 01:25 PM, Aaron Plattner wrote: On 12/26/2012 11:49 PM, Pierre-Loup A. Griffais wrote: Ping; anyone feel like merging this? To ssh://git.freedesktop.org/git/xorg/app/xrandr b26fd53..094b40e master - master -- Aaron Thanks, - Pierre-Loup On 12/19/2012 12:35

Re: [PATCH xrandr] xrandr: print primary output

2012-12-26 Thread Pierre-Loup A. Griffais
Ping; anyone feel like merging this? Thanks, - Pierre-Loup On 12/19/2012 12:35 PM, Pierre-Loup A. Griffais wrote: I could have sworn there was a change to do that in the wild already, but I couldn't find it. Thanks, - Pierre-Loup ___ xorg

[PATCH xrandr] xrandr: print primary output

2012-12-19 Thread Pierre-Loup A. Griffais
I could have sworn there was a change to do that in the wild already, but I couldn't find it. Thanks, - Pierre-Loup From 7d0720196cd89ac012fd7d0bf86cee0cffaea631 Mon Sep 17 00:00:00 2001 From: Pierre-Loup A. Griffais pgriff...@nvidia.com Date: Wed, 19 Dec 2012 12:32:03 -0800 Subject: [PATCH

[PATCH] xwininfo: report the Visual class of the selected Window

2012-10-09 Thread Pierre-Loup A. Griffais
Looks like fallout from the XCB port? Anyhow, appreciated if someone could push this on my behalf. Thanks! - Pierre-Loup From 12df33eb2424533fa0b9ae8b9ceecdd67fa84ffc Mon Sep 17 00:00:00 2001 From: Pierre-Loup A. Griffais pgriff...@nvidia.com Date: Tue, 9 Oct 2012 20:33:10 -0700 Subject: [PATCH

Re: Does Xorg'x XRender implementation support better-than-bilinear interpolation?

2012-09-11 Thread Pierre-Loup A. Griffais
On 09/11/2012 10:43 AM, Søren Sandmann wrote: Pierre-Loup A. Griffaispgriff...@nvidia.com writes: I'm not very familiar with bicubic interpolation, but couldn't it be achieved using the 'convolution' filter with the adequate kernel? (possibly in several passes at different scales). AFAIK

Re: Does Xorg'x XRender implementation support better-than-bilinear interpolation?

2012-09-10 Thread Pierre-Loup A. Griffais
On 09/10/2012 06:08 PM, Daniel Stone wrote: Hi, On 10 September 2012 23:33, Maarten Maathuismadman2...@gmail.com wrote: On Mon, Sep 10, 2012 at 11:05 PM, Clemens Eissererlinuxhi...@gmail.com wrote: I just realized that at least on my machine (fedora 17 + intel 20.2), the only interpolation

Re: [PATCH] xrandr: move transform limit checking after scaling

2012-03-23 Thread Pierre-Loup A. Griffais
Ping? On 03/20/2012 04:54 PM, Pierre-Loup A. Griffais wrote: Wasted a good chunk of time on that one. ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] xrandr: move transform limit checking after scaling

2012-03-20 Thread Pierre-Loup A. Griffais
Wasted a good chunk of time on that one. From f1a65814f119cb83d16e15093e81946f3adcde61 Mon Sep 17 00:00:00 2001 From: Pierre-Loup A. Griffais pgriff...@nvidia.com Date: Tue, 20 Mar 2012 16:46:22 -0700 Subject: [PATCH] xrandr: move transform limit checking after scaling This would trigger

[PATCH] xfree86: Fix RandR rotation across server generations

2011-11-05 Thread Pierre-Loup A. Griffais
From efced7bc4bba912e23a4c76f1057da7a1529dd92 Mon Sep 17 00:00:00 2001 From: Pierre-Loup A. Griffais pgriff...@nvidia.com Date: Fri, 4 Nov 2011 23:26:25 -0700 Subject: [PATCH] xfree86: Fix RandR rotation across server generations 245cb8e94fd1599 fixed xf86RotateDestroy() to actually run its

Re: [PATCH] xfree86: Fix RandR rotation across server generations

2011-11-05 Thread Pierre-Loup A. Griffais
people are getting today, even if the behaviour ends up changing in the future. On 11/04/2011 11:42 PM, Pierre-Loup A. Griffais wrote: From efced7bc4bba912e23a4c76f1057da7a1529dd92 Mon Sep 17 00:00:00 2001 From: Pierre-Loup A. Griffaispgriff...@nvidia.com Date: Fri, 4 Nov 2011 23:26:25 -0700

Re: [PATCH] Revert composite: Don't backfill non-MapWindow allocations

2011-07-29 Thread Pierre-Loup A. Griffais
On 07/29/2011 03:26 PM, Ville Syrjälä wrote: On Thu, Jul 28, 2011 at 01:00:54PM -0700, Pierre-Loup A. Griffais wrote: Oops, initially got an outdated address for Ville. Properly CCing now; the idea is that 193ecc8b453b22b3e6 breaks backfilling on resize if db8840600e8e213562 is also applied

[PATCH] Revert composite: Don't backfill non-MapWindow allocations

2011-07-28 Thread Pierre-Loup A. Griffais
This reverts commit db8840600e8e21356241eb87395031388d9b54d2. Conflicts: composite/compalloc.c --- composite/compalloc.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/composite/compalloc.c b/composite/compalloc.c index 5c27631..841b2dc 100644 ---

Re: [PATCH] Revert composite: Don't backfill non-MapWindow allocations

2011-07-28 Thread Pierre-Loup A. Griffais
Oops, initially got an outdated address for Ville. Properly CCing now; the idea is that 193ecc8b453b22b3e6 breaks backfilling on resize if db8840600e8e213562 is also applied. Thanks, - Pierre-Loup On 07/28/2011 12:58 PM, Pierre-Loup A. Griffais wrote: This reverts commit

Re: [PATCH] Revert composite: Don't backfill non-MapWindow allocations

2011-07-28 Thread Pierre-Loup A. Griffais
Yeah, it was somewhat lacking; fixed and added reviewed tag by ajax. Thanks! - Pierre-Loup On 07/28/2011 01:53 PM, Julien Cristau wrote: On Thu, Jul 28, 2011 at 13:00:54 -0700, Pierre-Loup A. Griffais wrote: now; the idea is that 193ecc8b453b22b3e6 breaks backfilling on resize

Re: [PATCH] rootless: Fix SetShape regression

2010-06-05 Thread Pierre-Loup A. Griffais
On 06/04/2010 09:58 PM, Jeremy Huddleston wrote: This fixes a regression in miext/rootless from 643cb6e87c10ab554c03ada81930001a8ebcc909 Whoops. Reviewed-by: Pierre-Loup A. Griffais pgriff...@nvidia.com Found-by: tinderbox Signed-off-by: Jeremy Huddlestonjerem...@apple.com --- miext

Re: [PATCH] Don't ValidateTree/expose when changing the input shape

2010-05-27 Thread Pierre-Loup A. Griffais
On 05/27/2010 04:13 AM, Daniel Stone wrote: * PGP Signed by an unknown key On Wed, May 26, 2010 at 04:57:02PM -0700, Pierre-Loup A. Griffais wrote: ValidateTree can be pretty expensive; gnome-shell floods the server with input shape requests when animating windows, so that change makes

[PATCH] Don't ValidateTree/expose when changing the input shape

2010-05-26 Thread Pierre-Loup A. Griffais
the input shape? The only thing that looks needed for sure is CheckCursorConfinement(), but I have my doubts about the rest. Thanks, - Pierre-Loup From d462db1f8bf99c428fcc59e1f167f563e789995e Mon Sep 17 00:00:00 2001 From: Pierre-Loup A. Griffais pgriff...@nvidia.com Date: Wed, 26 May 2010 15

Re: [PATCH] midispcur: Construct Picture objects lazily in case Render is disabled.

2010-05-25 Thread Pierre-Loup A. Griffais
On 05/24/2010 07:05 PM, Jamey Sharp wrote: On Mon, May 24, 2010 at 4:49 PM, Pierre-Loup A. Griffais pgriff...@nvidia.com wrote: On 05/24/2010 09:34 AM, Jamey Sharp wrote: These Pictures are not freed in miDCDeviceCleanup. Before the don't thrash resources patch, there was a comment suggesting

Re: multi-card breakage

2010-05-19 Thread Pierre-Loup A. Griffais
Tiago, On 05/19/2010 08:09 AM, Vignatti Tiago (Nokia-D/Helsinki) wrote: Hi Pierre, On Tue, May 04, 2010 at 10:21:55PM +0200, ext Pierre-Loup A. Griffais wrote: I just reproduced something that sounds like what you're describing with two R520 cards (one X screen per card) and the 'radeon

Re: [PATCH] Device init: Don't crash when CreateGC fails.

2010-05-14 Thread Pierre-Loup A. Griffais
That looks good to me. Sorry I for introducing this! - Pierre-Loup On 05/14/2010 11:37 AM, Jamey Sharp wrote: ActivateDevice was ignoring errors from DeviceCursorInitialize, so cursor-related calls failed later. Jeremy Huddleston saw that crash in miPointerConstrainCursor, while with Xvfb I

Re: multi-card breakage

2010-05-04 Thread Pierre-Loup A. Griffais
Tiago, This commit fixes the SW cursor with several screens, so the multi-card case is more or less the point of the change. Can you be more specific about the problems you're having and your testing environment? Do you have the SW cursor forced on? Removing the dependency on devPrivates

Re: multi-card breakage

2010-05-04 Thread Pierre-Loup A. Griffais
behind that is, the driver ought to fail more gracefully. In any case, I'm guessing you have similar spew in your logs? Thanks, - Pierre-Loup On 05/04/2010 10:28 AM, Pierre-Loup A. Griffais wrote: Tiago, This commit fixes the SW cursor with several screens, so the multi-card case is more

Re: [PATCH] Revert mi: don't thrash resources when displaying the software cursor across screens

2010-04-21 Thread Pierre-Loup A. Griffais
From: Pierre-Loup A. Griffais pgriff...@nvidia.com Date: Wed, 21 Apr 2010 12:02:26 -0700 Subject: [PATCH] Don't double-free the software cursor pictures. Signed-off-by: Pierre-Loup A. Griffais pgriff...@nvidia.com --- mi/midispcur.c |5 - 1 files changed, 0 insertions(+), 5 deletions

Re: [PATCH] Revert mi: don't thrash resources when displaying the software cursor across screens

2010-04-21 Thread Pierre-Loup A. Griffais
); } } -- 1.6.6.1 From 7ffae8aaa4ac445a727e663e1e1bf05a2510cd35 Mon Sep 17 00:00:00 2001 From: Pierre-Loup A. Griffais pgriff...@nvidia.com Date: Wed, 21 Apr 2010 16:46:17 -0700 Subject: [PATCH] mi: don't thrash resources when displaying the software cursor across screens This changes the DC layer

[PATCH] xf86: Don't crash when switching modes through RandR without owning the VT.

2010-04-21 Thread Pierre-Loup A. Griffais
Mon Sep 17 00:00:00 2001 From: Pierre-Loup A. Griffais pgriff...@nvidia.com Date: Wed, 21 Apr 2010 17:59:42 -0700 Subject: [PATCH] xf86: Don't crash when switching modes through RandR without owning the VT. While VT-switched, FB access is disabled and should remain so. Trying to switch modes

Re: [PATCH] mi: fix software cursor with several X screens

2010-04-07 Thread Pierre-Loup A. Griffais
Thanks for the review; responses inline and attached revised version of the patch: On 04/06/2010 06:52 PM, Peter Hutterer wrote: On Tue, Apr 06, 2010 at 03:32:49PM -0700, Pierre-Loup A. Griffais wrote: Now with a proper GC cleanup sequence instead of freeing the same GC in a loop. Thanks

Re: Software cursor broken with several X screens

2010-04-06 Thread Pierre-Loup A. Griffais
On 04/06/2010 08:20 AM, Tiago Vignatti wrote: On Tue, Apr 06, 2010 at 03:52:07AM +0200, ext Pierre-Loup A. Griffais wrote: The DC code is broken for setups with several screens. Devs only have one pSave pixmap and there's no code to thrash them like p[Save|Restore]GC. That means if you have

[PATCH] mi: fix software cursor with several X screens (was Re: Software cursor broken with several X screens)

2010-04-06 Thread Pierre-Loup A. Griffais
and miSpriteDeviceCursorInitialize to only perform their own setup once in that case. Opinions? Thanks, - Pierre-Loup On 04/06/2010 08:20 AM, Tiago Vignatti wrote: On Tue, Apr 06, 2010 at 03:52:07AM +0200, ext Pierre-Loup A. Griffais wrote: The DC code is broken for setups with several screens. Devs only have one pSave

Re: [PATCH] mi: fix software cursor with several X screens

2010-04-06 Thread Pierre-Loup A. Griffais
Now with a proper GC cleanup sequence instead of freeing the same GC in a loop. Thanks, - Pierre-Loup On 04/06/2010 02:44 PM, Pierre-Loup A. Griffais wrote: (disregard previous message sent too soon) Attached is a tentative patch that cleans that particular code up and fixes the issue

Software cursor broken with several X screens

2010-04-05 Thread Pierre-Loup A. Griffais
The DC code is broken for setups with several screens. Devs only have one pSave pixmap and there's no code to thrash them like p[Save|Restore]GC. That means if you have two X screens and force SW cursor on both, the server will end up passing a bunch of CopyAreas with mismatching screens to the

[PATCH xfree86] Don't keep a pointer to a possibly freed cursor when changing screens, preventing a crash in xf86CursorEnableDisableFBAccess() trying to restore it.

2010-04-02 Thread Pierre-Loup A. Griffais
Signed-off-by: Pierre-Loup A. Griffais pgriff...@nvidia.com --- hw/xfree86/ramdac/xf86Cursor.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/xfree86/ramdac/xf86Cursor.c b/hw/xfree86/ramdac/xf86Cursor.c index 7f23d9e..f5f0873 100644 --- a/hw/xfree86/ramdac

[PATCH] Fix source pictures getting random transforms after 2d6a8f668342a5190cdf43b5.

2010-01-19 Thread Pierre-Loup A. Griffais
Signed-off-by: Pierre-Loup A. Griffais pgriff...@nvidia.com Reviewed-by: Aaron Plattner aplatt...@nvidia.com --- fb/fbpict.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fb/fbpict.c b/fb/fbpict.c index f9f4343..c046bae 100644 --- a/fb/fbpict.c +++ b/fb/fbpict.c

[PATCH] Let the server expose 10bpc picture formats

2009-07-27 Thread Pierre-Loup A. Griffais
recipient, please contact the sender by reply email and destroy all copies of the original message. --- From 7495d36d1e9fd0ddfaa868c7628486591cac3f50 Mon Sep 17 00:00:00 2001 From: Pierre-Loup A. Griffais pgriff...@nvidia.com