Re: [PATCH xserver] GLX: Support TLS with better portability

2011-03-23 Thread Dan Nicholson
On Tue, Mar 22, 2011 at 9:13 PM, tom fogal tfo...@sci.utah.edu wrote: Jeremy Huddleston jerem...@apple.com writes: AX_TLS detects when toolchains support __thread or __declspec(thread), but existing code assumed __thread. Good find.  configure.ac            |    1 + [snip] +    

Re: [PATCH xserver] GLX: Support TLS with better portability

2011-03-23 Thread Jeremy Huddleston
On Mar 22, 2011, at 9:13 PM, tom fogal wrote: Jeremy Huddleston jerem...@apple.com writes: AX_TLS detects when toolchains support __thread or __declspec(thread), but existing code assumed __thread. Good find. configure.ac|1 + [snip] +AC_DEFINE(__XSERVER_TLS,

Re: [PATCH xserver] GLX: Support TLS with better portability

2011-03-23 Thread tom fogal
Dan Nicholson dbn.li...@gmail.com writes: On Tue, Mar 22, 2011 at 9:13 PM, tom fogal tfo...@sci.utah.edu wrote: The AX_TLS macro should AC_DEFINE_UNQUOTED TLS. I recommend using that instead of inventing our own define. Yeah, that seems reasonable. Tom, is that what's done in mesa? It

Re: [PATCH xserver] GLX: Support TLS with better portability

2011-03-23 Thread tom fogal
Jeremy Huddleston jerem...@apple.com writes: On Mar 22, 2011, at 9:13 PM, tom fogal wrote: I haven't looked to see if we have __thread anywhere else that should go away in favor of the macro, but I assume you have. I grepped through xserver because it was what broke in tinderbox. I

[PATCH xserver] GLX: Support TLS with better portability

2011-03-22 Thread Jeremy Huddleston
AX_TLS detects when toolchains support __thread or __declspec(thread), but existing code assumed __thread. Found-by: Tinderbox http://tinderbox.x.org/builds/2011-03-22-0007 Regression-from: 82b1eaa6cad20f39dbf15573bdb3d62acbcd91f9 Signed-off-by: Jeremy Huddleston jerem...@apple.com ---

Re: [PATCH xserver] GLX: Support TLS with better portability

2011-03-22 Thread tom fogal
Jeremy Huddleston jerem...@apple.com writes: AX_TLS detects when toolchains support __thread or __declspec(thread), but existing code assumed __thread. Good find. configure.ac|1 + [snip] + AC_DEFINE(__XSERVER_TLS, ${ac_cv_tls}, [Thread local storage directive] The