Re: [PATCH xserver] dix: Bump MAXHASHSIZE for the resource db

Adam Jackson writes: > From: Roberto Ragusa > > [This was originally a workaround for a client-side resource leak: > > http://lists.freedesktop.org/archives/xorg-devel/2012-November/034555.html > > Obviously that's a broken app, but the performance

Re: [PATCH xserver 0/3] xf86Cursor: Fix HW cursor positioning issues

Hi, On 05-10-16 11:45, Hans de Goede wrote: Hi, On 05-10-16 11:41, Michel Dänzer wrote: From: Michel Dänzer I wanted to enable HW cursors on PRIME slave screens in our drivers, but noticed that a few things aren't quite right yet. The series is ordered from the most

[PATCH xserver 2/3] xf86Cursor: Use CursoreRec::bits->x/yhot in xf86SetCursor

From: Michel Dänzer xf86CursorScreenRec::HotX/Y contain 0 for PRIME slave screens. Fixes intermittent incorrect HW cursor position on PRIME slave screens when switching between cursors with different hotspot positions. Also hoist the hotspot translation out from

[PATCH xserver 3/3] xf86Cursor: Take the input lock in xf86Set/MoveCursor

From: Michel Dänzer Prevents the HW cursor from intermittently jumping around when the cursor image is changed while the cursor is being moved. This is hardly noticeable in normal operation but can be quite confusing when stepping through these codepaths in a debugger.

Re: [PATCH xserver] glamor: Use eglGetPlatformDisplayEXT not eglGetDisplay

On 4 October 2016 at 18:34, Adam Jackson wrote: > eglGetDisplay forces the implementation to guess which kind of display > it's been handed. glvnd does something different from Mesa, and in > general it's impossible for the library to get this right. Instead use > the API where

[PATCH xserver 0/3] xf86Cursor: Fix HW cursor positioning issues

From: Michel Dänzer I wanted to enable HW cursors on PRIME slave screens in our drivers, but noticed that a few things aren't quite right yet. The series is ordered from the most obvious problem to more subtle ones. Patches 1 & 2 fix incorrect positioning of the HW

[PATCH xserver 1/3] xf86Cursor: Use CursoreRec::bits->x/yhot in xf86MoveCursor

From: Michel Dänzer xf86CursorScreenRec::HotX/Y contain 0 for PRIME slave screens. Fixes incorrect HW cursor position on PRIME slave screens. Also hoist the hotspot translation out from xf86ScreenMoveCursor to xf86MoveCursor, since the hotspot position is a property of

Re: Request changes in Compose.pre

Good day! Sorry for noise, but I'm discouraged by silence. Maybe I need send patch by another address or maybe I doing wrong something... Please give me a tips how I may do it correctly. On Tue, 4 Oct 2016 15:52:05 +0300 "Victor V. Kustov" wrote: > Good day! > > Please approve

Re: [PATCH xserver 0/3] xf86Cursor: Fix HW cursor positioning issues

Hi, On 05-10-16 11:41, Michel Dänzer wrote: From: Michel Dänzer I wanted to enable HW cursors on PRIME slave screens in our drivers, but noticed that a few things aren't quite right yet. The series is ordered from the most obvious problem to more subtle ones. Patches

Re: [PATCH xserver 0/3] xf86Cursor: Fix HW cursor positioning issues

On 05/10/16 07:05 PM, Hans de Goede wrote: > On 05-10-16 11:45, Hans de Goede wrote: >> On 05-10-16 11:41, Michel Dänzer wrote: >>> From: Michel Dänzer >>> >>> I wanted to enable HW cursors on PRIME slave screens in our drivers, but >>> noticed that a few things aren't

Re: [PATCH xserver] glamor: Use eglGetPlatformDisplayEXT not eglGetDisplay

Hi, On 04-10-16 19:34, Adam Jackson wrote: eglGetDisplay forces the implementation to guess which kind of display it's been handed. glvnd does something different from Mesa, and in general it's impossible for the library to get this right. Instead use the API where you specify what kind of

Re: [tigervnc-devel] PATCH: Add xorg-xserver 1.19 support to tigervnc

On 04/10/16 17:45, Hans de Goede wrote: If been working for 7 days on a row now to get 1.19 in shape for Fedora 25, so I'm afraid that the v2 of this patch I'm working on is going to be a take it or leave it offer from my pov. You are of course more then welcome to improve upon the patch

Re: [PATCH libX11 1/2] The validation of server responses avoids out of boundary accesses.

Hi all, Sorry I didn't get a chance to look at these before they went public... On Sun, Sep 25, 2016 at 22:50:40 +0200, Matthieu Herrb wrote: > From: Tobias Stoeckmann > > v2: FontNames.c return a NULL list whenever a single > length field from the server is incohent.

[PATCH v2 xserver] glamor: Fix pixmap offset for bitplane in glamor_copy_fbo_cpu

Commit cba28d5 - "glamor: Handle bitplane in glamor_copy_fbo_cpu" introduced a regression as the computed pixmap offset would not match the actual coordinates and write data elsewhere in memory causing a segfault in fbBltOne(). Translate the pixmap coordinates so that the data is read and written

Re: [PATCH libXi] Properly validate server responses.

On Sun, Sep 25, 2016 at 22:50:43 +0200, Matthieu Herrb wrote: > From: Tobias Stoeckmann > > By validating length fields from server responses, out of boundary > accesses and endless loops can be mitigated. > > Signed-off-by: Tobias Stoeckmann >

[PATCH xserver] test: Use $XSERVER_BUILDDIR for Xvfb executable path

From: Michel Dänzer Fixes make check with out-of-tree builds. Signed-off-by: Michel Dänzer --- test/scripts/xvfb-piglit.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/scripts/xvfb-piglit.sh

[PATCH] inputthread: Fix inputthread not listening if a fd gets re-added immediately after removal

When a fd is removed dev->state gets set to device_state_removed, if the fd then gets re-added before InputThreadDoWork() deals with the removal, the InputThreadDevice struct gets reused, but its state would stay device_state_removed, so it would still get removed on the first InputThreadDoWork()

[PATCH xf86-input-libinput] Fix crash when using threaded input and the first device goes away

When the xserver uses threaded input, it keeps a pointer to the InputInfo passed into xf86AddEnabledDevice and calls pointer->read_input on events. But when the first enabled device goes away the pInfo we've passed into xf86AddEnabledDevice gets freed and eventually pInfo->read_input gets

Re: [PATCH xf86-input-libinput] Fix crash when using threaded input and the first device goes away

Hi, On 05-10-16 15:31, Hans de Goede wrote: When the xserver uses threaded input, it keeps a pointer to the InputInfo passed into xf86AddEnabledDevice and calls pointer->read_input on events. But when the first enabled device goes away the pInfo we've passed into xf86AddEnabledDevice gets

[PATCH xserver] glamor: Use eglGetPlatformDisplay{,EXT} if we can

eglGetDisplay forces the implementation to guess which kind of display it's been handed. glvnd does something different from Mesa, and in general it's impossible for the library to get this right. Add a new inline that gets the logic right, and works around a quirk in epoxy. Signed-off-by: Adam

Re: [PATCH xserver] test: Use $XSERVER_BUILDDIR for Xvfb executable path

Michel Dänzer writes: > From: Michel Dänzer > > Fixes make check with out-of-tree builds. > > Signed-off-by: Michel Dänzer Reviewed-by: Keith Packard -- -keith signature.asc Description: PGP signature

[PATCH xserver] ephyr: Leave window unmapped for -glamor-skip-present

If we're never painting anything in the window, we probably don't need to map it. Signed-off-by: Keith Packard --- hw/kdrive/ephyr/hostx.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/kdrive/ephyr/hostx.c b/hw/kdrive/ephyr/hostx.c index

Re: [PATCH] inputthread: Fix inputthread not listening if a fd gets re-added immediately after removal

Hans de Goede writes: > When a fd is removed dev->state gets set to device_state_removed, > if the fd then gets re-added before InputThreadDoWork() deals with > the removal, the InputThreadDevice struct gets reused, but its > state would stay device_state_removed, so it

Re: [PATCH xserver] ephyr: Leave window unmapped for -glamor-skip-present

Keith Packard writes: > If we're never painting anything in the window, we probably don't need > to map it. > > Signed-off-by: Keith Packard Drop the extern ephyr_glamor_gles2 and it's: Reviewed-by: Eric Anholt signature.asc

Re: [PATCH xserver 01/14 v2] dix: Introduce CursorWarpedTo vfunc in Screen

On Tue, 2016-09-13 at 15:16 +0800, Jonas Ådahl wrote: > This new vfunc will be called, if set, after a client has issued a > WarpPointer request. This is necessary for implementing pointer warp > emulation in Xwayland. > > Signed-off-by: Jonas Ådahl > Reviewed-by: Peter

Re: [PATCH xserver 0/2] xwayland touch handling fixes

On Tue, 2016-09-27 at 19:03 +0200, Carlos Garnacho wrote: > Hi! > > I'm sending a couple of fixes to fix touch handling in wayland. The > first patch makes the XYToWindow proc handler friendlier to touch-driven > pointer emulation (and possibly other pointer-driving devices in the > future with

Re: [PATCH v2 xserver] glamor: Fix pixmap offset for bitplane in glamor_copy_fbo_cpu

On Wed, 2016-10-05 at 08:36 +0200, Olivier Fourdan wrote: > Commit cba28d5 - "glamor: Handle bitplane in glamor_copy_fbo_cpu" > introduced a regression as the computed pixmap offset would not match > the actual coordinates and write data elsewhere in memory causing a > segfault in fbBltOne(). > >

Re: [PATCH xserver] glamor: Use eglGetPlatformDisplay{, EXT} if we can

Adam Jackson writes: > eglGetDisplay forces the implementation to guess which kind of display > it's been handed. glvnd does something different from Mesa, and in > general it's impossible for the library to get this right. Add a new > inline that gets the logic right, and works

Re: [PATCH xserver] test: Use $XSERVER_BUILDDIR for Xvfb executable path

Michel Dänzer writes: > From: Michel Dänzer > > Fixes make check with out-of-tree builds. > > Signed-off-by: Michel Dänzer > --- > test/scripts/xvfb-piglit.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH 1/3] glx: drisw is not accelerated IGLX, reflect that in log messages

On Thu, 2016-09-29 at 18:41 +0100, Emil Velikov wrote: > The messages from glxdricommon.c (used by drisw) still have the A, but > at least we're don't have it locally. > > Cc: Adam Jackson > Signed-off-by: Emil Velikov Series merged (with fixup for

Re: [PATCH 1/4] configure.ac: default to DRI=yes on solaris platforms

On Thu, 2016-09-29 at 18:35 +0100, Emil Velikov wrote: > Afaict there's little-to-no reason/way one would want xserver without > DRI support on Solaris platforms. > > This will allow us to simplify/fix all the libdrm detection in the next > commit. Series merged (with trivial fixup for

Re: [PATCH xserver 1/3] xfree86: Immediately handle failure to set HW cursor, v5

On Fri, 2016-09-30 at 17:55 +0200, Michael Thayer wrote: > > > v5: Updated the patch to apply to current git HEAD, split up into two > patches (server and modesetting driver) and adjusted the code slightly > to match surrounding code.  I also removed the new exported function >

Re: [PATCH xserver] test: Use $XSERVER_BUILDDIR for Xvfb executable path

On Wed, 2016-10-05 at 10:34 -0700, Eric Anholt wrote: > Reviewed-by: Eric Anholt Merged: remote: I: patch #113692 updated using rev 95d3980c7c991b2cc8dcadac173635641ae15865. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver

Re: [PATCH xserver] glamor: Use eglGetPlatformDisplay{, EXT} if we can

On Wed, 2016-10-05 at 10:29 -0700, Eric Anholt wrote: > > Reviewed-by: Eric Anholt Merged: remote: I: patch #113802 updated using rev f4a41155479e68bf55740c1dfffafc78e4c02087. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver    

Re: [PATCH xserver 1/3] xfree86: Immediately handle failure to set HW cursor, v5

Hello Adam, On 05.10.2016 21:33, Adam Jackson wrote: On Fri, 2016-09-30 at 17:55 +0200, Michael Thayer wrote: v5: Updated the patch to apply to current git HEAD, split up into two patches (server and modesetting driver) and adjusted the code slightly to match surrounding code. I also

Re: [PATCH xserver] ephyr: Leave window unmapped for -glamor-skip-present

On Wed, Oct 5, 2016 at 09:42:19 -0700, Keith Packard wrote: > If we're never painting anything in the window, we probably don't need > to map it. > > Signed-off-by: Keith Packard > --- > hw/kdrive/ephyr/hostx.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) >

Re: [PATCH xserver] ephyr: Leave window unmapped for -glamor-skip-present

Julien Cristau writes: > The extern ephyr_glamor_skip_present declaration should probably live in > ephyr_glamor_glx.h so mismatches between it and ephyr_glamor_glx.c are > caught. Agreed; I was following the existing practice (and being a bit lazy). -- -keith