[PATCH xserver 03/15] dri3: annotate fds/strides/offsets arrays as const

From: Emil Velikov It makes it perfectly clear that we should not be modifying them. Should help highlight issues like the one fixed with previous commit. Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers") Cc: Louis-Francis Ratté-Boulianne

[PATCH xserver 06/15] dri3: use designated initializers for {s, }proc_dri3_vector

From: Emil Velikov Cc: Louis-Francis Ratté-Boulianne Cc: Daniel Stone Signed-off-by: Emil Velikov --- Seems like the underscore went missing with v1.2? --- dri3/dri3_request.c | 36

[PATCH xserver 04/15] dri3: simplify dri3_open() implementation

From: Emil Velikov Signed-off-by: Emil Velikov --- dri3/dri3_screen.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/dri3/dri3_screen.c b/dri3/dri3_screen.c index f5e87bc9e..628f7616e 100644

[PATCH xserver 05/15] dri3: annotate {s, }proc_dri3_vector as static const

From: Emil Velikov Read-only data, used only locally. Signed-off-by: Emil Velikov --- dri3/dri3_request.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/dri3/dri3_request.c b/dri3/dri3_request.c index

[PATCH xserver 10/15] dri3: return BadImplementation when missing ::get_{formats, modifiers}

From: Emil Velikov If the implementations is missing the required functionality simply return BadImplementation. Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers") Cc: Louis-Francis Ratté-Boulianne Cc: Daniel Stone

[PATCH xserver 09/15] dri3: check for ::get_drawable_modifiers failure

From: Emil Velikov Currently if the function fails, we'll fall into two false assumptions: - the the count is zero - that the storage pointer is safe for free() I've just fixed the former (in glamore + xwayland) and have no plans on adding yet another workaround

[PATCH xserver 11/15] xwayland: zero num_formats from the start

From: Emil Velikov The caller may ignore the return value (will be addressed with later commit) so simply zero the count from the get-go. We're pretty much do so, in all cases but one :-\ Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers") Cc:

[PATCH xserver 08/15] glamor: zero num_modifiers from the start

From: Emil Velikov The caller may ignore the return value (will be addressed with later commit) so simply zero the count from the get-go. We're pretty much do so, in all cases but one :-\ Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers") Cc:

[PATCH xserver 01/15] dri3: annotate the dri3_screen_info data as const

From: Emil Velikov dri3_screen_info is the user provide dispatch. Something that we do not and should not change. When using the _ptr typecast + const the compiler barfs at us (rightfully so), so use the _rec one. Fixes: 56313829886 ("dri3: Add DRI3 extension") Cc:

[PATCH xserver 02/15] xwayland: don't close() fds we don't own

From: Emil Velikov The glamor_pixmap_from_fds error path erroneously closes the fds. We don't own them, plus the caller closes them after the function in called. Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers") Cc: Louis-Francis Ratté-Boulianne

[PATCH xserver 14/15] dri3: s/intersect/window/ to match the names used in caller

From: Emil Velikov Cc: Louis-Francis Ratté-Boulianne Cc: Daniel Stone Signed-off-by: Emil Velikov --- dri3/dri3_screen.c | 30 +++--- 1 file changed, 15 insertions(+),

[PATCH xserver 15/15] dri3: correctly handle failed get_supported_modifiers requests

From: Emil Velikov Currently depending on the code path hit, the helper will set some of the output values and not others. It could also leak memory ;-) At the same time the caller was: - working around the broken behaviour - by initialising the variables -

[PATCH xserver 13/15] dri3: rework format/modifier caching

From: Emil Velikov Cut down the unnecessary malloc/memcpy/free by utilising the explicit copy provided by the client. But above all: do so, after ensuring we get valid data from the implementation. Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers") Cc:

[PATCH xserver 07/15] xwayland: zero num_modifiers from the start

From: Emil Velikov The caller may ignore the return value (will be addressed with later commit) so simply zero the count from the get-go. We're pretty much do so, in all cases but one :-\ Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers") Cc:

[PATCH xserver 12/15] glamor: zero num_formats from the start

From: Emil Velikov The caller may ignore the return value (will be addressed with later commit) so simply zero the count from the get-go. We're pretty much do so, in all cases but one :-\ Fixes: cef12efc15c ("glamor: Implement GetSupportedModifiers") Cc:

[PATCH xserver 2/2] docs: remove resource management references

From: Emil Velikov The code referenced was removed back in 2009. Signed-off-by: Emil Velikov --- hw/xfree86/doc/ddxDesign.xml | 168 --- 1 file changed, 168 deletions(-) diff --git

Re: [PATCH] modesetting/drmmode: add NULL pointer check in drmmode_output_dpms

On Fri, 2018-03-30 at 22:32 +0200, Tobias Klausmann wrote: > drmmode_output_dpms is called especially with !output->crtc found in > xf86DisableUnusedFunctions so we have to guard for it, else the server > segfaults: Merged, thanks: remote: I: patch #214118 updated using rev

[PATCH xserver 1/2] docs: purge some Isa references

From: Emil Velikov The respective Isa functions were dropped back in 2008 Signed-off-by: Emil Velikov --- hw/xfree86/doc/ddxDesign.xml | 89 +--- 1 file changed, 2 insertions(+), 87 deletions(-)

Re: 2018 Election voting OPEN

On Wed, Mar 21, 2018 at 8:40 PM, Rob Clark wrote: > To all X.Org Foundation Members: > > The X.Org Foundation's annual election is now open and will remain > open until 23:59 UTC on 5 April 2018. Reminder that the elections are open until midnight on Thurs, so if you have

Re: [PATCH] glamor: sanitze handling of "Debug" Option for "dmabuf_capable"

On Fri, 2018-03-30 at 22:31 +0200, Tobias Klausmann wrote: > With the appearance of the this new Option the X Server would crash if the > option is not set. > > Default dmabuf_capable to off/FALSE for now - a user without knowledge about > this option does not want to enable it until its save.

XDC 2018: Call for Papers

Hello, I have the pleasure to announce that the X.org Developer Conference 2018 will be held in A Coruña, Spain from September 26th to September 28th. The venue is located at the Computer Science faculty of the University of Coruña. This year, we have created a new website for the event:

Re: [PATCH xserver 2/2] docs: remove resource management references

On Mon, 2018-04-02 at 18:51 +0100, Emil Velikov wrote: > From: Emil Velikov > > The code referenced was removed back in 2009. > > Signed-off-by: Emil Velikov Fixed 1/2's commit message's capitalization of "ISA" and merged: remote: E:

[PATCH xserver] glx: Fix attribute handling for GLX_TEXTURE_FORMAT_EXT

Initialize it correctly to GLX_TEXTURE_FORMAT_NONE_EXT, and report it in GLXGetDrawableAttributes. Note that it and TEXTURE_TARGET are only meaningful attributes for GLXPixmaps. Signed-off-by: Adam Jackson --- glx/glxcmds.c | 17 + 1 file changed, 13

Re: [PATCH xserver 3/3] meson: Add pixman-1 to required modules in xorg-server.pc

On Thu, 2018-03-29 at 13:07 +0200, Thierry Reding wrote: > From: Thierry Reding > > pixman headers will be included for builds of external modules against > the xorg-server SDK. Make sure pixman is listed as a required module so > that the correct CFLAGS will be added. > >

Re: [PATCH xserver] glx: Fix attribute handling for GLX_TEXTURE_FORMAT_EXT

On Mon, 2018-04-02 at 14:52 -0400, Adam Jackson wrote: > @@ -1737,6 +1740,9 @@ __glXDisp_BindTexImageEXT(__GLXclientState * cl, GLbyte > * pc) >DixReadAccess, , )) > return error; > > +if (pGlxDraw->format == GLX_TEXTURE_FORMAT_NONE_EXT) > +

Re: [PATCH xserver] modesettings: Use actual crtc position for pageflip

On Thu, 2018-03-29 at 09:16 +0100, Daniel Stone wrote: > On 29 March 2018 at 08:42, Olivier Fourdan wrote: > > Otherwise the same content is shown on all outputs. > > Yeah, good point. > > Reviewed-by: Daniel Stone remote: I: patch #213635 updated

Re: [PATCH xserver 01/15] dri3: annotate the dri3_screen_info data as const

On Mon, 2018-04-02 at 16:41 +0100, Emil Velikov wrote: > Why do we have the explicit _rec and _ptr typecasts to begin with? Convention, mostly. The typedef for the struct is because 'struct' is a dumb word to need to say all the time. The typedef for the pointer is vaguely distasteful and I've

[PATCH xserver] meson: Fix module_dir configuration

meson.build has code to set the module_dir variable to ${libdir}/xorg/modules if the module_dir option string is empty. However, this has several problems: 1. The variable is only used for an unused @moduledir@ substitution in the man page. The rule for xorg-server.pc uses option('module_dir')

Re: 2018 Election voting OPEN

To all X.Org Foundation Members: Due to some technical difficulties, the earlier election notification messages to memb...@x.org list did not go through (but also did not trigger bounce/moderator notification). We cross referenced the members list to the subscriber lists for xorg-devel, xorg,

Re: [PATCH xserver 2/2] modesetting: Fix reported size when using atomic modesetting

On Thu, 2018-03-29 at 09:16 +0100, Daniel Stone wrote: > On 29 March 2018 at 08:46, Olivier Fourdan wrote: > > Looks good to me *but* this is not sufficient because > > do_queue_flip_on_crtc() calls drmmode_crtc_set_fb() with (x=0,y=0) for any > > CRTC regardless of its

[PATCH xserver] xfree86: Restore newline before "X Protocol Version" string

The newline before the protocl version got lost in commit 6cbefc3e0a33b380c147c533914437c7798d9b93. Prior to that commit, the release date printed a newline at the end: X.Org X Server 1.19.6 Release Date: 2017-12-20 X Protocol Version 11, Revision 0 Build Operating System: Linux

Re: [PATCH xserver] xfree86: Restore newline before "X Protocol Version" string

On Mon, Apr 02, 2018 at 03:04:08PM -0700, Aaron Plattner wrote: > The newline before the protocl version got lost in commit > 6cbefc3e0a33b380c147c533914437c7798d9b93. Prior to that commit, the > release date printed a newline at the end: > > X.Org X Server 1.19.6 > Release Date: 2017-12-20 >