Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

On Mon, Apr 16, 2018 at 7:04 PM, Mike Lothian wrote: > Hi Mario > > Have you also tried starting a wayland Kwin session to see if Xwayland > works? X apps don't work for me > Nope. Only KUbuntu 16.04.3 LTS + native X-Server 1.20-RC4, with all kinds of permutations of

[PATCH xserver] modesetting: Fix inverted check in dri2 WaitMSC

ms_queue_vblank() returns false on failure. Reported-by: Chris Wilson Signed-off-by: Adam Jackson --- hw/xfree86/drivers/modesetting/dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xfree86/drivers/modesetting/dri2.c

Re: [PATCH xserver] modesetting: Move GBM code inside #ifdef GLAMOR_HAS_GBM

On Mon, 2018-04-16 at 09:54 +0200, Olivier Fourdan wrote: > Reviewed-by: Olivier Fourdan Merged, thanks: remote: I: patch #217201 updated using rev a98a95b798a0062783ae6fd2135ad488af5efcfd. remote: I: 1 patch(es) updated to state Accepted. To

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

Hi Mario Have you also tried starting a wayland Kwin session to see if Xwayland works? X apps don't work for me Cheers Mike On Mon, 16 Apr 2018 at 07:37 Mario Kleiner wrote: > Hi again, > > with the fresh x-server patch i just sent out, the EGL + DRI3 problems >

Re: [PATCH xserver] xwayland: Fix build without glamor

On Mon, 2018-04-16 at 15:01 +0200, Roman Gilg wrote: > Thank you Olivier. Sorry for that. > > An alternative solution would be to only ifdef out the > xwl_glamor_pixmap_get_wl_buffer call in xwl_present_flip and otherwise > return FALSE. But we then would needlessly still build the Present >

Re: [PATCH xserver] xwayland: Fix build without glamor

Thank you Olivier. Sorry for that. An alternative solution would be to only ifdef out the xwl_glamor_pixmap_get_wl_buffer call in xwl_present_flip and otherwise return FALSE. But we then would needlessly still build the Present support when compiling without glamor. Reviewed-by: Roman Gilg

Re: [PATCH xserver] dri3: Fix dri3_buffers_from_pixmap request.

Hi Mario Thanks for finding this, I'll test it tonight Cheers Mike On Mon, 16 Apr 2018 at 07:15 Mario Kleiner wrote: > Sending pixmap depth and bpp was omitted, so the Mesa > X11 + EGL + DRI3 side of things always failed to >

Re: [PATCH xserver] xwayland: Fix build without glamor

Thanks Olivier! Reviewed-by: Matt Turner ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] modesetting: Fix inverted check in dri2 WaitMSC

Adam Jackson writes: > ms_queue_vblank() returns false on failure. > > Reported-by: Chris Wilson > Signed-off-by: Adam Jackson Reviewed-by: Frank Binns > --- > hw/xfree86/drivers/modesetting/dri2.c | 2 +- >

Re: [PATCH xserver] dri3: Fix dri3_buffers_from_pixmap request.

Thanks Mario for spotting that. On Mon, 2018-04-16 at 08:14 +0200, Mario Kleiner wrote: > Sending pixmap depth and bpp was omitted, so the Mesa > X11 + EGL + DRI3 side of things always failed to > dri3_create_image_khr_pixmap_from_buffers(), which led > to failure of X11 + EGL compositing under

Re: [PATCH xserver] modesetting: Fix inverted check in dri2 WaitMSC

I've applied this too as part of my testing, I don't see a dri3 file - does that mean the dri2 one covers both dri2&3? If it doesn't please ignore Tested-by: Mike Lothian On Mon, 16 Apr 2018 at 21:17 Frank Binns wrote: > Adam Jackson

Re: [PATCH xserver] dri3: Fix dri3_buffers_from_pixmap request.

Tested-by: Mike Lothian On Mon, 16 Apr 2018 at 20:33 Louis-Francis Ratté-Boulianne < l...@collabora.com> wrote: > Thanks Mario for spotting that. > > On Mon, 2018-04-16 at 08:14 +0200, Mario Kleiner wrote: > > Sending pixmap depth and bpp was omitted, so the Mesa > > X11 +

[PATCH xserver] dri3: Fix dri3_buffers_from_pixmap request.

Sending pixmap depth and bpp was omitted, so the Mesa X11 + EGL + DRI3 side of things always failed to dri3_create_image_khr_pixmap_from_buffers(), which led to failure of X11 + EGL compositing under DRI3 under, e.g., KDE Plasma 5. Fixes: 6e7c40f62db6 ("dri3: Add multi-planar/modifier buffer

[PATCH xserver] xwayland: Fix build without glamor

Present support in Xwayland relies on glamor, make sure Xwayland can be built without glamor by moving references to Present code inside the conditional GLAMOR_HAS_GBM. Reported-by: Matt Turner Signed-off-by: Olivier Fourdan --- hw/xwayland/Makefile.am

Re: [PATCH xserver] modesetting: Fix page flipping under DRI 3.2.

Hi again, with the fresh x-server patch i just sent out, the EGL + DRI3 problems under KDE are gone, at least as tested on an old Intel Ironlake and GeForce Tesla. I still see some more problems beyond those, which may or may not be related to the new DRI3.1/3.2 stuff. On KDE-5 the KDE panel

[PATCH xserver] modesetting: Move GBM code inside #ifdef GLAMOR_HAS_GBM

Fixes a compilation error without Glamor. Bugzilla: https://bugs.gentoo.org/653288 Signed-off-by: Matt Turner --- Unfortunately, there's more: Xwayland fails to link without Glamor. hw/xfree86/drivers/modesetting/drmmode_display.c | 14 +++--- 1 file changed, 7

Re: [PATCH xserver] modesetting: Move GBM code inside #ifdef GLAMOR_HAS_GBM

Hi, On Mon, Apr 16, 2018 at 8:37 AM, Matt Turner wrote: > Fixes a compilation error without Glamor. > > Bugzilla: https://bugs.gentoo.org/653288 > Signed-off-by: Matt Turner > --- > Unfortunately, there's more: Xwayland fails to link without Glamor. >

Re: [PATCH xserver] modesetting: Move GBM code inside #ifdef GLAMOR_HAS_GBM

On Mon, Apr 16, 2018 at 8:37 AM, Matt Turner wrote: > Fixes a compilation error without Glamor. > > Bugzilla: https://bugs.gentoo.org/653288 > Signed-off-by: Matt Turner > --- > Unfortunately, there's more: Xwayland fails to link without Glamor. > >