[PULL] Misc XQuartz warning and minor cleanup

up to 9003a3e5c55903ce4e371b2d5cb5030b5f97ae0e: XQuartz: Silence -Wformat-security for NSRunAlertPanel (2015-06-09 23:42:03 -0700) Jeremy Huddleston Sequoia (5): XQuartz: GLX: Use __glXEnableExtension to build extensions

Re: [PULL] Misc XQuartz warning and minor cleanup

Ping > On Jun 9, 2015, at 23:43, Jeremy Huddleston Sequoia > wrote: > > The following changes since commit fa12f2c150b2f50de9dac4a2b09265f13af353af: > > glamor: don't do render ops with matching source/dest (v3) (2015-06-02 > 14:16:26 +1000) > > are av

[PULL] XQuartz update for ATS allowance of our Sparkle feed and updated menu bar height logic

4513f924a7065edbd267cf96837af94ce5a58a6f: XQuartz: Fix how we calculate the height of the OSX menu bar (2015-10-13 14:19:05 -0700) Jeremy Huddleston Sequoia (2): XQuartz: Relax App Transport Security for communicating with the update server

annarchy disk space

I noticed some errors in my git post commit hooks just now. It looks like annarchy is out of space on / $ git push -f... remote: mail: /tmp/mail.Rs7Ah02H: No space left on device jeremyhu@annarchy:~$ df -h / Filesystem Size Used Avail Use% Moun

Re: [PULL] XQuartz update for ATS allowance of our Sparkle feed and updated menu bar height logic

> On Oct 14, 2015, at 06:32, Adam Jackson wrote: > > On Wed, 2015-10-14 at 00:40 -0700, Jeremy Huddleston Sequoia wrote: > >> XQuartz: Relax App Transport Security for communicating with the update >> server > > I'm not sure I'm a fan of this cha

[PATCH xquartz 03/10] xdmauth: Correct miscall of abs() to instrad call labs()

ut has parameter of type 'int' which may cause truncation of value [-Wabsolute-value,Semantic Issue] if (abs(client->time - now) > TwentyMinutes) { ^ xdmauth.c:302:9: note: use function 'labs' instead [Semantic Issue] if (abs(client->time - now) >

[PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

0:24: note: expanded from macro 'IntToxFixed' ^~ /opt/X11/include/pixman-1/pixman.h:130:56: note: expanded from macro 'pixman_int_to_fixed' ~~~ ^ Signed-off-by: Jeremy Huddleston Seq

[PATCH xquartz 05/10] xres: Silence -Wunused-function warnings when building !COMPOSITE or !RENDER

xres.c:422:1: warning: unused function 'ResFindCompositeClientWindowPixmaps' [-Wunused-function,Unused Entity Issue] ResFindCompositeClientWindowPixmaps (void *value, XID id, void *cdata) ^ Signed-off-by: Jeremy Huddleston Sequoia --- Xext/xres.c | 8 1 file changed, 4

[PATCH xquartz 02/10] randr: Correct a miscall of abs() to instead call fabs()

bs' instead [Semantic Issue] if ((v = abs(f_transform->m[j][i])) > max) ^~~ fabs Signed-off-by: Jeremy Huddleston Sequoia --- randr/rrtransform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/randr/rrtransfo

[PATCH xquartz 09/10] xdmcp: Declare XdmcpFatal _X_NORETURN

xdmcp.c:1404:1: warning: function 'XdmcpFatal' could be declared with attribute 'noreturn' [-Wmissing-noreturn,Semantic Issue] Signed-off-by: Jeremy Huddleston Sequoia --- os/xdmcp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/os/xdmcp.c b/os/xdmcp.c index 7939b41..

[PATCH xquartz 07/10] dix: Silence -Wunused-variable warning by moving window.c off of legacy region defines

window.c:223:15: warning: unused variable 'pScreen' [-Wunused-variable,Unused Entity Issue] ScreenPtr pScreen = pWin->drawable.pScreen; ^ Signed-off-by: Jeremy Huddleston Sequoia --- dix/window.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) dif

[PATCH xquartz 08/10] osinit: Silence -Wunused-variable warnings

Issue] char fname[PATH_MAX]; ^ Signed-off-by: Jeremy Huddleston Sequoia --- os/osinit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/os/osinit.c b/os/osinit.c index ddd3fce..41a0aa7 100644 --- a/os/osinit.c +++ b/os/osinit.c @@ -158,8 +158,6 @@ void OsInit(void) {

[PATCH xquartz 01/10] mi: Correct a miscall of abs() to instead call fabs()

abs(parc->angle2) >= 360.0) ^~~ fabs Signed-off-by: Jeremy Huddleston Sequoia --- mi/miarc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mi/miarc.c b/mi/miarc.c index 5e854b3..2588ee4 100644 --- a/mi/miarc.c +++ b/mi/miarc.c @@ -1711,7 +1711

[PATCH xquartz 06/10] security: Silence some benign -Wformat warnings

~~~ security.c:893:31: warning: format specifies type 'unsigned int' but the argument has type 'XID' (aka 'unsigned long') [-Wformat,Format String Issue] rec->pWin->drawable.id, ^~

[PATCH xquartz 10/10] glx: Fix header length error checking in __glXDisp_RenderLarge

glxcmds.c:2206:46: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare,Semantic Issue] if ((cmdlen = safe_pad(hdr->length)) < 0) ^ ~ Signed-off-by: Jeremy Huddleston Sequoia --- glx/glxcmds.c | 2 +

Re: [PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

> On Oct 14, 2015, at 15:33, Alan Coopersmith > wrote: > > On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: >> rrtransform.c:199:23: warning: shifting a negative signed value is undefined >> [-Wshift-negative-value,Semantic Issue] >&

Re: [PATCH xquartz 08/10] osinit: Silence -Wunused-variable warnings

will that make some other platforms with ancient compilers sad? > (OpenBSD with old gcc? Visual Studio on Windows?) > > -alan- > > On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: >> osinit.c:161:24: warning: unused variable 'devnull' >> [-Wunused-v

Re: [PATCH xquartz 03/10] xdmauth: Correct miscall of abs() to instrad call labs()

t; man 3 difftime > > i pretty sure it will cause a fundamental change ... > > > just my 2 cents > re, > wh > > Am 15.10.2015 00:13, schrieb Jeremy Huddleston Sequoia: >> xdmauth.c:230:13: warning: absolute value function 'abs' given an argu

Re: X server commit process

What is the current process for pulling into release branches? Are the breakdowns the same, or is someone specific going to manage release branches? > On Oct 16, 2015, at 09:21, Keith Packard wrote: > > > We had a discussion at XDC which resulted in some minor changes in how > patches are get

Re: [PATCH xserver] xorg-wrapper: when starting the server as root, reset its environment

I would suggest maybe instead doing: int main(int argc, char *argv[], char *envp[]) { ... if (getuid() != geteuid()) envp = {NULL, }; (void)execve(argv[0], argv, envp); ... } Or at least name the variable something like empty_envp to distinguish it more clearly from the p

[PATCH v2 1/4] randr: Silence -Wshift-negative-value warnings

0:24: note: expanded from macro 'IntToxFixed' ^~ /opt/X11/include/pixman-1/pixman.h:130:56: note: expanded from macro 'pixman_int_to_fixed' ~~~ ^ Signed-off-by: Jeremy Huddleston Seq

[PATCH v2 3/4] dix: Silence -Wunused-variable warning by moving window.c off of legacy region defines

window.c:223:15: warning: unused variable 'pScreen' [-Wunused-variable,Unused Entity Issue] ScreenPtr pScreen = pWin->drawable.pScreen; ^ Signed-off-by: Jeremy Huddleston Sequoia --- dix/window.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) dif

[PATCH v2 2/4] glx: Fix header length error checking in __glXDisp_RenderLarge

glxcmds.c:2206:46: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare,Semantic Issue] if ((cmdlen = safe_pad(hdr->length)) < 0) ^ ~ Signed-off-by: Jeremy Huddleston Sequoia --- glx/glxcmds.c | 2 +

[PATCH v2 4/4] osinit: Silence -Wunused-variable warnings

Issue] char fname[PATH_MAX]; ^ Signed-off-by: Jeremy Huddleston Sequoia --- os/osinit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/os/osinit.c b/os/osinit.c index ddd3fce..6ec2f11 100644 --- a/os/osinit.c +++ b/os/osinit.c @@ -158,8 +158,10 @@ void OsInit(void) { static Bool been_

Re: [PATCH v2 4/4] osinit: Silence -Wunused-variable warnings

Actually, only this last one is "v2". The others I just still need a Reviewed-by: for, but they're unchanged from earlier. Sorry for any confusion. > On Oct 18, 2015, at 23:12, Jeremy Huddleston Sequoia > wrote: > > osinit.c:161:24: warning: unused variable &

Re: [PATCH xquartz 04/10] randr: Silence -Wshift-negative-value warnings

> On Oct 19, 2015, at 08:31, Adam Jackson wrote: > > On Wed, 2015-10-14 at 15:44 -0700, Jeremy Huddleston Sequoia wrote: >>> On Oct 14, 2015, at 15:33, Alan Coopersmith wrote: >>> >>> On 10/14/15 03:13 PM, Jeremy Huddleston Sequoia wrote: >>&g

[PULL] XQuartz -- Fix launching with ASan

ed by automation a few years ago (2015-10-19 09:06:22 -0700) Jeremy Huddleston Sequoia (2): XQuartz: Make sure that darwin_all_modifier_mask_additions is 0-terminated XQuartz: Cleanup formatting of DarwinEQInit tha

Re: X server commit process

> On Oct 19, 2015, at 08:56, Julien Cristau wrote: > > On Mon, Oct 19, 2015 at 11:47:09 -0400, Adam Jackson wrote: > >> I don't think there's anyone currently working on 1.16 or older. >> > I'm still interested in 1.16 as that's what Debian 8 ships, but at this > point I guess it's going to be

[PATCH 1/1] xfree86: Use the correct __i386__ inline asm fallbacks in compiler.h

compiler.h:975:26: error: unknown use of instruction mnemonic without a size suffix [Inline Assembly Issue] :1:2: note: instantiated into assembly here out (%dx) ^ 2 errors generated. Signed-off-by: Jeremy Huddleston Sequoia CC: Adam Jackson --- hw/xfree86/common/compiler.h | 4 ++-- 1 fi

Re: [PATCH 1/1] xfree86: Use the correct __i386__ inline asm fallbacks in compiler.h

eremy > On Oct 20, 2015, at 10:52, Jeremy Huddleston Sequoia > wrote: > > ../../../../hw/xfree86/common/compiler.h:975:26: error: invalid operand in > inline asm: 'out${0:B} ($1)' [Inline Assembly Issue] >__asm__ __volatile__("out%B0 (%1)"::"a&quo

Re: [PATCH] xfree86: Use same inb/outb asm code for i386 amd64 and ia64

Reviewed-by: Jeremy Huddleston Sequoia > On Oct 21, 2015, at 09:24, Adam Jackson wrote: > > This matches the GCCUSESGAS path from the old monolith build (where that > macro was actually set), and fixes the build on modern OSX. > > Signed-off-by: Adam Jackson > --

Re: [PATCH:macros] XORG_MANPAGE_SECTIONS: limit SVR4 man page sections to Solaris 2.0-11

006, Oracle and/or its affiliates. All rights > reserved. > +dnl Copyright (c) 2005, 2015, Oracle and/or its affiliates. All rights > reserved. "-" rather than "," Other than that, Reviewed-by: Jeremy Huddleston Sequoia > dnl > dnl Permission is hereby g

Re: [PATCH:xserver 1/3] Xorg.man: move XLOCAL details to X(7) man page instead

Series: Reviewed-by: Jeremy Huddleston Sequoia > On Oct 27, 2015, at 19:44, Alan Coopersmith > wrote: > > These settings affect clients, not server, so belong there, next to > the information about how to set $DISPLAY. > > Signed-off-by: Alan Coopersmith > --- &

Re: [PATCH:xorg-docs 3/4] X.man: document protocol/ syntax in display string

Should we also mention the extension that was added for launchd support where we DISPLAY=[.] > On Oct 27, 2015, at 19:45, Alan Coopersmith > wrote: > > See > http://www.x.org/releases/X11R7.7/doc/libX11/libX11/libX11.html#Opening_the_Display > > Signed-off-by: Alan Coopersmith > --- > man/X

Re: Disabling RECORD by default

The XQuartz option was meant mainly for RECORD. I'll followup later to add a preference option for RECORD in XQuartz. Reviewed-by: Jeremy Huddleston Sequoia --Jeremy > On Nov 23, 2015, at 18:13, Keith Packard wrote: > > Keith Packard writes: > > Here's a patc

CC_CHECK_FLAGS_APPEND (was Re: libXfont: Changes to 'master')

./configure: line 19194: syntax error near unexpected token `with_cflags,' ./configure: line 19194: ` CC_CHECK_FLAGS_APPEND(with_cflags, CFLAGS, \' From what I can tell, CC_CHECK_FLAGS_APPEND comes from glib. Can we please not add a dependency on glib for this? --Jeremy > commit eb67d10ae

[PATCH libXaw3d 1/2] darwin: Remove incorrect export of vendorShellClassRec and vendorShellWidgetClass

Signed-off-by: Jeremy Huddleston Sequoia --- src/Vendor.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/Vendor.c b/src/Vendor.c index 8899cd1..6b34b31 100644 --- a/src/Vendor.c +++ b/src/Vendor.c @@ -110,12 +110,21 @@ static void

Re: [PATCH xserver 5/8] xquartz/glx: Error out for MakeContextCurrent(draw != read)

With the change to !=: Reviewed-by: Jeremy Huddleston Sequoia > On Mar 21, 2016, at 13:29, Adam Jackson wrote: > > CGL doesn't have a way to express this directly, unlike EGL WGL and GLX. > It might be implementable, but it's never actually worked, and it's a >

Re: [PATCH xserver 3/8] {xwin, xquartz}/glx: Always enable GLX_{ARB, SGIS}_multisample

The xquartz -s look good given the change to core. Reviewed-by: Jeremy Huddleston Sequoia > On Mar 21, 2016, at 13:29, Adam Jackson wrote: > > This is enabled unconditionally in the GLX core. For xwin, if the > backend doesn't support WGL_ARB_multisample, there will simply

Re: [PATCH rendercheck 3/5] Use ELF sections to make test setup easier.

The use of __attribute(section()), __start_test_section, and __stop_test_section is not portable. Could you please follow this up with a change that allows rendercheck to continue to function on non-ELF platforms as well? Preferably by just having alternate implementations of the DECLARE_RENDE

Clang Static Analysis

Hey folks, I just wanted to let you all know that I made some updates to my OS X tinderbox (yuffie). It's has been updated to use clang 3.8. You can find the static analysis results at https://people.freedesktop.org/~jeremyhu/analyzer/yuffie --Jeremy smime.p7s Description: S/MIME cryptogra

[PULL] XQuartz configure options

059d5ef30490233f410ca87084c7697b87e5b05e: XQuartz: Update copyright years (2016-05-04 00:08:34 -0700) Jeremy Huddleston Sequoia (6): XQuartz: Remove --with-launchd-id-prefix XQuartz: Fix the help text for --with-bundle-id-prefix XQuartz

Re: [PATCH xserver] Use separate name for --with-bundle-version help variable

05-07 00:43:36 -0700) -------- Jeremy Huddleston Sequoia (1): XQuartz: Fix default CFBundleVersion configure.ac | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) > On May 12, 2016, at 10:35, Keith Packard wrote: > > The help string fo

[PULL] XQuartz configure.ac fix for default CFBundleVersion

e6ac87cd05b459598e69eebee92bfd2f28292dae: XQuartz: Fix default CFBundleVersion (2016-05-18 09:56:33 -0700) Jeremy Huddleston Sequoia (1): XQuartz: Fix default CFBundleVersion configure.ac | 5 ++--- 1 file changed, 2

[PULL 1.18] XQuartz configure cherry-picks

: Fix default CFBundleVersion (2016-05-18 14:13:04 -0700) Jeremy Huddleston Sequoia (7): XQuartz: Remove --with-launchd-id-prefix XQuartz: Fix the help text for --with-bundle-id-prefix XQuartz: Update release feed URL

[PATCH libXfont 1/1] fserve: Fix a buffer read overrun in _fs_client_access

hich takes care of the padding for us. Signed-off-by: Jeremy Huddleston Sequoia --- src/fc/fserve.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/fc/fserve.c b/src/fc/fserve.c index fb1941d..708fc35 100644 --- a/src/fc/fserve.c +++ b/src/fc/fserve.c @@ -2856,14 +2856,1

[PATCH libXfont 1/4] FreeType: Correct an allocation size

ich is everywhere. Signed-off-by: Jeremy Huddleston Sequoia --- src/FreeType/ftfuncs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FreeType/ftfuncs.c b/src/FreeType/ftfuncs.c index bbd4db4..e7c8026 100644 --- a/src/FreeType/ftfuncs.c +++ b/src/Fr

[PATCH libXfont 2/4] bitmap: Bail out on invalid input to FontFileMakeDir instead of calling calloc for 0 bytes

Found by clang static analysis: Call to 'calloc' has an allocation size of 0 bytes Signed-off-by: Jeremy Huddleston Sequoia --- src/bitmap/bitscale.c | 4 1 file changed, 4 insertions(+) diff --git a/src/bitmap/bitscale.c b/src/bitmap/bitscale.c index 22747a9..00adcc6 100644

[PATCH libXfont 3/4] fserve: Silence a -Wformat warning

src/fc/fserve.c:653:32: warning: format specifies type 'int' but the argument has type 'CARD32' (aka 'unsigned long') [-Wformat] " from font server\n", rep->length); ^~~ 1 warning generated

[PATCH libXfont 4/4] fstrans: Remove unused foo() function

(void) is_numeric("a"); } ^ 1 warning generated. Signed-off-by: Jeremy Huddleston Sequoia CC: Keith Packard --- src/fc/fstrans.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/fc/fstrans.c b/src/fc/fstrans.c index 66bc978..902ef36 100644 --- a/src/fc/fstrans.c +

[PULL] XQuartz {Add, Remove}EnabledDevice build fixes and other cleanup

nges up to dd85834e3995671da908e825eaa7a228d11f0b3d: xquartz: Update for removal of AddEnabledDevice and RemoveEnabledDevice (2016-09-10 23:37:46 -0700) -------- Jeremy Huddleston Sequoia (4): XQuartz: Fix the issue where the h key cou

Re: [PATCH:xserver] Use pthread_setname_np to set thread names if available

Reviewed-by: Jeremy Huddleston Sequoia Tested-by: Jeremy Huddleston Sequoia (on current macOS) > On Sep 10, 2016, at 21:14, Alan Coopersmith > wrote: > > Autoconf logic borrowed from glib > > Signed-off-by: Alan Coopersmith > --- > conf

[PATCH 1/1] randr: Initialize RandR even if there are currently no screens attached

#11 0x7fffc5f16aaa in _pthread_body (libsystem_pthread.dylib+0x3aaa) #12 0x7fffc5f169f6 in _pthread_start (libsystem_pthread.dylib+0x39f6) #13 0x7fffc5f161fc in thread_start (libsystem_pthread.dylib+0x31fc) Signed-off-by: Jeremy Huddleston Sequoia --- randr/randr.c | 3 --- 1 file changed

[PATCH 1/1] dix/dispatch: Fix SmartScheduleClient interval adjustment to use best rather than pClient

: 8f1edf4bd3a1f050ce9eeb5eac45dd1a8f7a6d5e Signed-off-by: Jeremy Huddleston Sequoia --- dix/dispatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dix/dispatch.c b/dix/dispatch.c index 3b9600e..f1a074d 100644 --- a/dix/dispatch.c +++ b/dix/dispatch.c @@ -360,7 +360,7 @@ SmartScheduleClient

[PATCH 1/1] glx: Initialize glx even if there are currently no screens attached

(libsystem_pthread.dylib+0x3aaa) #14 0x7fffc5f169f6 in _pthread_start (libsystem_pthread.dylib+0x39f6) #15 0x7fffc5f161fc in thread_start (libsystem_pthread.dylib+0x31fc) Signed-off-by: Jeremy Huddleston Sequoia --- glx/glxext.c | 21 - 1 file changed, 21 deletions(-) diff --git

XLoadQueryFont() not returning with recent xserver master

Using current master plus the various patches I submitted to the list last night, I'm able to launch the server fairly reliably under ASan again, but some clients are getting wedged. Most notably, xterm gets stuck waiting for a reply from XLoadQueryFont(). Looking at the state of the server th

Re: XLoadQueryFont() not returning with recent xserver master

() as part of CloseDownConnection(). See https://bugs.freedesktop.org/show_bug.cgi?id=97770 for more details on that. > On Sep 11, 2016, at 12:24, Jeremy Huddleston Sequoia > wrote: > > Using current master plus the various patches I submitted to the list last > night, I'm

[PATCH 2/3] Xext/shm: Better support cases where O_CLOEXEC is not defined

Signed-off-by: Jeremy Huddleston Sequoia --- Xext/shm.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Xext/shm.c b/Xext/shm.c index 125000f..7a45dbd 100644 --- a/Xext/shm.c +++ b/Xext/shm.c @@ -1202,7 +1202,11 @@ shm_tmpfile(void) int flags; char

[PATCH 1/3] Xext/shm: Fix usage of F_GETFD to match standard

flags = fcntl(fd, F_GETFD) is compliant. fcntl(fd, F_GETFD, &flags) is non-compliant (Linux extension?) cf: http://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html Signed-off-by: Jeremy Huddleston Sequoia --- Xext/shm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH 3/3] os/inputthread: Fix setting of cloexec on file descriptors

http://pubs.opengroup.org/onlinepubs/9699919799/functions/fcntl.html Regressed-in: 30ac7567980a1eb79d084a63e0e74e1d9a3af673 Signed-off-by: Jeremy Huddleston Sequoia --- os/inputthread.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/os/inputthread.c b/os/inputthread.c

Re: [PATCH 2/3] Xext/shm: Better support cases where O_CLOEXEC is not defined

> On Sep 12, 2016, at 04:33, Julien Cristau wrote: > > On Sun, Sep 11, 2016 at 20:01:50 -0700, Jeremy Huddleston Sequoia wrote: > >> Signed-off-by: Jeremy Huddleston Sequoia >> --- >> Xext/shm.c | 6 +- >> 1 file changed, 5 insertions(+), 1 deletion(-

Re: [PULL] XQuartz {Add,Remove}EnabledDevice build fixes and other cleanup

> On Sep 13, 2016, at 07:48, Adam Jackson wrote: > > On Sun, 2016-09-11 at 00:03 -0700, Jeremy Huddleston Sequoia wrote: > >> os/connection: Improve abstraction for launchd secure sockets > > Mmm, not a huge fan of this one. You're not requiring that $DISP

[PATCH 1/1] os/connection: Improve abstraction for launchd secure sockets

This changes away from hard-coding the /tmp/launch-* path to now supporting a generic [.] format for $DISPLAY. cf-libxcb: d978a4f69b30b630f28d07f1003cf290284d24d8 Signed-off-by: Jeremy Huddleston Sequoia CC: Adam Jackson --- os/connection.c | 31 ++- 1 file changed

Re: [PATCH 1/1] glx: Initialize glx even if there are currently no screens attached

Ping. > On Sep 11, 2016, at 03:44, Jeremy Huddleston Sequoia > wrote: > > Failure to do so causes an overvlow in glxClientCallback > > Application Specific Information: > X.Org X Server 1.18.99.1

Re: [PATCH 1/1] randr: Initialize RandR even if there are currently no screens attached

Ping. > On Sep 11, 2016, at 02:23, Jeremy Huddleston Sequoia > wrote: > > Failure to do so causes an overvlow in RRClientCallback(). > > = > ==41262==ERROR: AddressSanitizer: global-buffer-overflow on address

Re: [ANNOUNCE] xorg-server 1.18.99.2

> On Sep 16, 2016, at 13:57, Keith Packard wrote: > > > I think we're ready for RC1 at this point, but wanted to give people a > chance to scream about "just one more API change" until tomorrow. Let me > know if there's something I'm missing; if I don't hear anything, I'll be > tagging RC1 in t

Re: XLoadQueryFont() not returning with recent xserver master

nyone else has a hunch as to what might be going on to narrow my search, I'd appreciate it. If not, I'll probably start by taking a closer look at this particular change to understand what's going wrong. Thanks, Jeremy > On Sep 11, 2016, at 16:54, Jeremy Huddleston Sequoia &

[PATCH 2/2] os/connection: Remove NewOutputPending

Use any_output_pending() instead. Signed-off-by: Jeremy Huddleston Sequoia CC: Keith Packard --- os/WaitFor.c| 2 +- os/connection.c | 2 -- os/io.c | 5 + os/osdep.h | 2 -- 4 files changed, 2 insertions(+), 9 deletions(-) diff --git a/os/WaitFor.c b/os/WaitFor.c index

[PATCH 1/2] os/connection: Call ClientReady() based on a level trigger rather than an edge trigger

early-exits if NewOutputPending is not set. The only place that is setting NewOutputPending is ClientReady(). The problem there is that ClientReady() is called based on an edge trigger and not a level trigger. Signed-off-by: Jeremy Huddleston Sequoia CC: Keith Packard --- os/connection.c | 2

Re: XLoadQueryFont() not returning with recent xserver master

just check any_output_pending()? The following two patches for consideration address these points. Thanks, Jeremy > On Sep 16, 2016, at 23:16, Jeremy Huddleston Sequoia > wrote: > > I bisected the issue to: > > f993091e7db81b0420e23c485378cba112278839 is t

CARD32 vs uint32_t

libXfont2's _xfont2_client_funcs struct has a get_time_in_millis entry that is declared as 'uint32_t (*get_time_in_millis)(void);' xserver tries to use GetTimeInMillis for this, but it is declared as 'CARD32 GetTimeInMillis(void)'. The issue is that CARD32 is actually 'unsigned long' on i386,

Re: [PATCH 2/2] os/connection: Remove NewOutputPending

> On Sep 18, 2016, at 08:51, Keith Packard wrote: > > Jeremy Huddleston Sequoia writes: > >> Use any_output_pending() instead. > > These aren't equivalent -- NewOutputPending is set when there is output > pending and we haven't detected that all of the cl

Re: [PATCH 1/2] os/connection: Call ClientReady() based on a level trigger rather than an edge trigger

> On Sep 18, 2016, at 09:58, Keith Packard wrote: > > Matthieu Herrb writes: > >> this doesn't fix an issue I'm seeing on OpenBSD with xterm not beeing >> able to start (it makes the X server spin at 100% CPU in >> WaitForSomething()), while Jeremy's patches do fix the issue for me. > > I thi

os/log.c thread safety

I noticed a data race in XQuartz. We call ErrorF in a couple places off of the main server thread. I could fix it by simply moving this logging onto the server thread (or not doing it with os/log), but with the split of InputThread off of MainThread, I'm wondering if it would be better to inst

[PATCH 1/1] dix: Make InitCoreDevices() failures more verbose.

Signed-off-by: Jeremy Huddleston Sequoia --- dix/devices.c | 37 ++--- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/dix/devices.c b/dix/devices.c index 56aae85..ea3c6c8 100644 --- a/dix/devices.c +++ b/dix/devices.c @@ -709,17 +709,32

[PATCH 1/1] dix: Hold the input_lock() when accessing the miEventQueue through checkForInput

c:263 in mieqEnqueue ====== Signed-off-by: Jeremy Huddleston Sequoia --- dix/dispatch.c | 21 ++--- os/WaitFor.c | 7 ++- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/dix/dispatch.c b/dix/dispatch.c index 26a461b..dbf7f97 100644 --- a/dix/dispatch.c +++ b/dix/

Re: os/log.c thread safety

> On Sep 18, 2016, at 21:58, Keith Packard wrote: > > Jeremy Huddleston Sequoia writes: > >> [ Unknown signature status ] >> I noticed a data race in XQuartz. We call ErrorF in a couple places off of >> the main server thread. I could fix it by simply mo

Re: [PATCH 1/1] dix: Hold the input_lock() when accessing the miEventQueue through checkForInput

> On Sep 19, 2016, at 08:30, Keith Packard wrote: > > Jeremy Huddleston Sequoia writes: > >> == >> WARNING: ThreadSanitizer: data race (pid=4943) >> Read of size 4 at 0x00010c4e3854 by thread T8: >>#0 WaitForSomething WaitFor.c:2

Re: [PATCH 1/1] dix: Hold the input_lock() when accessing the miEventQueue through checkForInput

> On Sep 19, 2016, at 09:52, Keith Packard wrote: > > Jeremy Huddleston Sequoia writes: > >> Yeah, I made the change mainly to shutup the analyzer while I was >> looking for other races. I decided to propose it in case we want to >> be strict here. > > Th

[PATCH xproto 4/4] Xfuncproto: Add support for _X_NOTSAN macro

Signed-off-by: Jeremy Huddleston Sequoia --- Xfuncproto.h.in | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index 8a9530a..8715c9d 100644 --- a/Xfuncproto.h.in +++ b/Xfuncproto.h.in @@ -210,4 +210,11 @@ in this Software without prior written

[PATCH xproto 2/4] Xfuncproto.h: Define __has_extension() if it isn't already

Signed-off-by: Jeremy Huddleston Sequoia --- Xfuncproto.h.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index 8556c27..7f06e99 100644 --- a/Xfuncproto.h.in +++ b/Xfuncproto.h.in @@ -82,6 +82,9 @@ in this Software without prior written authorization

[PATCH xproto 3/4] Xfuncproto: Add support for _X_DEPRECATED_MSG() macro

Signed-off-by: Jeremy Huddleston Sequoia --- Xfuncproto.h.in | 8 1 file changed, 8 insertions(+) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index 7f06e99..8a9530a 100644 --- a/Xfuncproto.h.in +++ b/Xfuncproto.h.in @@ -137,6 +137,14 @@ in this Software without prior written

[PATCH xproto 1/4] Xfuncproto.h: Define __has_feature() if it isn't already

Signed-off-by: Jeremy Huddleston Sequoia --- Xfuncproto.h.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index 5daa83e..8556c27 100644 --- a/Xfuncproto.h.in +++ b/Xfuncproto.h.in @@ -79,6 +79,9 @@ in this Software without prior written authorization

[PATCH 1/1] dix: Silence TSan warnings when checking for pending input

hreadSanitizer: data race mieq.c:263 in mieqEnqueue ====== Signed-off-by: Jeremy Huddleston Sequoia --- configure.ac | 2 +- dix/dispatch.c | 13 + os/WaitFor.c | 8 +++- 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac in

Re: [PATCH 1/1] dix: Silence TSan warnings when checking for pending input

> On Sep 22, 2016, at 00:22, Keith Packard wrote: > > Jeremy Huddleston Sequoia writes: > >> +static inline _X_NOTSAN Bool >> +InputCheckPending(void) >> +{ >> +return (*checkForInput[0] != *checkForInput[1]); >> +} > >> +stat

Re: [PATCH xserver 0/2] os: Fix write block handling in poll(2) path

Series is: Reviewed-by: Jeremy Huddleston Sequoia Tested-by: Jeremy Huddleston Sequoia I'd still like to get rid of the large NewOutputPending hammer, but this is good for now. Thanks, Jeremy > On Sep 21, 2016, at 16:53, Keith Packard wrote: > > My previous attempt to fix

[PATCH 1/1] dix: Silence TSan warnings when checking for pending input

t :29 (libdyld.dylib+0x5254) SUMMARY: ThreadSanitizer: data race mieq.c:263 in mieqEnqueue ====== Signed-off-by: Jeremy Huddleston Sequoia CC: Keith Packard --- configure.ac | 2 +- dix/dispatch.c | 7 +++ include/dix.h | 6 ++ os/WaitFor.c | 2 +- 4 files changed,

Re: [PATCH 1/1] dix: Silence TSan warnings when checking for pending input

> On Sep 22, 2016, at 11:26, Keith Packard wrote: > > Jeremy Huddleston Sequoia writes: > >> I would've but we're post API freeze at this point, yes? Would that be ok? > > Yeah, better than duplicating, and it doesn't affect the actual ABI/API > see

[PULL] XQuartz cleanup related to inputthread changes

5:03 -0700) -------- Jeremy Huddleston Sequoia (6): dix: Silence TSan warnings when checking for pending input XQuartz: Don't respond to SIGALRM on the AppKit thread XQuartz: Remove X11ApplicationFatalError XQuartz: pbproxy shouldn't need to wait for server initialization.

[PATCH 1/3] os/connection: Improve abstraction for launchd secure sockets

This changes away from hard-coding the /tmp/launch-* path to now supporting a generic [.] format for $DISPLAY. cf-libxcb: d978a4f69b30b630f28d07f1003cf290284d24d8 Signed-off-by: Jeremy Huddleston Sequoia CC: Adam Jackson --- os/connection.c | 31 ++- 1 file changed

[PATCH 2/3] randr: Initialize RandR even if there are currently no screens attached

#11 0x7fffc5f16aaa in _pthread_body (libsystem_pthread.dylib+0x3aaa) #12 0x7fffc5f169f6 in _pthread_start (libsystem_pthread.dylib+0x39f6) #13 0x7fffc5f161fc in thread_start (libsystem_pthread.dylib+0x31fc) Signed-off-by: Jeremy Huddleston Sequoia --- randr/randr.c | 3 --- 1 file changed

[PATCH 3/3] glx: Initialize glx even if there are currently no screens attached

(libsystem_pthread.dylib+0x3aaa) #14 0x7fffc5f169f6 in _pthread_start (libsystem_pthread.dylib+0x39f6) #15 0x7fffc5f161fc in thread_start (libsystem_pthread.dylib+0x31fc) Signed-off-by: Jeremy Huddleston Sequoia --- glx/glxext.c | 21 - 1 file changed, 21 deletions(-) diff --git

Re: [PATCH 2/3] randr: Initialize RandR even if there are currently no screens attached

> On Oct 10, 2016, at 03:33, Emil Velikov wrote: > > Hi Jeremy, > > On 9 October 2016 at 20:51, Jeremy Huddleston Sequoia > wrote: >> Failure to do so causes an overvlow in RRClientCallback(). >> > s/overvlow/overflow/ Doh, corrected the typo, thanks. &g

Re: [PATCH 3/3] glx: Initialize glx even if there are currently no screens attached

> On Oct 10, 2016, at 10:16, Adam Jackson wrote: > > On Sun, 2016-10-09 at 12:51 -0700, Jeremy Huddleston Sequoia wrote: >> Failure to do so causes an overvlow in glxClientCallback > > This patch makes no sense at all. glxClientCallback is only added to > the call chai

Re: [PATCH xserver] inputthread: leave the main thread's name as-is

Shouldn't glibc be fixed instead? Why punish the platforms that do it right? --Jeremy > On Oct 17, 2016, at 21:13, Peter Hutterer wrote: > > On Linux, setting the main thread's name changes the program name > (/proc/self/comm). Setting it to MainThread breaks scripts that rely on > the command

Re: [ANNOUNCE] xorg-server 1.19.2

> On Mar 3, 2017, at 08:50, Adam Jackson wrote: > > On Thu, 2017-03-02 at 18:13 -0500, Adam Jackson wrote: >> A collection of stability fixes here across glamor, Xwayland, input, >> and Prime support. Also a security fix for CVE-2017-2624, a timing >> attack which can brute-force MIT-MAGIC-COOKI

Re: [PATCH v2 xserver 5/7] hw/xquartz: fix path to pseudoramiX headers

Thanks. Reviewed-by: Jeremy Sequoia > On Apr 4, 2017, at 4:49 PM, Mihail Konev wrote: > > Fixes out-of-source XQuartz build. > > Fixes: 39c548da ("XQuartz: Fix build with moved pseudoramiX") > Signed-off-by: Mihail Konev > --- > v2: Reword. Add missing Cc. > > hw/xquartz/Makefile.am | 2

Re: [PATCH v2 xserver 4/7] configure.ac: factor out xquartz bundle destdir

I'm not familiar with the problem. Is this the canonical way to actually do this? It seems a bit odd, but it looks fine to me if just a bit quirky: Reviewed-by: Jeremy Sequoia > On Apr 4, 2017, at 4:49 PM, Mihail Konev wrote: > > Fixes DESTDIR not being included in x11appdir, allowing to ru

[PULL] XQuartz build fixes for ext changes fallout

The following changes since commit deb08658e2a6b1647a7213a316c6f3019bcdce48: xfree86: Strip dangling pointers from desiredMode (2012-07-11 15:55:22 -0700) are available in the git repository at: git://people.freedesktop.org/~jeremyhu/xserver master for you to fetch changes up to 1720cd9badf

Re: [PATCH] hw/xquartz: Various fixes for pseudoramiX.c

Seems right to me: Reviewed-by: Jeremy Huddleston Sequoia Thanks, Jeremy On Jul 23, 2012, at 04:16, Jon TURNEY wrote: > Various fixes, applied to panoramiX.c in commit 2b266eda, also need applying > to pseudoramiX.c: > Fix panoramiX request and reply swapping > Set window and s

  1   2   3   >