Re: [PATCH xserver 01/15] dri3: annotate the dri3_screen_info data as const

2018-04-10 Thread Adam Jackson
On Mon, 2018-04-02 at 16:41 +0100, Emil Velikov wrote: > From: Emil Velikov > > dri3_screen_info is the user provide dispatch. Something that we do > not and should not change. Merged 1-4, 7-9, and 11-13: remote: E: failed to find patch for rev

Re: [PATCH xserver 01/15] dri3: annotate the dri3_screen_info data as const

2018-04-04 Thread Emil Velikov
On 2 April 2018 at 20:34, Adam Jackson wrote: > On Mon, 2018-04-02 at 16:41 +0100, Emil Velikov wrote: > >> Why do we have the explicit _rec and _ptr typecasts to begin with? > > Convention, mostly. The typedef for the struct is because 'struct' is a > dumb word to need to say

Re: [PATCH xserver 01/15] dri3: annotate the dri3_screen_info data as const

2018-04-02 Thread Adam Jackson
On Mon, 2018-04-02 at 16:41 +0100, Emil Velikov wrote: > Why do we have the explicit _rec and _ptr typecasts to begin with? Convention, mostly. The typedef for the struct is because 'struct' is a dumb word to need to say all the time. The typedef for the pointer is vaguely distasteful and I've