; hw/xwin: Tidy-up of winmsg.h
> xwin/glx: Build fix for warnings about missing WGL extensioons
> hw/xwin: xcbify code for converting X11 icon to Win32 icon
> hw/xwin: In multiwindow mode, do window minimization entirely in the WM
> hw/xwin: xcbify
On Sun, Sep 18, 2016 at 10:00:30AM -0700, Keith Packard wrote:
> Jonas Ådahl <jad...@gmail.com> writes:
>
> > Any chance to get the patches[0] needed for Xwayland pointer warp emulation
> > merged before freezing the ABI/API?
>
> I haven't seen any review on them.
On Fri, Jul 31, 2015 at 09:48:53AM +0200, Olivier Fourdan wrote:
Hi
Some apps should be run in a plain X11 session but not in XWayland (e.g. an
X11 screensaver makes no sense in Wayland/XWayland).
There is one atom WL_SURFACE_ID that should be created only on/by XWayland
(for obvious
pointer to
> > an invalid cursor in order to trigger the update path next time a cursor
> > is displayed by dix.
> >
> > Signed-off-by: Jonas Ådahl <jad...@gmail.com>
> > ---
> >
> > This version of the patch doesn't do any API changes, but instead simply
&g
On Wed, Oct 07, 2015 at 12:09:17PM +0100, Daniel Stone wrote:
> Hi Jonas,
>
> On 7 October 2015 at 05:02, Jonas Ådahl <jad...@gmail.com> wrote:
> > When a new output is hot-plugged we need to not only update our internal
> > screen dimensions, but also the dix sc
When we have a single output, just set it to the physical size of that
output. Otherwise try to approximate it calculating a mean m.m. per
dot. Last fallback is to default to 96 DPI.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
I don't know how necessary this is (or rather, I don'
struct changing the "current sprite" pointer to
an invalid cursor in order to trigger the update path next time a cursor
is displayed by dix.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
This version of the patch doesn't do any API changes, but instead simply
copies priva
When a new output is hot-plugged we need to not only update our internal
screen dimensions, but also the dix screen dimensions, screenInfo
dimensions and the root window dimensions.
https://bugs.freedesktop.org/show_bug.cgi?id=92273
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
hw/xw
On Tue, Sep 29, 2015 at 10:04:40PM -0700, Keith Packard wrote:
> Jonas Ådahl <jad...@gmail.com> writes:
>
> > On Tue, Sep 29, 2015 at 09:49:46AM -0700, Keith Packard wrote:
> >> Jonas Ådahl <jad...@gmail.com> writes:
> >>
> >> > As m
On Tue, Sep 29, 2015 at 09:49:46AM -0700, Keith Packard wrote:
> Jonas Ådahl <jad...@gmail.com> writes:
>
> > As mentioned, a different approach would be to work-around the issue in
> > xwayland, but I consider such a solution more hacky than this. Please let
> > me
On Fri, Sep 25, 2015 at 12:13:13PM -0500, Keith Packard wrote:
> Jonas Ådahl <jad...@gmail.com> writes:
>
> > The reason I didn't do this was that we'd send duplicate set_cursor
> > requests when the cursor actually did change. What the patch does is
> > make it
On Wed, Sep 30, 2015 at 07:43:50AM -0700, Keith Packard wrote:
> Jonas Ådahl <jad...@gmail.com> writes:
>
> > Yes, otherwise we'd crash in miPointerUpdateSprite when trying to access
> > pCursor->bits.
>
> pSpriteCursor, not pCursor.
Ugh, poking in mipointe
of the pointer cursor sprite the next time dix asks
it to display one.
XWayland will now call this function upon receiving pointer focus, making
sure that subsequent calls will trigger resetting of the pointer cursor
sprite.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
Hi,
This is the
Instead of tracking what cursor is the current ourself, rely on the
next layer (most likely mipointer.c) do it for us. It leaves us with
a bit less logic in dix/ without any significant performance loss.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
dix/events.
On Mon, Sep 21, 2015 at 10:28:14PM +0100, Keith Packard wrote:
> Jonas Ådahl <jad...@gmail.com> writes:
>
> > In Wayland, a client (in this case XWayland) should set the cursor
> > surface when it receives pointer focus. Not doing this will leave the
> > curser
of the pointer cursor sprite through the various layers that
deals with that. The new function that does this is InvalidateCursor().
XWayland will now call this function upon receiving pointer focus,
making sure that subsequent calls will trigger resetting of the pointer
cursor sprite.
Signed-off-by: Jonas
ar so that we can
> continue submitting new cursor frames.
>
> Signed-off-by: Rui Matos <tiagoma...@gmail.com>
> Reviewed-by: Daniel Stone <dani...@collabora.com>
Reviewed-by: Jonas Ådahl <jad...@gmail.com>
> ---
>
> v2: as suggested by Jonas, moved the hunk fur
On Wed, Feb 03, 2016 at 05:46:35PM -0800, Bryce Harrington wrote:
> On Wed, Feb 03, 2016 at 04:14:09PM +0100, Rui Matos wrote:
> > The last cursor frame we commited before the pointer left one of our
> > surfaces might not have been shown. In that case we'll have a cursor
> > surface frame
On Fri, Feb 19, 2016 at 11:53:46AM +0100, Julien Cristau wrote:
> On Fri, Feb 19, 2016 at 15:08:13 +0800, Jonas Ådahl wrote:
>
> > We had HAVE_POSIX_FALLOCATE checks, but no such macros were ever
> > defined anywhere. This commit makes it so that this macro is defined if
>
Prefix the temporary file names used for allocating pixmaps with
"xwayland-" instead of "weston-". This makes it less confusing while
looking at the file names of the currently open fds of the Xwayland
process.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
hw/x
the clock was forced to be monotonic.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
Hi,
This patch fixes various issues[0] related to the race condition described in
the commit message. An alternative solution discussed has been to allow a
"grace period" as long as the c
sitor only supporting
CLOCK_MONOTONIC and X server to use the same clock.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Acked-by: Daniel Stone <dani...@collabora.com>
---
Here is a version that just simply forces it. I figured it would be annoynig to
have to detect the Xwayland version and appen
Hi,
With Wayland, the X server is no longer in control of the pointer
position, and as such, clients warping the pointer has no effect. This
causes many applications (mostly games) to fail to function properly, as
they depend on the warp requests to actually take effect. The same can
be said
We had HAVE_POSIX_FALLOCATE checks, but no such macros were ever
defined anywhere. This commit makes it so that this macro is defined if
the posix_fallocate is detected during configure.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
configure.ac | 3 ++-
hw/xwayland/xw
On Tue, Feb 23, 2016 at 08:54:47AM +0800, Jonas Ådahl wrote:
> On Fri, Feb 19, 2016 at 11:53:46AM +0100, Julien Cristau wrote:
> > On Fri, Feb 19, 2016 at 15:08:13 +0800, Jonas Ådahl wrote:
> >
> > > We had HAVE_POSIX_FALLOCATE checks, but no such macros were eve
sitor only supporting
CLOCK_MONOTONIC and X server to use the same clock.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Acked-by: Daniel Stone <dani...@collabora.com>
Tested-by: Olivier Fourdan <ofour...@redhat.com>
---
configure.ac | 4
hw/xwayland/xwayland.c | 2 ++
gned-off-by: Adam Jackson <a...@redhat.com>
Maybe changing the BUG_RETURN() statement to
BUG_RETURN(clockid && clockid != forced_clockid);
in ForceClockId() might be a better idea?
That way we'd still trigger BUG_RETURN on inproper use, instead of
ignoring it.
Anyway, this patch see
;tiagoma...@gmail.com>
Looks correct to me: Reviewed-by: Jonas Ådahl <jad...@gmail.com>
Jonas
> ---
> hw/xwayland/xwayland-output.c | 17 +
> hw/xwayland/xwayland.h| 2 +-
> 2 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/hw/x
On Sat, Nov 12, 2016 at 05:25:20PM +0100, Carlos Garnacho wrote:
> But just as long as the cursor is hidden. In the typical pattern in
> games of "hide cursor, grab with a confineTo, warp constantly the pointer
> to the middle of the window" the last warping step is actually rather
> optional.
>
On Sat, Nov 12, 2016 at 05:25:17PM +0100, Carlos Garnacho wrote:
> Of sorts, as we can't honor pointer warping across the whole root window
> coordinates, peek the pointer focus in this case.
>
> Signed-off-by: Carlos Garnacho
> ---
> hw/xwayland/xwayland.c | 4
> 1 file
On Sat, Nov 12, 2016 at 05:25:18PM +0100, Carlos Garnacho wrote:
> Of sorts, actually make it confine to the pointer focus, as the
> InputOnly window is entirely invisible to xwayland accounting,
> we don't have a xwl_window for it.
>
> Signed-off-by: Carlos Garnacho
> ---
>
On Thu, Mar 02, 2017 at 05:47:10AM -0500, Olivier Fourdan wrote:
> Hi Pekka,
>
> > I understand the attractiveness of adding an override, bypassing the
> > compositors like this. But, essentially it is just that: a
> > configuration bypass.
>
> True.
>
> > I would prefer leaning towards just
This new vfunc will be called, if set, after a client has issued a
WarpPointer request. This is necessary for implementing pointer warp
emulation in Xwayland.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
dix/events.c | 3 +++
include/scrnintstr.h | 9 +
2 files chang
it be
possible to land at least the ABI breaking ones (1-3?) so that it is possible
to distribute a patched version that will be ABI compatible with the coming
release?
Jonas
[0] https://github.com/jadahl/mutter/commits/wip/xwayland-pointer-warps
Jonas Ådahl (11):
dix: Introduce
Put device class initialization in init_[device_class](xwl_seat) and
releasing in release_[device class](xwl_seat). The purpose is to make
it easier to add more type of initialization here later, without making
the function too large.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
hw/xw
luding unaccelerated deltas, create a
secondary pointer device 'xwayland-relative-pointer', and use that for
emitting relative motion events.
Signed-off-by: Krzysztof Sobiecki <sob...@gmail.com>
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
hw/xwayland/xwa
Will be used by the pointer warp emulator.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
hw/xwayland/.gitignore | 2 ++
hw/xwayland/Makefile.am | 9 -
hw/xwayland/xwayland-input.c | 13 +
hw/xwayland/xwayland.h | 2 ++
4 files changed, 25 inse
pass the unaccelerated motion
event.
If the wl_seat advertised by the compositor is not new enough, assume
each relative and absolute pointer motion arrives within their own
separate frames.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
hw/xwayland/xwayland-input.
Add a valuator mask setter for setting absolute coordinate combined
with unaccelerated motion deltas. This will later be used by Xwayland
to combine a wl_pointer.motion() event with the unaccelerated delta of
a wp_relative_pointer.relative_motion() event.
Signed-off-by: Jonas Ådahl <
be ignored.
The pointer warp emulator will disable itself once the fake cursor
position leaves the window region, or the cursor is made visible.
This makes various games depending on pointer warping (such as 3D
first-person shooters and stategy games using click-to-drag-map like
things) work.
Signed-off
Will be used for getting unaccelerated motion events and later for
relative motions used by a pointer warp emulator.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
configure.ac | 4 +++-
hw/xwayland/.gitignore | 2 ++
hw/xwayland/Makefile.am
This function will be called when a pointer is grabbed non-root window
set as the 'confineTo'. This will enable the ddx to handle the
confinement their own way.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
dix/events.c | 5 +
include/scrnintstr.h | 5 +
2 files chang
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
hw/xwayland/xwayland.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c
index 847321e..5ceab0f 100644
--- a/hw/xwayland/xwayland.c
+++ b/hw/xwayland/xwayland.c
@@
properly.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
hw/xwayland/xwayland-input.c | 41 ++
hw/xwayland/xwayland.c | 53
hw/xwayland/xwayland.h | 7 ++
3 files changed, 101 insertions(+)
diff
Wait until wl_pointer.frame with dispatching the pointer motion event,
if wl_pointer.frame is supported by the compositor. This will later be
used to combine unaccelerated motion deltas with the absolute motion
delta.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
hw/xwayland/xwayland-i
On Fri, Sep 09, 2016 at 10:38:32AM -0600, Keith Packard wrote:
> Peter Hutterer writes:
>
> > Keith, I think the ABI changes should go in before we lock down, this is a
> > pretty important feature for the Wayland transition and our release cycles
> > aren't exactly
luding unaccelerated deltas, create a
secondary pointer device 'xwayland-relative-pointer', and use that for
emitting relative motion events.
Signed-off-by: Krzysztof Sobiecki <sob...@gmail.com>
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
Changes since v2:
Don't reset device->button to NU
On Fri, Sep 09, 2016 at 05:38:12PM +0900, Michel Dänzer wrote:
> On 09/09/16 05:12 PM, Jonas Ådahl wrote:
> > Bump both the xinput and videodrv versions. The xinput due to the added
> > valuator mask setter, and videodrv due to the added vfuncs to the
> > Screen struct
Bump both the xinput and videodrv versions. The xinput due to the added
valuator mask setter, and videodrv due to the added vfuncs to the
Screen struct.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
hw/xfree86/common/xf86Module.h | 4 ++--
1 file changed, 2 insertions(+), 2 del
Put device class initialization in init_[device_class](xwl_seat) and
releasing in release_[device class](xwl_seat). The purpose is to make
it easier to add more type of initialization here later, without making
the function too large.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Re
Bump both the xinput and videodrv versions. The xinput due to the added
valuator mask setter, and videodrv due to the added vfuncs to the
Screen struct.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
No changes since v1.
hw/xfree86/common/xf86Module.h | 4 ++--
1 file changed, 2 inse
Wait until wl_pointer.frame with dispatching the pointer motion event,
if wl_pointer.frame is supported by the compositor. This will later be
used to combine unaccelerated motion deltas with the absolute motion
delta.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Reviewed-by: Peter Hu
luding unaccelerated deltas, create a
secondary pointer device 'xwayland-relative-pointer', and use that for
emitting relative motion events.
Signed-off-by: Krzysztof Sobiecki <sob...@gmail.com>
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
Changes since v1:
The relative pointer now initi
Will be used by the pointer warp emulator.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>
---
No changes since v1.
hw/xwayland/.gitignore | 2 ++
hw/xwayland/Makefile.am | 9 -
hw/xwayland/xwayland-
Will be used for getting unaccelerated motion events and later for
relative motions used by a pointer warp emulator.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>
---
No changes since v1.
configure.ac | 4 +++-
Add a valuator mask setter for setting absolute coordinate combined
with unaccelerated motion deltas. This will later be used by Xwayland
to combine a wl_pointer.motion() event with the unaccelerated delta of
a wp_relative_pointer.relative_motion() event.
Signed-off-by: Jonas Ådahl <
We'll later use this for initializing buttons for the relative pointer
since they need to be the same.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
---
hw/xwayland/xwayland-input.c | 44 +++-
1 file changed, 27 insertions(+), 17 deletions(-)
diff
This new vfunc will be called, if set, after a client has issued a
WarpPointer request. This is necessary for implementing pointer warp
emulation in Xwayland.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>
---
No changes sin
This function will be called when a pointer is grabbed non-root window
set as the 'confineTo'. This will enable the ddx to handle the
confinement their own way.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>
---
No changes sin
be ignored.
The pointer warp emulator will disable itself once the fake cursor
position leaves the window region, or the cursor is made visible.
This makes various games depending on pointer warping (such as 3D
first-person shooters and stategy games using click-to-drag-map like
things) work.
Signed-off
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>
---
No changes since v1.
hw/xwayland/xwayland.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/xwayland/xwayland.c b/hw/xwayland/xwayland.c
i
properly.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>
---
No changes since v1.
hw/xwayland/xwayland-input.c | 41 ++
hw/xwayland/xwayland.c | 53
pass the unaccelerated motion
event.
If the wl_seat advertised by the compositor is not new enough, assume
each relative and absolute pointer motion arrives within their own
separate frames.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutte...@
xwl_screen = xwl_screen_get(screen);
> +xorg_list_for_each_entry_safe(xwl_seat, next_xwl_seat,
> + _screen->seat_list, link) {
No need to use _safe() here. We only change a field of the xwl_seat, we
never unlink it.
Other than that, this
Will be used for getting unaccelerated motion events and later for
relative motions used by a pointer warp emulator.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>
---
Changes since v2:
Fixed git history rewrite error (function
Will be used by the pointer warp emulator.
Signed-off-by: Jonas Ådahl <jad...@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>
---
Changes since v2:
Fix git history rewrite fail (return type of previous patch added in this one).
hw/xwayland/.gitignore
<tiagoma...@gmail.com>
Reviewed-by: Jonas Ådahl <jad...@gmail.com>
> ---
> hw/xwayland/xwayland-input.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/hw/xwayland/xwayland-input.c b/hw/xwayland/xwayland-input.c
> index f2327dc..1352197 100
On Wed, Mar 22, 2017 at 05:27:22PM +0100, Olivier Fourdan wrote:
> This patch introduces a new protocol for grabbing the keyboard from
> Xwayland.
>
> This is needed for X11 applications that map an override redirect window
> (ths not focused by the window manager) and issue an active grab on the
On Mon, Apr 03, 2017 at 09:45:46AM -0400, Olivier Fourdan wrote:
> Hey Peter,
>
> Thanks for the review!
>
> > woohoo, grabs. My favourite topic! ;)
> >
> > Mostly ok, a few complaints regarding the documentation but the protocol is
> > fine from my POV.
> >
> > On Wed, Mar 22, 2017 at
On Wed, Apr 05, 2017 at 02:30:15PM +0200, Olivier Fourdan wrote:
> This adds a new protocol to let Wayland clients specify that they want
> all keyboard events to be send to the client, regardless of the
> compositor own shortcuts.
>
> This is for use by virtual machine and remote connections
On Tue, Aug 01, 2017 at 10:26:54AM +0200, Olivier Fourdan wrote:
> This was added in wayland-protocols 1.10.
>
> Signed-off-by: Olivier Fourdan
> ---
> Note: This has not been tested with an actual compositor supporting
> xdg-output
>
> configure.ac |
This E-mail is quite long, but I tried to reply to some parts.
On Wed, Jul 12, 2017 at 12:07:29PM +0300, Pekka Paalanen wrote:
> On Fri, 7 Jul 2017 04:21:57 -0400 (EDT)
> Olivier Fourdan wrote:
>
> > Hi Pekka,
> >
> > > it's very hard for me to wrap my head around this,
be
> the output position and size in the global compositor space.
>
> Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
This one is
Reviewed-by: Jonas Ådahl <jad...@gmail.com>
but I'll wait with landing to see whether a consensus can be reached in
the E-mail thread.
an active grab on the
> keyboard to capture all keyboard events.
>
> Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
> Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net>
Reviewed-by: Jonas Ådahl <jad...@gmail.com>
and pushed.
Thanks!
> ---
> Makef
hine and remote connection
> viewers which require to pass all keyboard shortcuts to the hosted or
> remote system instead of being caught up by the compositor locally.
>
> Signed-off-by: Olivier Fourdan <ofour...@redhat.com>
> Reviewed-by: Peter Hutterer <peter.hutte...@wh
On Tue, Jun 06, 2017 at 02:03:39PM +0200, Olivier Fourdan wrote:
> This adds a new protocol to let Wayland clients specify that they want
> all keyboard events to be sent to the client, regardless of the
> compositor own shortcuts.
>
> This protocol can be used for virtual machine and remote
On Fri, Jun 02, 2017 at 11:06:25AM +0200, Olivier Fourdan wrote:
> This patch introduces a new protocol for grabbing the keyboard from
> Xwayland.
>
> This is needed for X11 applications that map an override redirect window
> (thus not focused by the window manager) and issue an active grab on
On Thu, Jun 29, 2017 at 04:44:34PM +0200, Olivier Fourdan wrote:
> This introduces a new protocol for the compositor to describe outputs
> size in a logical way for Xwayland.
>
> This is needed for X11 applications that would want to configure an X11
> window based on the size of the output,
On Mon, Mar 16, 2020 at 10:37:04PM -0500, Jason Ekstrand wrote:
> On Mon, Mar 16, 2020 at 6:39 PM Roman Gilg wrote:
> >
> > On Wed, Mar 11, 2020 at 8:21 PM Jason Ekstrand wrote:
> > >
> > > On Wed, Mar 11, 2020 at 12:31 PM Jason Ekstrand
> > > wrote:
> > > >
> > > > All,
> > > >
> > > > Sorry
On Wed, Apr 07, 2021 at 10:59:18AM +, Simon Ser wrote:
> FWIW, with my Sway/wlroots hat on I think this is a great idea and I'd
> definitely be interested in using such as library. A C API with no
> dependencies is pretty important from my point-of-view.
>
> I'd prefer if C++ was not used at
80 matches
Mail list logo