Var_D_0002-FEA-fibconfig_entry_set_rtmv2.cc-delete_entry-XLOG_W.patch
Description: Binary data
___
Xorp-hackers mailing list
Xorp-hackers@icir.org
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers
It still did not apply with 'git am'. I had to edit it to remove the
character in front of 'From' at the beginning of the patch.
I also fixed up the title and comments.
See the attached patch as an example of what I consider good
title and comment section for a patch.
The fixed-up patch has
On 03/21/2012 09:14 AM, Ben Greear wrote:
It still did not apply with 'git am'. I had to edit it to remove the
character in front of 'From' at the beginning of the patch.
I also fixed up the title and comments.
See the attached patch as an example of what I consider good
title and comment
Hi!
The fixed-up patch has been applied and will be pushed shortly.
I also fixed up the title and comments.
Thank You!
Thanks,
No problem :-)
It [Var_D] still did not apply with 'git am'.
- {-- XLOG_ASSERT
^^^
may be -- in Subj ( see diff of patches later) go to strange work
Hi!
Your patch looks better as an attachment, but please send
me patches created by 'git format-patch'
Attached file has good format?
It can be applyed itself? Or need renew?
Best regards, Victor Miasnikov
Blog: http://vvm.blog.tut.by/
On 03/20/2012 05:08 AM, Victor Miasnikov wrote:
Hi!
Your patch looks better as an attachment, but please send
me patches created by 'git format-patch'
Attached file has good format?
It can be applyed itself? Or need renew?
Best regards, Victor Miasnikov
Blog: http://vvm.blog.tut.by/
It
On 03/19/2012 04:11 AM, Victor Miasnikov wrote:
From: Victor Miasnikov v...@tut.by
FEA fibconfig_entry_set_rtmv2.cc delete_entry XLOG_WARNING {--
XLOG_ASSERT(vifp != NULL);
No XLOG_ASSERT when delete route for iface , but XLOG_WARNING a-la
fibconfig_entry_set_iphelper.cc
for prevent:
==
Hi!
The formatting looks bad in this patch. Please make sure code blocks
are indented by 4 characters.
Sorry :-( -- may be my e-mail client replace tab to 1 space :-/
Resend as attach
Best regards, Victor Miasnikov
Blog: http://vvm.blog.tut.by/
On 03/19/2012 09:29 AM, Victor Miasnikov wrote:
Your patch looks better as an attachment, but please send
me patches created by 'git format-patch' so that I can apply
them with 'git am'.
Preferably, you can just send them with 'git send-email' instead
of using your emailer..that will ensure
