Re: [Xorp-hackers] [PATCH 0/8] Enable sync of Xorp and kernel

2012-03-21 Thread Igor Maravić
Well, it's quite simple really :) We're writing new protocols for XORP (RSVP-TE and MPLS for now). We need XORP to be operational as much as possible so I'm fixing all XORP problems that I find along the way :) It bothered me that %get functions aren't called and I fixed that. BR Igor Током 20.

Re: [Xorp-hackers] [PATCH] FEA fibconfig_entry_set_rtmv2.cc delete_entry XLOG_WARNING {-- XLOG_ASSERT(vifp != NULL);

2012-03-21 Thread Victor Miasnikov
Var_D_0002-FEA-fibconfig_entry_set_rtmv2.cc-delete_entry-XLOG_W.patch Description: Binary data ___ Xorp-hackers mailing list Xorp-hackers@icir.org http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers

Re: [Xorp-hackers] [PATCH] FEA fibconfig_entry_set_rtmv2.cc delete_entry XLOG_WARNING {-- XLOG_ASSERT(vifp != NULL);

2012-03-21 Thread Ben Greear
It still did not apply with 'git am'. I had to edit it to remove the character in front of 'From' at the beginning of the patch. I also fixed up the title and comments. See the attached patch as an example of what I consider good title and comment section for a patch. The fixed-up patch has

Re: [Xorp-hackers] [PATCH] FEA fibconfig_entry_set_rtmv2.cc delete_entry XLOG_WARNING {-- XLOG_ASSERT(vifp != NULL);

2012-03-21 Thread Ben Greear
On 03/21/2012 09:14 AM, Ben Greear wrote: It still did not apply with 'git am'. I had to edit it to remove the character in front of 'From' at the beginning of the patch. I also fixed up the title and comments. See the attached patch as an example of what I consider good title and comment

[Xorp-hackers] [greearb/xorp.ct] 1ac240: FEA/rtmv2: Fix XLOG_ASSERT if vifp is not found.

2012-03-21 Thread GitHub
Branch: refs/heads/master Home: https://github.com/greearb/xorp.ct Commit: 1ac240caefa877932eaebbad5a2f7b157b0bc92d https://github.com/greearb/xorp.ct/commit/1ac240caefa877932eaebbad5a2f7b157b0bc92d Author: Victor Miasnikov v...@tut.by Date: 2012-03-21 (Wed, 21 Mar 2012)

Re: [Xorp-hackers] [PATCH] FEA fibconfig_entry_set_rtmv2.cc delete_entry XLOG_WARNING {-- XLOG_ASSERT(vifp != NULL);

2012-03-21 Thread Victor Miasnikov
Hi! The fixed-up patch has been applied and will be pushed shortly. I also fixed up the title and comments. Thank You! Thanks, No problem :-) It [Var_D] still did not apply with 'git am'. - {-- XLOG_ASSERT ^^^ may be -- in Subj ( see diff of patches later) go to strange work