Re: [xz-devel] Compatibility between CMake config file and FindLibLZMA.cmake

2021-02-14 Thread Markus Rickert
I'm afraid I didn't I fully understand the exact situation when this problem occurs. I trust that it's real and that you tested it, thus I committed this change. Thanks! I assume it has no significant downsides compared to the ALIAS method. Thanks, I just tested this and it also works for this

Re: [xz-devel] Compatibility between CMake config file and FindLibLZMA.cmake

2021-02-13 Thread Lasse Collin
On 2021-01-31 Markus Rickert wrote: > I noticed however, that there is still an issue when building against > a library that was built against liblzma due to using ALIAS (e.g., > testproject -> LibXml2 -> LibLZMA): > CMake will resolve the alias to include "liblzma::liblzma" instead of >

Re: [xz-devel] Compatibility between CMake config file and FindLibLZMA.cmake

2021-01-31 Thread Markus Rickert
I have committed both of your suggestions (hopefully correctly). Thanks! Thanks, I just tested this and it works correctly when building directly against liblzma via CMake, both with config and module mode. I noticed however, that there is still an issue when building against a library that

Re: [xz-devel] Compatibility between CMake config file and FindLibLZMA.cmake

2021-01-30 Thread Lasse Collin
On 2021-01-23 Markus Rickert wrote: > This could be solved by adding an alias to the config file: > add_library(LibLZMA::LibLZMA ALIAS liblzma::liblzma) > > An additional improvement would be to enable this on case-sensitive > file systems as well. For this, the config file would need to be >