Re: [Yade-dev] Unused state variables

2010-12-06 Thread Sergei D.
06.12.2010 21:05, Václav Šmilauer пишет: I was looking at the State class, and it seems to me some attributes (below) are not needed. Any reason to not get rid of them? I don't think we need accel and angAccel (grep the code to make sure, however), so you can go ahead I think. For refPos and

Re: [Yade-dev] Unused state variables

2010-12-06 Thread Václav Šmilauer
For accel and angAccel see NewtonIntegrator. Yes, but they are computed and consumed within one loop, so they could be stored in local vars (though it would need some care to not break what is there now). ___ Mailing list:

Re: [Yade-dev] Unused state variables

2010-12-06 Thread Bruno Chareyre
For refPos and refOri, they are used in the rendering code and some other functions. While you are cleaning up, there is also superfluous FrictPhys.frictionAngle (only the tangent is needed in computations I would think). v. Ok, I see. It is for scaling displacements (otherwise useless I

Re: [Yade-dev] Unused state variables

2010-12-06 Thread Bruno Chareyre
On 06/12/10 19:59, Bruno Chareyre wrote: For refPos and refOri, they are used in the rendering code and some other functions. While you are cleaning up, there is also superfluous FrictPhys.frictionAngle (only the tangent is needed in computations I would think). v. Ok, I see. It is for

Re: [Yade-dev] Unused state variables

2010-12-06 Thread Václav Šmilauer
Assuming I'll reach such a low level in the todo list (unlikely), ok to move refPos/Ori between some #ifdef YADE_OPENGL guards? I recall now there are also some post-processing functions (in post2d) that use reference positions... Let's perhaps discuss that again if you get that far on you