[jira] [Commented] (YARN-7180) Remove class ResourceType

2017-10-09 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196599#comment-16196599 ] John Zhuge commented on YARN-7180: -- [~rohithsharma] hadoop-yarn-server-resourcemanager: Compilation

[jira] [Commented] (YARN-7002) branch-2 build is broken by AllocationFileLoaderService.java

2017-08-11 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124470#comment-16124470 ] John Zhuge commented on YARN-7002: -- Thanks for the quick fix [~templedf]. > branch-2 build is broken by

[jira] [Created] (YARN-7002) branch-2 build is broken by AllocationFileLoaderService.java

2017-08-11 Thread John Zhuge (JIRA)
John Zhuge created YARN-7002: Summary: branch-2 build is broken by AllocationFileLoaderService.java Key: YARN-7002 URL: https://issues.apache.org/jira/browse/YARN-7002 Project: Hadoop YARN

[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster

2017-04-25 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982939#comment-15982939 ] John Zhuge commented on YARN-5007: -- +1 Thanks [~boky01] and [~ajisakaa] for the clarification. > Remove

[jira] [Commented] (YARN-5007) Remove deprecated constructors of MiniYARNCluster and MiniMRYarnCluster

2017-04-24 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982364#comment-15982364 ] John Zhuge commented on YARN-5007: -- If 3.0 is not a good time to remove deprecated method, when is a good

[jira] [Commented] (YARN-6501) FSSchedulerNode.java fails to compile with JDK7

2017-04-20 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977025#comment-15977025 ] John Zhuge commented on YARN-6501: -- Thanks [~jlowe] for the review and commit. Thanks [~ajisakaa] and

[jira] [Commented] (YARN-6432) FairScheduler: Reserve preempted resources for corresponding applications

2017-04-19 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976118#comment-15976118 ] John Zhuge commented on YARN-6432: -- Sounds good [~miklos.szeg...@cloudera.com]. > FairScheduler: Reserve

[jira] [Commented] (YARN-6432) FairScheduler: Reserve preempted resources for corresponding applications

2017-04-19 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976037#comment-15976037 ] John Zhuge commented on YARN-6432: -- No problem [~miklos.szeg...@cloudera.com]. In the addendum patch, you

[jira] [Updated] (YARN-6501) FSSchedulerNode.java fails to compile with JDK7

2017-04-19 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated YARN-6501: - Attachment: YARN-6501.branch-2.001.patch Patch branch-2.001 * Replace {{putIfAbsent}} with "get(), check

[jira] [Updated] (YARN-6501) FSSchedulerNode.java fails to compile with JDK7

2017-04-19 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated YARN-6501: - Summary: FSSchedulerNode.java fails to compile with JDK7 (was: FSSchedulerNode.java failed to build with

[jira] [Assigned] (YARN-6501) FSSchedulerNode.java failed to build with JDK7

2017-04-19 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge reassigned YARN-6501: Assignee: John Zhuge > FSSchedulerNode.java failed to build with JDK7 >

[jira] [Commented] (YARN-6432) FairScheduler: Reserve preempted resources for corresponding applications

2017-04-19 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975905#comment-15975905 ] John Zhuge commented on YARN-6432: -- [~kasha] {{FSSchedulerNode.java}} failed to build with JDK7 in

[jira] [Created] (YARN-6501) FSSchedulerNode.java failed to build with JDK7

2017-04-19 Thread John Zhuge (JIRA)
John Zhuge created YARN-6501: Summary: FSSchedulerNode.java failed to build with JDK7 Key: YARN-6501 URL: https://issues.apache.org/jira/browse/YARN-6501 Project: Hadoop YARN Issue Type: Bug

[jira] [Commented] (YARN-5777) TestLogsCLI#testFetchApplictionLogsAsAnotherUser fails

2016-10-25 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606081#comment-15606081 ] John Zhuge commented on YARN-5777: -- +1 (non-binding) The change looks good to me. Thanks [~ajisakaa] for

[jira] [Commented] (YARN-5007) MiniYarnCluster contains deprecated constructor which is called by the other constructors

2016-05-19 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15292245#comment-15292245 ] John Zhuge commented on YARN-5007: -- Like your idea of including MiniMRYarnCluster and MiniYarnCluster in

[jira] [Updated] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-10 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated YARN-4994: - Hadoop Flags: Reviewed > Use MiniYARNCluster with try-with-resources in tests >

[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-10 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278894#comment-15278894 ] John Zhuge commented on YARN-4994: -- +1 LGTM javac warnings: * YARN-5007 to fix the deprecated warnings

[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-10 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15278664#comment-15278664 ] John Zhuge commented on YARN-4994: -- I will take a quick look. Thanks for the great work! John Zhuge

[jira] [Commented] (YARN-4982) Test timeout :yarn-client testcase timeout and failures

2016-05-06 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274586#comment-15274586 ] John Zhuge commented on YARN-4982: -- [~bibinchundatt], in TestAMRMClient.java#732 of patch 0003: Why

[jira] [Commented] (YARN-4351) Tests in h.y.c.TestGetGroups get failed on trunk

2016-05-06 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274502#comment-15274502 ] John Zhuge commented on YARN-4351: -- Dup to YARN-4982? Its patch 0003 fixes TestGetGroups failure. I am not

[jira] [Commented] (YARN-5034) Failing tests after using try-with-resources

2016-05-06 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274481#comment-15274481 ] John Zhuge commented on YARN-5034: -- A dup of YARN-4982. To confirm, run the tests on a clean trunk. >

[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-06 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274437#comment-15274437 ] John Zhuge commented on YARN-4994: -- YARN-4982 Test timeout :yarn-client testcase timeout and failures"

[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-06 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274420#comment-15274420 ] John Zhuge commented on YARN-4994: -- TestGetGroups is known to fail: YARN-4351. Tests in

[jira] [Resolved] (YARN-5054) Remove redundent TestMiniDFSCluster.testDualClusters

2016-05-06 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge resolved YARN-5054. -- Resolution: Invalid Move to HDFS project. > Remove redundent TestMiniDFSCluster.testDualClusters >

[jira] [Created] (YARN-5054) Remove redundent TestMiniDFSCluster.testDualClusters

2016-05-06 Thread John Zhuge (JIRA)
John Zhuge created YARN-5054: Summary: Remove redundent TestMiniDFSCluster.testDualClusters Key: YARN-5054 URL: https://issues.apache.org/jira/browse/YARN-5054 Project: Hadoop YARN Issue Type:

[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-06 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15274332#comment-15274332 ] John Zhuge commented on YARN-4994: -- Could you rename the patches from HDFS-10287.* to YARN-4994.*? Let me

[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-03 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268376#comment-15268376 ] John Zhuge commented on YARN-4994: -- bq. Last week I created a new JIRA ticket to follow up this. Please

[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-05-02 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266958#comment-15266958 ] John Zhuge commented on YARN-4994: -- Nice work, [~boky01]. TestHadoopArchiveLogsRunner.java: * 134-136:

[jira] [Commented] (YARN-4994) Use MiniYARNCluster with try-with-resources in tests

2016-04-26 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258340#comment-15258340 ] John Zhuge commented on YARN-4994: -- Sure. A little busy now, may get to it tomorrow afternoon. If not,

[jira] [Resolved] (YARN-4959) MiniYARNCluster should implement AutoCloseable

2016-04-25 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge resolved YARN-4959. -- Resolution: Not A Problem Fix Version/s: 2.7.0 Already supported because: * {{MiniYARNCluster}}

[jira] [Moved] (YARN-4959) MiniYARNCluster should implement AutoCloseable

2016-04-14 Thread John Zhuge (JIRA)
[ https://issues.apache.org/jira/browse/YARN-4959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge moved HDFS-10288 to YARN-4959: - Assignee: (was: John Zhuge) Affects Version/s: (was: 2.7.0)