[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286909#comment-17286909 ] Qi Zhu commented on YARN-10589: --- [~tanu.ajmera] There still some checkstyle should handle. > Improve

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280866#comment-17280866 ] Hadoop QA commented on YARN-10589: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280774#comment-17280774 ] Tanu Ajmera commented on YARN-10589: [~zhuqi]  Thanks for the review. I have fixed the checkstyle

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279389#comment-17279389 ] Qi Zhu commented on YARN-10589: --- Thanks for [~tanu.ajmera] new patch. The new code LGTM. Should also fix

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278770#comment-17278770 ] Hadoop QA commented on YARN-10589: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278747#comment-17278747 ] Tanu Ajmera commented on YARN-10589: [~zhuqi] [~ztang] Thanks for the review. I have split the code

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277085#comment-17277085 ] Hadoop QA commented on YARN-10589: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277031#comment-17277031 ] Qi Zhu commented on YARN-10589: --- [~tanu.ajmera] I agree with [~ztang] that we need to split the code to

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276992#comment-17276992 ] Qi Zhu commented on YARN-10589: --- [~ztang] [~tanu.ajmera] I attached a new patch 003  based 002 , i think

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276973#comment-17276973 ] Zhankun Tang commented on YARN-10589: - [~zhuqi], Thanks a lot for the review! [~tanu.ajmera], I'm not

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276427#comment-17276427 ] Hadoop QA commented on YARN-10589: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276369#comment-17276369 ] zhuqi commented on YARN-10589: -- [~ztang] [~tanu.ajmera] I have reviewed the patch, i don't think the logic

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276170#comment-17276170 ] Zhankun Tang commented on YARN-10589: - [~zhuqi], could you please review Tanu's patch too? > Improve

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273523#comment-17273523 ] Hadoop QA commented on YARN-10589: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273499#comment-17273499 ] Tanu Ajmera commented on YARN-10589: [~zhuqi] In the code block I attached, it will create a set of

[jira] [Commented] (YARN-10589) Improve logic of multi-node allocation

[ https://issues.apache.org/jira/browse/YARN-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270635#comment-17270635 ] zhuqi commented on YARN-10589: -- [~tanu.ajmera] The logic has been improved from multi (node->partition) to