[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-12 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300390#comment-17300390 ] Qi Zhu commented on YARN-10687: --- Thanks [~Jim_Brennan] for last check. > Add option to disable/enable free

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-12 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300369#comment-17300369 ] Jim Brennan commented on YARN-10687: Thanks for the updates [~zhuqi]!  I am +1 on patch 004.   I will

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-12 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300240#comment-17300240 ] Hadoop QA commented on YARN-10687: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-12 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300155#comment-17300155 ] Qi Zhu commented on YARN-10687: --- Fixed the remaining checkstyle in latest patch. > Add option to

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-11 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300076#comment-17300076 ] Hadoop QA commented on YARN-10687: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-11 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300019#comment-17300019 ] Qi Zhu commented on YARN-10687: --- Thanks a lot [~Jim_Brennan] for patient review. I have fixed it in latest

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-11 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299827#comment-17299827 ] Jim Brennan commented on YARN-10687: Thanks for updating [~zhuqi]!  Can you please add a unit test to

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-11 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299786#comment-17299786 ] Hadoop QA commented on YARN-10687: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-11 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299649#comment-17299649 ] Qi Zhu commented on YARN-10687: --- [~Jim_Brennan] [~gandras] Updated the fix in latest patch. Thanks. >

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-11 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299616#comment-17299616 ] Qi Zhu commented on YARN-10687: --- Thanks a lot [~Jim_Brennan] for review and confirm. I will update your

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-11 Thread Jim Brennan (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299613#comment-17299613 ] Jim Brennan commented on YARN-10687: Thanks [~zhuqi]! These are not strictly needed, because the

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-11 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299447#comment-17299447 ] Hadoop QA commented on YARN-10687: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-10 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299387#comment-17299387 ] Qi Zhu commented on YARN-10687: --- Thanks a lot [~gandras] for review, very valid suggestion to me. I will

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-10 Thread Andras Gyori (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299386#comment-17299386 ] Andras Gyori commented on YARN-10687: - Thank you [~zhuqi] for the patch. I am by no means expert on

[jira] [Commented] (YARN-10687) Add option to disable/enable free disk space checking and percentage checking for full and not-full disks

2021-03-10 Thread Qi Zhu (Jira)
[ https://issues.apache.org/jira/browse/YARN-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299336#comment-17299336 ] Qi Zhu commented on YARN-10687: ---  [~pbacsko]  [~Jim_Brennan]  [~ebadger]  [~gandras]  If you could help