[jira] [Commented] (YARN-2925) Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom

2014-12-08 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238365#comment-14238365 ] Wangda Tan commented on YARN-2925: -- [~cwelch], Thanks for your comments, your suggestion m

[jira] [Commented] (YARN-2925) Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom

2014-12-08 Thread Craig Welch (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238155#comment-14238155 ] Craig Welch commented on YARN-2925: --- Hmm, there might be an even simpler approach - if we

[jira] [Commented] (YARN-2925) Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom

2014-12-05 Thread Craig Welch (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236461#comment-14236461 ] Craig Welch commented on YARN-2925: --- So, a few things things: I can see how we could get

[jira] [Commented] (YARN-2925) Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom

2014-12-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236455#comment-14236455 ] Hadoop QA commented on YARN-2925: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (YARN-2925) Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom

2014-12-05 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235941#comment-14235941 ] Wangda Tan commented on YARN-2925: -- Hi Craig, It is what I anticipated when reviewing of t

[jira] [Commented] (YARN-2925) Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom

2014-12-05 Thread Craig Welch (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235924#comment-14235924 ] Craig Welch commented on YARN-2925: --- Hey Wangda, couple questions: Have you actually see

[jira] [Commented] (YARN-2925) Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom

2014-12-05 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235901#comment-14235901 ] Wangda Tan commented on YARN-2925: -- Hi [~sunilg], No, I didn't intent to remove the CS loc

[jira] [Commented] (YARN-2925) Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom

2014-12-05 Thread Sunil G (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235788#comment-14235788 ] Sunil G commented on YARN-2925: --- HI [~wangda] Do you mean completely remove CS specific lock

[jira] [Commented] (YARN-2925) Internal fields in LeafQueue access should be protected when accessed from FiCaSchedulerApp to calculate Headroom

2014-12-04 Thread Wangda Tan (JIRA)
[ https://issues.apache.org/jira/browse/YARN-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234898#comment-14234898 ] Wangda Tan commented on YARN-2925: -- We cannot simply add a synchronized modifier to intern