[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074459#comment-15074459
]
Hudson commented on YARN-3480:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9036 (See
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074515#comment-15074515
]
Jun Gong commented on YARN-3480:
Thanks [~jianhe] for the suggestion, review and commit!
> Recovery may
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073360#comment-15073360
]
Jun Gong commented on YARN-3480:
[~jianhe] Thanks for suggestion. Attach a new patch to fix it.
> Recovery
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073461#comment-15073461
]
Hadoop QA commented on YARN-3480:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073258#comment-15073258
]
Jian He commented on YARN-3480:
---
actually, one more comment:
below code introduces one more loop for all
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15073567#comment-15073567
]
Hadoop QA commented on YARN-3480:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15072438#comment-15072438
]
Jian He commented on YARN-3480:
---
lgtm, +1
> Recovery may get very slow with lots of services with lots of
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068589#comment-15068589
]
Hadoop QA commented on YARN-3480:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069045#comment-15069045
]
Jun Gong commented on YARN-3480:
Discussed with [~jianhe] offline, we think the
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068394#comment-15068394
]
Jun Gong commented on YARN-3480:
Attach a new patch, move remove attempts logic to RMStateStore, then it
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069147#comment-15069147
]
Hadoop QA commented on YARN-3480:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067143#comment-15067143
]
Jian He commented on YARN-3480:
---
Hi [~hex108], thanks for updating.
bq. If RMStateStore fails to persist any
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066447#comment-15066447
]
Hadoop QA commented on YARN-3480:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066477#comment-15066477
]
Jun Gong commented on YARN-3480:
Test cases are not related, there are other issues tracking them.
>
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066330#comment-15066330
]
Jun Gong commented on YARN-3480:
Attach a new patch to fix above problems. Considering
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067480#comment-15067480
]
Jun Gong commented on YARN-3480:
Thanks for explaining.
These cases make removing attempts complex. We are
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065043#comment-15065043
]
Jun Gong commented on YARN-3480:
Thanks for review and suggestion!
{quote}
regarding this logic, it is
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064794#comment-15064794
]
Jian He commented on YARN-3480:
---
thanks for updating,
- regarding this logic, it is possible that a
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061702#comment-15061702
]
Jun Gong commented on YARN-3480:
Thanks! The new patch addresses above problems and add test cases.
>
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061888#comment-15061888
]
Hadoop QA commented on YARN-3480:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060978#comment-15060978
]
Jian He commented on YARN-3480:
---
thanks for updating, few more comments:
- rename startAttemptIdInStateStore
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059964#comment-15059964
]
Jun Gong commented on YARN-3480:
Fix findbugs and test errors.
> Recovery may get very slow with lots of
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059828#comment-15059828
]
Hadoop QA commented on YARN-3480:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060188#comment-15060188
]
Hadoop QA commented on YARN-3480:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059689#comment-15059689
]
Jun Gong commented on YARN-3480:
Attach a new patch to address above problems.
> Recovery may get very
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057754#comment-15057754
]
Jun Gong commented on YARN-3480:
Attach a new patch to add a global hard limit.
> Recovery may get very
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057960#comment-15057960
]
Jun Gong commented on YARN-3480:
IMO, 'max-allowed-attempts' does not need be overridden to a lower value
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059193#comment-15059193
]
Jian He commented on YARN-3480:
---
bq. In earlier patches, I did it in this way. Then max-allowed-attempts will
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15058076#comment-15058076
]
Hadoop QA commented on YARN-3480:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059399#comment-15059399
]
Jun Gong commented on YARN-3480:
Thanks for the suggestion!
{quote}
I meant we can reuse the
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057501#comment-15057501
]
Jun Gong commented on YARN-3480:
[~jianhe] Thanks for review and suggestion.
{quote}
how about removing
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056844#comment-15056844
]
Jian He commented on YARN-3480:
---
[~hex108],
how about removing the attempts that are beyond the
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054819#comment-15054819
]
Hadoop QA commented on YARN-3480:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054266#comment-15054266
]
Jun Gong commented on YARN-3480:
Hi [~jianhe], I just attached a patch that remove attempts beyond the
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15054341#comment-15054341
]
Hadoop QA commented on YARN-3480:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039560#comment-15039560
]
Jian He commented on YARN-3480:
---
[~hex108], i know it's been a long time, would you still like to work on
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15039613#comment-15039613
]
Jun Gong commented on YARN-3480:
[~jianhe] thanks for the remind. I thought the final solution is "we only
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14565385#comment-14565385
]
Vinod Kumar Vavilapalli commented on YARN-3480:
---
Tx. Linking YARN-1039.
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553451#comment-14553451
]
Jun Gong commented on YARN-3480:
{quote}
Without doing this, we will unnecessarily be
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547480#comment-14547480
]
Vinod Kumar Vavilapalli commented on YARN-3480:
---
bq. I think we need to have
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14547473#comment-14547473
]
Vinod Kumar Vavilapalli commented on YARN-3480:
---
bq. we might need keep
[
https://issues.apache.org/jira/browse/YARN-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534761#comment-14534761
]
Vinod Kumar Vavilapalli commented on YARN-3480:
---
bq. RM HA is enabled, use ZK
42 matches
Mail list logo
