[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369730#comment-15369730
]
Hudson commented on YARN-3995:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093086#comment-15093086
]
Naganarasimha G R commented on YARN-3995:
-
In line with this point hence i had changed the stop
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093087#comment-15093087
]
Naganarasimha G R commented on YARN-3995:
-
Thanks for the Commit and Review, [~sjlee0] &
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092256#comment-15092256
]
Varun Saxena commented on YARN-3995:
Should we use shutdownNow instead ? We are just removing entry
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092323#comment-15092323
]
Varun Saxena commented on YARN-3995:
That makes sense. I am +1 on the patch.
> Some of the NM events
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092274#comment-15092274
]
Sangjin Lee commented on YARN-3995:
---
I also thought about shutdownNow. The only reason I (slightly)
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15092386#comment-15092386
]
Sangjin Lee commented on YARN-3995:
---
I'm +1 on the latest patch too. I'll commit it shortly.
> Some of
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15089719#comment-15089719
]
Hadoop QA commented on YARN-3995:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090213#comment-15090213
]
Sangjin Lee commented on YARN-3995:
---
It looks pretty good. Thanks for updating the patch
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090448#comment-15090448
]
Hadoop QA commented on YARN-3995:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15090452#comment-15090452
]
Naganarasimha G R commented on YARN-3995:
-
checkstyle in the latest patch is for size of
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088490#comment-15088490
]
Naganarasimha G R commented on YARN-3995:
-
bq. Instead of spawning multiple threads may be we can
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088636#comment-15088636
]
Naganarasimha G R commented on YARN-3995:
-
Oops my mistake... assumed the interface wrongly !. its
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15088549#comment-15088549
]
Sangjin Lee commented on YARN-3995:
---
bq. Yes i wanted to address it as i was trying to point out earlier
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086072#comment-15086072
]
Naganarasimha G R commented on YARN-3995:
-
bq. Are you thinking of cases where the AM crashes? If
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086218#comment-15086218
]
Hadoop QA commented on YARN-3995:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070185#comment-15070185
]
Vrushali C commented on YARN-3995:
--
Hi [~Naganarasimha]
Thanks for the thoughts on the jira. I was
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070635#comment-15070635
]
Naganarasimha G R commented on YARN-3995:
-
Thanks for the comments [~sjlee0],
IIUC 2nd point is
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070709#comment-15070709
]
Naganarasimha G R commented on YARN-3995:
-
bq. If I recall, this window of opportunity is going to
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070690#comment-15070690
]
Sangjin Lee commented on YARN-3995:
---
If I recall, this window of opportunity is going to be quite small
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070716#comment-15070716
]
Varun Saxena commented on YARN-3995:
bq. what i am trying to suggest is close/remove the collector only
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070660#comment-15070660
]
Naganarasimha G R commented on YARN-3995:
-
Oops, Sorry my mistake ,
Thanks [~sjlee0] for correcting
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070723#comment-15070723
]
Sangjin Lee commented on YARN-3995:
---
bq. This is true in most of the cases, unless and untill AM doesn't
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15070643#comment-15070643
]
Sangjin Lee commented on YARN-3995:
---
That would be [~vrushalic], not me. :)
It might be bit better if we
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15068068#comment-15068068
]
Naganarasimha G R commented on YARN-3995:
-
Hi [~sjlee0],
As per the discussion we had in the status
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14650076#comment-14650076
]
Sangjin Lee commented on YARN-3995:
---
Let me give it some more thought. I'll chime in
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14649990#comment-14649990
]
Naganarasimha G R commented on YARN-3995:
-
Hi [~sjlee0] [~zjshen],
Hoping for some
[
https://issues.apache.org/jira/browse/YARN-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14647017#comment-14647017
]
Naganarasimha G R commented on YARN-3995:
-
Two approaches were discussed till now :
28 matches
Mail list logo