[
https://issues.apache.org/jira/browse/YARN-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163226#comment-16163226
]
Wangda Tan commented on YARN-4829:
--
Pushed changes to trunk, set fix version to 3.1.0
> Add support for
[
https://issues.apache.org/jira/browse/YARN-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197959#comment-15197959
]
Arun Suresh commented on YARN-4829:
---
bq. ..ones in the IEC standard. It's also the format used by
[
https://issues.apache.org/jira/browse/YARN-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197795#comment-15197795
]
Arun Suresh commented on YARN-4829:
---
The patch looks mostly good. Thanks [~vvasudev]
Couplo minor nits:
[
https://issues.apache.org/jira/browse/YARN-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200878#comment-15200878
]
Varun Vasudev commented on YARN-4829:
-
[~asuresh] - can you take a look at the latest patch and commit
[
https://issues.apache.org/jira/browse/YARN-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200326#comment-15200326
]
Hadoop QA commented on YARN-4829:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198171#comment-15198171
]
Hadoop QA commented on YARN-4829:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198456#comment-15198456
]
Hadoop QA commented on YARN-4829:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198012#comment-15198012
]
Arun Suresh commented on YARN-4829:
---
Thanks, LGTM
+1 pending Jenkins
> Add support for binary units
>
