[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262881#comment-15262881 ] Vinod Kumar Vavilapalli commented on YARN-4905: --- This looks very close. Few final nits -

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260571#comment-15260571 ] Hadoop QA commented on YARN-4905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258931#comment-15258931 ] Hadoop QA commented on YARN-4905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257408#comment-15257408 ] Xuan Gong commented on YARN-4905: - Thanks for the detail review, vinod. Attached a new patch to address

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246943#comment-15246943 ] Hadoop QA commented on YARN-4905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246712#comment-15246712 ] Xuan Gong commented on YARN-4905: - Thanks for the review. Uploaded a new patch to address all the comments.

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246395#comment-15246395 ] Vinod Kumar Vavilapalli commented on YARN-4905: --- Thanks for working on this [~xgong], this is

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242369#comment-15242369 ] Hadoop QA commented on YARN-4905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242229#comment-15242229 ] Xuan Gong commented on YARN-4905: - bq. It would be better if this function returned a formatted String

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15242219#comment-15242219 ] Xuan Gong commented on YARN-4905: - Thanks varun for the review. bq. Rename to printContainerLogMetadata

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15226389#comment-15226389 ] Varun Vasudev commented on YARN-4905: - Thanks for the patch [~xgong]. A few things - # If I don't have

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15222723#comment-15222723 ] Hadoop QA commented on YARN-4905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4905) Improve Yarn log Command line option to show log metadata

[ https://issues.apache.org/jira/browse/YARN-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221052#comment-15221052 ] Hadoop QA commented on YARN-4905: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||