[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416504#comment-15416504 ] Yufei Gu commented on YARN-5137: Thanks a lot [~rchiang] for the review and commit. Thanks

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416416#comment-15416416 ] Hudson commented on YARN-5137: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10258 (See [https

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416177#comment-15416177 ] Ray Chiang commented on YARN-5137: -- LGTM. +1 (binding). Committing soon if there are no

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413985#comment-15413985 ] Hadoop QA commented on YARN-5137: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412392#comment-15412392 ] Ray Chiang commented on YARN-5137: -- Thanks [~vvasudev] for your help on YARN-5444. I look

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397906#comment-15397906 ] Yufei Gu commented on YARN-5137: Filed YARN-5444 for fix in LinuxContainerExecutor and Tes

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396008#comment-15396008 ] Yufei Gu commented on YARN-5137: Hi [~vvasudev], thanks for the review. Since {{conf}} in

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395707#comment-15395707 ] Varun Vasudev commented on YARN-5137: - Can you explain why this was needed - {code} -

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394456#comment-15394456 ] Ray Chiang commented on YARN-5137: -- Yeah, I think the fix to LinuxContainerExecutor and T

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394278#comment-15394278 ] Yufei Gu commented on YARN-5137: The failed tests are unrelated. > Make DiskChecker plugga

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392858#comment-15392858 ] Hadoop QA commented on YARN-5137: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392593#comment-15392593 ] Ray Chiang commented on YARN-5137: -- Another minor nit. In the constructor for ContainerLo

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388629#comment-15388629 ] Hadoop QA commented on YARN-5137: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388617#comment-15388617 ] Hadoop QA commented on YARN-5137: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388561#comment-15388561 ] Yufei Gu commented on YARN-5137: Thanks Ray for the review. I uploaded patch 004 for all th

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388239#comment-15388239 ] Ray Chiang commented on YARN-5137: -- * In DirectoryCollection and ResourceLocalizationServi

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388213#comment-15388213 ] Hadoop QA commented on YARN-5137: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-5137) Make DiskChecker pluggable in NodeManager

[ https://issues.apache.org/jira/browse/YARN-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383299#comment-15383299 ] Hadoop QA commented on YARN-5137: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||